1. 05 Oct, 2020 11 commits
  2. 02 Oct, 2020 13 commits
  3. 01 Oct, 2020 9 commits
    • Mark Andrews's avatar
      Merge branch '2112-allow-task_test-subtests-to-be-selected-at-runtime' into 'main' · b154abd3
      Mark Andrews authored
      Resolve "Allow task_test and rdata_tests subtests to be selected at runtime."
      
      Closes #2112
      
      See merge request isc-projects/bind9!4059
      b154abd3
    • Mark Andrews's avatar
      62936820
    • Mark Andrews's avatar
      a9c33747
    • Mark Andrews's avatar
      Add the ability to select tests to run · 76837484
      Mark Andrews authored
      task_test [-t <test_name>]
      76837484
    • Mark Andrews's avatar
      Alphabetise tests · 96febe6b
      Mark Andrews authored
      96febe6b
    • Mark Andrews's avatar
      Merge branch... · c969cf86
      Mark Andrews authored
      Merge branch '2191-missing-locks-when-accessing-keynode-initial-and-keynode-managed-triggering-tsan' into 'main'
      
      Resolve "Missing locks when accessing keynode.initial and keynode.managed triggered TSAN."
      
      Closes #2191
      
      See merge request isc-projects/bind9!4205
      c969cf86
    • Mark Andrews's avatar
      Add missing rwlock calls when access keynode.initial and keynode.managed · 840cf7ad
      Mark Andrews authored
          WARNING: ThreadSanitizer: data race
          Write of size 1 at 0x000000000001 by thread T1 (mutexes: write M1):
          #0 dns_keynode_trust lib/dns/keytable.c:836
          #1 keyfetch_done lib/dns/zone.c:10187
          #2 dispatch lib/isc/task.c:1152
          #3 run lib/isc/task.c:1344
          #4 <null> <null>
      
          Previous read of size 1 at 0x000000000001 by thread T2 (mutexes: read M2):
          #0 keynode_dslist_totext lib/dns/keytable.c:682
          #1 dns_keytable_totext lib/dns/keytable.c:732
          #2 named_server_dumpsecroots bin/named/server.c:11357
          #3 named_control_docommand bin/named/control.c:264
          #4 control_command bin/named/controlconf.c:390
          #5 dispatch lib/isc/task.c:1152
          #6 run lib/isc/task.c:1344
          #7 <null> <null>
      
          Location is heap block of size 241 at 0x000000000010 allocated by thread T3:
          #0 malloc <null>
          #1 default_memalloc lib/isc/mem.c:713
          #2 mem_get lib/isc/mem.c:622
          #3 mem_allocateunlocked lib/isc/mem.c:1268
          #4 isc___mem_allocate lib/isc/mem.c:1288
          #5 isc__mem_allocate lib/isc/mem.c:2453
          #6 isc___mem_get lib/isc/mem.c:1037
          #7 isc__mem_get lib/isc/mem.c:2432
          #8 new_keynode lib/dns/keytable.c:346
          #9 insert lib/dns/keytable.c:393
          #10 dns_keytable_add lib/dns/keytable.c:421
          #11 process_key bin/named/server.c:955
          #12 load_view_keys bin/named/server.c:983
          #13 configure_view_dnsseckeys bin/named/server.c:1140
          #14 configure_view bin/named/server.c:5371
          #15 load_configuration bin/named/server.c:9110
          #16 loadconfig bin/named/server.c:10310
          #17 named_server_reconfigcommand bin/named/server.c:10693
          #18 named_control_docommand bin/named/control.c:250
          #19 control_command bin/named/controlconf.c:390
          #20 dispatch lib/isc/task.c:1152
          #21 run lib/isc/task.c:1344
          #22 <null> <null>
      
          Mutex M1 is already destroyed.
      
          Mutex M2 is already destroyed.
      
          Thread T1 (running) created by main thread at:
          #0 pthread_create <null>
          #1 isc_thread_create pthreads/thread.c:73
          #2 isc_taskmgr_create lib/isc/task.c:1434
          #3 create_managers bin/named/main.c:915
          #4 setup bin/named/main.c:1223
          #5 main bin/named/main.c:1523
      
          Thread T2 (running) created by main thread at:
          #0 pthread_create <null>
          #1 isc_thread_create pthreads/thread.c:73
          #2 isc_taskmgr_create lib/isc/task.c:1434
          #3 create_managers bin/named/main.c:915
          #4 setup bin/named/main.c:1223
          #5 main bin/named/main.c:1523
      
          Thread T3 (running) created by main thread at:
          #0 pthread_create <null>
          #1 isc_thread_create pthreads/thread.c:73
          #2 isc_taskmgr_create lib/isc/task.c:1434
          #3 create_managers bin/named/main.c:915
          #4 setup bin/named/main.c:1223
          #5 main bin/named/main.c:1523
      
          SUMMARY: ThreadSanitizer: data race lib/dns/keytable.c:836 in dns_keynode_trust
      840cf7ad
    • Mark Andrews's avatar
      Merge branch '2192-tsan-error-accessing-listener-connections' into 'main' · 061fb5e0
      Mark Andrews authored
      Resolve "TSAN error accessing listener->connections"
      
      Closes #2192
      
      See merge request isc-projects/bind9!4206
      061fb5e0
    • Mark Andrews's avatar
      Lock access to listener->connections · bea1326c
      Mark Andrews authored
      as it is accessed from multiple threads with libuv.
      
          WARNING: ThreadSanitizer: data race
          Write of size 8 at 0x000000000001 by thread T1:
          #0 conn_reset bin/named/controlconf.c:574
          #1 isc_nmhandle_detach netmgr/netmgr.c:1257
          #2 isc__nm_uvreq_put netmgr/netmgr.c:1389
          #3 tcp_send_cb netmgr/tcp.c:1030
          #4 <null> <null>
          #5 <null> <null>
      
          Previous read of size 8 at 0x000000000001 by thread T2:
          #0 conn_reset bin/named/controlconf.c:574
          #1 isc_nmhandle_detach netmgr/netmgr.c:1257
          #2 control_recvmessage bin/named/controlconf.c:556
          #3 recv_data lib/isccc/ccmsg.c:110
          #4 isc__nm_tcp_shutdown netmgr/tcp.c:1161
          #5 shutdown_walk_cb netmgr/netmgr.c:1511
          #6 uv_walk <null>
          #7 process_queue netmgr/netmgr.c:656
          #8 process_normal_queue netmgr/netmgr.c:582
          #9 process_queues netmgr/netmgr.c:590
          #10 async_cb netmgr/netmgr.c:548
          #11 <null> <null>
          #12 <null> <null>
      
          Location is heap block of size 265 at 0x000000000017 allocated by thread T3:
          #0 malloc <null>
          #1 default_memalloc lib/isc/mem.c:713
          #2 mem_get lib/isc/mem.c:622
          #3 isc___mem_get lib/isc/mem.c:1044
          #4 isc__mem_get lib/isc/mem.c:2432
          #5 add_listener bin/named/controlconf.c:1127
          #6 named_controls_configure bin/named/controlconf.c:1324
          #7 load_configuration bin/named/server.c:9181
          #8 run_server bin/named/server.c:9819
          #9 dispatch lib/isc/task.c:1152
          #10 run lib/isc/task.c:1344
          #11 <null> <null>
      
          Thread T1 (running) created by main thread at:
          #0 pthread_create <null>
          #1 isc_thread_create pthreads/thread.c:73
          #2 isc_nm_start netmgr/netmgr.c:232
          #3 create_managers bin/named/main.c:909
          #4 setup bin/named/main.c:1223
          #5 main bin/named/main.c:1523
      
          Thread T2 (running) created by main thread at:
          #0 pthread_create <null>
          #1 isc_thread_create pthreads/thread.c:73
          #2 isc_nm_start netmgr/netmgr.c:232
          #3 create_managers bin/named/main.c:909
          #4 setup bin/named/main.c:1223
          #5 main bin/named/main.c:1523
      
          Thread T3 (running) created by main thread at:
          #0 pthread_create <null>
          #1 isc_thread_create pthreads/thread.c:73
          #2 isc_taskmgr_create lib/isc/task.c:1434
          #3 create_managers bin/named/main.c:915
          #4 setup bin/named/main.c:1223
          #5 main bin/named/main.c:1523
      
          SUMMARY: ThreadSanitizer: data race bin/named/controlconf.c:574 in conn_reset
      bea1326c
  4. 30 Sep, 2020 7 commits
    • Ondřej Surý's avatar
      Merge branch 'ondrej/remove-dot-at-start-of-the-line-rst' into 'main' · cdd98524
      Ondřej Surý authored
      Remove the .key from the beginning of the line in rst file
      
      See merge request isc-projects/bind9!4203
      cdd98524
    • Ondřej Surý's avatar
      Remove the .key from the beginning of the line in rst file · a00ca65a
      Ondřej Surý authored
      The handling of . (dot) characted at the beginning of the line has
      changed between the sphinx-doc versions, and it was constantly giving us
      trouble when generating man pages when using different sphinx-doc.  This
      commit just changes the source rst file, so there's no more . (dot) the
      beginning of the line.
      a00ca65a
    • Mark Andrews's avatar
      Merge branch '2180-threadsanitizer-data-race-bin-named-server-c-9678-25-in-view_loaded' into 'main' · cf648346
      Mark Andrews authored
      Resolve "ThreadSanitizer: data race bin/named/server.c:9678:25 in view_loaded"
      
      Closes #2180
      
      See merge request isc-projects/bind9!4167
      cf648346
    • Mark Andrews's avatar
      make (named_server_t).reload_status atomic · b00ba7ac
      Mark Andrews authored
          WARNING: ThreadSanitizer: data race
          Write of size 4 at 0x000000000001 by thread T1:
          #0 view_loaded bin/named/server.c:9678:25
          #1 call_loaddone lib/dns/zt.c:308:3
          #2 doneloading lib/dns/zt.c:582:3
          #3 zone_asyncload lib/dns/zone.c:2322:3
          #4 dispatch lib/isc/task.c:1152:7
          #5 run lib/isc/task.c:1344:2
      
          Previous read of size 4 at 0x000000000001 by thread T2:
          #0 named_server_status bin/named/server.c:11903:14
          #1 named_control_docommand bin/named/control.c:272:12
          #2 control_command bin/named/controlconf.c:390:17
          #3 dispatch lib/isc/task.c:1152:7
          #4 run lib/isc/task.c:1344:2
      
          Location is heap block of size 409 at 0x000000000011 allocated by main thread:
          #0 malloc <null>
          #1 default_memalloc lib/isc/mem.c:713:8
          #2 mem_get lib/isc/mem.c:622:8
          #3 mem_allocateunlocked lib/isc/mem.c:1268:8
          #4 isc___mem_allocate lib/isc/mem.c:1288:7
          #5 isc__mem_allocate lib/isc/mem.c:2453:10
          #6 isc___mem_get lib/isc/mem.c:1037:11
          #7 isc__mem_get lib/isc/mem.c:2432:10
          #8 named_server_create bin/named/server.c:9978:27
          #9 setup bin/named/main.c:1256:2
          #10 main bin/named/main.c:1523:2
      
          Thread T1 (running) created by main thread at:
          #0 pthread_create <null>
          #1 isc_thread_create lib/isc/pthreads/thread.c:73:8
          #2 isc_taskmgr_create lib/isc/task.c:1434:3
          #3 create_managers bin/named/main.c:915:11
          #4 setup bin/named/main.c:1223:11
          #5 main bin/named/main.c:1523:2
      
          Thread T2 (running) created by main thread at:
          #0 pthread_create <null>
          #1 isc_thread_create lib/isc/pthreads/thread.c:73:8
          #2 isc_taskmgr_create lib/isc/task.c:1434:3
          #3 create_managers bin/named/main.c:915:11
          #4 setup bin/named/main.c:1223:11
          #5 main bin/named/main.c:1523:2
      
          SUMMARY: ThreadSanitizer: data race bin/named/server.c:9678:25 in view_loaded
      b00ba7ac
    • Mark Andrews's avatar
      Merge branch '2190-in-new-yaml-output-when-truncation-is-query-time-usec' into 'main' · 6e6ad6d3
      Mark Andrews authored
      dig: print timestamps with microsecond precision if "-u" is used in YAML output mode
      
      Closes #2190
      
      See merge request isc-projects/bind9!4193
      6e6ad6d3
    • Mark Andrews's avatar
      add CHANGES · b7512e87
      Mark Andrews authored
      b7512e87
    • Mark Andrews's avatar