Commit 69127fa6 authored by Marcin Siodelski's avatar Marcin Siodelski
Browse files

[991] Clarified the comment when responding to broadcast address.

parent 43ad3049
...@@ -528,7 +528,17 @@ Dhcpv4Srv::assignLease(const Pkt4Ptr& question, Pkt4Ptr& answer) { ...@@ -528,7 +528,17 @@ Dhcpv4Srv::assignLease(const Pkt4Ptr& question, Pkt4Ptr& answer) {
} else { } else {
// Since IfaceMgr does not support direct responses to // Since IfaceMgr does not support direct responses to
// clients not having IP address, we have to send response // clients not having IP address, we have to send response
// to broadcast. // to broadcast. Note that we don't check whether the
// use_bcast flag was set in the constructor or not.
// However, the use_bcast flag is mostly used by unit tests
// to prevent opening broadcast sockets in the constructor
// of this class because opening broadcast sockets requires
// root privileges. For this reason, it is rather unlikely
// that use_bcast flag is set to false in the real life
// scenario. On the other hand, if we fail to set remote
// address to broadcast here, we can't unit-test the case when
// server doesn't support direct responses to the client
// which doesn't have address yet.
answer->setRemoteAddr(IOAddress("255.255.255.255")); answer->setRemoteAddr(IOAddress("255.255.255.255"));
} }
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment