Skip to content
GitLab
Commit 7f464b31 authored by Tomek Mrugalski's avatar Tomek Mrugalski 🛰
Browse files

[3153] First unit-test for PD renew written

parent 0d5c7903
Hide whitespace changes
Inline Side-by-side
src/bin/dhcp6/tests/dhcp6_srv_unittest.cc
View file @ 7f464b31
......@@ -265,8 +265,7 @@ public:
// Check that we have got the address we requested.
checkIAAddr(addr, IOAddress("2001:db8:1:1::dead:beef"),
Lease::TYPE_NA, subnet_->getPreferred(),
subnet_->getValid());
Lease::TYPE_NA);
if (msg_type != DHCPV6_SOLICIT) {
// Check that the lease exists.
......@@ -663,8 +662,7 @@ TEST_F(Dhcpv6SrvTest, SolicitBasic) {
ASSERT_TRUE(addr);
// Check that the assigned address is indeed from the configured pool
checkIAAddr(addr, addr->getAddress(), Lease::TYPE_NA, subnet_->getPreferred(),
subnet_->getValid());
checkIAAddr(addr, addr->getAddress(), Lease::TYPE_NA);
// check DUIDs
checkServerId(reply, srv.getServerID());
......@@ -709,8 +707,7 @@ TEST_F(Dhcpv6SrvTest, pdSolicitBasic) {
ASSERT_TRUE(prefix);
// Check that the assigned prefix is indeed from the configured pool
checkIAAddr(prefix, prefix->getAddress(), Lease::TYPE_PD,
subnet_->getPreferred(), subnet_->getValid());
checkIAAddr(prefix, prefix->getAddress(), Lease::TYPE_PD);
EXPECT_EQ(pd_pool_->getLength(), prefix->getLength());
// check DUIDs
......@@ -765,8 +762,7 @@ TEST_F(Dhcpv6SrvTest, SolicitHint) {
ASSERT_TRUE(addr);
// check that we've got the address we requested
checkIAAddr(addr, hint, Lease::TYPE_NA, subnet_->getPreferred(),
subnet_->getValid());
checkIAAddr(addr, hint, Lease::TYPE_NA);
// check DUIDs
checkServerId(reply, srv.getServerID());
......@@ -815,8 +811,7 @@ TEST_F(Dhcpv6SrvTest, SolicitInvalidHint) {
ASSERT_TRUE(addr);
// Check that the assigned address is indeed from the configured pool
checkIAAddr(addr, addr->getAddress(), Lease::TYPE_NA, subnet_->getPreferred(),
subnet_->getValid());
checkIAAddr(addr, addr->getAddress(), Lease::TYPE_NA);
EXPECT_TRUE(subnet_->inPool(Lease::TYPE_NA, addr->getAddress()));
// check DUIDs
......@@ -880,12 +875,9 @@ TEST_F(Dhcpv6SrvTest, ManySolicits) {
ASSERT_TRUE(addr3);
// Check that the assigned address is indeed from the configured pool
checkIAAddr(addr1, addr1->getAddress(), Lease::TYPE_NA,
subnet_->getPreferred(), subnet_->getValid());
checkIAAddr(addr2, addr2->getAddress(), Lease::TYPE_NA,
subnet_->getPreferred(), subnet_->getValid());
checkIAAddr(addr3, addr3->getAddress(), Lease::TYPE_NA,
subnet_->getPreferred(), subnet_->getValid());
checkIAAddr(addr1, addr1->getAddress(), Lease::TYPE_NA);
checkIAAddr(addr2, addr2->getAddress(), Lease::TYPE_NA);
checkIAAddr(addr3, addr3->getAddress(), Lease::TYPE_NA);
// check DUIDs
checkServerId(reply1, srv.getServerID());
......@@ -955,8 +947,7 @@ TEST_F(Dhcpv6SrvTest, RequestBasic) {
ASSERT_TRUE(addr);
// check that we've got the address we requested
checkIAAddr(addr, hint, Lease::TYPE_NA, subnet_->getPreferred(),
subnet_->getValid());
checkIAAddr(addr, hint, Lease::TYPE_NA);
// check DUIDs
checkServerId(reply, srv.getServerID());
......@@ -1022,8 +1013,7 @@ TEST_F(Dhcpv6SrvTest, pdRequestBasic) {
ASSERT_TRUE(prf);
// check that we've got the address we requested
checkIAAddr(prf, hint, Lease::TYPE_PD, subnet_->getPreferred(),
subnet_->getValid());
checkIAAddr(prf, hint, Lease::TYPE_PD);
EXPECT_EQ(pd_pool_->getLength(), prf->getLength());
// check DUIDs
......@@ -1097,12 +1087,9 @@ TEST_F(Dhcpv6SrvTest, ManyRequests) {
ASSERT_TRUE(addr3);
// Check that the assigned address is indeed from the configured pool
checkIAAddr(addr1, addr1->getAddress(), Lease::TYPE_NA,
subnet_->getPreferred(), subnet_->getValid());
checkIAAddr(addr2, addr2->getAddress(), Lease::TYPE_NA,
subnet_->getPreferred(), subnet_->getValid());
checkIAAddr(addr3, addr3->getAddress(), Lease::TYPE_NA,
subnet_->getPreferred(), subnet_->getValid());
checkIAAddr(addr1, addr1->getAddress(), Lease::TYPE_NA);
checkIAAddr(addr2, addr2->getAddress(), Lease::TYPE_NA);
checkIAAddr(addr3, addr3->getAddress(), Lease::TYPE_NA);
// check DUIDs
checkServerId(reply1, srv.getServerID());
......@@ -1128,93 +1115,25 @@ TEST_F(Dhcpv6SrvTest, ManyRequests) {
// expected:
// - returned REPLY message has copy of client-id
// - returned REPLY message has server-id
// - returned REPLY message has IA that includes IAADDR
// - returned REPLY message has IA_NA that includes IAADDR
// - lease is actually renewed in LeaseMgr
TEST_F(Dhcpv6SrvTest, RenewBasic) {
NakedDhcpv6Srv srv(0);
const IOAddress addr("2001:db8:1:1::cafe:babe");
const uint32_t iaid = 234;
// Generate client-id also duid_
OptionPtr clientid = generateClientId();
// Check that the address we are about to use is indeed in pool
ASSERT_TRUE(subnet_->inPool(Lease::TYPE_NA, addr));
// Note that preferred, valid, T1 and T2 timers and CLTT are set to invalid
// value on purpose. They should be updated during RENEW.
Lease6Ptr lease(new Lease6(Lease::TYPE_NA, addr, duid_, iaid,
501, 502, 503, 504, subnet_->getID(), 0));
lease->cltt_ = 1234;
ASSERT_TRUE(LeaseMgrFactory::instance().addLease(lease));
// Check that the lease is really in the database
Lease6Ptr l = LeaseMgrFactory::instance().getLease6(Lease::TYPE_NA,
addr);
ASSERT_TRUE(l);
// Check that T1, T2, preferred, valid and cltt really set and not using
// previous (500, 501, etc.) values
EXPECT_NE(l->t1_, subnet_->getT1());
EXPECT_NE(l->t2_, subnet_->getT2());
EXPECT_NE(l->preferred_lft_, subnet_->getPreferred());
EXPECT_NE(l->valid_lft_, subnet_->getValid());
EXPECT_NE(l->cltt_, time(NULL));
// Let's create a RENEW
Pkt6Ptr req = Pkt6Ptr(new Pkt6(DHCPV6_RENEW, 1234));
req->setRemoteAddr(IOAddress("fe80::abcd"));
boost::shared_ptr<Option6IA> ia = generateIA(D6O_IA_NA, iaid, 1500, 3000);
OptionPtr renewed_addr_opt(new Option6IAAddr(D6O_IAADDR, addr, 300, 500));
ia->addOption(renewed_addr_opt);
req->addOption(ia);
req->addOption(clientid);
// Server-id is mandatory in RENEW
req->addOption(srv.getServerID());
// Pass it to the server and hope for a REPLY
Pkt6Ptr reply = srv.processRenew(req);
// Check if we get response at all
checkResponse(reply, DHCPV6_REPLY, 1234);
OptionPtr tmp = reply->getOption(D6O_IA_NA);
ASSERT_TRUE(tmp);
// Check that IA_NA was returned and that there's an address included
boost::shared_ptr<Option6IAAddr> addr_opt = checkIA_NA(reply, 234, subnet_->getT1(),
subnet_->getT2());
ASSERT_TRUE(addr_opt);
// Check that we've got the address we requested
checkIAAddr(addr_opt, addr, Lease::TYPE_NA, subnet_->getPreferred(),
subnet_->getValid());
// Check DUIDs
checkServerId(reply, srv.getServerID());
checkClientId(reply, clientid);
// Check that the lease is really in the database
l = checkLease(duid_, reply->getOption(D6O_IA_NA), addr_opt);
ASSERT_TRUE(l);
// Check that T1, T2, preferred, valid and cltt were really updated
EXPECT_EQ(l->t1_, subnet_->getT1());
EXPECT_EQ(l->t2_, subnet_->getT2());
EXPECT_EQ(l->preferred_lft_, subnet_->getPreferred());
EXPECT_EQ(l->valid_lft_, subnet_->getValid());
// Checking for CLTT is a bit tricky if we want to avoid off by 1 errors
int32_t cltt = static_cast<int32_t>(l->cltt_);
int32_t expected = static_cast<int32_t>(time(NULL));
// equality or difference by 1 between cltt and expected is ok.
EXPECT_GE(1, abs(cltt - expected));
TEST_F(Dhcpv6SrvTest, renewBasic) {
testRenewBasic(Lease::TYPE_NA, "2001:db8:1:1::cafe:babe",
"2001:db8:1:1::cafe:babe");
}
EXPECT_TRUE(LeaseMgrFactory::instance().deleteLease(addr_opt->getAddress()));
// This test verifies that incoming (positive) PD RENEW can be handled properly,
// that a REPLY is generated, that the response has a prefix and that prefix
// really belongs to the configured pool and that lease is actually renewed.
//
// expected:
// - returned REPLY message has copy of client-id
// - returned REPLY message has server-id
// - returned REPLY message has IA_PD that includes IAPREFIX
// - lease is actually renewed in LeaseMgr
TEST_F(Dhcpv6SrvTest, pdRenewBasic) {
testRenewBasic(Lease::TYPE_PD, "2001:db8:1:1::cafe:babe",
"2001:db8:1:1::cafe:babe");
}
// This test verifies that incoming (invalid) RENEW can be handled properly.
......
src/bin/dhcp6/tests/dhcp6_test_utils.cc
View file @ 7f464b31
......@@ -115,6 +115,132 @@ Dhcpv6SrvTest::checkPdLease(const DuidPtr& duid, const OptionPtr& ia_pd,
}
void
Dhcpv6SrvTest::testRenewBasic(Lease::Type type, const std::string& existing_addr,
const std::string& renew_addr) {
NakedDhcpv6Srv srv(0);
const IOAddress existing(existing_addr);
const IOAddress renew(renew_addr);
const uint32_t iaid = 234;
// Generate client-id also duid_
OptionPtr clientid = generateClientId();
// Check that the address we are about to use is indeed in pool
ASSERT_TRUE(subnet_->inPool(type, existing));
// Note that preferred, valid, T1 and T2 timers and CLTT are set to invalid
// value on purpose. They should be updated during RENEW.
Lease6Ptr lease(new Lease6(type, existing, duid_, iaid,
501, 502, 503, 504, subnet_->getID(), 128));
lease->cltt_ = 1234;
ASSERT_TRUE(LeaseMgrFactory::instance().addLease(lease));
// Check that the lease is really in the database
Lease6Ptr l = LeaseMgrFactory::instance().getLease6(type, existing);
ASSERT_TRUE(l);
// Check that T1, T2, preferred, valid and cltt really set and not using
// previous (500, 501, etc.) values
EXPECT_NE(l->t1_, subnet_->getT1());
EXPECT_NE(l->t2_, subnet_->getT2());
EXPECT_NE(l->preferred_lft_, subnet_->getPreferred());
EXPECT_NE(l->valid_lft_, subnet_->getValid());
EXPECT_NE(l->cltt_, time(NULL));
// Let's create a RENEW
Pkt6Ptr req = Pkt6Ptr(new Pkt6(DHCPV6_RENEW, 1234));
req->setRemoteAddr(IOAddress("fe80::abcd"));
uint16_t code = D6O_IA_NA;
OptionPtr subopt;
switch (type) {
case Lease::TYPE_NA:
code = D6O_IA_NA;
subopt.reset(new Option6IAAddr(D6O_IAADDR, renew, 300, 500));
break;
case Lease::TYPE_PD:
code = D6O_IA_PD;
subopt.reset(new Option6IAPrefix(D6O_IAPREFIX, renew, 32u, 300, 500));
default:
isc_throw(BadValue, "Invalid lease type specified");
}
boost::shared_ptr<Option6IA> ia = generateIA(code, iaid, 1500, 3000);
ia->addOption(subopt);
req->addOption(ia);
req->addOption(clientid);
// Server-id is mandatory in RENEW
req->addOption(srv.getServerID());
// Pass it to the server and hope for a REPLY
Pkt6Ptr reply = srv.processRenew(req);
// Check if we get response at all
checkResponse(reply, DHCPV6_REPLY, 1234);
OptionPtr tmp = reply->getOption(code);
ASSERT_TRUE(tmp);
// Check DUIDs
checkServerId(reply, srv.getServerID());
checkClientId(reply, clientid);
switch (type) {
case Lease::TYPE_NA: {
// Check that IA_NA was returned and that there's an address included
boost::shared_ptr<Option6IAAddr> addr_opt = checkIA_NA(reply, 234, subnet_->getT1(),
subnet_->getT2());
ASSERT_TRUE(addr_opt);
// Check that we've got the address we requested
checkIAAddr(addr_opt, renew, Lease::TYPE_NA);
// Check that the lease is really in the database
l = checkLease(duid_, reply->getOption(code), addr_opt);
ASSERT_TRUE(l);
break;
}
case Lease::TYPE_PD: {
// Check that IA_NA was returned and that there's an address included
boost::shared_ptr<Option6IAPrefix> prefix_opt
= checkIA_PD(reply, 234, subnet_->getT1(), subnet_->getT2());
ASSERT_TRUE(prefix_opt);
// Check that we've got the address we requested
checkIAAddr(prefix_opt, renew, Lease::TYPE_PD);
EXPECT_EQ(pd_pool_->getLength(), prefix_opt->getLength());
// Check that the lease is really in the database
l = checkLease(duid_, reply->getOption(code), prefix_opt);
ASSERT_TRUE(l);
break;
}
default:
isc_throw(BadValue, "Invalid lease type");
}
// Check that T1, T2, preferred, valid and cltt were really updated
EXPECT_EQ(l->t1_, subnet_->getT1());
EXPECT_EQ(l->t2_, subnet_->getT2());
EXPECT_EQ(l->preferred_lft_, subnet_->getPreferred());
EXPECT_EQ(l->valid_lft_, subnet_->getValid());
// Checking for CLTT is a bit tricky if we want to avoid off by 1 errors
int32_t cltt = static_cast<int32_t>(l->cltt_);
int32_t expected = static_cast<int32_t>(time(NULL));
// equality or difference by 1 between cltt and expected is ok.
EXPECT_GE(1, abs(cltt - expected));
EXPECT_TRUE(LeaseMgrFactory::instance().deleteLease(renew_addr));
}
// Generate IA_NA option with specified parameters
boost::shared_ptr<Option6IA>
NakedDhcpv6SrvTest::generateIA(uint16_t type, uint32_t iaid, uint32_t t1,
......
src/bin/dhcp6/tests/dhcp6_test_utils.h
View file @ 7f464b31
......@@ -360,9 +360,7 @@ public:
// and lifetime values match the configured subnet
void checkIAAddr(const boost::shared_ptr<Option6IAAddr>& addr,
const IOAddress& expected_addr,
Lease::Type type,
uint32_t /* expected_preferred */,
uint32_t /* expected_valid */) {
Lease::Type type) {
// Check that the assigned address is indeed from the configured pool.
// Note that when comparing addresses, we compare the textual
......@@ -379,9 +377,29 @@ public:
Lease6Ptr checkLease(const DuidPtr& duid, const OptionPtr& ia_na,
boost::shared_ptr<Option6IAAddr> addr);
/// @brief Verifies received IAPrefix option
///
/// Verifies if received IAPrefix option matches the lease in database
/// @param duid client's DUID
/// @param ia_pd IA_PD option that contains the IAPRefix option
/// @param prefix pointer to the IAPREFIX option
/// @return corresponding IPv6 lease (if found)
Lease6Ptr checkPdLease(const DuidPtr& duid, const OptionPtr& ia_pd,
boost::shared_ptr<Option6IAPrefix> prefix);
/// @brief Performs basic RENEW tests
///
/// See renewBasic and pdRenewBasic for detailed explanation.
/// In essence the test attempts to perform a successful RENEW scenario.
///
/// This method does not throw, but uses gtest macros to signify failures.
///
/// @param type type (TYPE_NA or TYPE_PD)
/// @param existing_addr address to be preinserted into the database
/// @param renew_addr address being sent in RENEW
void
testRenewBasic(Lease::Type type, const std::string& existing_addr,
const std::string& renew_addr);
~Dhcpv6SrvTest() {
CfgMgr::instance().deleteSubnets6();
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment