Commit 8274d824 authored by Marcin Siodelski's avatar Marcin Siodelski
Browse files

[3478] Addressed review comments.

parent d78e3367
...@@ -944,7 +944,7 @@ IfaceMgr::receive4(uint32_t timeout_sec, uint32_t timeout_usec /* = 0 */) { ...@@ -944,7 +944,7 @@ IfaceMgr::receive4(uint32_t timeout_sec, uint32_t timeout_usec /* = 0 */) {
// an error because of a signal being received or for some other // an error because of a signal being received or for some other
// reasaon. This is because DHCP servers use signals to trigger // reasaon. This is because DHCP servers use signals to trigger
// certain actions, like reconfiguration or graceful shutdown. // certain actions, like reconfiguration or graceful shutdown.
// By cacthing a dedicated exception the caller will know if the // By catching a dedicated exception the caller will know if the
// error returned by the function is due to the reception of the // error returned by the function is due to the reception of the
// signal or for some other reason. // signal or for some other reason.
if (errno == EINTR) { if (errno == EINTR) {
...@@ -1059,7 +1059,7 @@ Pkt6Ptr IfaceMgr::receive6(uint32_t timeout_sec, uint32_t timeout_usec /* = 0 */ ...@@ -1059,7 +1059,7 @@ Pkt6Ptr IfaceMgr::receive6(uint32_t timeout_sec, uint32_t timeout_usec /* = 0 */
// an error because of a signal being received or for some other // an error because of a signal being received or for some other
// reasaon. This is because DHCP servers use signals to trigger // reasaon. This is because DHCP servers use signals to trigger
// certain actions, like reconfiguration or graceful shutdown. // certain actions, like reconfiguration or graceful shutdown.
// By cacthing a dedicated exception the caller will know if the // By catching a dedicated exception the caller will know if the
// error returned by the function is due to the reception of the // error returned by the function is due to the reception of the
// signal or for some other reason. // signal or for some other reason.
if (errno == EINTR) { if (errno == EINTR) {
......
...@@ -612,6 +612,9 @@ public: ...@@ -612,6 +612,9 @@ public:
/// sockets. If reception is successful and all information about its /// sockets. If reception is successful and all information about its
/// sender is obtained, Pkt6 object is created and returned. /// sender is obtained, Pkt6 object is created and returned.
/// ///
/// This method also checks if data arrived over registered external socket.
/// This data may be of a different protocol family than AF_INET6.
///
/// @param timeout_sec specifies integral part of the timeout (in seconds) /// @param timeout_sec specifies integral part of the timeout (in seconds)
/// @param timeout_usec specifies fractional part of the timeout /// @param timeout_usec specifies fractional part of the timeout
/// (in microseconds) /// (in microseconds)
...@@ -631,6 +634,9 @@ public: ...@@ -631,6 +634,9 @@ public:
/// IPv4 sockets. If reception is successful and all information about /// IPv4 sockets. If reception is successful and all information about
/// its sender is obtained, Pkt4 object is created and returned. /// its sender is obtained, Pkt4 object is created and returned.
/// ///
/// This method also checks if data arrived over registered external socket.
/// This data may be of a different protocol family than AF_INET.
///
/// @param timeout_sec specifies integral part of the timeout (in seconds) /// @param timeout_sec specifies integral part of the timeout (in seconds)
/// @param timeout_usec specifies fractional part of the timeout /// @param timeout_usec specifies fractional part of the timeout
/// (in microseconds) /// (in microseconds)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment