Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Adam Osuchowski
Kea
Commits
fc5e5746
Commit
fc5e5746
authored
Jul 24, 2013
by
Thomas Markwalder
Browse files
[master] Fix missing virtual dtors and cppcheck failures in
new code from merge of Trac 3008.
parent
ee4bbde1
Changes
3
Hide whitespace changes
Inline
Side-by-side
src/bin/d2/ncr_io.cc
View file @
fc5e5746
...
...
@@ -199,7 +199,7 @@ NameChangeSender::sendNext() {
// If queue isn't empty, then get one from the front. Note we leave
// it on the front of the queue until we successfully send it.
if
(
send_queue_
.
size
())
{
if
(
!
send_queue_
.
empty
())
{
ncr_to_send_
=
send_queue_
.
front
();
// @todo start defense timer
...
...
@@ -262,7 +262,7 @@ NameChangeSender::invokeSendHandler(const NameChangeSender::Result result) {
void
NameChangeSender
::
skipNext
()
{
if
(
send_queue_
.
size
())
{
if
(
!
send_queue_
.
empty
())
{
// Discards the request at the front of the queue.
send_queue_
.
pop_front
();
}
...
...
src/bin/d2/ncr_io.h
View file @
fc5e5746
...
...
@@ -171,6 +171,9 @@ public:
/// @throw This method MUST NOT throw.
virtual
void
operator
()(
const
Result
result
,
NameChangeRequestPtr
&
ncr
)
=
0
;
virtual
~
RequestReceiveHandler
()
{
}
};
/// @brief Constructor
...
...
@@ -435,6 +438,9 @@ public:
/// @throw This method MUST NOT throw.
virtual
void
operator
()(
const
Result
result
,
NameChangeRequestPtr
&
ncr
)
=
0
;
virtual
~
RequestSendHandler
(){
}
};
/// @brief Constructor
...
...
src/bin/d2/ncr_msg.h
View file @
fc5e5746
...
...
@@ -105,7 +105,7 @@ public:
}
/// @brief Compares two D2Dhcids for inequality
bool
operator
!=
(
const
D2Dhcid
other
)
const
{
bool
operator
!=
(
const
D2Dhcid
&
other
)
const
{
return
(
this
->
bytes_
!=
other
.
bytes_
);
}
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment