1. 07 Nov, 2016 1 commit
  2. 01 Nov, 2016 1 commit
    • Thomas Markwalder's avatar
      [5058] - Addressed review comments · 43ad2f49
      Thomas Markwalder authored
          Fixed typos and added decline lease checks for DHCPv6
      
      src/lib/dhcp/duid.h
      src/lib/dhcp/duid.cc
      src/lib/dhcp/tests/duid_unittest.cc
          - Replaced DUID::generateEmpty() with DUID::EMPTY() which returns
          a constant reference to a static DUID instance.  This facilitates
          comparisions.
          - Updated TEST(DuidTest,empty) accordingly
      
      src/lib/dhcpsrv/csv_lease_file6.cc
          CSVLeaseFile6::next() - added test to permit the Empty DUID
          only if state is STATE_DECLINED.
      
      src/lib/dhcpsrv/lease.cc
          Lease6::decline() - modified to use DUID::EMPTY().
      
      src/lib/dhcpsrv/tests/csv_lease_file4_unittest.cc
          Fixed Typos
      
      src/lib/dhcpsrv/tests/csv_lease_file6_unittest.cc
          TEST_F(CSVLeaseFile6Test, declinedLeaseTest) - new test to
          verify proper handling of declined leases
      43ad2f49
  3. 31 Oct, 2016 1 commit
  4. 29 Oct, 2016 1 commit
  5. 28 Oct, 2016 3 commits
  6. 27 Oct, 2016 1 commit
  7. 26 Oct, 2016 1 commit
  8. 21 Oct, 2016 2 commits
  9. 18 Oct, 2016 1 commit
  10. 14 Oct, 2016 1 commit
  11. 12 Oct, 2016 1 commit
  12. 11 Oct, 2016 1 commit
  13. 05 Oct, 2016 2 commits
  14. 03 Oct, 2016 1 commit
  15. 21 Sep, 2016 1 commit
  16. 20 Sep, 2016 7 commits
  17. 19 Sep, 2016 1 commit
  18. 16 Sep, 2016 1 commit
    • Thomas Markwalder's avatar
      [5007] Addressed review comments · 1a986cf4
      Thomas Markwalder authored
      This is solution #2:
      
      src/lib/dhcpsrv/alloc_engine.h
      src/lib/dhcpsrv/alloc_engine.cc
          AllocEngine::extendLease6() - replaced logic to set the context flags with
          simply adding the original lease to the changed_leases_ list.
      
          AllocEngine::updateLeaseData() - removed logic to set the context flags.
      
      src/bin/dhcp6/dhcp6_srv.cc
          Dhcpv6Srv::createNameChangeRequests() - replaced the context flag check
          with logic which looks for candidate IA addresses in the ctx.changed_leases_
          list.  If found and the FDQN doman name has not changed, we move on to the
          next candidate.
      
      src/bin/dhcp6/tests/fqdn_unittest.cc
          TEST_F(FqdnDhcpv6SrvTest, createNameChangeRequestsNoAddr) - removed
          testing of context flag permutations
      1a986cf4
  19. 15 Sep, 2016 2 commits
    • Thomas Markwalder's avatar
      [5007] Suppress DDNS updates on DHCPv6 lease renewals unless the FQDN changes · 46f4c9fd
      Thomas Markwalder authored
      src/lib/dhcpsrv/alloc_engine.h
      src/lib/dhcpsrv/alloc_engine.cc
          - AllocEngine::extendLease6()
          - AllocEngine::updateLeaseData() - logic was added to clear the context
          DNS update flags when the renewal does not alter the lease's FQDN.
      
      src/bin/dhcp6/dhcp6_srv.h
      src/bin/dhcp6/dhcp6_srv.cc
          - Dhcpv6Srv::createNameChangeRequests() - added context as second parameter,
          and modified function to return without creating NCR(s) if both update flags
          in the context are false.
      
      src/bin/dhcp6/tests/fqdn_unittest.cc
          - TEST_F(FqdnDhcpv6SrvTest, createNameChangeRequests) - modified to verify
          combinations of context update flags
      
          - TEST_F(FqdnDhcpv6SrvTest, DISABLED_processTwoRequests) - renamed
          to TEST_F(FqdnDhcpv6SrvTest, processTwoRequestsDiffFqdn) and enabled.
          It had been disabled pending 3677 which has been completed.
      
          - TEST_F(FqdnDhcpv6SrvTest, processTwoRequestsSameFqdn)  - new test
          which verifies that client "renewing" a lease by sending a second
          request with the different FQDN generates the correct NCRs
      
          - TEST_F(FqdnDhcpv6SrvTest, DISABLED_processRequestRenew) - renamed
          to TEST_F(FqdnDhcpv6SrvTest, processRequestRenewDiffFqdn) and enabled.
          It had been disabled pending 3677 which has been completed.
      
          - TEST_F(FqdnDhcpv6SrvTest, processRequestRenewSameFqdn) - new test
          which verifies that client renewing a lease by sending a renew
          with the same FQDN does NOT generate any NCRs
      46f4c9fd
    • Marcin Siodelski's avatar
  20. 13 Sep, 2016 4 commits
  21. 06 Sep, 2016 1 commit
  22. 03 Sep, 2016 1 commit
  23. 01 Sep, 2016 1 commit
  24. 28 Aug, 2016 2 commits
  25. 26 Aug, 2016 1 commit