1. 06 Apr, 2016 1 commit
  2. 05 Apr, 2016 2 commits
  3. 04 Apr, 2016 1 commit
  4. 22 Mar, 2016 2 commits
  5. 18 Mar, 2016 1 commit
  6. 14 Mar, 2016 1 commit
  7. 13 Mar, 2016 3 commits
  8. 16 Dec, 2015 2 commits
  9. 11 Dec, 2015 2 commits
  10. 24 Nov, 2015 1 commit
  11. 11 Nov, 2015 2 commits
    • Thomas Markwalder's avatar
      [3601] More review comments · 71e6ef87
      Thomas Markwalder authored
      Minor log message and comment wording
      71e6ef87
    • Thomas Markwalder's avatar
      [3601] Addressed additional review comments · 2023588f
      Thomas Markwalder authored
      doc/guide/admin.xml
      src/lib/dhcpsrv/dhcpsrv_messages.mes
      src/lib/dhcpsrv/lease_file_loader.h
          minor clean up, typos
      
      src/lib/dhcpsrv/tests/csv_lease_file4_unittest.cc
      src/lib/dhcpsrv/tests/csv_lease_file6_unittest.cc
          removed unnecessary use of scoped_ptr
      
      src/lib/util/csv_file.cc
          CSVRow::trim() - replaced use of std::vector<>::erase with resise
      
      src/lib/util/versioned_csv_file.h
      src/lib/util/versioned_csv_file.cc
          VersionedCSVFile::next() - reorganized to use input_schema_state_
          VersionedCSVFile::columnCountError() - new convenience method
          minor cleanups
      2023588f
  12. 10 Nov, 2015 1 commit
    • Thomas Markwalder's avatar
      [3601] Addressed review comments, added ability to downgrade · 91a4978e
      Thomas Markwalder authored
      Several minor cleanup items based on review comments.  Implemented
      support for downgrading files from newer schema versions:
      
      doc/guide/admin.xml
          amended text on upgrading memfile to discuss downgrading
      
      src/lib/dhcpsrv/dhcpsrv_messages.mes
      src/lib/dhcpsrv/lease_file_loader.h
          revamped log messages to accomodate downgrading
      
      src/lib/dhcpsrv/memfile_lease_mgr.cc
      src/lib/dhcpsrv/memfile_lease_mgr.h
          added commentary to MemfileLeaseMgr ctor
          automatic conversion logic accomdates both upgrading and downgrading
      
      src/lib/dhcpsrv/tests/csv_lease_file4_unittest.cc
      src/lib/dhcpsrv/tests/csv_lease_file6_unittest.cc
          replaced tooManyHeaderColumns test with downGrade test
      
      src/lib/util/csv_file.h
      src/lib/util/csv_file.cc
          added CSVRow::trim()
      
      src/lib/util/tests/csv_file_unittest.cc
          added CSVRow.trim test
      
      src/lib/util/tests/versioned_csv_file_unittest.cc
          added VersionedCSVFileTest.currentSchemaTest test
          replaced tooManyHeaderColumns test with downGrading test
          revamped tests to check  getInputSchemaState() and needsConversion()
      
      src/lib/util/versioned_csv_file.h
          Updated commentary to describe downgrade support
      
      src/lib/util/versioned_csv_file.cc
          enum InputSchemaState
          input_schema_state_
          input_header_count_
          getInputHeaderCount()
          getInputSchemaState()
          needsConversion()
      
          next(CSVRow& row) - now supports downgrading rows
          validateHeder() -  now throws if called when no schema has been defined,
          and supports downgrading rows
      91a4978e
  13. 03 Nov, 2015 1 commit
    • Thomas Markwalder's avatar
      [3601] Added methods to VersionedCSVFile for tracking when updating is needed · 72a9ea19
      Thomas Markwalder authored
      src/lib/util/csv_file.h
          Made recreate() virtual
      
      src/lib/util/versioned_csv_file.h
      src/lib/util/versioned_csv_file.cc
          Added several methods to VersionedCSVFile:
      
          getValidColumnCount() - returns number of valid columns in header
      
          recreate() - wraps base class method, ensuring valid column
          count gets set to number of defined columns for new files
      
          needsUpgrading() - returns bool true if file schema is out of date
      
          getInputSchemaVersion() - returns schema version found in file
      
          getSchemaVersion() - returns current schema version
      
          getVersionedColumn() - returns the column definition for a given index
      
      src/lib/util/tests/versioned_csv_file_unittest.cc
          Added checks for new methods to existing tests
      72a9ea19
  14. 02 Nov, 2015 1 commit
    • Thomas Markwalder's avatar
      [3601] Added isc::util::VersionedCSVFile · a54b1107
      Thomas Markwalder authored
      src/lib/util/versioned_csv_file.h
      src/lib/util/versioned_csv_file.cc
          New files which implement VersionedCSVFile, CSV file which can
          support mulitple schema versions
      
      src/lib/util/tests/versioned_csv_file_unittest.h
      src/lib/util/tests/versioned_csv_file_unittest.cc
          new files for Unit tests for VersionedCSVFile
      
      src/lib/util/Makefile.am
          added new files
      
      src/lib/util/csv_file.cc
          includes read error message if header fails to validate
      
      src/lib/util/csv_file.h
          removed @todo for 3626, no longer applicable
      
      src/lib/util/tests/Makefile.am
          added versioned_csv_file_unittest.cc
      a54b1107
  15. 19 Oct, 2015 1 commit
  16. 15 Oct, 2015 1 commit
  17. 14 Oct, 2015 1 commit
  18. 13 Oct, 2015 2 commits
  19. 01 Oct, 2015 4 commits
  20. 29 Sep, 2015 2 commits
  21. 25 Sep, 2015 1 commit
  22. 24 Sep, 2015 1 commit
  23. 23 Sep, 2015 2 commits
  24. 22 Sep, 2015 3 commits
  25. 08 Sep, 2015 1 commit