GitLab

and source. Corrected other review items.

and make files; and process framework for the DHCP-DDNS daemon,
b10-d2srv.

... now that we handle this with an offset_ptr inside setNamedAddress()
itself.

This commit introduces a problem that allMemoryDeallocated() doesn't
work anymore, because the reserved memory is freed only when the segment
is destroyed.

One workaround is to temporarily release and re-reserve this memory in
allMemoryDeallocated(), but that would make it a non-const method.  I
don't see any other clean way of doing this.

We don't attempt to recover in this case.

Also change some error handling to simply asserts.

Initially I thought it was not possible to test this as
ZoneTableSegment::create() was used to create the zone table segment,
but it seems it's possible to do it this way using a mock class.

Conflicts:
	src/lib/dhcp/tests/pkt6_unittest.cc

It would be better if these were static (to save on space and also to
use them inside ZoneTableSegment::create()), but unfortunately we cannot
make it virtual then. Another option would be to pass a static string
from ZoneTableSegment::create() onto the ZoneTableSegment constructor
and make it a non-virtual base class method.

Ideally, this should use something like a SegmentObjectHolder, but a
SegmentObjectHolder takes unnecessary arguments. In this limited
usecase, ZoneTableSegment::destroy() just calls its destructor, so
std::auto_ptr should be ok here.

When the MySql lease manager tests create the database, they now also
create all the indexes as well.

while not really correct, this seems to work as a workaround for the crash
problem reported in #2946.
okayed on jabber.

this caused statici initialization fiasco for some build, e.g.:
http://git.bind10.isc.org/~tester/builder/BIND10/20130508225127-MacOSX10.6-x86_64-Clang-Static/logs/unittests.out

string objects moved inside the compare tests did not actually cause harm
in this environment, but should be generally better to be initialized
this way for the same reason.

while it's not a kind of 5-line patch, it should be pretty straightforward,
so I'm committing it at my discretion.

Conflicts:
	src/lib/dns/gen-rdatacode.py.in