GitLab

 - moved lease decline to Lease::decline()

 - Explanation why are we not updating assigned-addresses
 - DHCP4_DECLINE_LEASE message reworded as suggested
 - processDecline method described properly
 - declineNonMatchingIPAddresses description updated
 - global declined-addresses statistic added and tested
 -

 - distinction between ISC and std exceptions removed.
 - reference to support ticket removed.

    Modified v4 server to not enforce subnet match when clients attempt
    to release an existing, but out-of-range lease.

    Added a battery of unit tests to verify proper v4 server behavior
    when clients attempt to renew or release out-of-range addresses.

src/bin/dhcp4/dhcp4_messages.mes
 - deleted DHCP4_RELEAE_FILE_NO SUBNET as it is now obsolete

src/bin/dhcp4/dhcp4_srv.cc
 -  Dhcpv4Srv::processRelease() - removed the check to make sure the
    release pertains to a configured subnet.  This allows clients to
    release leases after configuration changes rendered them out of
    range.

src/bin/dhcp4/tests/Makefile.am
  - added out_of_range_unittest.cc

src/bin/dhcp4/tests/out_of_range_unittest.cc
 - New file containing DHCPv4 tests for server behavior regarding
   renews and releases of "out of range" addresses.

src/bin/dhcp4/tests/release_unittest.cc
 - TEST_F(ReleaseTest, releaseNoSubnet) - modified the test to
   verify that a client CAN release an out-of-range lease

  If std::exception would be thrown anywhere in message processing
  in Dhcp4Srv::run(), we would not catch it. In principle, that
  should never happen, as the Kea code only throws isc::Exception
  derivatives, but maybe some of the system or boost calls could
  throw std::exception.

  The calls to handleSignal() are now wrapped with catch clauses
  for both ISC and standard exceptions. This would not solve the
  underlying issue, but at least would cause the server to continue
  after the issue occurs.

  One of the hypotheses for the #8785 issue is mis-handling of
  the SingalInterruptOnSelect exception. This message will
  be printed every time a signal is received during select().

Conflicts:
	src/bin/dhcp4/dhcp4_messages.mes
	src/bin/dhcp4/dhcp4_srv.cc

Rather that stopping it explicitly, the server was relying D2ClientMgr
to stop itself during its own destruction.  This was falling over during
process wind-down because the IfaceMgr singletone was being destroyed before
the D2ClientMgr instance.  The server destructor now explicitly stops the
D2ClientMgr.

src/bin/dhcp6/dhcp6_messages.mes
    added DHCP6_SRV_D2STOP_ERROR log message

src/bin/dhcp6/dhcp6_srv.cc
    Dhcpv6Srv::stopD2() - new method stops the NCR sender, causing it to
    unregister its WathSocket from IfaceMgr

    Dhcpv6Srv::~Dhcpv6Srv() - added call to Dhcpv6Srv::stopD2()

src/bin/dhcp6/tests/dhcp6_process_tests.sh.in
    Enabled DNS updates in the CONFIG string.  This ensures the D2
    client will be started during system tests

Rather that stopping it explicitly, the server was relying D2ClientMgr
to stop itself during its own destruction.  This was falling over during
process wind-down because the IfaceMgr singletone was being destroyed before
the D2ClientMgr instance.
The server destructor now explicitly stops the D2ClientMgr.

src/bin/dhcp4/dhcp4_messages.mes
    added DHCP4_SRV_D2STOP_ERROR log message

src/bin/dhcp4/dhcp4_srv.cc
    Dhcpv4Srv::stopD2() - new method stops the NCR sender, causing it to
    unregister its WathSocket from IfaceMgr

    Dhcpv4Srv::~Dhcpv4Srv() - added call to Dhcpv4Srv::stopD2()

src/bin/dhcp4/tests/dhcp4_process_tests.sh.in
    Enabled DNS updates in the CONFIG string.  This ensures the D2
    client will be started during system tests

 - packet names updated in User's Guide
 - StatsMgr now uses int64_t, not uint64_t
 - StatsMgr::generateName() added
 - DISCOVER => DHCPDISCOVER

Mostly fixing typos and issues in comments and log messages.

 - Pkt4::check() removed
 - commented recent change in Pkt4::setType()
 - Pkt4::setType() now used OptionInt<uint8> rather than
   Option::setUint8()

Also added a few minor corrections to the DHCPv4 server and implemented
new Option6StatusCode.

1) Removed the srv-hooks logger
2) Updated DHCP4_NCR_CREATE message description
3) Updated logging doc.

Also, renamed loggers.