GitLab

ReentrantSetUp* methods are needed because you can't control iteration
count
Usage:
  ./configure --with-benchmark
      OR
  ./configure --with-benchmark-source=/path/to/benchmark/src

  make
  cd src/lib/dhcpsrv/benchmarks

  ./run-benchmarks
      OR
  ./run-benchmarks --benchmark_filter="RegExP*"

It is part of the generic_host_data_source_unittest.cc, able to be
implemented for other HDS as well. It executes INSERT statements and
a certain SELECT statement which Cassandra struggles in performance
with since it has to do two queries instead of a join. All statement
executions are timed and repeated on an increasingly number of hosts.
It is placed last and DISABLED_ as you don't want to run this during
a usual make check.

Added src/share/database/scripts/cql/upgrade_1.0_to_2.0.sh to include host_reservations table in Cassandra.
Updated documentation to indicate that Cassandra now supports host reservations.
Added src/lib/dhcpsrv/cql_host_data_source.cc and cql_host_data_source.h.
Fixed a bug in CfgOption::mergeInternal() where formatted_value_ was not taken into consideration when merging, this is needed for merging the denormalized results on host retrieval in Cassandra. The method is not used elsewhere so there is no regression impact.
Added Cassandra support in HostDataSourceFactory.
Implemented a todo in mysql_host_data_source.cc
Added cql_host_data_source_unittest.cc
Functionality that Cassandra is not capable of like ORDER BY clause is
adjusted in generic_host_data_source_unittest.cc.

Added src/share/database/scripts/cql/upgrade_1.0_to_2.0.sh to include host_reservations table in Cassandra.
Updated documentation to indicate that Cassandra now supports host reservations.
Added src/lib/dhcpsrv/cql_host_data_source.cc and cql_host_data_source.h.
Fixed a bug in CfgOption::mergeInternal() where formatted_value_ was not taken into consideration when merging, this is needed for merging the denormalized results on host retrieval in Cassandra. The method is not used elsewhere so there is no regression impact.
Added Cassandra support in HostDataSourceFactory.
Implemented a todo in mysql_host_data_source.cc
Added cql_host_data_source_unittest.cc
Functionality that Cassandra is not capable of like ORDER BY clause is
adjusted in generic_host_data_source_unittest.cc.

Replaced unrecommended backticks with $() in cql_version() in bash scripts.

*_execute() and *_execute_script() functions from src/bin/admin/admin-utils.sh now pass the parameters to the underlying backend binary whenever they are given rather than when there are 2 or more.

Corrected cql_version() return error in src/bin/admin/admin-utils.sh.

Removed redundant "USE" from cql_init() in src/bin/admin/kea-admin.in.

Inserted a newline in src/bin/admin/tests/Makefile.am to separate unrelated targets.

Style changes in cql_*_test() functions in src/bin/admin/tests/cql_tests.sh.in.

src/bin/admin/tests/dhcpdb_create_1.0.cql:
    "perfromance" typo
    Added comment headers
    Added index on expire since it is used in WHERE clauses (further performance testing may be required)
    Removed dhcp4_options and dhcp6_options table since they are not required for Cassandra

Added DROP INDEX in src/share/database/scripts/cql/dhcpdb_drop.cql.

Added sql_common.h
Added cql_exchange.h and cql_exchange.cc which mediate communication with Cassandra.
Added cql_lease_mgr.h and cql_lease_mgr.cc

Parameterized reconnect-wait-time, connect-timeout, request-timeout, tcp-keepalive, tcp-nodelay for Cassandra in kea.conf. Changes are in src/lib/dhcpsrv/cql_connection.cc and src/lib/dhcpsrv/parsers/dbaccess_parser.cc.

Reformated x != NULL into !x as specified in the Kea style guidelines

src/lib/dhcpsrv/cql_connection.cc:
    Added range check for port
    Added CqlConnection:setConsistency
    Added CqlConnection::startTransaction  which is a noop
    Added CqlTransaction method implementations.
    Corrected ending brace of namespace declaration, it doesn't need semicolon.

src/lib/dhcpsrv/cql_connection.h:
    Added explicit on CqlConnection constructor. Unlikely that this class will ever be derived, but it's good practice.
    Changed some comments.
    Added CqlTransaction class definition.

src/lib/dhcpsrv/cql_lease_mgr.cc:
    Formatted the entire code.
    Changed data types to cass_ types.

Added some log messages.

Moved structs, enums and typedefs from src/lib/dhcpsrv/lease_mgr.h to src/lib/dhcpsrv/sql_common.h

Added some missing tests in src/lib/dhcpsrv/tests/cql_lease_mgr_unittest.cc

 - SimpleParser concept implemented
 - Converted 4 parsers (option data, option data list, option defintion,
   option definition list)
 - updated unit-tests
 - converted other parsers (HostReservationParser{4,6}, ClientClassDefParser)
   to use those new parsers
 - converted kea-dhcp{4,6} to use those new parsers

Conflicts:
	src/bin/dhcp6/json_config_parser.cc
	src/lib/dhcpsrv/parsers/dhcp_parsers.cc

src/lib/dhcprsrv/images/pgsql_host_data_source.svg
    - New class diagram for PgSqlHostDataSource

doc/Doxyfile
    - Added src/lib/dhcprsrv/images to IMAGE_PATH

src/lib/dhcpsrv/Makefile.am
    - Added images/pgsql_host_data_source.svg to EXTRA_DIST

src/lib/dhcpsrv/libdhcpsrv.dox
    - Added subsection postgreSQLHostMgr

src/lib/dhcpsrv/pgsql_connection.h
src/lib/dhcpsrv/pgsql_exchange.h
    - Minor cleanup

src/lib/dhcpsrv
    pgsql_host_data_source.c
    pgsql_host_data_source.h  - new files, preliminary implementation

src/lib/dhcpsrv/Makefile.am
    Added new files pgsql_host_data_source.cc, pgsql_host_data_source.h

src/lib/dhcpsrv/dhcpsrv_messages.mes
    Added log messages DHCPSRV_PGSQL_HOST_DB_GET_VERSION, DHCPSRV_PGSQL_START_TRANSACTION

src/lib/dhcpsrv/pgsql_connection.cc
src/lib/dhcpsrv/pgsql_connection.h
    Added PgSqlTransaction
    Added PgSqlConnection::startTransaction()

src/lib/dhcpsrv/pgsql_exchange.cc
src/lib/dhcpsrv/pgsql_exchange.h
    PsqlBindArray
    - Added storage of conversion strings used for bound values
    - Added add() variants for uint8_t, IOAddress, uint8_t buffer
    - Added templated variant for miscellaneous types

    PgSqlExchange
    - Removed getColumnValue variants for various integers, replaced
    with templated version for miscellaneous types

src/lib/dhcpsrv/pgsql_lease_mgr.cc
    Added todo comment to remember to account for hwaddr columns added to lease6

src/lib/dhcpsrv/tests/pgsql_exchange_unittest.cc
    TEST(PsqlBindArray, basicOperation) - new test to exercise bind functions

src/lib/dhcpsrv/Makefile.am
    Added pgsql_exchange.cc and pgsql_exchange.h

src/lib/dhcpsrv/pgsql_exchange.h
src/lib/dhcpsrv/pgsql_exchange.cc
    New files, containng new base class PgSqlExchange from
    which was distilled from PgSqlLeaseExchange

src/lib/dhcpsrv/pgsql_lease_mgr.cc
    Refactored exchange classes to use new base class
    Moved PsqlBindArray into pgsql_exchange.*

    Initial refactoring of Postgresql connection logic out of
    PgSqlLeaseMgr into new PgSqlConnection.

This change was suggested during a ticket review.

The identifiers are held on an ordered list and the server will
use them to search for host reservations for each client using
this order.

In such case, the server will use a default configuration - memfile
lease database backend.

This reverts commit 8f2a1f8a, reversing
changes made to ed7edadc.

This  merge introduced regressions in our build farm and revealed
issues in the DHCP4o6 IPC code. It also revealed some differences
in sockets handling under Linux and BSD. Rather than continue
patching this here, we should work on the branch to resolve all
issues and then merge 1.1.

# Conflicts:
#	src/lib/dhcpsrv/mysql_lease_mgr.cc
#	src/lib/dhcpsrv/mysql_lease_mgr.h

src/bin/dhcp4/tests/config_parser_unittest.cc
src/bin/dhcp6/tests/config_parser_unittest.cc
src/lib/dhcpsrv/client_class_def.h
    Fixed spellings and spacing.

src/lib/dhcpsrv/Makefile.am
src/lib/dhcpsrv/tests/Makefile.am
    Move eval lib up in the link order