GitLab

We don't take any benefit from the parallel harness, since we have only
one test binary in each directory, and automake can't parallelize that.
But it was hiding test output, which was annoying.

Acked on the mailing list.

(reported by emhn: left over after a distclean)

Some of the makefiles clear that but not that one. We do
automate the distclean (via distcheck) as part of our
buildfarm. But I think this __pycache__ was introduced in python3.2 and
those build systems don't have it.

This is trivial so didn't get review.

The run.sh.in is in the distfile.
(issue reported by emhn: was removed with distclean but was in tarball)
Trivial so didn't get review.

They were installed twice (to /etc and to /share, removed the latter)
Also, the generated .pem files were included in the tarball, while they should be generated during the build process

committing at my discretion.

without this SunStudio will be confused about the namespace for the
declaration of internal Context below and refuse to compile.

confirmed it works, okayed on jabber.

(-rpath isn't actually checked in this macro)

Some dynamic linkers are wise enough (at least the Linux one) to correctly pick
needed shared libraries without hardcoded rpath. The --disable-rpath configure
switch allows distributors to avoid hardcoded rpath paths in libraries and
executables.
Signed-off-by: Adam Tkac <atkac@redhat.com>

On my home system I received error when running unit tests like:

Message DHCP4_SERVERID_LOADED server-id /home/reed/opt/bind10/var/b10-dhcp4-serverid has been loaded from file %2
assertion ""Excess logger placeholders still exist in message" == NULL" failed: file "../../../../src/lib/log/log_formatter.cc", line 69, function "void isc::log::checkExcessPlaceholders(std::string*, unsigned int)"

I am using --enable-logger-checks. The build farm also uses that.
I am not sure why this was not seen  on the build farm.

I added the missing value for dhcp4 and dhcp6 and the make check completed.

It had slight review on jabber.

Logging XFRIN_TRANSFER_PROTOCOL_ERROR as INFO level message could be
confusing. Rename to XFRIN_TRANSFER_PROTOCOL_VIOLATION, which is
neutral which has a neutral name regarding the log levels.

Also, include one known difference to bind9. This is both to store it
somewhere before we forget about it and to have an example to how the
file would look like.

The old version with . didn't work well with the form
  wait … for MESSAGE not OTHER_MESSAGE
Since the whole "MESSAGE not OTHER_MESSAGE" was captured into the first
(.+). This broke several tests in around xfrin and possibly others.

Now the tests pass and reviewed on jabber.

Perform post transfer validation of zone in XfrIn by isc.dn.check_zone and
reject broken zones.

To be aligned with the exception it describes.

Also adjust tests.

Also adjust tests.