GitLab

Dhcpv6Srv::createNameChangeRequests was not catching cases where FQDN flags
indicate NO changes should be made. This causes an exception to thrown by
the NCR constructor stating that both forward and reverse flags cannot be
false. Also moved the check up in the method, above of the options loop.

Unit tests did not detect that Dhcpv6Srv::createNameChangeRequests attempts
to make NCRs when the response FQDN flags indicate that none should be created.
FqdnDhcpv6Srv::testFqdn has been expanded to invoke this method and check the
outcome.

Updated Dhcpv6Srv to use D2ClientMgr::getUpdateDirections method and
adjusted FQDN unit tests to accomodate new client delegation behavior.
Also added a few unit tests that should have been added under 3034.

Updated Dhcpv4Srv to use D2ClientMgr::getUpdateDirections method and
adjusted FQDN unit tests to accomodate new client delegation behavior.

D2ClientMgr::analyzeFqdn template method was changed to correctly
set server S and N flags to properly support client delegation.
Added convenience method D2ClientMgr::getUpdateDirections.
Adjusted and added unit tests as appropriate.

The unit test,  Dhcp6SrvD2Test.enableDisable, which was
added with #3222 failed under FreeBSD.  The configuration
string used for test was missing a required parameter.
See Trac #3355 for a related change.

Conflicts:
	ChangeLog

Conflicts:
	ChangeLog

Improved doxygen commentary for new methods.

b10-dhcp6 fully able to do DHCP-DDNS

Conflicts:
	tests/tools/perfdhcp/Makefile.am

In addition to minor corrections, unit tests for NameChangeTransaction::
responseString was added.  Also added a similiar method NameChangeTransaction::
transactionOutcomeString() and unit tests.

data::merge function now merges map sub elements.

Solaris defines FIONREAD, used in unit test is dhcp_ddns/watch_socket_unittests.cc in sys/filio.h.  Added header check for this file to configure.ac and use
of HAVE_SYS_FILIO_H in the unit test source.

data::merge function is intended to merge to map elements together.
However, if those maps contain elements which are themselves maps they
are not merged.  The function uses recursion to merge map sub-elements.

Conflicts:
	ChangeLog
	src/bin/dhcp6/tests/dhcp6_srv_unittest.cc

Corrects DHO_HOST_OPTION bug in b10-dhcp4.

Also added section on templates, separate the options out into
different categories, and generally tidied up the XML.

Added a member instance of NakedDhcpv6Srv to FqdnDhcpv6SrvTest
rather than have an external local instance for each test.