GitLab

Dhcpv6Srv::createNameChangeRequests was not catching cases where FQDN flags
indicate NO changes should be made. This causes an exception to thrown by
the NCR constructor stating that both forward and reverse flags cannot be
false. Also moved the check up in the method, above of the options loop.

Updated Dhcpv6Srv to use D2ClientMgr::getUpdateDirections method and
adjusted FQDN unit tests to accomodate new client delegation behavior.
Also added a few unit tests that should have been added under 3034.

In addition to minor corrections, unit tests for NameChangeTransaction::
responseString was added.  Also added a similiar method NameChangeTransaction::
transactionOutcomeString() and unit tests.

Replaced use of internal queue in Dhcpv6Srv with posting
NCRs to D2ClientMgr. Upgraded unit tests accordingly.
b10-dhcp6 is now fully able to participate in DDNS.

Added D2ClientMgr send mode control and error handler
to Dhcp6vSrv and use of each to ControlledDhcpv6Srv.
Added new unit test files d2_unittest.h and cc.

Reviewed required a few comments to be added.

Replaced logic in Dhcpv6Srv::generateFqdn() which constructed the
FQDN from the lease address to use D2ClientMgr::generateFqdn() method.
Removed remaining obsolete FQDN_ constants.

Dhcpv6Srv now uses method in CfgMgr to test whether or not ddns updates
are enabled.  Add unit tests to verify NCRs are or are not created
accordingly.

Replaced constants and logic in Dhcp6Srv::processClientFqdn()
with use of D2ClientMgr configuration-sensitive FQDN flag
and domain name methods.

This is a result of the second review.

Also, moved lease unit tests to a dedicated test file.

Also, allow the server to generate FQDN if configured to do so, even if
client specified non-empty FQDN.

This gives us a very tiny speedup, as size() was a const method already.

 - Dhcpv{4,6}Srv::classifyPacket() is now better commented.
 - constants are now used instead of magic numbers
 - Pkt{4,6}::addClass is now better commented