GitLab

    Distcheck sporadically fails to clean up test_leases.csv.2
    can be left behind by dhcp4 and dhcp6 testing.

src/bin/dhcp4/tests/Makefile.am
src/bin/dhcp6/tests/Makefile.am
    - Added test_leases.csv.* to CLEANFILES

This reverts commit 8f2a1f8a, reversing
changes made to ed7edadc.

This  merge introduced regressions in our build farm and revealed
issues in the DHCP4o6 IPC code. It also revealed some differences
in sockets handling under Linux and BSD. Rather than continue
patching this here, we should work on the branch to resolve all
issues and then merge 1.1.

    Modified v4 server to not enforce subnet match when clients attempt
    to release an existing, but out-of-range lease.

    Added a battery of unit tests to verify proper v4 server behavior
    when clients attempt to renew or release out-of-range addresses.

src/bin/dhcp4/dhcp4_messages.mes
 - deleted DHCP4_RELEAE_FILE_NO SUBNET as it is now obsolete

src/bin/dhcp4/dhcp4_srv.cc
 -  Dhcpv4Srv::processRelease() - removed the check to make sure the
    release pertains to a configured subnet.  This allows clients to
    release leases after configuration changes rendered them out of
    range.

src/bin/dhcp4/tests/Makefile.am
  - added out_of_range_unittest.cc

src/bin/dhcp4/tests/out_of_range_unittest.cc
 - New file containing DHCPv4 tests for server behavior regarding
   renews and releases of "out of range" addresses.

src/bin/dhcp4/tests/release_unittest.cc
 - TEST_F(ReleaseTest, releaseNoSubnet) - modified the test to
   verify that a client CAN release an out-of-range lease

By generating config_report.cc in the cfgrpt directory Makefile
rather than configure, it can be treated as any other generated
source file, rather than a one-off special case.

Moved cfgrpt directory from bin to lib since it creates a library
rather than an executable.

mk_cfgrpt.sh is now generated by configure from a .in file and

Details:

configure.ac
   removed call to mk_cfgrpts.sh
   added mk_cfgprt.sh to list of files generated by configure

src/bin/Makefile.am
   removed cfgrpt dir

changed cfgrpt directory to lib
    src/bin/d2/Makefile.am
    src/bin/d2/tests/Makefile.am
    src/bin/dhcp4/Makefile.am
    src/bin/dhcp4/tests/Makefile.am
    src/bin/dhcp6/Makefile.am
    src/bin/dhcp6/tests/Makefile.am
    src/bin/lfc/Makefile.am
    src/bin/lfc/tests/Makefile.am
    src/bin/perfdhcp/Makefile.am
    src/bin/perfdhcp/tests/Makefile.am

src/lib/Makefile.am
    added cfgrpt dir

src/lib/cfgrpt/Makefile.am
    changed include dir to be in lib not dir
    added config_report.cc to CLEANFILES
    added config_report.cc to BUILD_SOURCES
    removed config_report.cc from libcfgrpt_la_SOURCES
    added rule for config_report.cc to call mk_cfgrpt.sh

src/lib/testutils/dhcp_test_lib.sh.in
    - server_pid_file_test() - common test for any server
    to verify PID file management

src/bin/d2/tests/d2_process_tests.sh.in
    remmoved duplicate_server_start_test
    now calls server_pid_file_test

Added PID file creation to DHCP4
    src/bin/dhcp4/dhcp4_messages.mes
    -  added log DHCP4_ALREADY_RUNNING

    src/bin/dhcp4/main.cc
    - added logic to create the PID and catch
    exception specific to PID conflict

    src/bin/dhcp4/tests/Makefile.am
    - exports KEA_PIDFILE_DIR

    src/bin/dhcp4/tests/dhcp4_process_tests.sh.in
    - added call to server_pid_file_test

    src/bin/dhcp4/tests/dhcp4_unittests.cc
    - main(int argc, char* argv[])
    sets env var KEA_PIDFILE_DIR

Unit tests in lib/config/tests and bin/dhcp4/tests were attempting
to write to TEST_DATA_DIR rather than TEST_DATA_BUILDDIR, make distcheck
to fail.

This change comes along with the new tests for DHCPRELEASE in the
separate file, and having a separate test fixture.

distcheck was failing to tests/dhcp(4/6)_process_tests.sh.
Since these files are now constructed from a .in file,
they must be pathed in abs_builddir.
dhcp(4/6)/tests/Makefile.am updated.

 - dhcp6_test.py removed
 - src/lib/testuitls/testdata/*.wire files are now in repo,
   no longer need python3 script to generate
 - src/lib/cc/proto_defs.h added to repo, no longer autogenerated
 - Added comment to get-rdatacode.py
 - removed LIBRARY_PATH_PLACEHOLDER hacks from several Makefiles.
 - ChangeLog entry added.

Also, a few corrections in Makefiles.