GitLab

    Distcheck sporadically fails to clean up test_leases.csv.2
    can be left behind by dhcp4 and dhcp6 testing.

src/bin/dhcp4/tests/Makefile.am
src/bin/dhcp6/tests/Makefile.am
    - Added test_leases.csv.* to CLEANFILES

This reverts commit 8f2a1f8a, reversing
changes made to ed7edadc.

This  merge introduced regressions in our build farm and revealed
issues in the DHCP4o6 IPC code. It also revealed some differences
in sockets handling under Linux and BSD. Rather than continue
patching this here, we should work on the branch to resolve all
issues and then merge 1.1.

Previous commit, 55207601, included
changes in the dhcp6/tests directory which should not have been included.
These have been removed.

The NO_HR enum value was erroneously set to an explicit
value, causing the wrong text to be used for some tests.
Changed reserved host name in config to avoid causing
NCR remove/adds during renewals.

By generating config_report.cc in the cfgrpt directory Makefile
rather than configure, it can be treated as any other generated
source file, rather than a one-off special case.

Moved cfgrpt directory from bin to lib since it creates a library
rather than an executable.

mk_cfgrpt.sh is now generated by configure from a .in file and

Details:

configure.ac
   removed call to mk_cfgrpts.sh
   added mk_cfgprt.sh to list of files generated by configure

src/bin/Makefile.am
   removed cfgrpt dir

changed cfgrpt directory to lib
    src/bin/d2/Makefile.am
    src/bin/d2/tests/Makefile.am
    src/bin/dhcp4/Makefile.am
    src/bin/dhcp4/tests/Makefile.am
    src/bin/dhcp6/Makefile.am
    src/bin/dhcp6/tests/Makefile.am
    src/bin/lfc/Makefile.am
    src/bin/lfc/tests/Makefile.am
    src/bin/perfdhcp/Makefile.am
    src/bin/perfdhcp/tests/Makefile.am

src/lib/Makefile.am
    added cfgrpt dir

src/lib/cfgrpt/Makefile.am
    changed include dir to be in lib not dir
    added config_report.cc to CLEANFILES
    added config_report.cc to BUILD_SOURCES
    removed config_report.cc from libcfgrpt_la_SOURCES
    added rule for config_report.cc to call mk_cfgrpt.sh

This test checks that the client can request allocation of the
prefix when it renews the existing IA_NA binding.

The DHCPv6 test client had to be extended to faciliate this.

Added PID file creation to DHCP6
    src/bin/dhcp6/dhcp6_messages.mes
    -  added log DHCP6_ALREADY_RUNNING

    src/bin/dhcp6/main.cc
    - added logic to create the PID and catch
    exception specific to PID conflict

    src/bin/dhcp6/tests/Makefile.am
    - exports KEA_PIDFILE_DIR

    src/bin/dhcp6/tests/dhcp6_process_tests.sh.in
    - added call to server_pid_file_test

    src/bin/dhcp6/tests/dhcp6_unittests.cc
    - main(int argc, char* argv[])
    sets env var KEA_PIDFILE_DIR

 - linker failure in lfc (and tests), added libkea-cc
 - linker failure in dhcp6 (and tests), added libkea-stats
 - remove troublesome CtrlDhcpv4SrvTest.DISABLED_commandSocketBasic test

src/bin/dhcp6/ctrl_dhcp6_srv.cc
    ControlledDhcpv6Srv::ControlledDhcpv6Srv()
        added CommandMgr init and handler registration

    ControlledDhcpv6Srv::~ControlledDhcpv6Srv() {
        added CommandMgr shutdown and handler deregistration

src/bin/dhcp6/json_config_parser.cc
    - createGlobal6DhcpConfigParser()
        added support for "control-socket" element

    - configureDhcp6Server()
        added logic to configure CommandMgr based on
        control-socket configuration element

src/bin/dhcp6/tests/ctrl_dhcp6_srv_unittest.cc
    - UnixControlClient  - new class that acts as UnixCommandSocket client    - CtrlChannelDhcpv6SrvTest - new test fixture for testing a DHCPv6 server
    with a Control Channel

    - Added the following tests:
    TEST_F(CtrlDhcpv6SrvTest, commandsRegistration)
    TEST_F(CtrlChannelDhcpv6SrvTest, controlChannelNegative)
    TEST_F(CtrlChannelDhcpv6SrvTest, controlChannelShutdown)
    TEST_F(CtrlChannelDhcpv6SrvTest, controlChannelStats)

Using the v4 changes as a guide (3798) add statistics
for subnets for v6.  The four stats are total addresses
and addresses used for both NA and PD.

Addressing more review comments...

new file - host_unittest.cc
    contains Dhcp6Client based host reservation tests

dhcp6_client.cc
dhcp6_client.h
    added setDuid(str) method to allow duid to be set to
    specific value

dhcp6_srv_unittest.cc -
    deleted host reservation tests, now in host_unittest.cc

dhcp6_test_utils.cc
dhcp6_test_utils.h
    deleted createHost6() method

distcheck was failing to tests/dhcp(4/6)_process_tests.sh.
Since these files are now constructed from a .in file,
they must be pathed in abs_builddir.
dhcp(4/6)/tests/Makefile.am updated.

 - dhcp6_test.py removed
 - src/lib/testuitls/testdata/*.wire files are now in repo,
   no longer need python3 script to generate
 - src/lib/cc/proto_defs.h added to repo, no longer autogenerated
 - Added comment to get-rdatacode.py
 - removed LIBRARY_PATH_PLACEHOLDER hacks from several Makefiles.
 - ChangeLog entry added.

Also, a few corrections in Makefiles.