GitLab

Adding missing commentary in ncr_io.h and ncr_upd.h

Changed dhcp_ddns::NameChangeSender to kick-start send process if there are
messages in the queue when startSending is called. Prior to this it required
the queuing of a new message via sendRequest().

Rememebering the io_service in use and how to run ready IO handlers was
pushed down from D2ClientMgr into NameChangeSender. NameChangeSender stop
logic was altered so it will now cleanly complete the last send as well
as interrupting the daisy-chain of instigating the next send upon
completion of the current send.

Also ran dhcp_ddns_messages.mes through reorder tool.

Shored up the error handling in the sender when the WatchSocket fails to mark
or clear. Addes unit tests accordingly.

Fixed a couple doxgyen errors and removed the commented
out include of ioctl.h in d2_upd_unittest.cc

Made behavior of dhcp_ddns::WatchSocket a bit more robust in handling
programmatic abuse.
Cleaned up addresses used in ncr_upd_unittest.cc, added specific test
for client side address if 0.0.0.0/port 0.
Updated copyrights as appropriate and other cosmetics.

Compilation under Fedora turned a couple of missing includes,
errno.h and stdint.h.

Integrated use of WatchSocket to NameChangeSender and NameChangeUDPSender.
Added addtional methods for accessing sender's send queue.
Created include and source for common dhcp_ddns lib test components.

Added a new to libdhcp_ddns, WatchSocket. This class provides an open
file descriptor whose read-readiness can be set or cleared and checked
via select() or poll() variants.

Removed configuration parameter allow-client-update.
It was deemed to really just be the inverse of override-client-update.
Renamed convenience method isDhcpDdns to ddnsEnabled.
Made enum to string converion functions case insenstive.
Updated copyright dates and other cosmetic changes.

Added configuration paramters to dhcp4 and its spec file to support DHCP-DDNS.
Created new classes D2ClientMgr, D2ClientConfig, and D2CientConfigParser in the
libdhcpsrv.   The new parameters are parsed, validated, and stored  but do
not yet affect behavior.  That will be implemented as a seperate ticket.

Changed dhcp_ddns::NameChangeRequest to store lease address as
IOAddress only.  Corrected logic that handles request build
exceptions and added unit tests for same.  Other minor changes.

Added methods for constructing all three types of DNS update requests
required by d2::NameAddTransaction to complete the implementation of its
state machine.  Also refactored some unit test code into nc_test_utils.h
and .cc, and ran much needed spell checking.

Using EXPECT_EQ on class D2Dhcid failed under gtest 1.5
due to lack of "<<" operator.  Adding it solves this problem.

Minor corrections only, there were no major revisions.

Added main process event loop to D2Process which is the
primary application "object" in b10-dchp-ddns.

Along the way it was necessary to adjust D2QueueManager to treat
stopping as an asyncrhonous event when IO is pending. This
requied a change in lib-dchp-ddns to have awareness of when
IO is pending.

Fixed a bug in D2 configuration parsing in which parsing a
a subsequent configuration caused duplicate TSIGKeyInfo
entries.

Added initial implemenation of D2UpdateMgr class to src/bin/d2.

Build was failing under Solaris.