GitLab

Also add some comments.


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac316@2771 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac316@2770 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2762 e5f2f494-b856-4b98-b285-d166d9295462

There is one open issue; there is a difference in behaviour between the different versions, in c++, an exception is thrown, while in the python version None is returned. The python version should probably be updated, but this also requires changes in the modules that use it, and is hence left out for now (and left for a future ticket item)


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2761 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac296@2760 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac296@2759 e5f2f494-b856-4b98-b285-d166d9295462

for ext/asio external code.

By the way, as of 2010-08-17, this code coverage was:

ext/asio/asio 		70.1% 	 	246 / 351 lines

ext/asio/asio/detail 	66.2% 		952 / 1438 lines

ext/asio/asio/impl 	47.6%	 	69 / 145 lines

ext/asio/asio/ip 	95.0% 		190 / 200 lines

ext/asio/asio/local 	53.1%	 	17 / 32 lines


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2756 e5f2f494-b856-4b98-b285-d166d9295462

(testability is checked in tests/Makefile.am)

suggested by Jeremy, okay by myself.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2755 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac296@2754 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2753 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac296@2752 e5f2f494-b856-4b98-b285-d166d9295462

minor zonemgr unittest fix: main thread will wait for 1 sec before accessing zonemgr data, so zone data should already be updated by zone timer.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2751 e5f2f494-b856-4b98-b285-d166d9295462

remove io_service.reset() call from blocking read; application using it is responsible for keeping io_service alive (if necessary by using a io_service::work object).
Also added a test with multiple reads


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac296@2750 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2749 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2746 e5f2f494-b856-4b98-b285-d166d9295462

 - added surrandong parentheses for return values based on agreed guideline
 - removed redundant semicolons after a block
 - fixed curly brace position

diff is large, but the change is very trivial.  so I'm skipping explicit review.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2745 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2742 e5f2f494-b856-4b98-b285-d166d9295462

removed double path line included by previous commit
(test file problem reported as make distcheck error and patch checked by likun)


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2741 e5f2f494-b856-4b98-b285-d166d9295462

internal cc message format for notifies seems to have changed, updated the tests that check that format


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2740 e5f2f494-b856-4b98-b285-d166d9295462

Fix the error in code comments according stephem's review for ticket289, which should be done in trac289.

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2739 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2738 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2737 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2736 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac296@2735 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac289@2733 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac289@2732 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac289@2731 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac289@2730 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2729 e5f2f494-b856-4b98-b285-d166d9295462

 - catch exceptions by reference
 - and constify them

should be trivial enough, so I'm skipping explicit review.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2728 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2727 e5f2f494-b856-4b98-b285-d166d9295462

  - removed a redundant blank line
  - folded a long line


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac296@2726 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2724 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2723 e5f2f494-b856-4b98-b285-d166d9295462

introduced a new ./configure option --enable-static-link to statically link executables while still building dynamic loadable modules correctly.


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac309@2722 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac309@2721 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2720 e5f2f494-b856-4b98-b285-d166d9295462

new approach for blocking reads to prevent races: if the timeout or read is canceled, also wait until the cancel signal is processed

other cleanup;

only use one variable for the read_result and timer_result (with boost::optional)
setResult does not need to be a member function, so i moved it out of the class
don't cancel timer if it wasn't set
added an io_service.reset() call to reset internal flags before the run_one() calls


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac296@2716 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac296@2715 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2714 e5f2f494-b856-4b98-b285-d166d9295462