GitLab

A previous change updated the test for removeIdentical().  This
change was omitted from the test for the const version.

Original code checked the wrong variable when doing a status check
on read(2)/write(2).

shared_ptr is a candidates for the next STL version and Windows has
already adopted it.  This change removes ambiguity between the Boost
and Windows versions of the class.

A method iterates over a std::map and removes from it elements that
match those in another map.  This can lead to a problem on some
operating systems if the element removal affects the iterator.
The fix here is to iterate over the (unchanging) reference map.

This leads to a warning on some compiler.

The .cc has it defined as "struct" and the .h file referenced a
"class".  This has now been harmonised as "struct".

Some loops changed to use unsigned loop indexes to avoid warning
messages from some compilers.

One compiler had a problem with the unqualifier data type
"error_code".  This has been changed to "asio::error_code".

Was declared as "class" in one and "struct" in another - now declared
as "struct" in both.

Some compilers warn if "this" is referred to in a constructor
initialization list.  This change replaces such initializations
with an assignment within the constructor body.

This will fix build failure due to the mixture of these in ?:.  (and in any
event when we can make something const that's generally good to do)

Conflicts:
	src/lib/datasrc/database.cc
	src/lib/datasrc/datasrc_messages.mes

Conflicts:
	ChangeLog

also fixed a minor type for entry 338 (as discussed on the dev ML)

This reverts commit 662233a1, reversing
changes made to b41b7dc3.

This reverts commit 8dcf5eeb.