GitLab

A previous change updated the test for removeIdentical().  This
change was omitted from the test for the const version.

A method iterates over a std::map and removes from it elements that
match those in another map.  This can lead to a problem on some
operating systems if the element removal affects the iterator.
The fix here is to iterate over the (unchanging) reference map.

briefly talked about it on jabber, no one opposed to it, Jeremy explicitly
agreed.  changes are trivial themselves, so no explicit review.

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac397focused@3885 e5f2f494-b856-4b98-b285-d166d9295462

need more cleanups


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac365@3157 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac310@2748 e5f2f494-b856-4b98-b285-d166d9295462

 - added surrandong parentheses for return values based on agreed guideline
 - removed redundant semicolons after a block
 - fixed curly brace position

diff is large, but the change is very trivial.  so I'm skipping explicit review.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@2745 e5f2f494-b856-4b98-b285-d166d9295462

introduced a new ./configure option --enable-static-link to statically link executables while still building dynamic loadable modules correctly.


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac309@2722 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac172@2353 e5f2f494-b856-4b98-b285-d166d9295462

made number parser use strol/d
added 'support' for numbers of the form '.1'
IntElement now contains long int instead of int



git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac172@2345 e5f2f494-b856-4b98-b285-d166d9295462

address review comments part 3 of 3 (or 4, there were a few general comments that i'm not sure we should adress in this ticket)


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac172@2304 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac172@2296 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac172@2295 e5f2f494-b856-4b98-b285-d166d9295462

made pos and line arguments in the inline throwJSONError convenience function mandatory


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac172@2124 e5f2f494-b856-4b98-b285-d166d9295462

check for overflow when parsing numbers


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac172@2114 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac172@2113 e5f2f494-b856-4b98-b285-d166d9295462

empty constructors for lists and maps, and corresponding 'factory' functions Element::createList() and Element::createMap()


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac172@2112 e5f2f494-b856-4b98-b285-d166d9295462

created toJSON functions (which are mostly the old str() ones, str() is now a general Element function that calls toJSON)
toWire now also simply calls toJSON(), so str() and toWire are the same for now (in the future we could add formatting to str version)
Added NullElement, and support for reading of exponent format
updated tests


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac172@2110 e5f2f494-b856-4b98-b285-d166d9295462

check map tag size in create functions too, for consistency, i think we should indeed remove the direct map access and constructor, see comment in ticket 129


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1668 e5f2f494-b856-4b98-b285-d166d9295462

it cannot exceed 255 bytes, but the "from string" constructor didn't check
it.  added test cases for long tags including this specific case.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1666 e5f2f494-b856-4b98-b285-d166d9295462

This is based on ideas done in experiments/jreed-layout, but
I manually did this again.

Moved around directory structures.
A single python subdirectory under src/lib for single "isc" module.
No "cpp" directories.

No pyshared or includes symlink trees.

I tested running the c++ tests and python tests.
I tested running run_bind10.sh from source tree (with nothing installed).
I tested running bind10 from installed (after moving source).


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1120 e5f2f494-b856-4b98-b285-d166d9295462

added isc::data::merge(element, element), that merges the values in the second mapelement into the first (copies the pointers that are present in the second element, and removes from a the values that are empty pointers in the second)

the ElementPtr passed to the module's config handler now only contains the data that has actually changed (settings that are the same as before are removed from what is passed to the config handler)


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1041 e5f2f494-b856-4b98-b285-d166d9295462

added a removeIdentical(mapelement, mapelement) for use in config update handlers


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1040 e5f2f494-b856-4b98-b285-d166d9295462

added unittest


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/jelte-configuration@809 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/parkinglot@710 e5f2f494-b856-4b98-b285-d166d9295462

added one more optional createFromString method that lets you specify the source file name for better error reporting


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/parkinglot@707 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/parkinglot@704 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/parkinglot@701 e5f2f494-b856-4b98-b285-d166d9295462

nearly complete code coverage (toXML is not covered, and the bad_alloc catches, should those be removed?)



git-svn-id: svn://bind10.isc.org/svn/bind10/branches/parkinglot@425 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/parkinglot@408 e5f2f494-b856-4b98-b285-d166d9295462

ISC -> isc
ISC::Data -> isc::data
ISC::CC -> isc::cc


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/parkinglot@407 e5f2f494-b856-4b98-b285-d166d9295462

also added a is_null(ElementPtr) function
added a test target to the main makefile (which will execute any executable binary in the tree that ends with "unittests")


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/parkinglot@387 e5f2f494-b856-4b98-b285-d166d9295462