- more consitify
- avoid using C-style cast
- combine two short lines

build/tests okay.  skipping review.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1725 e5f2f494-b856-4b98-b285-d166d9295462

- follow coding guidelines
- use anonymous namespace instead of file-static functions
- constify as much as possible.

build and tests are okay (basically no behavioral change), commiting to trunk skipping review.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1724 e5f2f494-b856-4b98-b285-d166d9295462

include "config.h" in public header files.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1610 e5f2f494-b856-4b98-b285-d166d9295462

- add unit test for wildcard->CNAME->NXRRSET
- add unit test for wildcard->CNAME->NXDOMAIN


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1496 e5f2f494-b856-4b98-b285-d166d9295462

on a flawed understanding of the protocol, and once the code had been
corrected, the tests needed to be corrected as well.)


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1479 e5f2f494-b856-4b98-b285-d166d9295462

wildcard record.  (Unit tests to follow in the morning.)


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1474 e5f2f494-b856-4b98-b285-d166d9295462

- query for NSEC, DS, or DNAME at a zone cut now returns a referral
  if the parent doesn't have data of the requested type to return


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1433 e5f2f494-b856-4b98-b285-d166d9295462

the class is IN.  Added a test case where this assumption could trigger a
catastrophic result.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1422 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1404 e5f2f494-b856-4b98-b285-d166d9295462

object so that they'll be valid regardless of how the QueryTask is constructed.

In the current usage patter the previous behavior is probably safe, but
since this object is passed beyond a scope of a single function, there's
always a risk of retaining a stale reference to a temporary object.  This fix
solves that potential problem.

Note that copy of these member objects should be cheap because in this sense
they are mostly native integer types.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1395 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1329 e5f2f494-b856-4b98-b285-d166d9295462

- handle wildcard queries correctly when there is a wildcard CNAME
- added a unit test for the nodata case (still need to do one for the CNAME)


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1317 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1316 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1311 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1301 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1289 e5f2f494-b856-4b98-b285-d166d9295462

if not set, the hardcoded default is used
Added removeDataSrc(ConstDataSrcPtr) to remove a running one (auth_srv has a copy of the currently running sqlite datasrcptr to keep track of this)
added test for addDataSrc and removeDataSrc (for which is also added an dataSrcCount() function)
removed zone_list from auth.spec to avoid confusion
updated ccsession to give a better error when there is something wrong (like a bad .spec file)


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1203 e5f2f494-b856-4b98-b285-d166d9295462

skip data sources that definitely won't match.  (I'm not sure about the
design here and may revisit it, but there should be a marginal speedup
from not having to compare every single qname to "authors.bind" and
"version.bind".)


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1191 e5f2f494-b856-4b98-b285-d166d9295462

- added a RETERR macro for readability


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1187 e5f2f494-b856-4b98-b285-d166d9295462

directly under the zone apex (i.e., a.b.c.d.e.foo.com), we need to return
the NSEC3 covering the closest enclosing name, not for the zone name
itself.  We also need to avoid sending multiple copies of the same NSEC3.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1184 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1183 e5f2f494-b856-4b98-b285-d166d9295462

now that the generic exception code is a separate library in the isc namespace
it doesn't make sense to call it dns_something.
I know it's a big change, but I believe we should do this cleanup sooner
than later.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1181 e5f2f494-b856-4b98-b285-d166d9295462

dynamically allocated "getNsec3Param *" can leak when exception happens
(and it can happen in this code) before it's deleted.

Remember: code that handles a bare pointer dynamically allocated by 'new' is
almost always buggy as long as we use exceptions.  let's drop that idea.

Note: in this specific case, shared_ptr is overspec because it doesn't have
to be shared.  boost::scoped_ptr should be sufficient, but since we already
rely on shared_ptr, I chose to minimize dependency.  (plus, NSEC3 processing
is heavy anyway, so performance overhead of shared_ptr doesn't matter much
in this context).


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1175 e5f2f494-b856-4b98-b285-d166d9295462

- fixed a bug in the NSEC3 hashing algorithm


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1158 e5f2f494-b856-4b98-b285-d166d9295462

- fixed several bugs in NSEC3 logic


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1155 e5f2f494-b856-4b98-b285-d166d9295462

 - refactored NSEC support
 - fixed bug in which NSEC records could be duplicated
 - added NSEC3 code -- please note NSEC3 is COMPLETELY untested


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1145 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1140 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1137 e5f2f494-b856-4b98-b285-d166d9295462

- changed QueryTask.qname from Name& to Name (forcing a copy)
  because it was possible for names to be deallocated before the
  task was serviced


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1136 e5f2f494-b856-4b98-b285-d166d9295462

 - added code for findCoveringNSEC3()


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1126 e5f2f494-b856-4b98-b285-d166d9295462

but IMO it doesn't make sense


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1121 e5f2f494-b856-4b98-b285-d166d9295462

This is based on ideas done in experiments/jreed-layout, but
I manually did this again.

Moved around directory structures.
A single python subdirectory under src/lib for single "isc" module.
No "cpp" directories.

No pyshared or includes symlink trees.

I tested running the c++ tests and python tests.
I tested running run_bind10.sh from source tree (with nothing installed).
I tested running bind10 from installed (after moving source).


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1120 e5f2f494-b856-4b98-b285-d166d9295462

- fixed memory leak for Datasrc* stored in the MetaDataSrc vector.
  there are several possible ways to do this, but I chose to using
  boost::shared_ptr.  expect for portability issues this seems to be the
  cleanest solution, and, regarding portability, we already heavily rely on
  boost anyway, so we should revisit the whole design if/when we seriously
  consider binary portability.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1118 e5f2f494-b856-4b98-b285-d166d9295462

this led to a larger refactoring:
  - I figured out we actually don't have to have this information in QueryTask:
    everything can be passed directly as a function argument.
  - I've also changed 'Name* zone' method argument to 'const Name*' based on
    the policy of 'make things const as much as possible'
  - also changed variable name from zone to zonename (because we might want to
    have a more generic notion of "zone" like BIND9's lib/dns/zone module)


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1113 e5f2f494-b856-4b98-b285-d166d9295462

- use forward declarations instead of including headers when possible
- partly as a result of that, moved method definitions from .h to .cc unless
  it does very trivial thing and is deemed to be performance sensitive.
- avoid 'using namespace' in header files
- made data-source related objects non-copyable as much as possible
- fixed a bug of an uninitialized variable
- made coding style more consistent


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1110 e5f2f494-b856-4b98-b285-d166d9295462

now that we support EDNS.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1092 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1023 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1018 e5f2f494-b856-4b98-b285-d166d9295462

  this should fix a memory leak
- changed several instances of "QueryTask t" to "QueryTask newtask",
  after Michael noted it as a readability problem


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1004 e5f2f494-b856-4b98-b285-d166d9295462

ticket #50 for full details)


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@988 e5f2f494-b856-4b98-b285-d166d9295462