GitLab

Fix a misspelling in a log output.
Also fix same misspelling in some comments and unittest output.

[2138] max number of columns (79)
[2138] recovered TEST_F(AuthConfigTest, exceptionGuarantee)
       to use server.setListenAddresses().

 from peliodic sending via statistics channel
 to passive retrieval via config session

- Added "getstats" command to retrieve statistics data via config session.
  = type "Auth getstats" command using bindctl shows statistics data.
- Removed StatisticsIntervalTimer
- Removed "sendstats" command
- Changed that each config command can return values.
  - returns Element::createlist(), Element::fromJSON("{}") or Statistics

Opinion:
- Each command should return conditions and values using createAnswer()
   rather than using throw/catch.

As most of the handling moved to the ConfigurableClientList, it got so
simple the separate validate() method needed more care to pass values
around than the work it actually did, so it got inlined.

Tests are not yet enabled. This is slightly against the TDD approach,
but the tests are mostly written, they just need to be enabled and
refactored, so it's not that bad.

Some of the previously disabled tests that needed #2046 are now enabled.

Some ripping out of internals (the old in-memory) happened on the way.
This led to temporarily commenting out some test code, but it was in
disabled tests anyway.

As it was no longer used to answer queries, the old data sources (both
the new API and old sqlite3 stuff) was ripped out. Their configuration
goes with them. The loadzone command, unfortunately, too, because it
handled the old stuff and we don't really have a way to load to
in-memory now (needs #2044/#2046) so it would do nothing anyway.

The configuration options are left in the spec file, because other
modules refer to them. Once the other modules are solved, it can be
removed.

See http://bind10.isc.org/ticket/1207#comment:11

The temporary name with the added P is no longer necessary now the original method has been removed.

Made the getZoneCount() method from inmemory client a general datasource client
call (which throws NotImplemented by default), as this does seem useful in other
 cases as well.

Now the work starts to pay off; removed the temporary pointer variable (getInMemoryClientP() still returns a pointer but now directly retrieved from the container), and any direct reference to isc::datasrc::InMemoryClient is removed from au
th_srv (but not from tests as of yet)

Instead of the direct shared_ptr.

Changes needed:
Moved loading of zones in config into the memory_datasrc implementation; at this moment the general API has no method for this (and it may not be necessary; datasources should handle their own config anyway).
This does have one drawback; through the dynamic loading mechanism we currently lose exception type information. So for now specific exceptions such as MasterLoadError end up as 'general' DataSourceErrors. Tests have been updated to reflect this.

Also, I made config handler slightly more lenient; it has hardcoded defaults and will now accept config parts without "class" or "zones"; using .spec -derived values is impractical here with the current config API, but in this case it shouldn't *really* matter; as IN is hardcoded in several places anyway atm.

The values are deduced from something else, no need to keep them. This
eliminates the ugly initialization with wrong values.

It is now placed into the getZoneConfig method. This is code cleanup
only, functionality should not be changed.

It now looks into the configuration and checks if the zone should be
loaded from the sqlite3 data source instead of the text file.

They'd get caught by an exception anyway.

zone->zone_finder in many cases

To preserve consistency.

And some more similar renaming. Just to match naming conventions.

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac467@4116 e5f2f494-b856-4b98-b285-d166d9295462