GitLab

This reverts commit 3f9c7bb8.

This issue was detected post-merge, and seems to have been introduced
by commit 86ed7ae9 in master.

Conflicts:
	src/bin/bind10/bind10_src.py.in

This has a chance that some log messages get lost (DEBUG messages during startup in case -v is not given but the config has DEBUG set)

This is for trac #2481. Review via jabber.

this will suppress a cppcheck error:
http://git.bind10.isc.org/~tester/builder//BIND10-cppcheck/20121209143001-FreeBSD8-amd64-GCC/logs/cppcheck.out

okayed on jabber.

by encapsulating the appender in SharedAppenderPtr immediately after the
creation, we can make sure buffer_appender1 won't leak even if the
creation of the second appender fails.

- renamed test class
- added a subclass of BufferAppender to directly test append()
(and re-enabled the relevant test case)
- minor doxy updates

And use those in the case of flushStdout() upon destruction

Since LogBuffer no longer exists, the file name did not match its content anymore

and pull its functionality into BufferAppender
(one unit test temporarily disabled, might be removed in next commit or updated to get around the protected method it uses)

The test used to create template files in a testdata folder without write
permissions. That caused 'make distcheck' errors. This regression had
been introduced with the ticket #2479. Okayed on jabber.

cppcheck was complaining about what was effectively:
const int A = 6; const int B = A; std::string array[b];

Changing this to
const int B = 6; std::string array[b];

... works

This reflects the fact that at the moment, the data is stored in
memory and not in a backing file.