GitLab

src/lib/dhcpsrv/client_class_def.cc
src/lib/dhcpsrv/client_class_def.h
src/lib/dhcpsrv/tests/client_class_def_unittest.cc
    New files that define client class storage classes and tests

src/lib/dhcp/classify.h
    Amended commentary to reflect how these classes are now being used.

src/lib/dhcp/option.h
    Added typedefs:
        boost::shared_ptr<Option> OptionPtr;
        boost::shared_ptr<OptionCollection> OptionCollectionPtr;

src/lib/dhcpsrv/Makefile.am
    Added entries for new files

src/lib/dhcpsrv/tests/Makefile.am
    Added entries for new file

src/lib/eval/token.h b/src/lib/eval/token.h
    Added typedef:
        boost::shared_ptr<Expression> ExpressionPtr;

reviewed by jelte via jabber.

Changes some log message descriptions and some
function arguments and some output.

Mostly adding "const" to methods that don't change the class, but
also correcting a few other points that were raised.

Also change type of exception thrown by packX() if universe is incorrect.

Also fix some issues from the review.

Definition now matches the declaration.

- it is now not possible to register 0 and 255 options
- all methods now use uint16_t for type
- many smaller coding style clean-ups
- added checks for option 0 and 255
- added test for InputBuffer constructor

- port is now specified using uint16_t in IfaceMgr
- support for proper DUID generation implemented
- implemented new tests
- new HWTYPEs defines
- unpack methods now return size_t type
- comments updated in option*.h headers

- Migrated from boost::shared_array to std::vector<uint8>
- Pkt6 now have all fields private, getters/setters implemented
- Many smaller clean-ups
- Tests updated to follow new procedure
- isc::util::OutputBuffer is now used

- processDiscover(), processRequest(), copyDefaultFields(),
  appendDefaultOptions() implemented in dhcpv4_srv class

- setUint8(), setUint16(), setUint32() added to Option class.

- Pkt4 class now properly sets packet type after parsing.

- DHCPv4 tests now simulate detection of 127.0.0.1 address
- DHCPv4 tests now open sockets on loopback
- Option::getUintX() now uses code from isc::util::getUintX
- Option::getUintX() methods are now documented
- Test for option::getUintX() implemented
- src/lib/dns/benchmarks/Makefile that was added by mistake removed

- len() returns now uint16_t type
- using pre-increment intead of post-increment
- using distance() function
- moved some simple implementation to header

- check() method added in Option class. Constructors are now simpler.
- compilation fix in option_unittest.cc

Added Option4_AddrLst class that represents DHCPv4 option that stores
a single IPv4 address or a list of IPv4 addresses.
Added tests for this new option.
Added check in Option6_AddrLst, so it accepts only IPv6 addresses.
Removed unnecessary pack4() method in Option class.