ISC Open Source Projects issueshttps://gitlab.isc.org/groups/isc-projects/-/issues2020-11-04T12:40:11Zhttps://gitlab.isc.org/isc-projects/stork/-/issues/400problems with access to private registry in push operation in demo deployment2020-11-04T12:40:11ZMichal Nowikowskiproblems with access to private registry in push operation in demo deployment0.13Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/kea/-/issues/1416perfdhcp should be able to generate traffic from multiple v6 subnets2021-05-17T13:44:40ZWlodzimierz Wencelperfdhcp should be able to generate traffic from multiple v6 subnetsperfdhcp can now simulate traffic from multiple subnets in v4 not v6. Implement this :) and then enable performance testsperfdhcp can now simulate traffic from multiple subnets in v4 not v6. Implement this :) and then enable performance testskea1.9.8Wlodzimierz WencelWlodzimierz Wencelhttps://gitlab.isc.org/isc-projects/kea/-/issues/1415Create container holding free leases for lease pre-allocation feature2020-09-16T14:49:39ZMarcin SiodelskiCreate container holding free leases for lease pre-allocation featureThe following document: https://gitlab.isc.org/isc-projects/kea/-/wikis/designs/Backend-Assisted-Lease-Selection-design describes how we're going to deal with the leases pre-allocation to improve performance of allocation when the pools ...The following document: https://gitlab.isc.org/isc-projects/kea/-/wikis/designs/Backend-Assisted-Lease-Selection-design describes how we're going to deal with the leases pre-allocation to improve performance of allocation when the pools are nearly exhausted. The key aspect of this design is how to store the free leases. This issue is meant to come up with a PoC of the container for free leases that would meet (or at least get close to) the following requirements:
- it must be possible to pre-allocate only a part of the pool and allocate more on demand,
- the offered leases must be returned in "random" order,
- the lease reclamation process should return the leases into this container efficiently,
- reclaimed leases should go to the back of the queue for the pool which they belong to (in case they belong to a pool),
- the state should be stored within the container, i.e. externally I should only call "give me a new lease and this is my 4th attempt"
- the container must not be tightly coupled with the Memfile backend so as it can be re-used as a lease pre-allocation mechanism for other backendskea1.9.0Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/bind9/-/issues/2132BIND 9.11 fails to build on FreeBSD with devel/jsoncpp installed2020-09-08T08:56:29ZMichal NowakBIND 9.11 fails to build on FreeBSD with devel/jsoncpp installed`9.11` (but not `9_16` and `main`) fails to build on FreeBSD when `devel/jsoncpp` is installed and JSON is enabled in BIND:
```
--- app.o ---
In file included from app.c:33:
In file included from ../include/isc/mem.h:20:
In file included...`9.11` (but not `9_16` and `main`) fails to build on FreeBSD when `devel/jsoncpp` is installed and JSON is enabled in BIND:
```
--- app.o ---
In file included from app.c:33:
In file included from ../include/isc/mem.h:20:
In file included from ../include/isc/json.h:36:
In file included from /usr/local/include/json/json.h:9:
/usr/local/include/json/config.h:8:10: fatal error: 'cstddef' file not found
#include <cstddef>
^~~~~~~~~
```
For the time being I resolved this locally by uninstalling `devel/jsoncpp` port.
Here's downstream bug report (for 9.14) https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243387 with a link to their solution.October 2020 (9.11.24, 9.11.24-S1, 9.16.8, 9.16.8-S1, 9.17.6)https://gitlab.isc.org/isc-projects/DNS-Compliance-Testing/-/issues/38Webpage links to Spammy Loan advertisement2020-09-09T00:05:27ZHanno BöckWebpage links to Spammy Loan advertisementThe webpage
https://ednscomp.isc.org/ednscomp/
contains a link to Boutell.com for the CGIC library.
It looks like this was previously the home of that library, but now it's an advertisement for some loans and looks very spammy.
CGIC se...The webpage
https://ednscomp.isc.org/ednscomp/
contains a link to Boutell.com for the CGIC library.
It looks like this was previously the home of that library, but now it's an advertisement for some loans and looks very spammy.
CGIC seems to be maintained on Github now:
https://github.com/boutell/cgic
(Also it seems it no longer comes under its own license terms - the "Basic License" - but under a normal MIT license.)https://gitlab.isc.org/isc-projects/bind9/-/issues/2131TSAN data race in accessing controls->symtab2020-09-24T11:28:26ZMark AndrewsTSAN data race in accessing controls->symtab```
WARNING: ThreadSanitizer: data race
Read of size 8 at 0x000000000001 by thread T1:
#0 isccc_symtab_foreach lib/isccc/symtab.c:277:14
#1 isccc_cc_cleansymtab lib/isccc/cc.c:954:2
#2 control_recvmessage bin/named/control...```
WARNING: ThreadSanitizer: data race
Read of size 8 at 0x000000000001 by thread T1:
#0 isccc_symtab_foreach lib/isccc/symtab.c:277:14
#1 isccc_cc_cleansymtab lib/isccc/cc.c:954:2
#2 control_recvmessage bin/named/controlconf.c:477:2
#3 recv_data lib/isccc/ccmsg.c:110:2
#4 read_cb lib/isc/netmgr/tcp.c:769:4
#5 <null> <null>
Previous write of size 8 at 0x000000000001 by thread T2:
#0 isccc_symtab_define lib/isccc/symtab.c:242:2
#1 isccc_cc_checkdup lib/isccc/cc.c:1026:11
#2 control_recvmessage bin/named/controlconf.c:478:11
#3 recv_data lib/isccc/ccmsg.c:110:2
#4 read_cb lib/isc/netmgr/tcp.c:769:4
#5 <null> <null>
Location is heap block of size 190352 at 0x000000000011 allocated by main thread:
#0 malloc <null>
#1 isccc_symtab_create lib/isccc/symtab.c:76:18
#2 isccc_cc_createsymtab lib/isccc/cc.c:948:10
#3 named_controls_create bin/named/controlconf.c:1483:11
#4 named_server_create bin/named/server.c:10057:2
#5 setup bin/named/main.c:1256:2
#6 main bin/named/main.c:1523:2
Thread T1 (running) created by main thread at:
#0 pthread_create <null>
#1 isc_thread_create lib/isc/pthreads/thread.c:73:8
#2 isc_nm_start lib/isc/netmgr/netmgr.c:215:3
#3 create_managers bin/named/main.c:909:15
#4 setup bin/named/main.c:1223:11
#5 main bin/named/main.c:1523:2
Thread T2 (running) created by main thread at:
#0 pthread_create <null>
#1 isc_thread_create lib/isc/pthreads/thread.c:73:8
#2 isc_nm_start lib/isc/netmgr/netmgr.c:215:3
#3 create_managers bin/named/main.c:909:15
#4 setup bin/named/main.c:1223:11
#5 main bin/named/main.c:1523:2
SUMMARY: ThreadSanitizer: data race lib/isccc/symtab.c:277:14 in isccc_symtab_foreach
```October 2020 (9.11.24, 9.11.24-S1, 9.16.8, 9.16.8-S1, 9.17.6)Mark AndrewsMark Andrewshttps://gitlab.isc.org/isc-projects/stork/-/issues/399automate tarballs and release notes deployment2020-09-14T07:06:43ZMichal Nowikowskiautomate tarballs and release notes deployment0.12https://gitlab.isc.org/isc-projects/bind9/-/issues/2130ThreadSanitizer: heap-use-after-free lib/ns/tests/nstest.c:125:11 in __wrap_i...2020-09-17T08:12:49ZOndřej SurýThreadSanitizer: heap-use-after-free lib/ns/tests/nstest.c:125:11 in __wrap_isc_nmhandle_detachHappens in !4089 MR:
```
WARNING: ThreadSanitizer: heap-use-after-free
Write of size 8 at 0x000000000001 by main thread:
#0 __wrap_isc_nmhandle_detach lib/ns/tests/nstest.c:125:11
#1 ns_test_qctx_destroy lib/ns/tests/nstest.c:8...Happens in !4089 MR:
```
WARNING: ThreadSanitizer: heap-use-after-free
Write of size 8 at 0x000000000001 by main thread:
#0 __wrap_isc_nmhandle_detach lib/ns/tests/nstest.c:125:11
#1 ns_test_qctx_destroy lib/ns/tests/nstest.c:872:3
#2 run_sfcache_test lib/ns/tests/query_test.c:163:2
#3 ns__query_sfcache_test lib/ns/tests/query_test.c:245:3
#4 cmocka_run_one_test_or_fixture <null>
#5 __libc_start_main /build/glibc-vjB4T1/glibc-2.28/csu/../csu/libc-start.c:308:16
Previous write of size 8 at 0x000000000001 by main thread (mutexes: write M1):
#0 free <null>
#1 default_memfree lib/isc/mem.c:742:2
#2 mem_put lib/isc/mem.c:654:2
#3 isc___mem_put lib/isc/mem.c:1110:3
#4 isc__mem_put lib/isc/mem.c:2439:2
#5 __wrap_isc_nmhandle_detach lib/ns/tests/nstest.c:122:3
#6 ns_test_qctx_destroy lib/ns/tests/nstest.c:872:3
#7 run_sfcache_test lib/ns/tests/query_test.c:163:2
#8 ns__query_sfcache_test lib/ns/tests/query_test.c:245:3
#9 cmocka_run_one_test_or_fixture <null>
#10 __libc_start_main /build/glibc-vjB4T1/glibc-2.28/csu/../csu/libc-start.c:308:16
Mutex M1 (0x000000000014) created at:
#0 pthread_mutex_init <null>
#1 isc__mutex_init lib/isc/pthreads/mutex.c:288:8
#2 mem_create lib/isc/mem.c:765:2
#3 isc_mem_create lib/isc/mem.c:2425:2
#4 ns_test_begin lib/ns/tests/nstest.c:303:2
#5 _setup lib/ns/tests/query_test.c:43:11
#6 cmocka_run_one_test_or_fixture <null>
#7 __libc_start_main /build/glibc-vjB4T1/glibc-2.28/csu/../csu/libc-start.c:308:16
SUMMARY: ThreadSanitizer: heap-use-after-free lib/ns/tests/nstest.c:125:11 in __wrap_isc_nmhandle_detach
```October 2020 (9.11.24, 9.11.24-S1, 9.16.8, 9.16.8-S1, 9.17.6)Evan HuntEvan Hunthttps://gitlab.isc.org/isc-projects/bind9/-/issues/2129ThreadSanitizer: data race bin/named/controlconf.c:645:22 in control_newconn2020-09-17T08:13:41ZOndřej SurýThreadSanitizer: data race bin/named/controlconf.c:645:22 in control_newconnThis happens !4089:
```
WARNING: ThreadSanitizer: data race
Write of size 1 at 0x000000000001 by thread T1:
#0 control_newconn bin/named/controlconf.c:645:22
#1 isc__nm_async_tcpchildaccept lib/isc/netmgr/tcp.c:493:2
#2 pro...This happens !4089:
```
WARNING: ThreadSanitizer: data race
Write of size 1 at 0x000000000001 by thread T1:
#0 control_newconn bin/named/controlconf.c:645:22
#1 isc__nm_async_tcpchildaccept lib/isc/netmgr/tcp.c:493:2
#2 process_queue lib/isc/netmgr/netmgr.c:625:4
#3 async_cb lib/isc/netmgr/netmgr.c:593:2
#4 uv__async_io obj-x86_64-linux-gnu/./src/unix/async.c:163:5
Previous write of size 1 at 0x000000000001 by thread T2:
#0 control_newconn bin/named/controlconf.c:645:22
#1 isc__nm_async_tcpchildaccept lib/isc/netmgr/tcp.c:493:2
#2 process_queue lib/isc/netmgr/netmgr.c:625:4
#3 async_cb lib/isc/netmgr/netmgr.c:593:2
#4 uv__async_io obj-x86_64-linux-gnu/./src/unix/async.c:163:5
Location is heap block of size 265 at 0x000000000007 allocated by thread T3:
#0 malloc <null>
#1 default_memalloc lib/isc/mem.c:713:8
#2 mem_get lib/isc/mem.c:622:8
#3 isc___mem_get lib/isc/mem.c:1044:9
#4 isc__mem_get lib/isc/mem.c:2432:10
#5 add_listener bin/named/controlconf.c:1118:13
#6 named_controls_configure bin/named/controlconf.c:1316:6
#7 load_configuration bin/named/server.c:9132:2
#8 run_server bin/named/server.c:9769:2
#9 dispatch lib/isc/task.c:1152:7
#10 run lib/isc/task.c:1344:2
Thread T1 (running) created by main thread at:
#0 pthread_create <null>
#1 isc_thread_create lib/isc/pthreads/thread.c:73:8
#2 isc_nm_start lib/isc/netmgr/netmgr.c:223:3
#3 create_managers bin/named/main.c:909:15
#4 setup bin/named/main.c:1223:11
#5 main bin/named/main.c:1523:2
Thread T2 (running) created by main thread at:
#0 pthread_create <null>
#1 isc_thread_create lib/isc/pthreads/thread.c:73:8
#2 isc_nm_start lib/isc/netmgr/netmgr.c:223:3
#3 create_managers bin/named/main.c:909:15
#4 setup bin/named/main.c:1223:11
#5 main bin/named/main.c:1523:2
Thread T3 (running) created by main thread at:
#0 pthread_create <null>
#1 isc_thread_create lib/isc/pthreads/thread.c:73:8
#2 isc_taskmgr_create lib/isc/task.c:1434:3
#3 create_managers bin/named/main.c:915:11
#4 setup bin/named/main.c:1223:11
#5 main bin/named/main.c:1523:2
SUMMARY: ThreadSanitizer: data race bin/named/controlconf.c:645:22 in control_newconn
```October 2020 (9.11.24, 9.11.24-S1, 9.16.8, 9.16.8-S1, 9.17.6)Evan HuntEvan Hunthttps://gitlab.isc.org/isc-projects/stork/-/issues/398Stork cannot connect large Kea installation2023-06-12T17:00:19ZPeter DaviesStork cannot connect large Kea installation---
name: Stork cannot connect large Kea installation
about: Stork 0.10 is unable to connect to agent when there a large number of subnets defined in Kea (1.8).
---
KEA 1.8.0 today and installed Stork 0.10, I noticed that Stork server c...---
name: Stork cannot connect large Kea installation
about: Stork 0.10 is unable to connect to agent when there a large number of subnets defined in Kea (1.8).
---
KEA 1.8.0 today and installed Stork 0.10, I noticed that Stork server can't connect to my large instances (with ~4500 subnets) and I see the following errors logged in Events tab:
grpc manager is unable to re-establish connection with the agent 192.168.1.5:8080: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (4607854 vs. 4194304)
RT [#17072](https://support.isc.org/Ticket/Modify.html?id=17072)
## Comments:
According to the gRPC doc there are two functions
to set maximum sizes:
- MaxCallRecvMsgSize
- MaxCallSendMsgSize
The default seems to be 4MB (confirmed by the error message).
Another idea is to use compression: JSON should
be very easy to compress efficiently...0.13Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/bind9/-/issues/2128Coverity missing lock warning 9.112020-09-18T01:56:59ZMark AndrewsCoverity missing lock warning 9.11```
*** CID 306682: Concurrent data access violations (MISSING_LOCK)
/lib/isc/tests/task_test.c: 799 in manytasks()
793 result = isc_mem_create(0, 0, &mctx);
794 assert_int_equal(result, ISC_R_SUCCESS);
795
796 resu...```
*** CID 306682: Concurrent data access violations (MISSING_LOCK)
/lib/isc/tests/task_test.c: 799 in manytasks()
793 result = isc_mem_create(0, 0, &mctx);
794 assert_int_equal(result, ISC_R_SUCCESS);
795
796 result = isc_taskmgr_create(mctx, 4, 0, &taskmgr);
797 assert_int_equal(result, ISC_R_SUCCESS);
798
CID 306682: Concurrent data access violations (MISSING_LOCK)
Accessing "done" without holding lock "lock". Elsewhere, "done" is accessed with "lock" held 8 out of 9 times.
799 done = false;
800
801 event = isc_event_allocate(mctx, (void *)1, 1, maxtask_cb,
802 (void *)ntasks, sizeof(*event));
803 assert_non_null(event);
804
```October 2020 (9.11.24, 9.11.24-S1, 9.16.8, 9.16.8-S1, 9.17.6)Mark AndrewsMark Andrewshttps://gitlab.isc.org/isc-projects/stork/-/issues/397Error in the example command line starting the agent2020-10-12T12:34:09ZMarcin SiodelskiError in the example command line starting the agentThe ARM says this in section 2.2.4:
```
$ sudo systemctl enable isc-stork-server
$ sudo systemctl start isc-stork-server
```
but should be:
```
$ sudo systemctl enable isc-stork-agent
$ sudo systemctl start isc-stork-agent
```The ARM says this in section 2.2.4:
```
$ sudo systemctl enable isc-stork-server
$ sudo systemctl start isc-stork-server
```
but should be:
```
$ sudo systemctl enable isc-stork-agent
$ sudo systemctl start isc-stork-agent
```0.12Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/396Canceling edit breaks down adding new machines2020-10-12T12:42:06ZTomek MrugalskiCanceling edit breaks down adding new machinesHere's how to repro this problem:
1. start as usual (`rake docker_up`)
1. add machine (don't close the tab)
1. click the crayon icon near the agent-kea:8080, click cancel
1. try to add another machine
When I click on the add new machin...Here's how to repro this problem:
1. start as usual (`rake docker_up`)
1. add machine (don't close the tab)
1. click the crayon icon near the agent-kea:8080, click cancel
1. try to add another machine
When I click on the add new machine, there's the popup (this works as intended). But once I type the name and click add, nothing happens visually and there's this error in the console.
![add-machine-fail](/uploads/c76a90bd79f0b48c7dd1814c50cf238c/add-machine-fail.png)0.11https://gitlab.isc.org/isc-projects/bind9/-/issues/2127Update ARM with lost changes since the conversion to RST files2020-09-22T07:43:31ZMatthijs Mekkingmatthijs@isc.orgUpdate ARM with lost changes since the conversion to RST filesThe ARM does not yet mention that signing can be done with `dnssec-policy` (oops).
This is caused by commit 9fb6d11abbdb10ded128f0ee5c004f24b4030ede (converting documentation to Sphinx). The commit was authored on March 31, 2019 and was...The ARM does not yet mention that signing can be done with `dnssec-policy` (oops).
This is caused by commit 9fb6d11abbdb10ded128f0ee5c004f24b4030ede (converting documentation to Sphinx). The commit was authored on March 31, 2019 and was merged on May 7, 2020.
It is likely that other documentation changes between that period may have been lost in translation.
@michal provided a `git` command to go over the changes to XML files that were made in that period.
```
git log --patch --color-words d571b3346818dd28bfca1528449e16bee86bb3cc..9fb6d11abbdb10ded128f0ee5c004f24b4030ede^ -- $(git diff-tree -r --no-commit-id --name-only 9fb6d11abbdb10ded128f0ee5c004f24b4030ede -- ':*.xml*' ':!doc/arm/notes*')
```
1. commit 978c7b2e89aa37a7ddfe2f6b6ba12ce73dd04528 changes `libdns` documentation but since the libraries have been
made private we no longer have to worry about that.
2. commit 98b3b93791777218c04a67ddaef22619162249f7 removes the Python based DNSSEC tools after the introduction of
`dnssec-policy`. They don't appear in the latest version of the RST files, so all good.
3. commit 4e8f8da6611d5dd93d058a4bb262085a85e128cf adds information on `nsdname-wait-recurse`. Yes, also present in
`reference.rst`.
4. commit 6fb568caae23e4adf7a43df24748bd7a902831e9 improves the readability of the bibliography. Lots of style
changes, but no content changes.
5. commit d9a6fef0201a1865542fdf6e51b7c759e484c339 shortens the text of mirror zones. That same change I see has
been made in `reference.rst`.
6. commit 9e4a153f3bc265cb6b0f4e65c54a21452da435bd use relative width for zone tables. No content changes.
7. commit 47e42d575027ce62f7e814d6703b45f113d66340 explains that DNSSEC keys are not shared among zones. I see that
text also in `reference.rst`.
8. commit 5a23e7abd157e39eb4ce98081c708bbeea12246f documents `max-ixfr-ratio`. The same text is present in
`advancded.rst` and `reference.rst`.
9. commit fa3fbf62e8bf2177a7b5caad5a592701835632e2 adds a clarification on "glob expression". Is also there in
`reference.rst`.
10. commit ba0313e649b9de3d746cc8a748cd02da75f258bd fixes spelling errors reported by Fossies. These also seem to
have been fixed in the RST files.
11. commit c7866acbf7805763f74c960bb1ba04a3581a9451 revises `dnssec-policy` documentation. Those revisions have also
been made in the RST files.
12. commit 21bb9fa77f7999ad4b64eb3245b38cd4927096cc improves query logging documentation. Those improvements can
also be seen in `reference.rst`.
13. commit 58aa084edc96ce00b58060a983c5cea86e470d29 adds support for algorithm mnemonics in `dnssec-policy`. Those
mnemonics have also been added in `reference.rst`.
14. commit 2733edb2a61da7094f85d6c28d77e2466114cf4f allows an unlimited key lifetime. Also in `reference.rst`.
15. commit 9dc630016eb2377ea75a54a5811e4048005caf3c renames `zone-max-ttl` to `max-zone-ttl` in both documentation
formats.
16. commit be3a11029a336f6a3d66bbd89ab72c3eb7b3caa1 documents forwarders config `port` and `dscp` parameters. Also
made it to `reference.rst`.
17. commit 05c6a29c87bbc84f1fbeaf79f3db8a01711e4005 documents that version also controls `authors.bind` in both
documentation formats.
18. commit fc36798a81cb1aeef54f482b7aa0d8704127247e removes the restriction that `key` and `ds` trust anchors cannot
be mixed. That restriction is also not present in the RST files.
19. commit 343c6d357cf6b99714da94dfd3c9760b0d4ed425 updates platform compatibility. Both documentation sets are in
sync with respect to platforms.
20. commit 2df13f79efa12335f52bcbe585e89bd695dceb17 adds `2020` to the copyright years. RST deals with that
differently.
21. commit 4b66c0ebf44a8b9f9b93df0aa62f6b78eb2a96fa changes some `dnssec-policy` defaults, also in `reference.rst`.
22. commit a339a6df482ec69362d05f0018d050ab576e10d6 updates documentation with durations. I see them in both.
23. commit 8fd8404e16a1511892a5e20c9c65143ec6687e3b removes two leftover `ttlval` references. No `ttlval` references
can be found in the RST files.
24. commit 8c37d3d320d9fd752446e148feb19d478aa27a77 renames `dnssec-keys` to `trust-anchors`. **It looks like the
changed made it, but grepping for `dnssec-keys` I found some leftover references to `dnssec-keys`.**
25. commit c29ccae2a6f70237f96db2c3beb70a0f30899acd documents `static-ds` and `static-key`. Also in `reference.rst`.
26. commit 45d6239829476652efc2aa48d20ad1d85cd00bba adds `dnssec-policy` grammar. This is also included in the RST
files.
27. commit 6468ffc3369c290d7aaa92a33de0ce8979b2cdae adds keywords to `dnssec-policy`'s `keys` clause, also in
`reference.rst`.
28. commit 1f0d6296a1501e372a0abb1f1f0c76b7815d361f exposes more key timing configurations. Those are also present
in `reference.rst`.
29. commit da0ae5299f51c0ffdd4edc3b880d105a64590cf6 updates DNSSEC documentation and adds `dnssec-policy` to the
list of methods to sign your zone. **This change did NOT make it in `dnssec.rst`.**
30. commit a50d707fdcf702e9e07a3ad5ea74761cb6e3d08d introduces `dnssec-policy`. Made it to `reference.rst`.
31. commit b7c5bfb203ea547f552e37c4ae14663c92953764 extends `ttlval` to also use ISO 8601 durations and was also
done in `reference.rst`.
32. commit c67379fb92b43229d9842a4df43eee401c31f5d0 changes indentation, so not important.
33. commit ebc61946b2d8f0c407eb64134768aba4669962ff adds a sentence on overlapping selectors. That sentence can
also be found in `reference.rst`.
34. commit e0618174b6b84e8c82b9d50ff1ffa89d3277e3c0 adds more info about `automatic-interface-scan` and `interface-
interval`. That info has also been added in `reference.rst`.
35. commit f7eea400a8f1ae8b7112c0a79bf29a681cb1adc8 changes the default for the `lock-file` to `none`. And in
`reference.rst` the default is also `none`.
36. commit c6f91f8bd0edb9be84995cda9392ee475c5cd925 adds `require-server-cookie` explanation. And `reference.rst`
explains the same thing.
37. commit c5453ea3283d4326116955a24cc0cd18397a5ebb adds `require-server-cookie` when to set. **The text is there
although has been reworded. I think this requires no further action.**
38. commit 1ea6aadf6fe2c5047431546ea424f964e03ea121 documents `resolver-nonbackoff-tries` and
`resolver-retry-interval`. It is also documented in `reference.rst`.
39. commit d8abf4f5b6e36f2feea608b509371f492aadc678 adds defaults for `require-server-cookie` and `send-cookie`
options. The `reference.rst` documents the same defaults.
40. commit a20c42dca68737ca341bd24fff403cf5c7940aa1 disables NSEC aggressive caching, alos in `reference.rst`.
41. commit aca78add3a686f7df1053efc3cba3b7df44b7342 removes discussion about fallback to plain DNS on timeout. I
don't see that discussion in `reference.rst` either.
42. commit 9fc4be226d7eb606071ccb07160ab2a42beddcf0 removes `rate-limit` reference from "Response Rate Limiting"
section. It is also missing in `reference.rst`.
43. commit 2ceb4b6a9853004dc73cda80e6b033e29edbad02 improves cache db statistics documentation. Also improved in
`reference.rst`.
44. commit c9d56a818522ace828aaec71400d2add992fddc1 documents the `~` mark in cache db statistics. `reference.rst`
also mentions the tilde mark.
45. commit 33bddbb5d18e17e909142c9a01d893da963697a7 clarifies relationship between ACLs and RPZs. That clarification
made it in `reference.rst`.
46. commit 5ed13fe426d37f496257574bd60797f9667ad484 removes DLV from ARM. The `general.rst` file also moves DLV to
historic.
47. commit 02d95d0b62b79c3354f27695370de5ffea13251d removes `dnssec-lookaside`. I don't see it anywhere in the RST
files.
48. commit a7ec7eb6edaa71c3cc141879ce23c5369bbabf87 checks bits 64..71 and so does `reference.rst`.
49. commit bded8af7b8188e71604e276ea2481638b530d939 corrects default for `rrset-order`. It changed to `random` and
that is also what is in `reference.rst`.
50. commit 9ba3e3f1b594c291999b45a036acbe3abb6b1126 converts `geoip` to `geoip2`. The added note regarding Windows
systems can also be found in `reference.rst`.
51. commit 55cca87d8a428c0e28ead80d474c040f28bbd53b removes references to legacy GeoIP. No "legacy GeoIP" mentions
can be found in the RST files.
52. commit 77c2a8bcbdad9684afae2c7ce77b331ee75d88aa removes spurious commas, moving on.
53. commit d1503cbfa28f1abf6052320753097b956d4a286d deprecates `dnssec-lookaside` validation (and was later removed,
so carry on).
54. commit a5dc24b25a7531c4172f98dec81d416896b81ba0 marks some `managed-keys` instances as deprecated and I have
seen them marked as deprecated in the RST files.
55. commit c9945d61482dff4e6657460ba74b5ac459342530 updates the ARM with the new GeoIP and those have made it into
`reference.rst`.
56. commit 3a3f40e3729e1e3ab32f6c18eeecfd4749812ffb includes a note on DNSSEC sign metrics. *This note has been
lost in `reference.rst`.**
57. commit e21103f2d37d339886b09387b08239c838d50ef1 fixes statistics for x86 Windows builds. The note on 32-bit
Windows that was added here cannot be found in the RST files, but that is because we dropped support for 32-bit
Windows. So all good.
58. commit 3853b3cf6d83cb144377963ee40ff51ffe5df667 updates documentation for `dnssec-keys`. Has made it to the RST
files.
59. commit a9dca5831b459617f309d6081a52f2d67b84b9f9 removes `cleaning-interval`. Also obsoleted in `reference.rst`.
60. commit 4889e06c3a16a0c7c746519ab7b803f15b4181c4 fixes NODATA ANCOUNT, and the same fix is in `reference.rst`.
61. commit d809ec6c14ca3b38c7466f82535c0fe5bfcb3e77 restores tcp-clients < interfaces. Also restored in
`reference.rst`.
62. commit b7e9115793f55372fba20901788936fb1e809d5e revises `minimal-responses`. The revision has also made it to
`reference.rst`.
63. commit 91dca0f8da192e8b3439e80717bad3bfc139118f updates documentation on `allow-update-forwarding`. The added
text can also be found in `reference.rst`.
64. commit 1d45ad8f39dcd66f7e664e5d05d4ac553fdcbc0b ignores trust anchors using disabled algorithms, and
`reference.rst` approves.
65. commit d06965862600485b8e68467fa4092b0c6504d28f removes `dnssec-enable` and is marked as obsoleted in
`reference.rst`.
66. commit d1fa8be611505755e389897f05659ab18d236e11 adds `add-soa` and is also added in `reference.rst`.October 2020 (9.11.24, 9.11.24-S1, 9.16.8, 9.16.8-S1, 9.17.6)Matthijs Mekkingmatthijs@isc.orgMatthijs Mekkingmatthijs@isc.orghttps://gitlab.isc.org/isc-projects/bind9/-/issues/2126Cycles in lock order graphs [v9.11]2020-09-23T01:24:32ZOndřej SurýCycles in lock order graphs [v9.11]## dns_view_findzonecut2 vs dns_resolver_createfetch3
```
WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock)
Cycle in lock order graph: M1 (0x000000000001) => M2 (0x000000000002) => M1
Mutex M2 acquired here while h...## dns_view_findzonecut2 vs dns_resolver_createfetch3
```
WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock)
Cycle in lock order graph: M1 (0x000000000001) => M2 (0x000000000002) => M1
Mutex M2 acquired here while holding mutex M1 in thread T1:
#0 pthread_mutex_lock <null>
#1 dns_view_findzonecut2 lib/dns/view.c:1300:2
#2 dns_view_findzonecut lib/dns/view.c:1261:9
#3 fctx_create lib/dns/resolver.c:4459:13
#4 dns_resolver_createfetch3 lib/dns/resolver.c:9630:12
#5 query_recurse bin/named/query.c:4368:11
#6 rpz_rrset_find bin/named/query.c:4677:13
#7 rpz_rewrite bin/named/query.c:5707:13
#8 query_find bin/named/query.c:7441:13
#9 query_resume bin/named/query.c:4164:12
#10 dispatch lib/isc/task.c:1157:7
#11 run lib/isc/task.c:1331:2
Mutex M1 previously acquired by the same thread here:
#0 pthread_mutex_lock <null>
#1 dns_resolver_createfetch3 lib/dns/resolver.c:9587:2
#2 query_recurse bin/named/query.c:4368:11
#3 rpz_rrset_find bin/named/query.c:4677:13
#4 rpz_rewrite bin/named/query.c:5707:13
#5 query_find bin/named/query.c:7441:13
#6 query_resume bin/named/query.c:4164:12
#7 dispatch lib/isc/task.c:1157:7
#8 run lib/isc/task.c:1331:2
Mutex M1 acquired here while holding mutex M2 in thread T1:
#0 pthread_mutex_lock <null>
#1 dns_resolver_shutdown lib/dns/resolver.c:9399:4
#2 view_flushanddetach lib/dns/view.c:603:4
#3 dns_view_detach lib/dns/view.c:654:2
#4 ns_client_endrequest bin/named/client.c:884:3
#5 exit_check bin/named/client.c:516:3
#6 ns_client_detach bin/named/client.c:3690:8
#7 query_find bin/named/query.c
#8 query_resume bin/named/query.c:4164:12
#9 dispatch lib/isc/task.c:1157:7
#10 run lib/isc/task.c:1331:2
Mutex M2 previously acquired by the same thread here:
#0 pthread_mutex_lock <null>
#1 view_flushanddetach lib/dns/view.c:601:3
#2 dns_view_detach lib/dns/view.c:654:2
#3 ns_client_endrequest bin/named/client.c:884:3
#4 exit_check bin/named/client.c:516:3
#5 ns_client_detach bin/named/client.c:3690:8
#6 query_find bin/named/query.c
#7 query_resume bin/named/query.c:4164:12
#8 dispatch lib/isc/task.c:1157:7
#9 run lib/isc/task.c:1331:2
Thread T1 (running) created by main thread at:
#0 pthread_create <null>
#1 isc_thread_create lib/isc/pthreads/thread.c:60:8
#2 isc__taskmgr_create lib/isc/task.c:1468:7
#3 isc_taskmgr_create lib/isc/task.c:2109:11
#4 create_managers bin/named/./main.c:886:11
#5 setup bin/named/./main.c:1305:11
#6 main bin/named/./main.c:1556:2
SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock) in pthread_mutex_lock
```
## dns_view_find2 vs dns_adb_createfind2
```
WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock)
Cycle in lock order graph: M1 (0x000000000000) => M2 (0x000000000001) => M3 (0x000000000000) => M1
Mutex M2 acquired here while holding mutex M1 in thread T1:
#0 pthread_mutex_lock <null>
#1 dns_view_find2 lib/dns/view.c:1038:2
#2 dbfind_name lib/dns/adb.c:3719:11
#3 dns_adb_createfind2 lib/dns/adb.c:3093:12
#4 dns_adb_createfind lib/dns/adb.c:2936:10
#5 notify_find_address lib/dns/zone.c:11137:11
#6 zone_notify lib/dns/zone.c:11593:3
#7 zone_maintenance lib/dns/zone.c:10268:4
#8 zone_timer lib/dns/zone.c:13113:2
#9 dispatch lib/isc/task.c:1157:7
#10 run lib/isc/task.c:1331:2
Mutex M1 previously acquired by the same thread here:
#0 pthread_mutex_lock <null>
#1 find_name_and_lock lib/dns/adb.c:2048:3
#2 dns_adb_createfind2 lib/dns/adb.c:3027:12
#3 dns_adb_createfind lib/dns/adb.c:2936:10
#4 notify_find_address lib/dns/zone.c:11137:11
#5 zone_notify lib/dns/zone.c:11593:3
#6 zone_maintenance lib/dns/zone.c:10268:4
#7 zone_timer lib/dns/zone.c:13113:2
#8 dispatch lib/isc/task.c:1157:7
#9 run lib/isc/task.c:1331:2
Mutex M3 acquired here while holding mutex M2 in thread T2:
#0 pthread_mutex_lock <null>
#1 dns_adb_shutdown lib/dns/adb.c:2909:2
#2 view_flushanddetach lib/dns/view.c:605:4
#3 dns_view_detach lib/dns/view.c:654:2
#4 ns_client_endrequest bin/named/client.c:884:3
#5 exit_check bin/named/client.c:516:3
#6 ns_client_detach bin/named/client.c:3690:8
#7 query_find bin/named/query.c
#8 query_resume bin/named/query.c:4164:12
#9 dispatch lib/isc/task.c:1157:7
#10 run lib/isc/task.c:1331:2
Mutex M2 previously acquired by the same thread here:
#0 pthread_mutex_lock <null>
#1 view_flushanddetach lib/dns/view.c:601:3
#2 dns_view_detach lib/dns/view.c:654:2
#3 ns_client_endrequest bin/named/client.c:884:3
#4 exit_check bin/named/client.c:516:3
#5 ns_client_detach bin/named/client.c:3690:8
#6 query_find bin/named/query.c
#7 query_resume bin/named/query.c:4164:12
#8 dispatch lib/isc/task.c:1157:7
#9 run lib/isc/task.c:1331:2
Mutex M1 acquired here while holding mutex M3 in thread T3:
#0 pthread_mutex_lock <null>
#1 shutdown_names lib/dns/adb.c:1231:3
#2 shutdown_stage2 lib/dns/adb.c:2894:8
#3 dispatch lib/isc/task.c:1157:7
#4 run lib/isc/task.c:1331:2
Mutex M3 previously acquired by the same thread here:
#0 pthread_mutex_lock <null>
#1 shutdown_stage2 lib/dns/adb.c:2891:2
#2 dispatch lib/isc/task.c:1157:7
#3 run lib/isc/task.c:1331:2
Thread T2 (running) created by main thread at:
#0 pthread_create <null>
#1 isc_thread_create lib/isc/pthreads/thread.c:60:8
#2 isc__taskmgr_create lib/isc/task.c:1468:7
#3 isc_taskmgr_create lib/isc/task.c:2109:11
#4 create_managers bin/named/./main.c:886:11
#5 setup bin/named/./main.c:1305:11
#6 main bin/named/./main.c:1556:2
Thread T2 (running) created by main thread at:
#0 pthread_create <null>
#1 isc_thread_create lib/isc/pthreads/thread.c:60:8
#2 isc__taskmgr_create lib/isc/task.c:1468:7
#3 isc_taskmgr_create lib/isc/task.c:2109:11
#4 create_managers bin/named/./main.c:886:11
#5 setup bin/named/./main.c:1305:11
#6 main bin/named/./main.c:1556:2
Thread T3 (running) created by main thread at:
#0 pthread_create <null>
#1 isc_thread_create lib/isc/pthreads/thread.c:60:8
#2 isc__taskmgr_create lib/isc/task.c:1468:7
#3 isc_taskmgr_create lib/isc/task.c:2109:11
#4 create_managers bin/named/./main.c:886:11
#5 setup bin/named/./main.c:1305:11
#6 main bin/named/./main.c:1556:2
SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock) in pthread_mutex_lock
```
## dns_view_find2 vs dns_adb_createfind2
```
WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock)
Cycle in lock order graph: M1 (0x000000000000) => M2 (0x000000000001) => M3 (0x000000000000) => M1
Mutex M2 acquired here while holding mutex M1 in thread T1:
#0 pthread_mutex_lock <null>
#1 dns_view_find2 lib/dns/view.c:1038:2
#2 dbfind_name lib/dns/adb.c:3719:11
#3 dns_adb_createfind2 lib/dns/adb.c:3133:12
#4 findname lib/dns/resolver.c:3166:11
#5 fctx_getaddresses lib/dns/resolver.c:3462:3
#6 fctx_try lib/dns/resolver.c:3819:12
#7 fctx_timeout lib/dns/resolver.c:4038:4
#8 dispatch lib/isc/task.c:1157:7
#9 run lib/isc/task.c:1331:2
Mutex M1 previously acquired by the same thread here:
#0 pthread_mutex_lock <null>
#1 find_name_and_lock lib/dns/adb.c:2048:3
#2 dns_adb_createfind2 lib/dns/adb.c:3027:12
#3 findname lib/dns/resolver.c:3166:11
#4 fctx_getaddresses lib/dns/resolver.c:3462:3
#5 fctx_try lib/dns/resolver.c:3819:12
#6 fctx_timeout lib/dns/resolver.c:4038:4
#7 dispatch lib/isc/task.c:1157:7
#8 run lib/isc/task.c:1331:2
Mutex M3 acquired here while holding mutex M2 in thread T2:
#0 pthread_mutex_lock <null>
#1 dns_adb_shutdown lib/dns/adb.c:2909:2
#2 view_flushanddetach lib/dns/view.c:605:4
#3 dns_view_detach lib/dns/view.c:654:2
#4 ns_client_endrequest bin/named/client.c:884:3
#5 exit_check bin/named/client.c:516:3
#6 ns_client_detach bin/named/client.c:3690:8
#7 query_find bin/named/query.c
#8 query_resume bin/named/query.c:4164:12
#9 dispatch lib/isc/task.c:1157:7
#10 run lib/isc/task.c:1331:2
Mutex M2 previously acquired by the same thread here:
#0 pthread_mutex_lock <null>
#1 view_flushanddetach lib/dns/view.c:601:3
#2 dns_view_detach lib/dns/view.c:654:2
#3 ns_client_endrequest bin/named/client.c:884:3
#4 exit_check bin/named/client.c:516:3
#5 ns_client_detach bin/named/client.c:3690:8
#6 query_find bin/named/query.c
#7 query_resume bin/named/query.c:4164:12
#8 dispatch lib/isc/task.c:1157:7
#9 run lib/isc/task.c:1331:2
Mutex M1 acquired here while holding mutex M3 in thread T2:
#0 pthread_mutex_lock <null>
#1 shutdown_names lib/dns/adb.c:1231:3
#2 shutdown_stage2 lib/dns/adb.c:2894:8
#3 dispatch lib/isc/task.c:1157:7
#4 run lib/isc/task.c:1331:2
Mutex M3 previously acquired by the same thread here:
#0 pthread_mutex_lock <null>
#1 shutdown_stage2 lib/dns/adb.c:2891:2
#2 dispatch lib/isc/task.c:1157:7
#3 run lib/isc/task.c:1331:2
Thread T2 (running) created by main thread at:
#0 pthread_create <null>
#1 isc_thread_create lib/isc/pthreads/thread.c:60:8
#2 isc__taskmgr_create lib/isc/task.c:1468:7
#3 isc_taskmgr_create lib/isc/task.c:2109:11
#4 create_managers bin/named/./main.c:886:11
#5 setup bin/named/./main.c:1305:11
#6 main bin/named/./main.c:1556:2
Thread T2 (running) created by main thread at:
#0 pthread_create <null>
#1 isc_thread_create lib/isc/pthreads/thread.c:60:8
#2 isc__taskmgr_create lib/isc/task.c:1468:7
#3 isc_taskmgr_create lib/isc/task.c:2109:11
#4 create_managers bin/named/./main.c:886:11
#5 setup bin/named/./main.c:1305:11
#6 main bin/named/./main.c:1556:2
SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock) in pthread_mutex_lock
```October 2020 (9.11.24, 9.11.24-S1, 9.16.8, 9.16.8-S1, 9.17.6)Mark AndrewsMark Andrewshttps://gitlab.isc.org/isc-projects/bind9/-/issues/2125Data races in dnstap [v9.11]2020-09-30T15:55:21ZOndřej SurýData races in dnstap [v9.11]There's all kind of data races in dnstap part of libdns:
## ThreadSanitizer: data race in fwrite
```
WARNING: ThreadSanitizer: data race
Read of size 8 at 0x000000000001 by thread T1:
#0 fwrite <null>
#1 <null> <null>
Previ...There's all kind of data races in dnstap part of libdns:
## ThreadSanitizer: data race in fwrite
```
WARNING: ThreadSanitizer: data race
Read of size 8 at 0x000000000001 by thread T1:
#0 fwrite <null>
#1 <null> <null>
Previous write of size 8 at 0x000000000001 by main thread:
#0 malloc <null>
#1 pack_dt lib/dns/dnstap.c:543:14
#2 dns_dt_send lib/dns/dnstap.c:779:6
#3 send_test lib/dns/tests/dnstap_test.c:258:3
#4 cmocka_run_one_test_or_fixture <null>
#5 __libc_start_main /build/glibc-vjB4T2/glibc-2.28/csu/../csu/libc-start.c:308:16
Location is heap block of size 256 at 0x000000000010 allocated by main thread:
#0 malloc <null>
#1 pack_dt lib/dns/dnstap.c:543:14
#2 dns_dt_send lib/dns/dnstap.c:779:6
#3 send_test lib/dns/tests/dnstap_test.c:258:3
#4 cmocka_run_one_test_or_fixture <null>
#5 __libc_start_main /build/glibc-vjB4T2/glibc-2.28/csu/../csu/libc-start.c:308:16
Thread T2 (running) created by main thread at:
#0 pthread_create <null>
#1 fstrm_iothr_init <null>
#2 send_test lib/dns/tests/dnstap_test.c:176:11
#3 cmocka_run_one_test_or_fixture <null>
#4 __libc_start_main /build/glibc-vjB4T2/glibc-2.28/csu/../csu/libc-start.c:308:16
SUMMARY: ThreadSanitizer: data race in fwrite
```
## ThreadSanitizer: data race in free
```
WARNING: ThreadSanitizer: data race
Write of size 8 at 0x000000000001 by thread T1:
#0 free <null>
#1 <null> <null>
Previous write of size 8 at 0x000000000001 by main thread:
#0 malloc <null>
#1 pack_dt lib/dns/dnstap.c:543:14
#2 dns_dt_send lib/dns/dnstap.c:779:6
#3 send_test lib/dns/tests/dnstap_test.c:260:3
#4 cmocka_run_one_test_or_fixture <null>
#5 __libc_start_main /build/glibc-vjB4T2/glibc-2.28/csu/../csu/libc-start.c:308:16
Thread T2 (running) created by main thread at:
#0 pthread_create <null>
#1 fstrm_iothr_init <null>
#2 send_test lib/dns/tests/dnstap_test.c:176:11
#3 cmocka_run_one_test_or_fixture <null>
#4 __libc_start_main /build/glibc-vjB4T2/glibc-2.28/csu/../csu/libc-start.c:308:16
SUMMARY: ThreadSanitizer: data race in free
```
## ThreadSanitizer: data race in memcpy
```
WARNING: ThreadSanitizer: data race
Read of size 8 at 0x000000000001 by thread T1:
#0 memcpy <null>
#1 <null> <null>
Previous write of size 8 at 0x000000000001 by main thread:
#0 memcpy <null>
#1 <null> <null>
#2 dns_dt_send lib/dns/dnstap.c:780:3
#3 send_test lib/dns/tests/dnstap_test.c:254:3
#4 cmocka_run_one_test_or_fixture <null>
#5 __libc_start_main /build/glibc-vjB4T2/glibc-2.28/csu/../csu/libc-start.c:308:16
Location is heap block of size 16384 at 0x000000000009 allocated by main thread:
#0 calloc <null>
#1 <null> <null>
#2 send_test lib/dns/tests/dnstap_test.c:176:11
#3 cmocka_run_one_test_or_fixture <null>
#4 __libc_start_main /build/glibc-vjB4T2/glibc-2.28/csu/../csu/libc-start.c:308:16
Thread T2 (running) created by main thread at:
#0 pthread_create <null>
#1 fstrm_iothr_init <null>
#2 send_test lib/dns/tests/dnstap_test.c:176:11
#3 cmocka_run_one_test_or_fixture <null>
#4 __libc_start_main /build/glibc-vjB4T2/glibc-2.28/csu/../csu/libc-start.c:308:16
SUMMARY: ThreadSanitizer: data race in memcpy
```October 2020 (9.11.24, 9.11.24-S1, 9.16.8, 9.16.8-S1, 9.17.6)Mark AndrewsMark Andrewshttps://gitlab.isc.org/isc-projects/stork/-/issues/395Sanity checks for 0.11.02022-02-02T09:51:29ZMichal NowikowskiSanity checks for 0.11.0Please do sanity checks according to steps below:
1. Please, get the tarball and check it, run tests.<br>
tarball: https://gitlab.isc.org/isc-projects/stork/-/jobs/1136730/artifacts/browse
2. Start demo locally (rake docker_up) ...Please do sanity checks according to steps below:
1. Please, get the tarball and check it, run tests.<br>
tarball: https://gitlab.isc.org/isc-projects/stork/-/jobs/1136730/artifacts/browse
2. Start demo locally (rake docker_up) and follow the steps from https://gitlab.isc.org/isc-projects/stork/-/wikis/Demo
3. Install server and agent locally e.g. in VMs from binary packages:<br>
debs: https://gitlab.isc.org/isc-projects/stork/-/jobs/1136731/artifacts/browse<br>
rpms: https://gitlab.isc.org/isc-projects/stork/-/jobs/1136732/artifacts/browse0.12https://gitlab.isc.org/isc-projects/bind9/-/issues/2124Bind 9.16.6 Assertion failure message.c:4733: REQUIRE(msg->state == (-1)) failed2023-07-01T10:18:15ZPeter DaviesBind 9.16.6 Assertion failure message.c:4733: REQUIRE(msg->state == (-1)) failed
### Summary
Bind exits with a assertion failure.
```
Sep 3 07:20:14 r9 named[63118]: message.c:4733: REQUIRE(msg->state == (-1)) failed, back trace
Sep 3 07:20:14 r9 named[63118]: #0 0x2ced70 in ??
Sep 3 07:20:14 r9 named[63118]:...
### Summary
Bind exits with a assertion failure.
```
Sep 3 07:20:14 r9 named[63118]: message.c:4733: REQUIRE(msg->state == (-1)) failed, back trace
Sep 3 07:20:14 r9 named[63118]: #0 0x2ced70 in ??
Sep 3 07:20:14 r9 named[63118]: #1 0x4b077a in ??
Sep 3 07:20:14 r9 named[63118]: #2 0x38eea3 in ??
Sep 3 07:20:14 r9 named[63118]: #3 0x404086 in ??
Sep 3 07:20:14 r9 named[63118]: #4 0x4d5a3c in ??
Sep 3 07:20:14 r9 named[63118]: #5 0x800a75736 in ??
Sep 3 07:20:14 r9 named[63118]: exiting (due to assertion failure).
```
### BIND version used
```
$ named -V
BIND 9.16.4 (Stable Release) <id:0849b42>
running on FreeBSD amd64 12.1-RELEASE-p6 FreeBSD 12.1-RELEASE-p6 GENERIC
built by make with '--disable-linux-caps' '--localstatedir=/var' '--sysconfdir=/usr/local/etc/namedb' '--with-dlopen=yes' '--with-libxml2' '--with-openssl=/usr' '--with-readline=-L/usr/local/lib -ledit' '--with-dlz-filesystem=yes' '--enable-dnstap' '--disable-fixed-rrset' '--disable-geoip' '--without-maxminddb' '--without-gssapi' '--with-libidn2=/usr/local' '--with-json-c' '--disable-largefile' '--with-lmdb=/usr/local' '--disable-native-pkcs11' '--without-python' '--disable-querytrace' 'STD_CDEFINES=-DDIG_SIGCHASE=1' '--enable-tcp-fastopen' '--with-tuning=large' '--disable-symtable' '--prefix=/usr/local' '--mandir=/usr/local/man' '--infodir=/usr/local/share/info/' '--build=amd64-portbld-freebsd12.1' 'build_alias=amd64-portbld-freebsd12.1' 'CC=cc' 'CFLAGS=-O2 -pipe -DLIBICONV_PLUG -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing ' 'LDFLAGS= -L/usr/local/lib -ljson-c -fstack-protector-strong ' 'LIBS=-L/usr/local/lib' 'CPPFLAGS=-DLIBICONV_PLUG -isystem /usr/local/include' 'CPP=cpp' 'PKG_CONFIG=pkgconf'
compiled by CLANG 4.2.1 Compatible FreeBSD Clang 8.0.1 (tags/RELEASE_801/final 366581)
compiled with OpenSSL version: OpenSSL 1.1.1d-freebsd 10 Sep 2019
linked to OpenSSL version: OpenSSL 1.1.1d-freebsd 10 Sep 2019
compiled with libxml2 version: 2.9.10
linked to libxml2 version: 20910
compiled with json-c version: 0.14
linked to json-c version: 0.14
compiled with zlib version: 1.2.11
linked to zlib version: 1.2.11
compiled with protobuf-c version: 1.3.2
linked to protobuf-c version: 1.3.2
threads support is enabled
default paths:
named configuration: /usr/local/etc/namedb/named.conf
rndc configuration: /usr/local/etc/namedb/rndc.conf
DNSSEC root key: /usr/local/etc/namedb/bind.keys
nsupdate session key: /var/run/named/session.key
named PID file: /var/run/named/pid
named lock file: /var/run/named/named.lock
```
### What is the current *bug* behavior?
Bind exits
### Relevant configuration files
See RT [#1776](https://support.isc.org/Ticket/Display.html?id=17076)
### Relevant logs and/or screenshots
```
Sep 3 07:20:14 r9 named[63118]: message.c:4733: REQUIRE(msg->state == (-1)) failed, back trace
Sep 3 07:20:14 r9 named[63118]: #0 0x2ced70 in ??
Sep 3 07:20:14 r9 named[63118]: #1 0x4b077a in ??
Sep 3 07:20:14 r9 named[63118]: #2 0x38eea3 in ??
Sep 3 07:20:14 r9 named[63118]: #3 0x404086 in ??
Sep 3 07:20:14 r9 named[63118]: #4 0x4d5a3c in ??
Sep 3 07:20:14 r9 named[63118]: #5 0x800a75736 in ??
Sep 3 07:20:14 r9 named[63118]: exiting (due to assertion failure).
```
### Comment:
- The failing assertion is `REQUIRE(msg->state == DNS_SECTION_ANY);`.
I do not think we have seen similar crashes in the past few months.
- Assuming this is a resolver without any secondary zones configured,
there is just one call to `dns_message_setclass()` that could have
triggered the crash: `lib/dns/resolver.c:7589`. It would be
interesting to see what state fctx->rmessage is in at the time of
the crash.
- Some ThreadSanitizer fixes were merged since 9.16.4, but I would
personally be surprised if any of them actually addressed this
problem.
- Maybe this is something related to prefetch? Nothing should be
touching `fctx->rmessage->state` until a response to a query comes
in... unless multiple queries are involved?October 2020 (9.11.24, 9.11.24-S1, 9.16.8, 9.16.8-S1, 9.17.6)Diego dos Santos FronzaDiego dos Santos Fronzahttps://gitlab.isc.org/isc-projects/dhcp/-/issues/134A core dump occurs when the dhclient process runs(x86)2021-03-02T07:27:16ZyuanxinA core dump occurs when the dhclient process runs(x86)---
name: Bug report
about: A core dump occurs when the dhclient process runs a normal test case(x86).
---
**Describe the bug**
When the dhclient process is running, the client->active in the state_bound function (in the dhclinet.c fil...---
name: Bug report
about: A core dump occurs when the dhclient process runs a normal test case(x86).
---
**Describe the bug**
When the dhclient process is running, the client->active in the state_bound function (in the dhclinet.c file) accesses a null pointer.
![12](/uploads/d4c705bd7e091fb3476ea13cf6510a18/12.png)
**To Reproduce**
1.modify the dhclinet.c code.
![123](/uploads/262ce731af9ff9f15af699f2fe373b7a/123.png)
2.make: Compile the modified code.
3.run the following command:
gdb –args ./dhclient –d xxx
(xxx indicates the network adapter name.)
4.Delete the
/var/lib/dhclient/dhclient.leases
file when the gdb is suspended after running.
**Expected behavior**
A coredump occurs.
**Environment:**
- DHCP version 4.4.2
**Additional Information**
Analyze the code and construct a scenario where the white-box problem is the same as the error code. The black-box problem cannot be reproduced.
**Contacting you**
Email : 1041793952@qq.comhttps://gitlab.isc.org/isc-projects/bind9/-/issues/2123Lock order inversions in main2020-09-17T08:28:16ZMark AndrewsLock order inversions in mainThere are a number of lock order inversions in !3997 that are applicable to main.
Extract them into a seperate MR so they can be applied to all applicable branches.There are a number of lock order inversions in !3997 that are applicable to main.
Extract them into a seperate MR so they can be applied to all applicable branches.October 2020 (9.11.24, 9.11.24-S1, 9.16.8, 9.16.8-S1, 9.17.6)