ISC Open Source Projects issueshttps://gitlab.isc.org/groups/isc-projects/-/issues2018-11-01T17:37:56Zhttps://gitlab.isc.org/isc-projects/bind9/-/issues/547Initial implementation of modules doesn't support multiple instances2018-11-01T17:37:56ZEvan HuntInitial implementation of modules doesn't support multiple instancesThe following discussion from !632 should be addressed:
- [ ] @michal started a [discussion](https://gitlab.isc.org/isc-projects/bind9/merge_requests/632#note_21178): (+1 comment)
> As for commit 882a62c61877dbbf8d964ca3be8147c700...The following discussion from !632 should be addressed:
- [ ] @michal started a [discussion](https://gitlab.isc.org/isc-projects/bind9/merge_requests/632#note_21178): (+1 comment)
> As for commit 882a62c61877dbbf8d964ca3be8147c700c2d0fa, I am afraid it does not solve another high-level issue that has only occurred to me just now: it is impossible to use two instances of a given hook module in separate views, which kind of renders the concept of per-view hook tables bogus :(
>
> I would consider reverting 882a62c61877dbbf8d964ca3be8147c700c2d0fa and moving to a more complex model that would solve both issues. An example would be:
>
> * track modules currently in use using a server-wide list; each element in that list would be a reference-counted structure representing a single shared object mapped using `dlopen()` (that can be released once its reference count drops to 0),
> * introduce hook instances (hey, remember b7a25260e13fe4b0d0913610c6cd679da1c56552? ;)), i.e. make every `hook` statement present in a configuration grab a reference to the module structure from the previous bullet point and make sure it acts independently from any other `hook` statements,
> * use instance-specific configuration and data tables in modules,
> * keep per-view lists of hook instances currently registered in that view's hook table.
>
> I know this hurts, but I do not think we can defend the current approach in the long run due to its very limited flexibility.
>
> Perhaps we should consider implementing this in a follow-up MR rather than right now. In any case, I think we should address this before making a release with hooks available.Evan HuntEvan Hunthttps://gitlab.isc.org/isc-projects/bind9/-/issues/655Bind9 Not Detected by system "Linux Mint 19"2018-11-03T02:31:01ZGhost UserBind9 Not Detected by system "Linux Mint 19"I finally figured out how to configure bind9 or so I thought, Because it was working a few months ago, Then when i rebooted my computer after updating bind9 is just acting really weird
I tried running "dig localhost" because It's link...I finally figured out how to configure bind9 or so I thought, Because it was working a few months ago, Then when i rebooted my computer after updating bind9 is just acting really weird
I tried running "dig localhost" because It's linked with /etc/bind/named.conf.default.zones
zone "localhost" {
type master;
file "/etc/bind/db.local";
};
zone "127.in-addr.arpa" {
type master;
file "/etc/bind/db.127";
};
Then my file "/etc/bind/db.local" held It's default
$TTL 604800
@ IN SOA localhost. root.localhost. (
22 ; Serial
604800 ; Refresh
86400 ; Retry
2419200 ; Expire
604800 ) ; Negative Cache TTL
;
@ IN NS localhost.
@ IN A 127.0.0.1
@ IN AAAA ::1
My /etc/hosts file has the original 127.0.0.1 localhost and the /etc/bind/named.conf.options file was
options {
directory "/var/cache/bind";
dnssec-validation auto;
auth-nxdomain no;
};
So i decided to change 127.0.0.1 to 127.1.0.1 inside of /etc/bind/db.local then restarted bind9 and i got no errors, nothing failed... checkzone came up ok for the file, But when i did a dig localhost the same thing came back 127.0.0.1 So i just copied /etc/bind/db.local to db.locallocal so it couldn't detect it, I restarted bind9, No errors. So i did a dig localhost and it still came back 127.0.0.1
What is happening here, Isn't the point of bind9 to resolve names to IPv4 address's, This isn't only an issue with the localhost, I also tried changing the zone name to a new name and it was not detected, and also made my own file and it resolved my ipv4 from my Ethernet in ifconfig, Not what i told it to resolve in my zone file
By the way i also went inside of /etc/hosts and tried changing 127.0.0.1 to 120.0.1.1https://gitlab.isc.org/isc-projects/bind9/-/issues/541After implementing hook modules, add a way to check them with named-checkconf2018-11-04T01:35:30ZEvan HuntAfter implementing hook modules, add a way to check them with named-checkconfThe following discussion from !632 should be addressed:
- [ ] @michal started a [discussion](https://gitlab.isc.org/isc-projects/bind9/merge_requests/632#note_20464):
> In the long run, we could use a method for checking various h...The following discussion from !632 should be addressed:
- [ ] @michal started a [discussion](https://gitlab.isc.org/isc-projects/bind9/merge_requests/632#note_20464):
> In the long run, we could use a method for checking various hook module configurations.Evan HuntEvan Hunthttps://gitlab.isc.org/isc-projects/kea/-/issues/180Address some doxygen warnings / errors2018-11-05T08:06:52ZFrancis DupontAddress some doxygen warnings / errorsKea1.5-beta2https://gitlab.isc.org/isc-projects/kea/-/issues/65library for yang <-> json configuration element translators2018-11-05T09:44:05ZGhost Userlibrary for yang <-> json configuration element translatorsNew library with yang <-> json translators for representation of configuration elements.
A priori one fro `src/lib/dhcpsrv/parsers` parse class.New library with yang <-> json translators for representation of configuration elements.
A priori one fro `src/lib/dhcpsrv/parsers` parse class.Kea1.5-beta1Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/issues/202distcheck failing after adding api documentation2018-11-05T10:11:58ZWlodzimierz Wenceldistcheck failing after adding api documentationAfter merging #10 we have distcheck failing, tried to mark that issue on jabber but nothing happened.
https://jenkins.isc.org/job/kea-master-distcheck/68/
error: https://jenkins.isc.org/job/kea-master-distcheck/68/execution/node/84/log...After merging #10 we have distcheck failing, tried to mark that issue on jabber but nothing happened.
https://jenkins.isc.org/job/kea-master-distcheck/68/
error: https://jenkins.isc.org/job/kea-master-distcheck/68/execution/node/84/log/
```
configure: creating ./config.status
config.status: creating Makefile
config.status: creating compatcheck/Makefile
config.status: creating dns++.pc
config.status: creating doc/Makefile
config.status: creating doc/guide/Makefile
config.status: creating doc/version.ent
config.status: error: cannot find input file: `doc/docgen/Makefile.in'
Makefile:833: recipe for target 'distcheck' failed
make: *** [distcheck] Error 1
```
I assume that code from docgen should be included into release package, so my fix is below (but I'm not sure if it's what Tomek had in mind)
```
diff --git a/doc/Makefile.am b/doc/Makefile.am
index 951c257..184e347 100644
--- a/doc/Makefile.am
+++ b/doc/Makefile.am
@@ -1,4 +1,4 @@
-SUBDIRS = guide
+SUBDIRS = guide docgen
EXTRA_DIST = version.ent.in Doxyfile Doxyfile-xml
EXTRA_DIST += devel/bison.dox
diff --git a/doc/docgen/Makefile.am b/doc/docgen/Makefile.am
index 72d8bd9..612d921 100644
--- a/doc/docgen/Makefile.am
+++ b/doc/docgen/Makefile.am
@@ -12,7 +12,7 @@ noinst_PROGRAMS = kea-docgen
kea_docgen_SOURCES = kea_docgen.cc
# For bare distcheck
-EXTRA_DIST = cmd_docgen
+EXTRA_DIST = generate-templates
kea_docgen_LDADD = $(top_builddir)/src/lib/cc/libkea-cc.la
kea_docgen_LDADD += $(top_builddir)/src/lib/exceptions/libkea-exceptions.la
```
also in some files in doc/docgen/ "cmd_docgen" is mentioned but not existing.
Marking this as critical because it's stalling my testing just before release.Kea1.5-beta1https://gitlab.isc.org/isc-projects/kea/-/issues/112distcheck failure2018-11-05T10:13:33ZWlodzimierz Wenceldistcheck failuredistcheck reporting error:
```
[ubuntu-64-latest] make[4]: Leaving directory '/home/jenkins/workspace/kea-master-distcheck/src/lib/eval'
[ubuntu-64-latest] (cd dhcpsrv && make top_distdir=../../../kea-1.4.0-git distdir=../../../kea-1....distcheck reporting error:
```
[ubuntu-64-latest] make[4]: Leaving directory '/home/jenkins/workspace/kea-master-distcheck/src/lib/eval'
[ubuntu-64-latest] (cd dhcpsrv && make top_distdir=../../../kea-1.4.0-git distdir=../../../kea-1.4.0-git/src/lib/dhcpsrv \
[ubuntu-64-latest] am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
[ubuntu-64-latest] make[4]: Entering directory '/home/jenkins/workspace/kea-master-distcheck/src/lib/dhcpsrv'
[ubuntu-64-latest] make[4]: *** No rule to make target 'parsers/dbaccess_parser.cc', needed by 'distdir'. Stop.
[ubuntu-64-latest] make[4]: Leaving directory '/home/jenkins/workspace/kea-master-distcheck/src/lib/dhcpsrv'
[ubuntu-64-latest] Makefile:531: recipe for target 'distdir' failed
[ubuntu-64-latest] make[3]: *** [distdir] Error 1
[ubuntu-64-latest] make[3]: Leaving directory '/home/jenkins/workspace/kea-master-distcheck/src/lib'
[ubuntu-64-latest] Makefile:526: recipe for target 'distdir' failed
[ubuntu-64-latest] make[2]: *** [distdir] Error 1
[ubuntu-64-latest] make[2]: Leaving directory '/home/jenkins/workspace/kea-master-distcheck/src'
[ubuntu-64-latest] Makefile:715: recipe for target 'distdir' failed
[ubuntu-64-latest] make[1]: *** [distdir] Error 1
[ubuntu-64-latest] make[1]: Leaving directory '/home/jenkins/workspace/kea-master-distcheck'
[ubuntu-64-latest] Makefile:814: recipe for target 'dist' failed
[ubuntu-64-latest] make: *** [dist] Error 2
```Kea1.5-beta1https://gitlab.isc.org/isc-projects/bind9/-/issues/654lame-servers due to qname-minimization2018-11-05T10:14:09ZTony Finchlame-servers due to qname-minimizationAfter the recent qmin refactoring, I noticed a *lot* of lame-servers warnings in my logs, listing the gtld-servers.net IP addresses. These warnings go away if I set `qname-minimization disabled;`
If I turn up the trace level, I can see ...After the recent qmin refactoring, I noticed a *lot* of lame-servers warnings in my logs, listing the gtld-servers.net IP addresses. These warnings go away if I set `qname-minimization disabled;`
If I turn up the trace level, I can see it sending (e.g.) `motherboard.vice.com. AAAA ?` to the gtld-servers then complaining when it gets a referral.
Earlier in the logs (in the space of about 1ms) it logs about doing a `createfind` for *every* gtld-server for this one query. This seems to be much too much! It then goes to find the vice.com NS and DS records, then sends the motherboard.vice.com queries to the gtld-servers. It all seems very confused.BIND-9.13.4Witold KrecickiWitold Krecickihttps://gitlab.isc.org/isc-projects/kea/-/issues/64a new hook to manage client class 'class_cmds'2018-11-05T16:48:10ZGhost Usera new hook to manage client class 'class_cmds'For yang/netconf and config backend we need a way to manage client-classes so a 'class_cmds' which provides the usual function: adding, querying (aka get) and deleting client classes from the running configuration.
Open questions:
- wh...For yang/netconf and config backend we need a way to manage client-classes so a 'class_cmds' which provides the usual function: adding, querying (aka get) and deleting client classes from the running configuration.
Open questions:
- where to put it? a priori support package
- what to do with dependent expressions? If a class is just removed this can lead to a configuration which cannot be reloaded so a priori expressions of following classes should be checked against dangling references.
- do we need a change/update? as the class order is critical IMHO we should provide one.
Note that class-list should simply return the list of configured class names. Add should append the new class to the end.Kea1.5-beta1Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/kea/-/issues/80HA: timeout for disabling DHCP service during lease synchronization should be...2018-11-05T19:25:30ZGhost UserHA: timeout for disabling DHCP service during lease synchronization should be controllableThe leases synchronization timeout is now controlled via the 'sync-timeout'. While the synchronization is performed, the DHCP service of the active partner is disabled, but for the hardcoded time of 60 seconds. This should either be the ...The leases synchronization timeout is now controlled via the 'sync-timeout'. While the synchronization is performed, the DHCP service of the active partner is disabled, but for the hardcoded time of 60 seconds. This should either be the same as the timeout for communication over the control channel or should have its own configuration knob. In fact, when we implement the #5652 we can't really set to the same value as the timeout for communication over control channel, because we will be sending multiple commands but the service should be disabled for the entire synchronization.Kea1.5-beta1https://gitlab.isc.org/isc-projects/kea/-/issues/78Extend HA hooks library to synchronize leases by chunks, i.e. multiple fetche...2018-11-05T19:25:30ZGhost UserExtend HA hooks library to synchronize leases by chunks, i.e. multiple fetches of leasesOne of the major use cases for the lease_cmds hooks library is to provide a way to synchronize leases between HA enabled servers. Currently the HA hooks library will fetch the entire lease database which requires the lease_cmds hooks lib...One of the major use cases for the lease_cmds hooks library is to provide a way to synchronize leases between HA enabled servers. Currently the HA hooks library will fetch the entire lease database which requires the lease_cmds hooks library to create a JSON structure of the whole lease database. This eats the CPU and memory. In case of large number of leases in the database it may freeze the server for a long period of time.
In order to mitigate this issue the lease_cmds hooks librart must support fetching limited number of leases, e.g. 1000, 2000 leases etc. The controlling client should be able to specify last fetched leases with the limit and the server should return leases with addresses beyond this last fetched address. That way, the entire lease database may be returned in chunks with client specifying the start of the next chunk.
This ticket is about extending the HA hooks library to utilize this mechanism implemented with #5651 in the lease_cmds.Kea1.5-beta1https://gitlab.isc.org/isc-projects/bind9/-/issues/645Get rid of vector socket functions2018-11-05T20:05:49ZWitold KrecickiGet rid of vector socket functionsisc_socket_recvv, isc_socket_sendv, isc_socket_sendtov, isc_socket_sendtov2 are used only by httpd and dig, we can get rid of them and simplify socket code.isc_socket_recvv, isc_socket_sendv, isc_socket_sendtov, isc_socket_sendtov2 are used only by httpd and dig, we can get rid of them and simplify socket code.Witold KrecickiWitold Krecickihttps://gitlab.isc.org/isc-projects/bind9/-/issues/634Unchecked returns in resolver.c2018-11-05T23:03:06ZMark AndrewsUnchecked returns in resolver.c```
10355 if (fctx->qmin_labels < nlabels) {
10356 /*
10357 * We want to query for qmin_labels from fctx->name
10358 */
10359 dns_fixedname_t fname;
10360 ...```
10355 if (fctx->qmin_labels < nlabels) {
10356 /*
10357 * We want to query for qmin_labels from fctx->name
10358 */
10359 dns_fixedname_t fname;
10360 dns_fixedname_init(&fname);
10361 dns_name_split(&fctx->name,
10362 fctx->qmin_labels,
10363 NULL, dns_fixedname_name(&fname));
CID 1436960 (#1 of 2): Unchecked return value (CHECKED_RETURN) [select issue]
10364 dns_name_dup(dns_fixedname_name(&fname), fctx->mctx,
10365 &fctx->qminname);
10366 fctx->qmintype = dns_rdatatype_ns;
10367 fctx->minimized = true;
10368 } else {
10369 /* Minimization is done, we'll ask for whole qname */
10370 fctx->qmintype = fctx->type;
CID 1436960 (#2 of 2): Unchecked return value (CHECKED_RETURN)
8. check_return: Calling dns_name_dup without checking return value (as is done elsewhere 59 out of 67 times).
10371 dns_name_dup(&fctx->name, fctx->mctx, &fctx->qminname);
10372 fctx->minimized = false;
10373 }
```https://gitlab.isc.org/isc-projects/bind9/-/issues/617If RRL is configured the "require-server-cookie yes;" is ignored.2018-11-05T23:18:38ZMichael McNallyIf RRL is configured the "require-server-cookie yes;" is ignored.David Beck of Men and Mice reported the following via e-mail to security-officer:
### Summary
If RRL is configured the "require-server-cookie yes;" is ignored.
### BIND Version used
```
% named -V
BIND 9.12.2 <id:3631aeb>
running on Li...David Beck of Men and Mice reported the following via e-mail to security-officer:
### Summary
If RRL is configured the "require-server-cookie yes;" is ignored.
### BIND Version used
```
% named -V
BIND 9.12.2 <id:3631aeb>
running on Linux x86_64 4.11.12-100.fc24.x86_64 #1 SMP Fri Jul 21 17:35:20 UTC 2017
built by make with '--sysconfdir=/etc/namedb'
compiled by GCC 8.2.0
compiled with OpenSSL version: OpenSSL 1.1.0h 27 Mar 2018
linked to OpenSSL version: OpenSSL 1.1.0h 27 Mar 2018
threads support is enabled
```
### Steps to reproduce
1. Use this very reduced configuration:
```
options {
directory "/etc/namedb"; require-server-cookie yes; rate-limit {};
};
zone "zoneXX.dnslab.org" { type master; file "zoneXX.dnslab.org"; };
```
Note that the empty rate-limit {} stanza with only defaults isn't the issue. I originally had responses-per-second, ipv4-prefix-length, and slip statements. I removed them one-by-one get to the core of the problem.
3. Have a valid zone file: zoneXX.dnslab.org
4. Start named
5. Query:
```
dig +norec @::1 zonexx.dnslab.org soa +nobadcookie
```
The response is NOERROR with the SOA being properly returned in the ANSWER section.
This is the bug. The response code should be BADCOOKIE.
### What is the expected *correct* behavior?
1. Remove or comment out: rate-limit {};
2. Load the new configuration.
3. Repeat the same query as above.
The response will be BADCOOKIE, which is correct.
### Relevant configuration files
See above.
### Relevant logs and/or screenshots
Running 'named -g' I saw nothing of use in the logs.
### Possible fixes
No idea.https://gitlab.isc.org/isc-projects/kea/-/issues/210NetconfAgentTest.validate unit tests failure2018-11-06T09:46:15ZWlodzimierz WencelNetconfAgentTest.validate unit tests failureI have failure of a unit test, ubuntu 16.04.5, weird thing this failure just on distcheck. Problem is that is on a system I am using for releases.
```
[ RUN ] NetconfAgentTest.validate
Server successfully configured.
Sending signal...I have failure of a unit test, ubuntu 16.04.5, weird thing this failure just on distcheck. Problem is that is on a system I am using for releases.
```
[ RUN ] NetconfAgentTest.validate
Server successfully configured.
Sending signal 2 to Kea process (pid=31226).
INFO/test_lib: wait_for_message DCTL_SHUTDOWN: .
INFO/test_lib: wait_for_server_down kea-netconf: ..
../../../../../../src/bin/netconf/tests/netconf_unittests.cc:276: Failure
Failed
timeout
../../../../../../src/bin/netconf/tests/netconf_unittests.cc:309: Failure
Expected: json = Element::fromJSON(rbuf) doesn't throw an exception.
Actual: it throws.
../../../../../../src/bin/netconf/tests/netconf_unittests.cc:310: Failure
Value of: json
Actual: false
Expected: true
../../../../../../src/bin/netconf/tests/netconf_unittests.cc:348: Failure
Value of: timeout
Actual: true
Expected: false
../../../../../../src/bin/netconf/tests/netconf_unittests.cc:349: Failure
Value of: accepted
Actual: false
Expected: true
../../../../../../src/bin/netconf/tests/netconf_unittests.cc:350: Failure
Value of: received
Actual: false
Expected: true
../../../../../../src/bin/netconf/tests/netconf_unittests.cc:351: Failure
Value of: sent
Actual: false
Expected: true
../../../../../../src/bin/netconf/tests/netconf_unittests.cc:352: Failure
Expected: sent
Which is: 0
To be equal to: sbuf.size()
Which is: 15
../../../../../../src/bin/netconf/tests/netconf_unittests.cc:291: Failure
Value of: ec
Actual: true
Expected: false
../../../../../../src/bin/netconf/tests/netconf_unittests.cc:1055: Failure
Expected: 2
To be equal to: requests_.size()
Which is: 1
PASSED netconf.sigint_test
START TEST netconf.variables
[ FAILED ] NetconfAgentTest.validate (1546 ms)
```https://gitlab.isc.org/isc-projects/kea/-/issues/207crypto compilation error after crypto change in kea core2018-11-06T09:48:04ZWlodzimierz Wencelcrypto compilation error after crypto change in kea corehttps://jenkins.isc.org/job/kea-master/75/execution/node/133/log/
https://jenkins.isc.org/job/kea-master/75/execution/node/108/log/
```
../../../../../../src/lib/dhcpsrv/.libs/libkea-dhcpsrv.so: undefined reference to `isc::cryptolink::...https://jenkins.isc.org/job/kea-master/75/execution/node/133/log/
https://jenkins.isc.org/job/kea-master/75/execution/node/108/log/
```
../../../../../../src/lib/dhcpsrv/.libs/libkea-dhcpsrv.so: undefined reference to `isc::cryptolink::random(unsigned long)'
collect2: error: ld returned 1 exit status
Makefile:580: recipe for target 'libdhcp_legal_log_unittests' failed
make[9]: *** [libdhcp_legal_log_unittests] Error 1
```
solution:
```
diff --git a/src/hooks/dhcp/flex_id/tests/Makefile.am b/src/hooks/dhcp/flex_id/tests/Makefile.am
index 37f35e3..f1c3323 100644
--- a/src/hooks/dhcp/flex_id/tests/Makefile.am
+++ b/src/hooks/dhcp/flex_id/tests/Makefile.am
@@ -45,6 +45,7 @@ flex_id_unittests_LDADD += $(top_builddir)/src/lib/hooks/libkea-hooks.la
flex_id_unittests_LDADD += $(top_builddir)/src/lib/log/libkea-log.la
flex_id_unittests_LDADD += $(top_builddir)/src/lib/util/libkea-util.la
flex_id_unittests_LDADD += $(top_builddir)/src/lib/exceptions/libkea-exceptions.la
+flex_id_unittests_LDADD += $(top_builddir)/src/lib/cryptolink/libkea-cryptolink.la
flex_id_unittests_LDADD += $(LOG4CPLUS_LIBS)
flex_id_unittests_LDADD += $(CRYPTO_LIBS)
flex_id_unittests_LDADD += $(BOOST_LIBS)
diff --git a/src/hooks/dhcp/forensic_log/libloadtests/Makefile.am b/src/hooks/dhcp/forensic_log/libloadtests/Makefile.am
index 7d204fc..d7485d6 100644
--- a/src/hooks/dhcp/forensic_log/libloadtests/Makefile.am
+++ b/src/hooks/dhcp/forensic_log/libloadtests/Makefile.am
@@ -65,6 +65,7 @@ libdhcp_legal_log_unittests_LDADD += $(top_builddir)/src/lib/hooks/libkea-hooks.
libdhcp_legal_log_unittests_LDADD += $(top_builddir)/src/lib/log/libkea-log.la
libdhcp_legal_log_unittests_LDADD += $(top_builddir)/src/lib/util/libkea-util.la
libdhcp_legal_log_unittests_LDADD += $(top_builddir)/src/lib/exceptions/libkea-exceptions.la
+libdhcp_legal_log_unittests_LDADD += $(top_builddir)/src/lib/cryptolink/libkea-cryptolink.la
libdhcp_legal_log_unittests_LDADD += $(LOG4CPLUS_LIBS)
libdhcp_legal_log_unittests_LDADD += $(CRYPTO_LIBS)
libdhcp_legal_log_unittests_LDADD += $(BOOST_LIBS)
diff --git a/src/hooks/dhcp/host_cache/libloadtests/Makefile.am b/src/hooks/dhcp/host_cache/libloadtests/Makefile.am
index d282abd..0036d21 100644
--- a/src/hooks/dhcp/host_cache/libloadtests/Makefile.am
+++ b/src/hooks/dhcp/host_cache/libloadtests/Makefile.am
@@ -44,6 +44,7 @@ libdhcp_host_cache_unittests_LDADD += $(top_builddir)/src/lib/dns/libkea-dns++.l
libdhcp_host_cache_unittests_LDADD += $(top_builddir)/src/lib/log/libkea-log.la
libdhcp_host_cache_unittests_LDADD += $(top_builddir)/src/lib/util/libkea-util.la
libdhcp_host_cache_unittests_LDADD += $(top_builddir)/src/lib/exceptions/libkea-exceptions.la
+libdhcp_host_cache_unittests_LDADD += $(top_builddir)/src/lib/cryptolink/libkea-cryptolink.la
libdhcp_host_cache_unittests_LDADD += $(LOG4CPLUS_LIBS)
libdhcp_host_cache_unittests_LDADD += $(CRYPTO_LIBS)
libdhcp_host_cache_unittests_LDADD += $(BOOST_LIBS)
diff --git a/src/hooks/dhcp/host_cache/tests/Makefile.am b/src/hooks/dhcp/host_cache/tests/Makefile.am
index 007bb92..724b03a 100644
--- a/src/hooks/dhcp/host_cache/tests/Makefile.am
+++ b/src/hooks/dhcp/host_cache/tests/Makefile.am
@@ -51,6 +51,7 @@ host_cache_unittests_LDADD += $(top_builddir)/src/lib/database/libkea-database.l
host_cache_unittests_LDADD += $(top_builddir)/src/lib/log/libkea-log.la
host_cache_unittests_LDADD += $(top_builddir)/src/lib/util/libkea-util.la
host_cache_unittests_LDADD += $(top_builddir)/src/lib/exceptions/libkea-exceptions.la
+host_cache_unittests_LDADD += $(top_builddir)/src/lib/cryptolink/libkea-cryptolink.la
host_cache_unittests_LDADD += $(LOG4CPLUS_LIBS)
host_cache_unittests_LDADD += $(CRYPTO_LIBS)
host_cache_unittests_LDADD += $(BOOST_LIBS)
diff --git a/src/hooks/dhcp/host_cmds/tests/Makefile.am b/src/hooks/dhcp/host_cmds/tests/Makefile.am
index ab2efaf..1c0c488 100644
--- a/src/hooks/dhcp/host_cmds/tests/Makefile.am
+++ b/src/hooks/dhcp/host_cmds/tests/Makefile.am
@@ -44,6 +44,7 @@ host_cmds_unittests_LDADD += $(top_builddir)/src/lib/hooks/libkea-hooks.la
host_cmds_unittests_LDADD += $(top_builddir)/src/lib/log/libkea-log.la
host_cmds_unittests_LDADD += $(top_builddir)/src/lib/util/libkea-util.la
host_cmds_unittests_LDADD += $(top_builddir)/src/lib/exceptions/libkea-exceptions.la
+host_cmds_unittests_LDADD += $(top_builddir)/src/lib/cryptolink/libkea-cryptolink.la
host_cmds_unittests_LDADD += $(LOG4CPLUS_LIBS)
host_cmds_unittests_LDADD += $(CRYPTO_LIBS)
host_cmds_unittests_LDADD += $(BOOST_LIBS)
```Wlodzimierz WencelWlodzimierz Wencelhttps://gitlab.isc.org/isc-projects/kea/-/issues/58KB article about required classes2018-11-07T00:06:51ZGhost UserKB article about required classesKea1.5-beta1Cathy AlmondCathy Almondhttps://gitlab.isc.org/isc-projects/kea/-/issues/230delete FAQ from docs2018-11-07T03:47:26ZVicky Riskvicky@isc.orgdelete FAQ from docs@tomek This shouldn't be here, it should be in the KB. What is in the FAQ is not even the frequently-asked questions.
I wanted to delete the file myself, but the last thing I want to do right before the beta release is break the build. ...@tomek This shouldn't be here, it should be in the KB. What is in the FAQ is not even the frequently-asked questions.
I wanted to delete the file myself, but the last thing I want to do right before the beta release is break the build. I didn't see a mention of the faq.xml in the makefile in the guide directory, but I assume it is listed somewhere ...https://gitlab.isc.org/isc-projects/kea/-/issues/215Premium hooks compilation failure (forensic-log)2018-11-07T04:18:52ZTomek MrugalskiPremium hooks compilation failure (forensic-log)@wlodek reported a compilation failure on debian9-64-3 (yes, that's the same machine again):
Full log [on jenkins](https://jenkins.isc.org/job/kea-master/82/execution/node/128/log/).
Important part:
```
libtool: link: ccache g++ -Wall ...@wlodek reported a compilation failure on debian9-64-3 (yes, that's the same machine again):
Full log [on jenkins](https://jenkins.isc.org/job/kea-master/82/execution/node/128/log/).
Important part:
```
libtool: link: ccache g++ -Wall -Wextra -Wnon-virtual-dtor -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -pthread -Wno-missing-field-initializers -fPIC -g -O2 -o .libs/libdhcp_legal_log_unittests libdhcp_legal_log_unittests-run_unittests.o libdhcp_legal_log_unittests-backend_store_unittests.o libdhcp_legal_log_unittests-command_log_unittests.o libdhcp_legal_log_unittests-legal_log4_unittests.o libdhcp_legal_log_unittests-legal_log6_unittests.o libdhcp_legal_log_unittests-rotating_file_unittests.o ../../../../../../src/lib/dhcpsrv/testutils/.libs/libdhcpsrvtest.a /home/jenkins/workspace/kea-master/src/lib/database/.libs/libkea-database.so -L/opt/log4cplus/lib /home/jenkins/workspace/kea-master/src/lib/cc/.libs/libkea-cc.so /home/jenkins/workspace/kea-master/src/lib/log/.libs/libkea-log.so /home/jenkins/workspace/kea-master/src/lib/util/threads/.libs/libkea-threads.so ../../../../../../premium/src/hooks/dhcp/forensic_log/.libs/liblegl.a ../../../../../../src/lib/dhcpsrv/.libs/libkea-dhcpsrv.so ../../../../../../src/lib/process/.libs/libkea-process.so ../../../../../../src/lib/dhcp/.libs/libkea-dhcp++.so ../../../../../../src/lib/database/testutils/.libs/libdatabasetest.a ../../../../../../src/lib/database/.libs/libkea-database.so ../../../../../../src/lib/asiolink/.libs/libkea-asiolink.so ../../../../../../src/lib/hooks/.libs/libkea-hooks.so ../../../../../../src/lib/testutils/.libs/libkea-testutils.a /home/jenkins/workspace/kea-master/src/lib/asiolink/.libs/libkea-asiolink.so /home/jenkins/workspace/kea-master/src/lib/dns/.libs/libkea-dns++.so /home/jenkins/workspace/kea-master/src/lib/cryptolink/.libs/libkea-cryptolink.so /home/jenkins/workspace/kea-master/src/lib/util/.libs/libkea-util.so /home/jenkins/workspace/kea-master/src/lib/exceptions/.libs/libkea-exceptions.so -lpthread ../../../../../../src/lib/cc/.libs/libkea-cc.so ../../../../../../src/lib/log/.libs/libkea-log.so ../../../../../../src/lib/util/.libs/libkea-util.so ../../../../../../src/lib/exceptions/.libs/libkea-exceptions.so /opt/log4cplus/lib/liblog4cplus.so -lcrypto -lboost_system ../../../../../../ext/gtest/libgtest.a -ldl -pthread -Wl,-rpath -Wl,/home/jenkins/kea_installed/lib -Wl,-rpath -Wl,/opt/log4cplus/lib
../../../../../../src/lib/dhcpsrv/.libs/libkea-dhcpsrv.so: undefined reference to `isc::dhcp::dependOnClass(boost::shared_ptr<std::vector<boost::shared_ptr<isc::dhcp::Token>, std::allocator<boost::shared_ptr<isc::dhcp::Token> > > > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
collect2: error: ld returned 1 exit status
Makefile:631: recipe for target 'libdhcp_legal_log_unittests' failed
make[9]: *** [libdhcp_legal_log_unittests] Error 1
make[9]: Leaving directory '/home/jenkins/workspace/kea-master/premium/src/hooks/dhcp/forensic_log/tests'
```Kea1.5-beta1https://gitlab.isc.org/isc-projects/kea/-/issues/120Problems building and running tests with master2018-11-07T04:26:26ZFrancis DupontProblems building and running tests with master3 common issues in building:
- libprocess commented in `src/lib/dhcpsrv/Makefile.am`
- `src/bin/netconf/main.cc` include not updated moving daemon code from dhcpsrv to process library.
- `src/bin/netconf/main.cc` still using ```isc::d...3 common issues in building:
- libprocess commented in `src/lib/dhcpsrv/Makefile.am`
- `src/bin/netconf/main.cc` include not updated moving daemon code from dhcpsrv to process library.
- `src/bin/netconf/main.cc` still using ```isc::dhcp::Daemon``` space (again ```s/dhcp/process/```.
One specific to macOS: `DaemonTest.createPIDFileOverwrite` stalls. I propose to change the ```exit (0);``` line 216 of `src/lib/process/tests/daemon_unittest.cc` by ```_exit (0);``` which BTW is safer and faster.Kea1.5-beta1