ISC Open Source Projects issueshttps://gitlab.isc.org/groups/isc-projects/-/issues2021-05-04T14:32:10Zhttps://gitlab.isc.org/isc-projects/kea/-/issues/1441RADIUS hook tweaks for Cisco hardware: optional different formatting of a par...2021-05-04T14:32:10ZTomek MrugalskiRADIUS hook tweaks for Cisco hardware: optional different formatting of a parameterThere's a [support#16875](https://support.isc.org/Ticket/Display.html?id=16875), asking for solution to the RADIUS problem with non-standard formatting for a parameter. In this deployment, a Cisco hardware is used as RADIUS server.
The ...There's a [support#16875](https://support.isc.org/Ticket/Display.html?id=16875), asking for solution to the RADIUS problem with non-standard formatting for a parameter. In this deployment, a Cisco hardware is used as RADIUS server.
The implementation expects the radius attribute conveying the MAC address to use a non-standard 0000.0000.0000, rather than the typical 00:00:00:00:00:00.
I haven't looked at the implementation, but it seems reasonable to provide an optional formatting knob that, when enabled, will use this alternative formatting. The default should remain as it is now.kea1.9.1Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/bind9/-/issues/2193TSAN errors in v9_16 to be investigated.2020-10-02T01:43:18ZMark AndrewsTSAN errors in v9_16 to be investigated.Job [#1192145](https://gitlab.isc.org/isc-projects/bind9/-/jobs/1192145) failed for fc3cab22a44cff8458cf39865836c7e5d883cbed:
```
I:System test result summary:
I: 2 FAIL
I: 94 PASS
I: 3 SKIPPED
I:The following system tests...Job [#1192145](https://gitlab.isc.org/isc-projects/bind9/-/jobs/1192145) failed for fc3cab22a44cff8458cf39865836c7e5d883cbed:
```
I:System test result summary:
I: 2 FAIL
I: 94 PASS
I: 3 SKIPPED
I:The following system tests failed:
I: nsupdate
I: tcp
I:ThreadSanitizer reported issues for the following system tests:
I: tcp
```
Races over access to `sock->rcb.recv` and `sock->rcbarg`. `sock->rcbarg` in this case.
`sock->rcbarg` is set to NULL before calling `isc_nm_stoplistening`. Additionally we
need to wait for isc_nm_stoplistening to be processed when it is sent via the event
queue.
```
WARNING: ThreadSanitizer: data race
Read of size 8 at 0x000000000001 by thread T1:
#0 processbuffer lib/isc/netmgr/tcpdns.c:185:15
#1 resume_processing lib/isc/netmgr/tcpdns.c:421:12
#2 isc_nmhandle_unref lib/isc/netmgr/netmgr.c:1173:4
#3 isc__nm_uvreq_put lib/isc/netmgr/netmgr.c:1288:3
#4 tcpdnssend_cb lib/isc/netmgr/tcpdns.c:449:2
#5 tcp_send_cb lib/isc/netmgr/tcp.c:892:2
#6 <null> <null>
Previous write of size 8 at 0x000000000001 by thread T2 (mutexes: write M1):
#0 memset <null>
#1 isc__nm_tcpdns_stoplistening lib/isc/netmgr/tcpdns.c:330:15
#2 isc_nm_stoplistening lib/isc/netmgr/netmgr.c:1358:3
#3 ns_interface_shutdown lib/ns/interfacemgr.c:564:3
#4 purge_old_interfaces lib/ns/interfacemgr.c:658:4
#5 ns_interfacemgr_shutdown lib/ns/interfacemgr.c:386:2
#6 shutdown_server bin/named/./server.c:9851:2
#7 dispatch lib/isc/task.c:1152:7
#8 run lib/isc/task.c:1344:2
```November 2020 (9.11.25, 9.11.25-S1, 9.16.9, 9.16.9-S1, 9.17.7)https://gitlab.isc.org/isc-projects/kea/-/issues/1440wrap lines in ChangeLog to 732020-10-02T08:53:38ZMichal Nowikowskiwrap lines in ChangeLog to 73This is needed to make email with announcement look ok.This is needed to make email with announcement look ok.kea1.9.1https://gitlab.isc.org/isc-projects/bind9/-/issues/2192TSAN error accessing listener->connections2020-10-02T08:48:36ZMark AndrewsTSAN error accessing listener->connectionsJob [#1191892](https://gitlab.isc.org/isc-projects/bind9/-/jobs/1191892) failed for cdd9852447067a0ec4841ff3ffbd326ad03bb5a7:
```
WARNING: ThreadSanitizer: data race
Write of size 8 at 0x000000000001 by thread T1:
#0 conn_reset b...Job [#1191892](https://gitlab.isc.org/isc-projects/bind9/-/jobs/1191892) failed for cdd9852447067a0ec4841ff3ffbd326ad03bb5a7:
```
WARNING: ThreadSanitizer: data race
Write of size 8 at 0x000000000001 by thread T1:
#0 conn_reset bin/named/controlconf.c:574
#1 isc_nmhandle_detach netmgr/netmgr.c:1257
#2 isc__nm_uvreq_put netmgr/netmgr.c:1389
#3 tcp_send_cb netmgr/tcp.c:1030
#4 <null> <null>
#5 <null> <null>
Previous read of size 8 at 0x000000000001 by thread T2:
#0 conn_reset bin/named/controlconf.c:574
#1 isc_nmhandle_detach netmgr/netmgr.c:1257
#2 control_recvmessage bin/named/controlconf.c:556
#3 recv_data lib/isccc/ccmsg.c:110
#4 isc__nm_tcp_shutdown netmgr/tcp.c:1161
#5 shutdown_walk_cb netmgr/netmgr.c:1511
#6 uv_walk <null>
#7 process_queue netmgr/netmgr.c:656
#8 process_normal_queue netmgr/netmgr.c:582
#9 process_queues netmgr/netmgr.c:590
#10 async_cb netmgr/netmgr.c:548
#11 <null> <null>
#12 <null> <null>
Location is heap block of size 265 at 0x000000000017 allocated by thread T3:
#0 malloc <null>
#1 default_memalloc lib/isc/mem.c:713
#2 mem_get lib/isc/mem.c:622
#3 isc___mem_get lib/isc/mem.c:1044
#4 isc__mem_get lib/isc/mem.c:2432
#5 add_listener bin/named/controlconf.c:1127
#6 named_controls_configure bin/named/controlconf.c:1324
#7 load_configuration bin/named/server.c:9181
#8 run_server bin/named/server.c:9819
#9 dispatch lib/isc/task.c:1152
#10 run lib/isc/task.c:1344
#11 <null> <null>
Thread T1 (running) created by main thread at:
#0 pthread_create <null>
#1 isc_thread_create pthreads/thread.c:73
#2 isc_nm_start netmgr/netmgr.c:232
#3 create_managers bin/named/main.c:909
#4 setup bin/named/main.c:1223
#5 main bin/named/main.c:1523
Thread T2 (running) created by main thread at:
#0 pthread_create <null>
#1 isc_thread_create pthreads/thread.c:73
#2 isc_nm_start netmgr/netmgr.c:232
#3 create_managers bin/named/main.c:909
#4 setup bin/named/main.c:1223
#5 main bin/named/main.c:1523
Thread T3 (running) created by main thread at:
#0 pthread_create <null>
#1 isc_thread_create pthreads/thread.c:73
#2 isc_taskmgr_create lib/isc/task.c:1434
#3 create_managers bin/named/main.c:915
#4 setup bin/named/main.c:1223
#5 main bin/named/main.c:1523
SUMMARY: ThreadSanitizer: data race bin/named/controlconf.c:574 in conn_reset
```October 2020 (9.11.24, 9.11.24-S1, 9.16.8, 9.16.8-S1, 9.17.6)Mark AndrewsMark Andrewshttps://gitlab.isc.org/isc-projects/bind9/-/issues/2191Missing locks when accessing keynode.initial and keynode.managed triggered TSAN.2020-10-02T08:49:12ZMark AndrewsMissing locks when accessing keynode.initial and keynode.managed triggered TSAN.Job [#1190729](https://gitlab.isc.org/isc-projects/bind9/-/jobs/1190729) failed for 96d2ec16a29c73050f8ad7a97930093294ba9ac7:
```
WARNING: ThreadSanitizer: data race
Write of size 1 at 0x000000000001 by thread T1 (mutexes: write M1):...Job [#1190729](https://gitlab.isc.org/isc-projects/bind9/-/jobs/1190729) failed for 96d2ec16a29c73050f8ad7a97930093294ba9ac7:
```
WARNING: ThreadSanitizer: data race
Write of size 1 at 0x000000000001 by thread T1 (mutexes: write M1):
#0 dns_keynode_trust lib/dns/keytable.c:836
#1 keyfetch_done lib/dns/zone.c:10187
#2 dispatch lib/isc/task.c:1152
#3 run lib/isc/task.c:1344
#4 <null> <null>
Previous read of size 1 at 0x000000000001 by thread T2 (mutexes: read M2):
#0 keynode_dslist_totext lib/dns/keytable.c:682
#1 dns_keytable_totext lib/dns/keytable.c:732
#2 named_server_dumpsecroots bin/named/server.c:11357
#3 named_control_docommand bin/named/control.c:264
#4 control_command bin/named/controlconf.c:390
#5 dispatch lib/isc/task.c:1152
#6 run lib/isc/task.c:1344
#7 <null> <null>
Location is heap block of size 241 at 0x000000000010 allocated by thread T3:
#0 malloc <null>
#1 default_memalloc lib/isc/mem.c:713
#2 mem_get lib/isc/mem.c:622
#3 mem_allocateunlocked lib/isc/mem.c:1268
#4 isc___mem_allocate lib/isc/mem.c:1288
#5 isc__mem_allocate lib/isc/mem.c:2453
#6 isc___mem_get lib/isc/mem.c:1037
#7 isc__mem_get lib/isc/mem.c:2432
#8 new_keynode lib/dns/keytable.c:346
#9 insert lib/dns/keytable.c:393
#10 dns_keytable_add lib/dns/keytable.c:421
#11 process_key bin/named/server.c:955
#12 load_view_keys bin/named/server.c:983
#13 configure_view_dnsseckeys bin/named/server.c:1140
#14 configure_view bin/named/server.c:5371
#15 load_configuration bin/named/server.c:9110
#16 loadconfig bin/named/server.c:10310
#17 named_server_reconfigcommand bin/named/server.c:10693
#18 named_control_docommand bin/named/control.c:250
#19 control_command bin/named/controlconf.c:390
#20 dispatch lib/isc/task.c:1152
#21 run lib/isc/task.c:1344
#22 <null> <null>
Mutex M1 is already destroyed.
Mutex M2 is already destroyed.
Thread T1 (running) created by main thread at:
#0 pthread_create <null>
#1 isc_thread_create pthreads/thread.c:73
#2 isc_taskmgr_create lib/isc/task.c:1434
#3 create_managers bin/named/main.c:915
#4 setup bin/named/main.c:1223
#5 main bin/named/main.c:1523
Thread T2 (running) created by main thread at:
#0 pthread_create <null>
#1 isc_thread_create pthreads/thread.c:73
#2 isc_taskmgr_create lib/isc/task.c:1434
#3 create_managers bin/named/main.c:915
#4 setup bin/named/main.c:1223
#5 main bin/named/main.c:1523
Thread T3 (running) created by main thread at:
#0 pthread_create <null>
#1 isc_thread_create pthreads/thread.c:73
#2 isc_taskmgr_create lib/isc/task.c:1434
#3 create_managers bin/named/main.c:915
#4 setup bin/named/main.c:1223
#5 main bin/named/main.c:1523
SUMMARY: ThreadSanitizer: data race lib/dns/keytable.c:836 in dns_keynode_trust
```October 2020 (9.11.24, 9.11.24-S1, 9.16.8, 9.16.8-S1, 9.17.6)Mark AndrewsMark Andrewshttps://gitlab.isc.org/isc-projects/kea/-/issues/1439Sanity checks for Kea 1.9.0 rc12020-10-02T12:03:54ZjenkinsSanity checks for Kea 1.9.0 rc1```We are now at step SANITY CHECKS of Kea 1.9.0 rc1.
Please verify the packages and files according to
https://wiki.isc.org/bin/view/QA/KeaReleaseProcess, "4. Sanity Checks" chapter
and your imagination.
Before starting any checks. ple...```We are now at step SANITY CHECKS of Kea 1.9.0 rc1.
Please verify the packages and files according to
https://wiki.isc.org/bin/view/QA/KeaReleaseProcess, "4. Sanity Checks" chapter
and your imagination.
Before starting any checks. please, state in Sanity Checks issue in GitLab
what check you are doing in a thread/discussion (not as comment).
When you finish given check state in the same thread/discussion what is the result.
This way we know what is covered upfront and we can avoid repeating ourselves.
Release content is located on:
1) [tarballs] repo.isc.org in the following folders:
/data/shared/sweng/kea/releases/1.9.0-rc1
/data/shared/sweng/kea/releases/premium-1.9.0-rc1
/data/shared/sweng/kea/releases/subscription-1.9.0-rc1
SHA256 (kea-1.9.0.tar.gz) = 054e66b9cd987a43d2745abd7c850d4ffb532e611da1c8b13f23ccbb4a71f8e0)
SHA256 (kea-premium-1.9.0.tar.gz) = f4b5e36a5936727e15c1566d6a2f08d3d9c1b5eb8a8a3c0e348f9b280b5dc397)
SHA256 (kea-subscription-1.9.0.tar.gz) = 535a4177d9c227efa7c7b0f3af759fff7947ae6499885fcd9ec72e62656aeb3f)
2) [rpm/deb packages] on packages.isc.org, exact packages versions are stored here:
https://jenkins.isc.org/job/kea-dev/job/pkg/64/
Release version is 1.9.0-isc0003520200928143245 (please verify if it is this version while installing).
Install instruction is here: https://wiki.isc.org/bin/view/QA/KeaReleaseProcess, chapter 4. Sanity Checks, point 9.
```https://gitlab.isc.org/isc-projects/dhcp/-/issues/139ipv6 address contains 'add', make conf check error2021-06-22T15:15:46Zdreamandtureipv6 address contains 'add', make conf check erroripv6 address contains 'add', make conf check error
fixed-address6 240c:4051:2125:713:add:89ff:fd63:1e42;
line 2132: Invalid IPv6 address.
fixed-address6 240c:4051:2125:713:add:
^
!...ipv6 address contains 'add', make conf check error
fixed-address6 240c:4051:2125:713:add:89ff:fd63:1e42;
line 2132: Invalid IPv6 address.
fixed-address6 240c:4051:2125:713:add:
^
![image](/uploads/6f906431f0ffffe32338c0045505d2f9/image.png)https://gitlab.isc.org/isc-projects/bind9/-/issues/2190dig: "-u" (microsecond timestamp precision) does not work in YAML output mode2022-04-26T13:14:41Zchampiondotdig: "-u" (microsecond timestamp precision) does not work in YAML output modeHI,ALL:
The version BIND-9.16.7 of the software I'm using
dig www.google.com +yaml
When using the above command to query, there is no query time like option('-u') in the output result
dig www.google.com -u
**;; Query time: 6999 u...HI,ALL:
The version BIND-9.16.7 of the software I'm using
dig www.google.com +yaml
When using the above command to query, there is no query time like option('-u') in the output result
dig www.google.com -u
**;; Query time: 6999 usec**
Combined with the output
dig www.google.com -u +yamlOctober 2020 (9.11.24, 9.11.24-S1, 9.16.8, 9.16.8-S1, 9.17.6)https://gitlab.isc.org/isc-projects/bind9/-/issues/2189some comments in lib/dns/stats.c use incorrect notation for bit values2020-10-02T09:24:41ZBrian Conrysome comments in lib/dns/stats.c use incorrect notation for bit valuesSome of the comments in `lib/dns/stats.c` refer to values in a 2-bit field as `0x11`, which requires 5 bits, instead of `0b11`.
affects 9.16 and 9.17Some of the comments in `lib/dns/stats.c` refer to values in a 2-bit field as `0x11`, which requires 5 bits, instead of `0b11`.
affects 9.16 and 9.17October 2020 (9.11.24, 9.11.24-S1, 9.16.8, 9.16.8-S1, 9.17.6)https://gitlab.isc.org/isc-projects/kea/-/issues/1438Simplify and document version-info bump up procedure2020-12-07T21:15:03ZMarcin SiodelskiSimplify and document version-info bump up procedureThe following page describes how to bump up library version numbers before a software release with libtool:
https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
Most of the cases we bump up `current` version ...The following page describes how to bump up library version numbers before a software release with libtool:
https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
Most of the cases we bump up `current` version number to indicate that new Kea must use new library. The major source of confusion was the `age` number. This number should be set back to 0 whenever the new library should not be used by the old Kea code to avoid crashes. In libtool terms this is the case when existing interfaces has been changed or removed. The old Kea version could be using those interfaces in the form in which they previously existed leading to crashes.
We recently tried to follow the guidelines in keeping the `age` number positive and incremented, rather than set to 0 in cases when the new lib version could work with old Kea version. In libtool terms it is the case when new interfaces were added and existing interfaces were neither changed nor removed. So, the old Kea version is never using new interfaces but that's ok. Since old interfaces are not modified it is safe for old Kea to use them. That's the theory....
The reality is that engineers working on the tickets to bump up lib version numbers often face a dilemma what it means that the interfaces are neither changed nor removed. Well, removed may be more obvious. For changes, the fact that you don't instantly see them doesn't mean they don't exist. Kea is a complex software and there are many dependencies between various modules. We think that we made a mistake several times assuming that no interfaces were changed but the changes took place, only they weren't that obvious.
This ticket is to propose and document some consistent way of using libtool version numbers which would minimize the risk of mistakes.
One of the schemes to be considered is the following:
- if there were any code changes in the library between previous release and current release bump up current version number and set other numbers to 0, i.e. c+1:0:0.
- if there were no code changes in the library, leave the version-info as is.
That way we'd preclude the use of old Kea versions with new Kea libraries versions. We'd also require that new Kea version is always using the most recent code, even if the applied changes were cosmetic. This is a brute force way to keep the libs consistent with the Kea version, which may be considered as a down side, but it also has some advantages besides mistakes avoidance....
One of the benefits of such approach is that it becomes trivial to automate lib version bumps with a script that checks whether there were any changes in the lib and bumps up current number. Previously, an engineer had to look and investigate what class of changes were applied and that's not something the script could do.kea1.9.3Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/bind9/-/issues/2188Bug in message.c:673: ENSURE(isc_mempool_getallocated(msg->namepool) == 0) fa...2024-03-22T08:14:06ZFstarkBug in message.c:673: ENSURE(isc_mempool_getallocated(msg->namepool) == 0) failed<!--
If the bug you are reporting is potentially security-related - for example,
if it involves an assertion failure or other crash in `named` that can be
triggered repeatedly - then please do *NOT* report it here, but send an
email to [...<!--
If the bug you are reporting is potentially security-related - for example,
if it involves an assertion failure or other crash in `named` that can be
triggered repeatedly - then please do *NOT* report it here, but send an
email to [security-officer@isc.org](security-officer@isc.org).
-->
### Summary
message.c:673: ENSURE(isc_mempool_getallocated(msg->namepool) == 0) failed, back trace
```
test@test:~/bind9/collect$ ./dns_message_parse_fuzzer id\:000000\,sig\:06\,src\:002736+001626\,time\:192782276\,op\:splice\,rep\:128
INFO: Seed: 1666455395
INFO: Loaded 1 modules (61310 inline 8-bit counters): 61310 [0x100d2b0, 0x101c22e),
INFO: Loaded 1 PC tables (61310 PCs): 61310 [0x101c230,0x110ba10),
./dns_message_parse_fuzzer: Running 1 inputs 1 time(s) each.
Running: id:000000,sig:06,src:002736+001626,time:192782276,op:splice,rep:128
message.c:673: ENSURE(isc_mempool_getallocated(msg->namepool) == 0) failed, back trace
./dns_message_parse_fuzzer() [0xab474a]
./dns_message_parse_fuzzer() [0xab43d0]
./dns_message_parse_fuzzer() [0xab422a]
./dns_message_parse_fuzzer() [0x566c5f]
./dns_message_parse_fuzzer() [0x566da7]
./dns_message_parse_fuzzer() [0x551bc4]
./dns_message_parse_fuzzer() [0x550f98]
./dns_message_parse_fuzzer() [0x45a0c2]
./dns_message_parse_fuzzer() [0x445843]
./dns_message_parse_fuzzer() [0x44b89f]
./dns_message_parse_fuzzer() [0x473213]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7) [0x7f0090f5eb97]
./dns_message_parse_fuzzer() [0x41fed9]
==23768== ERROR: libFuzzer: deadly signal
#0 0x527611 in __sanitizer_print_stack_trace /src/llvm-project/compiler-rt/lib/asan/asan_stack.cpp:86:3
#1 0x472a38 in fuzzer::PrintStackTrace() /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerUtil.cpp:210:5
#2 0x458b63 in fuzzer::Fuzzer::CrashCallback() /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:232:3
#3 0x7f009196489f (/lib/x86_64-linux-gnu/libpthread.so.0+0x1289f)
#4 0x7f0090f7bf46 in __libc_signal_restore_set /build/glibc-2ORdQG/glibc-2.27/signal/../sysdeps/unix/sysv/linux/nptl-signals.h:80
#5 0x7f0090f7bf46 in gsignal /build/glibc-2ORdQG/glibc-2.27/signal/../sysdeps/unix/sysv/linux/raise.c:48
#6 0x7f0090f7d8b0 in abort /build/glibc-2ORdQG/glibc-2.27/stdlib/abort.c:79
#7 0xab4233 in isc_assertion_failed /src/bind9/lib/isc/assertions.c:47:2
#8 0x566c5e in msgreset /src/bind9/lib/dns/message.c:673:2
#9 0x566da6 in dns_message_destroy /src/bind9/lib/dns/message.c:801:2
#10 0x551bc3 in render_message /src/bind9/fuzz/dns_message_parse.c:131:2
#11 0x550f97 in LLVMFuzzerTestOneInput /src/bind9/fuzz/dns_message_parse.c:162:11
#12 0x45a0c1 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:558:15
#13 0x445842 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:296:6
#14 0x44b89e in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:796:9
#15 0x473212 in main /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:19:10
#16 0x7f0090f5eb96 in __libc_start_main /build/glibc-2ORdQG/glibc-2.27/csu/../csu/libc-start.c:310
#17 0x41fed8 in _start (/home/test/bind9/collect/dns_message_parse_fuzzer+0x41fed8)
NOTE: libFuzzer has rudimentary signal handlers.
Combine libFuzzer with AddressSanitizer or similar for better crash reports.
SUMMARY: libFuzzer: deadly signal
```
### BIND version used
master-git
### Steps to reproduce
./fuzzer POC
[bind9.zip](/uploads/58bf9e655b37622954937535b1e69bd6/bind9.zip)
### What is the current *bug* behavior?
crash
### Relevant logs and/or screenshots
File in zip
### Possible fixes
(If you can, link to the line of code that might be responsible for the
problem.)October 2020 (9.11.24, 9.11.24-S1, 9.16.8, 9.16.8-S1, 9.17.6)Mark AndrewsMark Andrewshttps://gitlab.isc.org/isc-projects/kea/-/issues/1437distcheck is failing2020-09-28T10:31:43ZMichal Nowikowskidistcheck is failingFailed builds on jenkins:
https://jenkins.isc.org/job/kea-dev/job/distcheck/
from # 10 to # 13.
The failures can look differently:
1.
```
[----------] Global test environment tear-down
[==========] 651 tests from 46 test cases ran. (6...Failed builds on jenkins:
https://jenkins.isc.org/job/kea-dev/job/distcheck/
from # 10 to # 13.
The failures can look differently:
1.
```
[----------] Global test environment tear-down
[==========] 651 tests from 46 test cases ran. (6828 ms total)
[ PASSED ] 642 tests.
[ FAILED ] 9 tests, listed below:
[ FAILED ] IfaceMgrTest.receiveTimeout6
[ FAILED ] IfaceMgrTest.sockets6
[ FAILED ] IfaceMgrTest.socketsFromIface
[ FAILED ] IfaceMgrTest.socketsFromAddress
[ FAILED ] IfaceMgrTest.socketsFromRemoteAddress
[ FAILED ] IfaceMgrTest.sendReceive6
[ FAILED ] PktFilterInet6Test.openSocket
[ FAILED ] PktFilterInet6Test.send
[ FAILED ] PktFilterInet6Test.receive
9 FAILED TESTS
YOU HAVE 7 DISABLED TESTS
FAIL: libdhcp++_unittests
======================================
1 of 1 test failed
Please report to kea-dev@lists.isc.org
======================================
make[7]: *** [Makefile:1738: check-TESTS] Błąd 1
make[7]: Opuszczenie katalogu '/home/godfryd/isc/repos/kea/kea-1.9.0-git/_build/sub/src/lib/dhcp/tests'
make[6]: *** [Makefile:1889: check-am] Błąd 2
make[6]: Opuszczenie katalogu '/home/godfryd/isc/repos/kea/kea-1.9.0-git/_build/sub/src/lib/dhcp/tests'
make[5]: *** [Makefile:1645: check-recursive] Błąd 1
make[5]: Opuszczenie katalogu '/home/godfryd/isc/repos/kea/kea-1.9.0-git/_build/sub/src/lib/dhcp/tests'
make[4]: *** [Makefile:1171: check-recursive] Błąd 1
make[4]: Opuszczenie katalogu '/home/godfryd/isc/repos/kea/kea-1.9.0-git/_build/sub/src/lib/dhcp'
make[3]: *** [Makefile:458: check-recursive] Błąd 1
make[3]: Opuszczenie katalogu '/home/godfryd/isc/repos/kea/kea-1.9.0-git/_build/sub/src/lib'
make[2]: *** [Makefile:451: check-recursive] Błąd 1
make[2]: Opuszczenie katalogu '/home/godfryd/isc/repos/kea/kea-1.9.0-git/_build/sub/src'
make[1]: *** [Makefile:622: check-recursive] Błąd 1
make[1]: Opuszczenie katalogu '/home/godfryd/isc/repos/kea/kea-1.9.0-git/_build/sub'
make: *** [Makefile:836: distcheck] Błąd 1
```
or 2.
```
22:14:46.082 [----------] Global test environment tear-down
22:14:46.082 [==========] 650 tests from 25 test cases ran. (14302 ms total)
22:14:46.082 [ PASSED ] 649 tests.
22:14:46.082 [ FAILED ] 1 test, listed below:
22:14:46.082 [ FAILED ] CtrlChannelDhcpv4SrvTest.controlChannelStats
22:14:46.082
22:14:46.082 1 FAILED TEST
22:14:46.082 YOU HAVE 2 DISABLED TESTS
22:14:46.082
22:14:46.082 FAIL: dhcp4_unittests
22:14:46.082 ======================================
22:14:46.082 1 of 1 test failed
22:14:46.082 Please report to kea-dev@lists.isc.org
22:14:46.082 ======================================
22:14:46.082 make[6]: *** [Makefile:1307: check-TESTS] Error 1
22:14:46.082 make[6]: Leaving directory '/home/jenkins/workspace/kea-dev/distcheck/kea-1.9.0-git/_build/sub/src/bin/dhcp4/tests'
22:14:46.082 make[5]: *** [Makefile:1433: check-am] Error 2
22:14:46.082 make[5]: Leaving directory '/home/jenkins/workspace/kea-dev/distcheck/kea-1.9.0-git/_build/sub/src/bin/dhcp4/tests'
22:14:46.082 make[4]: *** [Makefile:714: check-recursive] Error 1
22:14:46.082 make[4]: Leaving directory '/home/jenkins/workspace/kea-dev/distcheck/kea-1.9.0-git/_build/sub/src/bin/dhcp4'
22:14:46.082 make[3]: *** [Makefile:453: check-recursive] Error 1
22:14:46.082 make[3]: Leaving directory '/home/jenkins/workspace/kea-dev/distcheck/kea-1.9.0-git/_build/sub/src/bin'
22:14:46.082 make[2]: *** [Makefile:451: check-recursive] Error 1
22:14:46.082 make[2]: Leaving directory '/home/jenkins/workspace/kea-dev/distcheck/kea-1.9.0-git/_build/sub/src'
22:14:46.082 make[1]: *** [Makefile:622: check-recursive] Error 1
22:14:46.082 make[1]: Leaving directory '/home/jenkins/workspace/kea-dev/distcheck/kea-1.9.0-git/_build/sub'
22:14:46.082 make: *** [Makefile:836: distcheck] Error 1
```
or 3.
```
20:50:12.373 Running command "/home/jenkins/workspace/kea-dev/distcheck/kea-1.9.0-git/_build/sub/src/bin/dhcp4/kea-dhcp4 -t /home/jenkins/workspace/kea-dev/distcheck/kea-1.9.0-git/_build/sub/src/bin/dhcp4/tests/test_config.json".
20:50:12.373 Syntax check failed with: /home/jenkins/workspace/kea-dev/distcheck/kea-1.9.0-git/_build/sub/src/bin/dhcp4/tests/test_config.json:1.11-22: got unexpected keyword "interfaces" in Dhcp4 map.
20:50:12.373 PASSED dhcpv4.syntax_check_bad_syntax
20:50:12.373
20:50:12.373
20:50:12.374 START TEST dhcpv4.syntax_check_bad_values
20:50:12.374 Creating Kea configuration file: /home/jenkins/workspace/kea-dev/distcheck/kea-1.9.0-git/_build/sub/src/bin/dhcp4/tests/test_config.json.
20:50:12.374 Running command "/home/jenkins/workspace/kea-dev/distcheck/kea-1.9.0-git/_build/sub/src/bin/dhcp4/kea-dhcp4 -t /home/jenkins/workspace/kea-dev/distcheck/kea-1.9.0-git/_build/sub/src/bin/dhcp4/tests/test_config.json".
20:50:12.374 Error encountered: subnet configuration failed: a pool of type V4, with the following address range: 192.168.0.10-192.168.0.100 does not match the prefix of a subnet: 10.0.0.0/8 to which it is being added (/home/jenkins/workspace/kea-dev/distcheck/kea-1.9.0-git/_build/sub/src/bin/dhcp4/tests/test_config.json:1:173)
20:50:12.374 PASSED dhcpv4.syntax_check_bad_values
20:50:12.374
20:50:12.374 make[6]: Leaving directory '/home/jenkins/workspace/kea-dev/distcheck/kea-1.9.0-git/_build/sub/src/bin/dhcp4/tests'
20:50:12.374 Makefile:1392: recipe for target 'check-am' failed
20:50:12.374 make[5]: *** [check-am] Error 2
20:50:12.374 make[5]: Leaving directory '/home/jenkins/workspace/kea-dev/distcheck/kea-1.9.0-git/_build/sub/src/bin/dhcp4/tests'
20:50:12.374 Makefile:701: recipe for target 'check-recursive' failed
20:50:12.374 make[4]: *** [check-recursive] Error 1
20:50:12.374 make[4]: Leaving directory '/home/jenkins/workspace/kea-dev/distcheck/kea-1.9.0-git/_build/sub/src/bin/dhcp4'
20:50:12.374 Makefile:453: recipe for target 'check-recursive' failed
20:50:12.374 make[3]: *** [check-recursive] Error 1
20:50:12.374 make[3]: Leaving directory '/home/jenkins/workspace/kea-dev/distcheck/kea-1.9.0-git/_build/sub/src/bin'
20:50:12.374 Makefile:451: recipe for target 'check-recursive' failed
20:50:12.374 make[2]: *** [check-recursive] Error 1
20:50:12.374 make[2]: Leaving directory '/home/jenkins/workspace/kea-dev/distcheck/kea-1.9.0-git/_build/sub/src'
20:50:12.374 Makefile:622: recipe for target 'check-recursive' failed
20:50:12.374 make[1]: *** [check-recursive] Error 1
20:50:12.374 make[1]: Leaving directory '/home/jenkins/workspace/kea-dev/distcheck/kea-1.9.0-git/_build/sub'
20:50:12.374 Makefile:828: recipe for target 'distcheck' failed
20:50:12.374 make: *** [distcheck] Error 1
```kea1.9.0https://gitlab.isc.org/isc-projects/kea/-/issues/1436Document DHCPv6 options set by Kea2020-10-23T11:04:48ZTomek MrugalskiDocument DHCPv6 options set by KeaThere's a long list of v6 options that Kea supports, but they're not listed as supported, because they can't be configured explicitly. However, support requested a documentation for similar options in v4 (see #1323) and @tomek added it. ...There's a long list of v6 options that Kea supports, but they're not listed as supported, because they can't be configured explicitly. However, support requested a documentation for similar options in v4 (see #1323) and @tomek added it. We should have a similar list for v6.
It's actually easy to do: checkout old branch (e.g. v1_4_0) and look at doc/guide/dhcp6-srv.xml for comments around line 1344.kea1.9.1https://gitlab.isc.org/isc-projects/kea/-/issues/1435Backport #1431 (remove mutli-threading experimental message)2020-11-27T06:38:00ZTomek MrugalskiBackport #1431 (remove mutli-threading experimental message)We should remove the experimental message from 1.8.x branch.We should remove the experimental message from 1.8.x branch.kea1.8.1Thomas MarkwalderThomas Markwalderhttps://gitlab.isc.org/isc-projects/kea/-/issues/1433hammer: problem with building centos 8 and passing attempts argument2021-05-04T10:55:36ZMichal Nowikowskihammer: problem with building centos 8 and passing attempts argumentkea1.9.0Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/kea/-/issues/1432hammer: building centos 8 fails due to network issues2021-05-04T10:55:36ZMichal Nowikowskihammer: building centos 8 fails due to network issuessolution: add retries on network operationssolution: add retries on network operationskea1.9.0Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/bind9/-/issues/2187Release Checklist for BIND 9.11.24, BIND 9.11.24-S1, BIND 9.16.8, BIND 9.16.8...2020-10-28T16:58:10ZMichał KępieńRelease Checklist for BIND 9.11.24, BIND 9.11.24-S1, BIND 9.16.8, BIND 9.16.8-S1, BIND 9.17.6## Release Schedule
**Code Freeze:** Wednesday, October 7th, 2020
**Tagging Deadline:** Monday, October 12th, 2020
**Public Release:** Wednesday, October 21st, 2020
## Release Checklist
### Before the Code Freeze
- [x] ***(QA)*** ...## Release Schedule
**Code Freeze:** Wednesday, October 7th, 2020
**Tagging Deadline:** Monday, October 12th, 2020
**Public Release:** Wednesday, October 21st, 2020
## Release Checklist
### Before the Code Freeze
- [x] ***(QA)*** Inform Support and Marketing of impending release (and give estimated release dates).
- [x] ***(QA)*** Ensure there are no permanent test failures on any platform.
- [x] ***(QA)*** Check Perflab to ensure there has been no unexplained drop in performance for the versions being released.
- [x] ***(QA)*** Check whether all issues assigned to the release milestone are resolved[^1].
- [x] ***(QA)*** Ensure that there are no outstanding merge requests in the private repository[^1] (Subscription Edition only).
- [x] ***(QA)*** Ensure all merge requests marked for backporting have been indeed backported.
### Before the Tagging Deadline
- [x] ***(QA)*** Look for outstanding documentation issues (e.g. `CHANGES` mistakes) and address them if any are found.
- [x] ***(QA)*** Ensure release notes are correct, ask Support and Marketing to check them as well.
- [x] ***(Support)*** Check release notes, ask QA to correct any mistakes found.
- [x] ***(Marketing)*** Check release notes, ask QA to correct any mistakes found.
- [x] ***(SwEng)*** Update API files for libraries with new version information.
- [x] ***(SwEng)*** Change software version and library versions in `configure.ac` (new major release only).
- [x] ***(SwEng)*** Rebuild `configure` using Autoconf on `docs.isc.org`.
- [x] ***(SwEng)*** Update `CHANGES`.
- [x] ***(SwEng)*** Update `CHANGES.SE` (Subscription Edition only).
- [x] ***(SwEng)*** Update `README.md`.
- [x] ***(SwEng)*** Update `version`.
- [x] ***(SwEng)*** Build documentation on `docs.isc.org`.
- [x] ***(QA)*** Check that all the above steps were performed correctly.
- [x] ***(QA)*** Check that the formatting is correct for text, PDF, and HTML versions of release notes.
- [x] ***(SwEng)*** Tag the releases[^2]. (Tags may only be pushed to the public repository for releases which are *not* security releases.)
- [x] ***(SwEng)*** If this is the first tag for a release (e.g. beta), create a release branch named `release_v9_X_Y` to allow development to continue on the maintenance branch whilst release engineering continues.
### Before the ASN Deadline (for ASN Releases) or the Public Release Date (for Regular Releases)
- [x] ***(QA)*** Verify GitLab CI results for the tags created and prepare a QA report for the releases to be published.
- [x] ***(QA)*** Request signatures for the tarballs, providing their location and checksums.
- [x] ***(Signers)*** Validate tarball checksums, sign tarballs, and upload signatures.
- [x] ***(QA)*** Verify tarball signatures and check tarball checksums again.
- [x] ***(Support)*** Pre-publish ASN and/or Subscription Edition tarballs so that packages can be built.
- [x] ***(QA)*** Build and test ASN and/or Subscription Edition packages.
- [x] ***(QA)*** Notify Support that the releases have been prepared.
- [x] ***(Support)*** Send out ASNs (if applicable).
### On the Day of Public Release
- [x] ***(Support)*** Wait for clearance from Security Officer to proceed with the public release (if applicable).
- [x] ***(Support)*** Place tarballs in public location on FTP site.
- [x] ***(Support)*** Publish links to downloads on ISC website.
- [x] ***(Support)*** Write release email to *bind-announce*.
- [x] ***(Support)*** Write email to *bind-users* (if a major release).
- [x] ***(Support)*** Send eligible customers updated links to the Subscription Edition.
- [x] ***(Support)*** Update tickets in case of waiting support customers.
- [x] ***(QA)*** Build and test any outstanding private packages.
- [x] ***(QA)*** Build public packages (`*.deb`, RPMs).
- [x] ***(QA)*** Inform Marketing of the release.
- [x] ***(QA)*** Update the internal [BIND release dates wiki page](https://wiki.isc.org/bin/view/Main/BindReleaseDates) when public announcement has been made.
- [x] ***(Marketing)*** Post short note to Twitter.
- [x] ***(Marketing)*** Update [Wikipedia entry for BIND](https://en.wikipedia.org/wiki/BIND).
- [x] ***(Marketing)*** Write blog article (if a major release).
- [x] ***(QA)*** Ensure all new tags are annotated and signed.
- [x] ***(SwEng)*** Merge the automatically prepared `prep 9.X.Y` commit which updates `version` and documentation on the release branch into the relevant maintenance branch (`v9_X`).
- [x] ***(SwEng)*** Push tags for the published releases to the public repository.
- [x] ***(QA)*** For each maintained branch, update the `BIND_BASELINE_VERSION` variable for the `abi-check` job in `.gitlab-ci.yml` to the latest published BIND version tag for a given branch.
- [x] ***(QA)*** Prepare empty release notes for the next set of releases.
- [x] ***(QA)*** Sanitize all confidential issues assigned to the release milestone and make them public.
- [x] ***(QA)*** Update QA tools used in GitLab CI (e.g. Flake8, PyLint) by modifying the relevant `Dockerfile`.
[^1]: If not, use the time remaining until the tagging deadline to ensure all outstanding issues are either resolved or moved to a different milestone.
[^2]: Preferred command line: `git tag -u <DEVELOPER_KEYID> -a -s -m "BIND 9.X.Y[alphatag]" v9_X_Y[alphatag]`, where `[alphatag]` is an optional string such as `b1`, `rc1`, etc.October 2020 (9.11.24, 9.11.24-S1, 9.16.8, 9.16.8-S1, 9.17.6)Michał KępieńMichał Kępień2020-10-21https://gitlab.isc.org/isc-projects/kea/-/issues/1431Misleading multithread msg being generated on startup2020-11-04T20:08:17ZPeter DaviesMisleading multithread msg being generated on startupKea 1.8.0
When multithreading is enabled Kea logs the following message:
DHCP4_MULTI_THREADING_WARNING The multi-threading feature is experimental. Don't use in production environment." is multi-threading still a experimental feature?
T...Kea 1.8.0
When multithreading is enabled Kea logs the following message:
DHCP4_MULTI_THREADING_WARNING The multi-threading feature is experimental. Don't use in production environment." is multi-threading still a experimental feature?
This text ought to be amended.kea1.9.0Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/bind9/-/issues/2185nsdname-wait-recurse speed test fails under tsan2020-10-02T08:38:18ZMark Andrewsnsdname-wait-recurse speed test fails under tsan```
7640I:rpzrecurse:checking 'nsdname-wait-recurse no' is faster than 'nsdname-wait-recurse yes' (72)
7641I:rpzrecurse:timing 'nsdname-wait-recurse yes' (default)
7642I:rpzrecurse:elapsed time 0 seconds
7643I:rpzrecurse:timing 'nsdname-...```
7640I:rpzrecurse:checking 'nsdname-wait-recurse no' is faster than 'nsdname-wait-recurse yes' (72)
7641I:rpzrecurse:timing 'nsdname-wait-recurse yes' (default)
7642I:rpzrecurse:elapsed time 0 seconds
7643I:rpzrecurse:timing 'nsdname-wait-recurse no'
7644I:rpzrecurse:elapsed time 0 seconds
7645I:rpzrecurse:failed
```October 2020 (9.11.24, 9.11.24-S1, 9.16.8, 9.16.8-S1, 9.17.6)Michał KępieńMichał Kępieńhttps://gitlab.isc.org/isc-projects/bind9/-/issues/2184Add RFC8906 to list of RFCs in doc/arm/general.rst2020-09-24T11:55:10ZSuzanne GoldlustAdd RFC8906 to list of RFCs in doc/arm/general.rstNow that RFC8906 has been officially accepted/published, I want to add it to the list of RFCs in the ARM.Now that RFC8906 has been officially accepted/published, I want to add it to the list of RFCs in the ARM.October 2020 (9.11.24, 9.11.24-S1, 9.16.8, 9.16.8-S1, 9.17.6)Suzanne GoldlustSuzanne Goldlust