ISC Open Source Projects issueshttps://gitlab.isc.org/groups/isc-projects/-/issues2019-04-10T18:24:32Zhttps://gitlab.isc.org/isc-projects/kea/-/issues/412Merge DHCPv6 options fetched from the CB into the configuration2019-04-10T18:24:32ZMarcin SiodelskiMerge DHCPv6 options fetched from the CB into the configuration`SrvConfig::merge` must be updated to merge options into existing staging or current configuration.`SrvConfig::merge` must be updated to merge options into existing staging or current configuration.Kea1.6Thomas MarkwalderThomas Markwalderhttps://gitlab.isc.org/isc-projects/kea/-/issues/411Merge DHCPv6 option definitions fetched from the CB into the configuration2019-04-10T18:24:14ZMarcin SiodelskiMerge DHCPv6 option definitions fetched from the CB into the configuration`SrvConfig::merge` must be updated to merge DHCPv6 option definitions into existing staging or current config.`SrvConfig::merge` must be updated to merge DHCPv6 option definitions into existing staging or current config.Kea1.6Thomas MarkwalderThomas Markwalderhttps://gitlab.isc.org/isc-projects/kea/-/issues/410Merge DHCPv6 shared networks fetched from the CB into the configuration2019-09-02T07:12:01ZMarcin SiodelskiMerge DHCPv6 shared networks fetched from the CB into the configuration`SrvConfig::merge` must be updated to merge DHCPv6 shared networks into existing staging or current config.`SrvConfig::merge` must be updated to merge DHCPv6 shared networks into existing staging or current config.Kea1.6Thomas MarkwalderThomas Markwalderhttps://gitlab.isc.org/isc-projects/kea/-/issues/131HA hook depends on http library which is not linked with servers.2019-02-20T09:40:10ZFrancis DupontHA hook depends on http library which is not linked with servers.So kea-dhcp4 from the build directory (vs installed) fails to load the HA hook. The solution is to add the http library in the dhcp4 and dhcp6 Makefile.am files. It adds a dependency which is not used in the common case, at the other han...So kea-dhcp4 from the build directory (vs installed) fails to load the HA hook. The solution is to add the http library in the dhcp4 and dhcp6 Makefile.am files. It adds a dependency which is not used in the common case, at the other hand it is not good to dynamic load a Kea standard library with a hook.Kea1.6https://gitlab.isc.org/isc-projects/kea/-/issues/102CB: Add two step configuration to the DHCPv6 server2019-04-11T12:37:41ZMarcin SiodelskiCB: Add two step configuration to the DHCPv6 serverOnce the CfgMgr can merge local configuration with the configuration fetched from the database, the DHCPv6 server configuration and re-configuration procedure must be modified to first load configuration from the file and then from the d...Once the CfgMgr can merge local configuration with the configuration fetched from the database, the DHCPv6 server configuration and re-configuration procedure must be modified to first load configuration from the file and then from the database. The detailed state diagram is depicted here: https://gitlab.isc.org/isc-projects/kea/wikis/designs/configuration-in-db-design#configuration-state-diagram but this ticket excludes the bootstrap phase.Kea1.6https://gitlab.isc.org/isc-projects/kea/-/issues/101CB: Add two step configuration to the DHCPv4 server2019-01-30T21:18:12ZMarcin SiodelskiCB: Add two step configuration to the DHCPv4 serverOnce the CfgMgr can merge local configuration with the configuration fetched from the database, the DHCPv4 server configuration and re-configuration procedure must be modified to first load configuration from the file and then from the d...Once the CfgMgr can merge local configuration with the configuration fetched from the database, the DHCPv4 server configuration and re-configuration procedure must be modified to first load configuration from the file and then from the database. The detailed state diagram is depicted here: https://gitlab.isc.org/isc-projects/kea/wikis/designs/configuration-in-db-design#configuration-state-diagram but this ticket excludes the bootstrap phase.Kea1.6Thomas MarkwalderThomas Markwalderhttps://gitlab.isc.org/isc-projects/kea/-/issues/33CB: Add support for 'reload-subnets' command2019-02-19T12:25:11ZGhost UserCB: Add support for 'reload-subnets' commandOnce all other configuration scaling tickets are done (#3579-#3584), a command that triggers the server to reload subnet configuration would be useful.Once all other configuration scaling tickets are done (#3579-#3584), a command that triggers the server to reload subnet configuration would be useful.Kea1.6Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/kea/-/issues/565Client-Classes break KEA Config-Set API Call?2019-05-21T12:36:55ZGhost UserClient-Classes break KEA Config-Set API Call?---
name: Client-Classes break KEA Config-Set API Call?
about: Config-Set API call
---
**Describe the bug**
We've created a client-class for IP-phones in the KEA configuration. Now that we've started automating with the API we discover...---
name: Client-Classes break KEA Config-Set API Call?
about: Config-Set API call
---
**Describe the bug**
We've created a client-class for IP-phones in the KEA configuration. Now that we've started automating with the API we discovered an issue with the config-set API call, which reports a bad request.
The configuration is live, and KEA accepts it. However, even when we get the config through the API, and try to set it without changing it, it reports a "bad request".
**To Reproduce**
(Part of the) Config that works:
"shared-networks": [ ],
"client-classes": [
{
"name": "Innovaphone"
}
],
"subnet4": [
(Part of the) Config that doesn't work:
"shared-networks": [ ],
"client-classes": [
{
"name": "Innovaphone",
"test": "option[60].hex == '1.3.6.1.4.1.6666'",
"option-def": [
{
"name": "vendor-encapsulated-options",
"code": 43,
"type": "empty",
"encapsulate": "Innovaphone"
}
],
"option-data": [
{
"name": "h323-gatekeeper",
"code": 200,
"space": "Innovaphone",
"data": "10.90.249.1"
},
{
"name": "default-coder",
"code": 203,
"space": "Innovaphone",
"data": "G711A\\,20\\,k4/G711a\\,20\\,k4"
},
{
"name": "language",
"code": 204,
"space": "Innovaphone",
"data": "dut"
},
{
"name": "dialtone-type",
"code": 210,
"space": "Innovaphone",
"data": "0x2C"
},
{
"name": "update-URL",
"code": 215,
"space": "Innovaphone",
"data": "http://10.90.249.1/DRIVE/CF0/update/"
},
{
"name": "vendor-encapsulated-options",
"code": 43
}
]
}
],
"subnet4": [
**Expected behavior**
Being able to set the exact same config through the API that would work on the CLI.
**Environment:**
- Kea version: which release? KEA 1.4
- OS:Ubuntu 16.04 x64
**Contacting you**
gitlab / emailKea1.6Wlodzimierz WencelWlodzimierz Wencelhttps://gitlab.isc.org/isc-projects/kea/-/issues/500remote-option-def4-set accepts incorrect code values2019-05-16T05:07:26ZWlodzimierz Wencelremote-option-def4-set accepts incorrect code valuesuser can configure option definition using code 0 or any code from standard options list.user can configure option definition using code 0 or any code from standard options list.Kea1.6Wlodzimierz WencelWlodzimierz Wencelhttps://gitlab.isc.org/isc-projects/kea/-/issues/394Recalculate statistics when server configuration is changed as a result of a ...2019-04-10T08:55:27ZMarcin SiodelskiRecalculate statistics when server configuration is changed as a result of a commandWhile reviewing !197 we found a general issue that statistics needs to be recalculated when incremental changes are applied to the configuration. The specific case discussed in !197 was that when new subnet is added to the database and t...While reviewing !197 we found a general issue that statistics needs to be recalculated when incremental changes are applied to the configuration. The specific case discussed in !197 was that when new subnet is added to the database and the server detects this change, it will fetch the subnet data and merge the subnet into the configuration it is currently running. Because, it bypasses the staging/commit phase, the statistics is not recalculated.
We also checked that subnet_cmds doesn't deal with this problem either. We may need to find some generic solution for it.Kea1.6https://gitlab.isc.org/isc-projects/kea/-/issues/300Installing *messages.h files doesn't seem to be trivial2019-05-13T19:25:36ZMarcin SiodelskiInstalling *messages.h files doesn't seem to be trivialFor Kea 1.5.0 beta2 we attempted to install all *_messages.h files which contain labels of log messages used by loggers. That turned out to be a problem for `make distcheck` because it requires to compile .mes files using the message com...For Kea 1.5.0 beta2 we attempted to install all *_messages.h files which contain labels of log messages used by loggers. That turned out to be a problem for `make distcheck` because it requires to compile .mes files using the message compiler from the `$(top_builddir)` where the kea-msg-compiler is not available. At the stage where the compiler is needed the compiler is presumably available in the $(top_distdir) instead. We haven't figured out why this issue occurs when we attempt to install the files and not when we don't. Because this issue was found right before the Kea 1.5.0 beta2 release we didn't have time to investigate it and find the proper solution. We simply backed off the changes (we don't install message headers) hoping for some solution for it later.
We should also consider whether the messages files should be installed at all. It seems they will only be needed if there are any header files installed which require the message files. That could be the case if we have a template class implemented within the header file which requires logging. As far as we can tell today, we don't have such cases in the code. So, backing off the changes seemed safe for Kea 1.5.0 beta2.Kea1.6Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/issues/273Warn about legacy top-level entries2019-05-23T20:24:14ZFrancis DupontWarn about legacy top-level entriesAnnounce in ~~1.5~~ 1.6 release that a Dhcp6 entry in a DHCPv4 server configuration is ignored and will raise an error in the next release.Announce in ~~1.5~~ 1.6 release that a Dhcp6 entry in a DHCPv4 server configuration is ignored and will raise an error in the next release.Kea1.6https://gitlab.isc.org/isc-projects/kea/-/issues/56premium config/build fixes and cleanups2019-02-04T19:24:35ZGhost Userpremium config/build fixes and cleanupsSet `SHARE_DIR` (cf #5639 3. **bug**)
Made freeradius checks conditional on the radius hook existence.
Find an usage or remove config.setup
Move `m4_sinclude` calls to top-level (it is an illusion to believe they can be conditional)
...Set `SHARE_DIR` (cf #5639 3. **bug**)
Made freeradius checks conditional on the radius hook existence.
Find an usage or remove config.setup
Move `m4_sinclude` calls to top-level (it is an illusion to believe they can be conditional)
Cleanup `Makefile.in`
Investigate if distcheck with and without autoreconf works (aka Marcin's test). If not either fix and document as not working.Kea1.6https://gitlab.isc.org/isc-projects/kea/-/issues/574cb-cmds: inconsistent way of handling embedded containers2019-06-13T07:35:07ZMichal Nowikowskicb-cmds: inconsistent way of handling embedded containersIf empty list of pools is passed to remote-subnet4-set then it causes deleting all pools in given subnet.
If empty list of subnets is passed to remote-network4-set then nothing happens, it does not cause deleting subnets in the shared ne...If empty list of pools is passed to remote-subnet4-set then it causes deleting all pools in given subnet.
If empty list of subnets is passed to remote-network4-set then nothing happens, it does not cause deleting subnets in the shared network.
This is inconsistent and unintuitive. Users will have problems with that.
Explaining this in docs is not a fix for this issue.Kea1.6Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/kea/-/issues/569Correction to flex-id documentation for options "replace-client-id" and "matc...2019-04-19T13:17:56ZCathy AlmondCorrection to flex-id documentation for options "replace-client-id" and "match-client-id"In testing, one of our customers found out the following:
```
"replace-client-id": "true"
"match-client-id": "true"
```
Is actually wrong syntax and the plugin will fail to load. It's also wrong in the docs: https://ftp.isc.org/isc/kea...In testing, one of our customers found out the following:
```
"replace-client-id": "true"
"match-client-id": "true"
```
Is actually wrong syntax and the plugin will fail to load. It's also wrong in the docs: https://ftp.isc.org/isc/kea/cur/doc/kea-guide.html#flex-id
If it is a boolean it needs to be without quotes:
```
"replace-client-id": true,
"match-client-id": true
```
He provided a patch (attached) for the docs :)
[RT #14311](https://support.isc.org/Ticket/Display.html?id=14311#txn-482221)
[flex-id-docs.diff](/uploads/7772104eb0c461c1f3ced660cbccd037/flex-id-docs.diff)Kea1.6https://gitlab.isc.org/isc-projects/kea/-/issues/555cql-config script does not work2019-04-08T18:29:33ZTomek Mrugalskicql-config script does not workFrom this [jenkins build](https://jenkins.isc.org/job/kea-master-db-backends/86/console):
```
tools/cql_config: 30: tools/cql_config: source: not found
tools/cql_config: 38: [: --print-errors: unexpected operator
tools/cql_config: 71: [...From this [jenkins build](https://jenkins.isc.org/job/kea-master-db-backends/86/console):
```
tools/cql_config: 30: tools/cql_config: source: not found
tools/cql_config: 38: [: --print-errors: unexpected operator
tools/cql_config: 71: [: --print-errors: unexpected operator
tools/cql_config: 75: [: --print-errors: unexpected operator
tools/cql_config: 80: [: --print-errors: unexpected operator
tools/cql_config: 85: [: --print-errors: unexpected operator
tools/cql_config: 93: [: --print-errors: unexpected operator
wrong parameter
run: `tools/cql_config --help` for more help
configure: error: tools/cql_config cassandra failed
```
Seems like replacing `source` with `.` should fix the first problem. No idea about the following ones.Kea1.6https://gitlab.isc.org/isc-projects/kea/-/issues/508remote-network4-set doesn't save subnet2019-05-07T11:46:12ZWlodzimierz Wencelremote-network4-set doesn't save subnetWasn't it fixed in isc-projects/kea#493
Command:
```
{
"arguments": {
"remote": {
"type": "mysql"
},
"server-tags": [
"abc"
],
"shared-networks": [
{
"name": "net1",
"interface": "e...Wasn't it fixed in isc-projects/kea#493
Command:
```
{
"arguments": {
"remote": {
"type": "mysql"
},
"server-tags": [
"abc"
],
"shared-networks": [
{
"name": "net1",
"interface": "enp0s9",
"subnet4": [
{
"interface": "enp0s9",
"pools": [
{
"pool": "192.168.52.1-192.168.52.100"
}
],
"subnet": "192.168.52.0/24"
}
]
}
]
},
"command": "remote-network4-set"
}
```
result:
```
{
"arguments": {
"shared-networks": [
{
"name": "net1"
}
]
},
"result": 0,
"text": "IPv4 shared network successfully set."
}
```
but mysql db is missing subnet:
```
mysql> select * from dhcp4_shared_network;
+----+------+--------------+-----------+-----------------+---------------------+--------------+-------+-------------+------------------------+------------------+--------------+----------------+
| id | name | client_class | interface | match_client_id | modification_ts | rebind_timer | relay | renew_timer | require_client_classes | reservation_mode | user_context | valid_lifetime |
+----+------+--------------+-----------+-----------------+---------------------+--------------+-------+-------------+------------------------+------------------+--------------+----------------+
| 1 | | NULL | enp0s9 | 1 | 2019-02-21 05:40:02 | NULL | NULL | NULL | [ ] | 3 | NULL | NULL |
+----+------+--------------+-----------+-----------------+---------------------+--------------+-------+-------------+------------------------+------------------+--------------+----------------+
1 row in set (0.00 sec)
mysql> select * from dhcp4_subnet;
Empty set (0.00 sec)
```
and network4-get return incorrect network:
```
{
"arguments": {
"count": 1,
"shared-networks": [
{
"authoritative": false,
"interface": "enp0s9",
"match-client-id": true,
"name": "net1",
"option-data": [],
"relay": {
"ip-addresses": []
},
"reservation-mode": "all",
"subnet4": []
}
]
},
"result": 0,
"text": "IPv4 shared network 'net1' found."
}
```Kea1.6Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/issues/493remote-network4-set accept empty name2019-02-27T15:46:03ZWlodzimierz Wencelremote-network4-set accept empty name```
{
"arguments": {
"remote": {
"type": "mysql"
},
"server-tags": [
"abc"
],
"shared-networks": [
{
"name": "",
"interface": "enp0s9",
"subnet4": [
{
...```
{
"arguments": {
"remote": {
"type": "mysql"
},
"server-tags": [
"abc"
],
"shared-networks": [
{
"name": "",
"interface": "enp0s9",
"subnet4": [
{
"interface": "enp0s9",
"pools": [
{
"pool": "192.168.52.1-192.168.52.100"
}
],
"subnet": "192.168.52.0/24"
}
]
}
]
},
"command": "remote-network4-set"
}
```
result:
```
{
"arguments": {
"shared-networks": [
{
"name": ""
}
]
},
"result": 0,
"text": "IPv4 shared network successfully set."
}
```
```
mysql> select * from dhcp4_shared_network;
+----+------+--------------+-----------+-----------------+---------------------+--------------+-------+-------------+------------------------+------------------+--------------+----------------+
| id | name | client_class | interface | match_client_id | modification_ts | rebind_timer | relay | renew_timer | require_client_classes | reservation_mode | user_context | valid_lifetime |
+----+------+--------------+-----------+-----------------+---------------------+--------------+-------+-------------+------------------------+------------------+--------------+----------------+
| 1 | | NULL | enp0s9 | 1 | 2019-02-21 05:40:02 | NULL | NULL | NULL | [ ] | 3 | NULL | NULL |
+----+------+--------------+-----------+-----------------+---------------------+--------------+-------+-------------+------------------------+------------------+--------------+----------------+
1 row in set (0.00 sec)
```
interesting fact is that after kea restart (to force merging config) kea logs:
```
[kea-dhcp4.dhcp4/20684] DHCP4_OPEN_CONFIG_DB Opening configuration database: name=keadb password=***** type=mysql user=keauser
[kea-dhcp4.dhcp4/20684] DHCP4_CONFIG_FETCH Fetching configuration data from config backends.
[kea-dhcp4.dhcp4/20684] DHCP4_CONFIG_MERGED Configuration backend data has been merged.
```
So it looks like it was accepted, so I checked running configuration using `config-get` and this is what I found:
```
"shared-networks": [
{
"authoritative": false,
"interface": "enp0s9",
"match-client-id": true,
"option-data": [],
"relay": {
"ip-addresses": []
},
"reservation-mode": "all",
"subnet4": []
}
],
```
so:
1. kea accepted empty name
1. remote-network4-set command doesn't save subnet in the database (probably another issue should be opened for this)
Also I re-run test for shared-network empty name in JSON configuration file and there kea complain about empty name parameter and fail to start.Kea1.6https://gitlab.isc.org/isc-projects/kea/-/issues/456failing cb_cmd unit tests2019-03-06T12:09:57ZWlodzimierz Wencelfailing cb_cmd unit testsWe have one tests that is failing on 3 different systems:
https://jenkins.isc.org/job/kea-master/247/testReport/
which git commits were tested: https://jenkins.isc.org/job/kea-master/247/We have one tests that is failing on 3 different systems:
https://jenkins.isc.org/job/kea-master/247/testReport/
which git commits were tested: https://jenkins.isc.org/job/kea-master/247/Kea1.6Wlodzimierz WencelWlodzimierz Wencelhttps://gitlab.isc.org/isc-projects/kea/-/issues/443hammer followup and experiment2019-02-28T14:48:24ZFrancis Duponthammer followup and experimentNot a real issue, more a skeleton for doc.Not a real issue, more a skeleton for doc.Kea1.6Francis DupontFrancis Dupont