ISC Open Source Projects issueshttps://gitlab.isc.org/groups/isc-projects/-/issues2023-10-04T17:26:11Zhttps://gitlab.isc.org/isc-projects/stork/-/issues/1154Stop using self-signed certs during agent registration2023-10-04T17:26:11ZSlawek FigielStop using self-signed certs during agent registrationBug report:
Stork agent fails to start after upgrading to 1.12. It was working on the previous version.
The logs contain the below message:
```
Aug 30 20:00:43 user (...) time="2023-08-30 20:00:43" level="error" msg="problem registerin...Bug report:
Stork agent fails to start after upgrading to 1.12. It was working on the previous version.
The logs contain the below message:
```
Aug 30 20:00:43 user (...) time="2023-08-30 20:00:43" level="error" msg="problem registering machine: problem sending POST to https://host/api/machines: Post \"https://host/api/machines\": x509: certificate signed by unknown authority" file=" register.go:383 "
```1.13Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1148Improve creating DB guide for modern Postgres2023-10-02T16:47:43ZSlawek FigielImprove creating DB guide for modern PostgresThe issue was reported on [our mailing list](https://lists.isc.org/pipermail/stork-users/2023-August/000168.html).
Some modern Postgres versions may require explicitly granting the privileges on the `public` schema to Stork users. We sh...The issue was reported on [our mailing list](https://lists.isc.org/pipermail/stork-users/2023-August/000168.html).
Some modern Postgres versions may require explicitly granting the privileges on the `public` schema to Stork users. We should mention it in our documentation.
```
GRANT ALL ON SCHEMA public TO stork;
```1.13Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1143Notify about breaking changes in release notes2023-09-26T09:34:48ZSlawek FigielNotify about breaking changes in release notesThe problem was reported on [the stork-users mailing list](https://lists.isc.org/pipermail/stork-users/2023-August/000163.html).
A user has updated the Stork server (1.12) but kept the previous version of the Stork agent (1.11). The Sto...The problem was reported on [the stork-users mailing list](https://lists.isc.org/pipermail/stork-users/2023-August/000163.html).
A user has updated the Stork server (1.12) but kept the previous version of the Stork agent (1.11). The Stork agent was not able to communicate with the server.
The problem was caused by changing the method of compressing the data exchanged between the agent and server.
We don't guarantee that the previous agent versions will work properly with the server's current version. However, we could warn users if any changes in the GRPC protocol are provided. It would make the update a bit smoother.1.13Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1142Fix dependency problems reported by dependabot2023-10-02T08:51:39ZTomek MrugalskiFix dependency problems reported by dependabotDependabot on github [reports](https://github.com/isc-projects/stork/security/dependabot) the following 5 high/7 moderate/1 low:
- [x] 5 in `tests/sim`
- [x] 3 in `doc/src`
- [x] 5 in `webui`Dependabot on github [reports](https://github.com/isc-projects/stork/security/dependabot) the following 5 high/7 moderate/1 low:
- [x] 5 in `tests/sim`
- [x] 3 in `doc/src`
- [x] 5 in `webui`1.13Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1140Typing using appId: or subnetId: in Filter Subnet field results in field bein...2023-10-03T15:33:19Zfue36Typing using appId: or subnetId: in Filter Subnet field results in field being wipedTyping using `appId:` or `subnetId:` in Filter Subnet field results in the field being wiped
Stork Build: 1.12.0 - official rpm Redhat build running on AlmaLinux 9.2 x64.
Browser Build: Firefox 116.0.3 (64-bit) running Ubuntu Linux 22.0...Typing using `appId:` or `subnetId:` in Filter Subnet field results in the field being wiped
Stork Build: 1.12.0 - official rpm Redhat build running on AlmaLinux 9.2 x64.
Browser Build: Firefox 116.0.3 (64-bit) running Ubuntu Linux 22.04
Expected Result: The typed field content is not wiped, the behavior of `appId:3` or `subnetId:5` should be the same as the Host Reservation Filter. If I paste in the completed text in the search field, for example `appId:3` or `subnetId:5` then it works as expected.1.13Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1137Alpine Setup script not available2023-09-28T11:20:25ZThomas GerstenbergAlpine Setup script not availableStork documentation chapter [2.5.1.3](https://stork.readthedocs.io/en/latest/install.html#installing-on-alpine) mentions a setup script to install stork on Alpine ([https://dl.cloudsmith.io/public/isc/stork/cfg/setup/setup.alpine.sh](htt...Stork documentation chapter [2.5.1.3](https://stork.readthedocs.io/en/latest/install.html#installing-on-alpine) mentions a setup script to install stork on Alpine ([https://dl.cloudsmith.io/public/isc/stork/cfg/setup/setup.alpine.sh](https://dl.cloudsmith.io/public/isc/stork/cfg/setup/setup.alpine.sh)).
This script however is not available on cloudsmith.
I can imagine that this is related to #863. However, if there are no packages available, the documentation should not state that there are.1.13Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1136API mock has invalid filename2023-09-15T07:41:27ZSlawek FigielAPI mock has invalid filenameThe issue was found by @slawek during [1.12 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1124#note_393232).
The build system generates the `api_mock.go` file instead of `apimock_test.go`. The old name was reverted b...The issue was found by @slawek during [1.12 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1124#note_393232).
The build system generates the `api_mock.go` file instead of `apimock_test.go`. The old name was reverted by [this commit](https://gitlab.isc.org/isc-projects/stork/-/commit/9b140db674124d2a0ca3bc96420c9b2317e719d5).1.13Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1135Not summarized shared network statistic counters2023-10-04T10:04:48ZSlawek FigielNot summarized shared network statistic countersThe issue was found by @slawek during [1.12 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1124#note_393204).
The shared network statistics are not summarized.
I've generated traffic for the `192.1.16.0/24` subnet in...The issue was found by @slawek during [1.12 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1124#note_393204).
The shared network statistics are not summarized.
I've generated traffic for the `192.1.16.0/24` subnet in the `mouse` shared network.
The pie chart shows some addresses are assigned, but the counters below show zero values.
![image](https://gitlab.isc.org/isc-projects/stork/uploads/dd62de7153437f7aad8fd682de511acd/image.png)
The subnet page displays a proper pie chart and counter values.
![image](https://gitlab.isc.org/isc-projects/stork/uploads/fe6be2d9d0ea064b61b77089371c2816/image.png)1.13Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1133Hyperlinks for shared networks on the dashboard2023-09-20T17:22:56ZSlawek FigielHyperlinks for shared networks on the dashboardThe issue was found by @wlodek during [1.12 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1124#note_393193).
In the dashboard v6 shared networks are not hyperlinks:
![Screenshot_2023-08-02_at_15.29.50](https://gitla...The issue was found by @wlodek during [1.12 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1124#note_393193).
In the dashboard v6 shared networks are not hyperlinks:
![Screenshot_2023-08-02_at_15.29.50](https://gitlab.isc.org/isc-projects/stork/uploads/1cd7972c3b3e3af8049e6f625bcf7534/Screenshot_2023-08-02_at_15.29.50.png)1.13Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1131Missing issue count in the header of the config review panel2023-09-28T15:18:22ZSlawek FigielMissing issue count in the header of the config review panelThe issue was found by @marcin during [1.12 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1122#note_393190).
The config review component has a broken summary text:
![Zrzut_ekranu_2023-08-2_o_15.14.01](https://gitlab...The issue was found by @marcin during [1.12 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1122#note_393190).
The config review component has a broken summary text:
![Zrzut_ekranu_2023-08-2_o_15.14.01](https://gitlab.isc.org/isc-projects/stork/uploads/36070bb1c85968564948e7bb935f974c/Zrzut_ekranu_2023-08-2_o_15.14.01.png)
It starts with "issues found in...". The `totalIssues` value that should be output before this text is undefined, so it is not visible here. It creates an impression that some issues have been found, but in fact it should say: "No issues" (so the opposite).1.13Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1128Simulator is broken after Python code refactoring2023-09-26T09:31:46ZSlawek FigielSimulator is broken after Python code refactoringThe issue was found by @wlodek during [1.12 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1122#note_393139).
While running demo I am getting this error:
```
stork-1120-simulator-1 | * Serving Flask ap...The issue was found by @wlodek during [1.12 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1122#note_393139).
While running demo I am getting this error:
```
stork-1120-simulator-1 | * Serving Flask app 'sim.py' (lazy loading)
stork-1120-simulator-1 | * Environment: development
stork-1120-simulator-1 | * Debug mode: on
stork-1120-simulator-1 | Traceback (most recent call last):
stork-1120-simulator-1 | File "/usr/local/bin/flask", line 11, in <module>
stork-1120-simulator-1 | sys.exit(main())
stork-1120-simulator-1 | File "/usr/local/lib/python3.6/dist-packages/flask/cli.py", line 995, in main
stork-1120-simulator-1 | cli.main(args=sys.argv[1:])
stork-1120-simulator-1 | File "/usr/local/lib/python3.6/dist-packages/flask/cli.py", line 601, in main
stork-1120-simulator-1 | return super().main(*args, **kwargs)
stork-1120-simulator-1 | File "/usr/local/lib/python3.6/dist-packages/click/core.py", line 1053, in main
stork-1120-simulator-1 | rv = self.invoke(ctx)
stork-1120-simulator-1 | File "/usr/local/lib/python3.6/dist-packages/click/core.py", line 1659, in invoke
stork-1120-simulator-1 | return _process_result(sub_ctx.command.invoke(sub_ctx))
stork-1120-simulator-1 | File "/usr/local/lib/python3.6/dist-packages/click/core.py", line 1395, in invoke
stork-1120-simulator-1 | return ctx.invoke(self.callback, **ctx.params)
stork-1120-simulator-1 | File "/usr/local/lib/python3.6/dist-packages/click/core.py", line 754, in invoke
stork-1120-simulator-1 | return __callback(*args, **kwargs)
stork-1120-simulator-1 | File "/usr/local/lib/python3.6/dist-packages/click/decorators.py", line 84, in new_func
stork-1120-simulator-1 | return ctx.invoke(f, obj, *args, **kwargs)
stork-1120-simulator-1 | File "/usr/local/lib/python3.6/dist-packages/click/core.py", line 754, in invoke
stork-1120-simulator-1 | return __callback(*args, **kwargs)
stork-1120-simulator-1 | File "/usr/local/lib/python3.6/dist-packages/flask/cli.py", line 850, in run_command
stork-1120-simulator-1 | app = DispatchingApp(info.load_app, use_eager_loading=eager_loading)
stork-1120-simulator-1 | File "/usr/local/lib/python3.6/dist-packages/flask/cli.py", line 325, in __init__
stork-1120-simulator-1 | self._load_unlocked()
stork-1120-simulator-1 | File "/usr/local/lib/python3.6/dist-packages/flask/cli.py", line 351, in _load_unlocked
stork-1120-simulator-1 | self._app = rv = self.loader()
stork-1120-simulator-1 | File "/usr/local/lib/python3.6/dist-packages/flask/cli.py", line 407, in load_app
stork-1120-simulator-1 | app = locate_app(self, import_name, name)
stork-1120-simulator-1 | File "/usr/local/lib/python3.6/dist-packages/flask/cli.py", line 260, in locate_app
stork-1120-simulator-1 | __import__(module_name)
stork-1120-simulator-1 | File "/sim/sim.py", line 214, in <module>
stork-1120-simulator-1 | app, log = init()
stork-1120-simulator-1 | File "/sim/sim.py", line 204, in init
stork-1120-simulator-1 | log_instance = create_logger(app)
stork-1120-simulator-1 | File "/usr/local/lib/python3.6/dist-packages/flask/logging.py", line 66, in create_logger
stork-1120-simulator-1 | logger = logging.getLogger(app.name)
stork-1120-simulator-1 | AttributeError: 'NoneType' object has no attribute 'name'
```1.13Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1126Fix the release period in README file2023-10-02T11:16:20ZSlawek FigielFix the release period in README fileThe issue was found by @marcin during [1.12 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1122#note_393097).
The README says we have monthly development releases, but we now have bi-monthly releases.The issue was found by @marcin during [1.12 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1122#note_393097).
The README says we have monthly development releases, but we now have bi-monthly releases.1.13Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1014Fix misalignment of inline icons after PrimeNG upgrade2023-09-27T07:21:53ZSlawek FigielFix misalignment of inline icons after PrimeNG upgradeThe issue was reported by @slawek during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364517).
The checkbox is not aligned with the label inside the "Checker list" panel. The problem occurs o...The issue was reported by @slawek during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364517).
The checkbox is not aligned with the label inside the "Checker list" panel. The problem occurs on the application and "Review Checkers" pages. It may indicate a problem with table CSS styles after the last PrimeNG update.
![image](https://gitlab.isc.org/isc-projects/stork/uploads/99b2c3c10cb1c58e81a6123f5284b7be/image.png)
EDIT: The similar problem occurs for most of the inline icons in the text (icons on the "Review Checkers", button on any machine page, buttons on the machine list).1.13Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/stork/-/issues/995Upgrade Kea version in demo and fix systemtests version parsing2023-08-31T17:50:40ZSlawek FigielUpgrade Kea version in demo and fix systemtests version parsingThe default Kea version used in the demo (2.0.2) is pretty old; we should upgrade it.
We should also add some containers with different Kea versions. It's possible from a few releases by providing build arguments in compose file.The default Kea version used in the demo (2.0.2) is pretty old; we should upgrade it.
We should also add some containers with different Kea versions. It's possible from a few releases by providing build arguments in compose file.1.13Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/stork/-/issues/974Stork not consider bind chroot path in all cases2023-10-03T11:59:42ZJuliano GuidiniStork not consider bind chroot path in all cases---
name: Feature request
about: Suggest an idea for this project
---
**Some initial questions**
- Are you sure what you would like to do is not possible using some other mechanisms?
Maybe, changing all Bind setup, stork will find th...---
name: Feature request
about: Suggest an idea for this project
---
**Some initial questions**
- Are you sure what you would like to do is not possible using some other mechanisms?
Maybe, changing all Bind setup, stork will find the conf files.
- Stork is in very early stages of development. If your request is not simple, it
may be a while until anyone does anything with your request. Are you ok with that?
OK.
**Is your feature request related to a problem? Please describe.**
Yes. My Bind setup, and a wich a great number of Binds running, are on chroot environment. All Bind configuration is relactive to chroot path and in some them (my case) the configuration files are inside chroot.
Sample:
```
stork agent version: 1.9.0.230131111245
OS: Ubuntu 18.04.6 LTS - amd_64
chroot path: /var/lib/named
diretory absolute path: /var/lib/named/databases
bind command line: /var/lib/named/sbin/named -f -u bind -t /var/lib/named
```
Starting stork, in log it shows:
```
Feb 7 15:33:10 teste-compilando-bind-UB18 stork-agent[9802]: time="2023-02-07 15:33:10" level="warning" msg="cannot parse BIND 9 config file /etc/named.conf: exit status 1; /etc/named.conf.options:5: change directory to '/databases' failed: file not found\n\n/etc/named.conf.options:5: parsing failed: file not found\n" file=" bind9.go:405 "
```
Examining backend/agent/bind9.go
(commit 639fbb707313e7e7c9ac99d15c413fca1b6860f7 (HEAD -> master, tag: v1.9.0, origin/master, origin/HEAD))
```go
403 out, err := executor.Output(namedCheckconfPath, "-p", bind9ConfPath)
```
If I understand the code (sorry, programing is not my best :-) ) this function result on:
```bash
named-checkconf -p /etc/named.conf
/etc/named.conf.options:5: change directory to '/databases' failed: file not found
/etc/named.conf.options:5: parsing failed: file not found
```
Line 5 of /etc/named.conf.options is:
```
2 options {
3
4
5 directory "/databases";
```
This directory is relative to chroot path, but chroot path is not indicated to named-checonf -t option.
My Bind is compiled, so i think this is some part of the trouble.
If i use Bind from distro ( apt-get install bind9 ), this error not occours, see:
```
stork agent version: 1.9.0.230131111245
OS: Ubuntu 18.04.6 LTS - amd_64
chroot path: /var/bind9/chroot
diretory absolute path: /var/cache/bind
bind command line: /usr/sbin/named -f -u bind -t /var/bind9/chroot
```
/etc/bind/named.conf.options
```
1 options {
2
3 directory "/var/cache/bind";
```
This directory exists outside chroot directory, this way named-checkconf -p works whitout -t, of course, and all conf files are in /etc/bind.
I would like stork consider the chroot directory, automatically or by configuration the file agent.env, and if possible, configurations parameters to indicate bind named.conf.
**Describe alternatives you've considered**
To indicate Bind conf files a link was created from chroot/etc to /etc/bind.
But no solution to use chroot unless change all Bind setup on all my servers.
Thanks.1.13Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/958Create a UI form for updating a subnet2023-11-07T11:29:01ZMarcin SiodelskiCreate a UI form for updating a subnetWhen user clicks `Edit Subnet` button a new form should be opened where user can create new subnet and specify all required DHCP parameters, pools, options, etc. It depends on #956 and #957.When user clicks `Edit Subnet` button a new form should be opened where user can create new subnet and specify all required DHCP parameters, pools, options, etc. It depends on #956 and #957.1.13Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/957REST API calls to update a subnet2023-11-07T11:29:01ZMarcin SiodelskiREST API calls to update a subnetThere are several REST API calls to update a subnet (similar to the calls we have for the host reservations). Specifically, we need: `createSubnetUpdate`, `commitSubnetUpdate`. Internally they will make calls to the config manager's func...There are several REST API calls to update a subnet (similar to the calls we have for the host reservations). Specifically, we need: `createSubnetUpdate`, `commitSubnetUpdate`. Internally they will make calls to the config manager's functions: `BeginSubnetUpdate`, `ApplySubnetUpdate` and `Commit`.1.13Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/893ARM support2023-09-15T12:56:44ZSlawek FigielARM supportSome of our developers use MacBook M1 (ARM architecture). We should support this platform for development.Some of our developers use MacBook M1 (ARM architecture). We should support this platform for development.1.13Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/689Update Ubuntu version in Docker demo2023-09-27T11:58:18ZMarcin SiodelskiUpdate Ubuntu version in Docker demoCurrently our docker demo runs on Ubuntu 18. I'd suggest moving to Ubuntu 20, suspecting that it will also shorten the time required to run the demo because less system updates would be fetched during installation.Currently our docker demo runs on Ubuntu 18. I'd suggest moving to Ubuntu 20, suspecting that it will also shorten the time required to run the demo because less system updates would be fetched during installation.1.13Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/638LDAP support2023-10-05T11:36:45ZPeter DaviesLDAP supportIs is a request for LDAP/Active Directory support in Stork
The goal is to be able to use LDAP for authenticating Stork users for now. However, in the future the scope of LDAP support will likely be expanded to cover other functionalitie...Is is a request for LDAP/Active Directory support in Stork
The goal is to be able to use LDAP for authenticating Stork users for now. However, in the future the scope of LDAP support will likely be expanded to cover other functionalities.
[RT #19920](https://support.isc.org/Ticket/Display.html?id=19920)1.13Slawek FigielSlawek Figiel