ISC Open Source Projects issueshttps://gitlab.isc.org/groups/isc-projects/-/issues2020-06-29T13:02:26Zhttps://gitlab.isc.org/isc-projects/bind9/-/issues/1474ThreadSanitizer: data race lib/dns/message.c2020-06-29T13:02:26ZOndřej SurýThreadSanitizer: data race lib/dns/message.cMultiple issues found (all in rpz test):
```
WARNING: ThreadSanitizer: data race (pid=15310)
Write of size 4 at 0x7b50000c0008 by thread T1:
#0 msginitheader /home/ondrej/Projects/bind9/lib/dns/message.c:362 (libdns.so.1505+0xc2cdd...Multiple issues found (all in rpz test):
```
WARNING: ThreadSanitizer: data race (pid=15310)
Write of size 4 at 0x7b50000c0008 by thread T1:
#0 msginitheader /home/ondrej/Projects/bind9/lib/dns/message.c:362 (libdns.so.1505+0xc2cdd)
#1 msginit /home/ondrej/Projects/bind9/lib/dns/message.c:408 (libdns.so.1505+0xc2cdd)
#2 msgreset /home/ondrej/Projects/bind9/lib/dns/message.c:656 (libdns.so.1505+0xc2cdd)
#3 dns_message_reset /home/ondrej/Projects/bind9/lib/dns/message.c:797 (libdns.so.1505+0xc325e)
#4 ns_client_endrequest /home/ondrej/Projects/bind9/lib/ns/client.c:215 (libns.so.1502+0x122fa)
#5 ns__client_reset_cb /home/ondrej/Projects/bind9/lib/ns/client.c:1528 (libns.so.1502+0x122fa)
#6 isc_nmhandle_unref /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:1083 (libisc.so.1504+0x409eb)
#7 isc__nm_uvreq_put /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:1218 (libisc.so.1504+0x41c3f)
#8 udp_send_cb /home/ondrej/Projects/bind9/lib/isc/netmgr/udp.c:439 (libisc.so.1504+0x46c8d)
#9 <null> <null> (libuv.so.1+0x1d283)
#10 <null> <null> (libtsan.so.0+0x29b3d)
Previous read of size 4 at 0x7b50000c0008 by thread T12:
#0 ns_client_send /home/ondrej/Projects/bind9/lib/ns/client.c:665 (libns.so.1502+0x110db)
#1 respond /home/ondrej/Projects/bind9/lib/ns/update.c:1559 (libns.so.1502+0x4ecb6)
#2 respond /home/ondrej/Projects/bind9/lib/ns/update.c:1551 (libns.so.1502+0x4ecb6)
#3 updatedone_action /home/ondrej/Projects/bind9/lib/ns/update.c:3391 (libns.so.1502+0x4f598)
#4 dispatch /home/ondrej/Projects/bind9/lib/isc/task.c:1134 (libisc.so.1504+0x56fa6)
#5 run /home/ondrej/Projects/bind9/lib/isc/task.c:1319 (libisc.so.1504+0x56fa6)
#6 <null> <null> (libtsan.so.0+0x29b3d)
Location is heap block of size 497 at 0x7b50000c0000 allocated by thread T4:
#0 malloc <null> (libtsan.so.0+0x2b1a3)
#1 default_memalloc /home/ondrej/Projects/bind9/lib/isc/mem.c:685 (libisc.so.1504+0x33fee)
#2 mem_get /home/ondrej/Projects/bind9/lib/isc/mem.c:598 (libisc.so.1504+0x3c001)
#3 isc___mem_get /home/ondrej/Projects/bind9/lib/isc/mem.c:1013 (libisc.so.1504+0x3c001)
#4 isc__mem_get /home/ondrej/Projects/bind9/lib/isc/mem.c:2365 (libisc.so.1504+0x3aef1)
#5 dns_message_create /home/ondrej/Projects/bind9/lib/dns/message.c:715 (libdns.so.1505+0xbcc0e)
#6 ns__client_setup /home/ondrej/Projects/bind9/lib/ns/client.c:2250 (libns.so.1502+0x132d3)
#7 ns__client_request /home/ondrej/Projects/bind9/lib/ns/client.c:1634 (libns.so.1502+0x13d2a)
#8 udp_recv_cb /home/ondrej/Projects/bind9/lib/isc/netmgr/udp.c:317 (libisc.so.1504+0x46926)
#9 <null> <null> (libuv.so.1+0x1d6d4)
#10 <null> <null> (libtsan.so.0+0x29b3d)
Thread T1 'isc-net-0000' (tid=15325, running) created by main thread at:
#0 pthread_create <null> (libtsan.so.0+0x2be1b)
#1 isc_thread_create /home/ondrej/Projects/bind9/lib/isc/pthreads/thread.c:75 (libisc.so.1504+0x7bcc4)
#2 isc_nm_start /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:149 (libisc.so.1504+0x3ec7a)
#3 create_managers main.c:895 (named+0x1ae90)
#4 setup main.c:1235 (named+0x1ae90)
#5 main main.c:1515 (named+0x1ae90)
Thread T12 'isc-worker0003' (tid=15336, running) created by main thread at:
#0 pthread_create <null> (libtsan.so.0+0x2be1b)
#1 isc_thread_create /home/ondrej/Projects/bind9/lib/isc/pthreads/thread.c:75 (libisc.so.1504+0x7bcc4)
#2 isc_taskmgr_create /home/ondrej/Projects/bind9/lib/isc/task.c:1410 (libisc.so.1504+0x59d63)
#3 create_managers main.c:902 (named+0x1aeec)
#4 setup main.c:1235 (named+0x1aeec)
#5 main main.c:1515 (named+0x1aeec)
Thread T4 'isc-net-0003' (tid=15328, running) created by main thread at:
#0 pthread_create <null> (libtsan.so.0+0x2be1b)
#1 isc_thread_create /home/ondrej/Projects/bind9/lib/isc/pthreads/thread.c:75 (libisc.so.1504+0x7bcc4)
#2 isc_nm_start /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:149 (libisc.so.1504+0x3ec7a)
#3 create_managers main.c:895 (named+0x1ae90)
#4 setup main.c:1235 (named+0x1ae90)
#5 main main.c:1515 (named+0x1ae90)
SUMMARY: ThreadSanitizer: data race /home/ondrej/Projects/bind9/lib/dns/message.c:362 in msginitheader
```
```
WARNING: ThreadSanitizer: data race (pid=15310)
Write of size 2 at 0x7b50000c000c by thread T1:
#0 msginitheader /home/ondrej/Projects/bind9/lib/dns/message.c:363 (libdns.so.1505+0xc2ced)
#1 msginit /home/ondrej/Projects/bind9/lib/dns/message.c:408 (libdns.so.1505+0xc2ced)
#2 msgreset /home/ondrej/Projects/bind9/lib/dns/message.c:656 (libdns.so.1505+0xc2ced)
#3 dns_message_reset /home/ondrej/Projects/bind9/lib/dns/message.c:797 (libdns.so.1505+0xc325e)
#4 ns_client_endrequest /home/ondrej/Projects/bind9/lib/ns/client.c:215 (libns.so.1502+0x122fa)
#5 ns__client_reset_cb /home/ondrej/Projects/bind9/lib/ns/client.c:1528 (libns.so.1502+0x122fa)
#6 isc_nmhandle_unref /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:1083 (libisc.so.1504+0x409eb)
#7 isc__nm_uvreq_put /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:1218 (libisc.so.1504+0x41c3f)
#8 udp_send_cb /home/ondrej/Projects/bind9/lib/isc/netmgr/udp.c:439 (libisc.so.1504+0x46c8d)
#9 <null> <null> (libuv.so.1+0x1d283)
#10 <null> <null> (libtsan.so.0+0x29b3d)
Previous read of size 2 at 0x7b50000c000c by thread T12:
#0 ns_client_send /home/ondrej/Projects/bind9/lib/ns/client.c:652 (libns.so.1502+0x10fee)
#1 respond /home/ondrej/Projects/bind9/lib/ns/update.c:1559 (libns.so.1502+0x4ecb6)
#2 respond /home/ondrej/Projects/bind9/lib/ns/update.c:1551 (libns.so.1502+0x4ecb6)
#3 updatedone_action /home/ondrej/Projects/bind9/lib/ns/update.c:3391 (libns.so.1502+0x4f598)
#4 dispatch /home/ondrej/Projects/bind9/lib/isc/task.c:1134 (libisc.so.1504+0x56fa6)
#5 run /home/ondrej/Projects/bind9/lib/isc/task.c:1319 (libisc.so.1504+0x56fa6)
#6 <null> <null> (libtsan.so.0+0x29b3d)
Location is heap block of size 497 at 0x7b50000c0000 allocated by thread T4:
#0 malloc <null> (libtsan.so.0+0x2b1a3)
#1 default_memalloc /home/ondrej/Projects/bind9/lib/isc/mem.c:685 (libisc.so.1504+0x33fee)
#2 mem_get /home/ondrej/Projects/bind9/lib/isc/mem.c:598 (libisc.so.1504+0x3c001)
#3 isc___mem_get /home/ondrej/Projects/bind9/lib/isc/mem.c:1013 (libisc.so.1504+0x3c001)
#4 isc__mem_get /home/ondrej/Projects/bind9/lib/isc/mem.c:2365 (libisc.so.1504+0x3aef1)
#5 dns_message_create /home/ondrej/Projects/bind9/lib/dns/message.c:715 (libdns.so.1505+0xbcc0e)
#6 ns__client_setup /home/ondrej/Projects/bind9/lib/ns/client.c:2250 (libns.so.1502+0x132d3)
#7 ns__client_request /home/ondrej/Projects/bind9/lib/ns/client.c:1634 (libns.so.1502+0x13d2a)
#8 udp_recv_cb /home/ondrej/Projects/bind9/lib/isc/netmgr/udp.c:317 (libisc.so.1504+0x46926)
#9 <null> <null> (libuv.so.1+0x1d6d4)
#10 <null> <null> (libtsan.so.0+0x29b3d)
Thread T1 'isc-net-0000' (tid=15325, running) created by main thread at:
#0 pthread_create <null> (libtsan.so.0+0x2be1b)
#1 isc_thread_create /home/ondrej/Projects/bind9/lib/isc/pthreads/thread.c:75 (libisc.so.1504+0x7bcc4)
#2 isc_nm_start /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:149 (libisc.so.1504+0x3ec7a)
#3 create_managers main.c:895 (named+0x1ae90)
#4 setup main.c:1235 (named+0x1ae90)
#5 main main.c:1515 (named+0x1ae90)
Thread T12 'isc-worker0003' (tid=15336, running) created by main thread at:
#0 pthread_create <null> (libtsan.so.0+0x2be1b)
#1 isc_thread_create /home/ondrej/Projects/bind9/lib/isc/pthreads/thread.c:75 (libisc.so.1504+0x7bcc4)
#2 isc_taskmgr_create /home/ondrej/Projects/bind9/lib/isc/task.c:1410 (libisc.so.1504+0x59d63)
#3 create_managers main.c:902 (named+0x1aeec)
#4 setup main.c:1235 (named+0x1aeec)
#5 main main.c:1515 (named+0x1aeec)
Thread T4 'isc-net-0003' (tid=15328, running) created by main thread at:
#0 pthread_create <null> (libtsan.so.0+0x2be1b)
#1 isc_thread_create /home/ondrej/Projects/bind9/lib/isc/pthreads/thread.c:75 (libisc.so.1504+0x7bcc4)
#2 isc_nm_start /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:149 (libisc.so.1504+0x3ec7a)
#3 create_managers main.c:895 (named+0x1ae90)
#4 setup main.c:1235 (named+0x1ae90)
#5 main main.c:1515 (named+0x1ae90)
SUMMARY: ThreadSanitizer: data race /home/ondrej/Projects/bind9/lib/dns/message.c:363 in msginitheader
```
```
WARNING: ThreadSanitizer: data race (pid=15310)
Write of size 8 at 0x7b50000c0170 by thread T1:
#0 msginittsig /home/ondrej/Projects/bind9/lib/dns/message.c:394 (libdns.so.1505+0xc2edd)
#1 msginit /home/ondrej/Projects/bind9/lib/dns/message.c:410 (libdns.so.1505+0xc2edd)
#2 msgreset /home/ondrej/Projects/bind9/lib/dns/message.c:656 (libdns.so.1505+0xc2edd)
#3 dns_message_reset /home/ondrej/Projects/bind9/lib/dns/message.c:797 (libdns.so.1505+0xc325e)
#4 ns_client_endrequest /home/ondrej/Projects/bind9/lib/ns/client.c:215 (libns.so.1502+0x122fa)
#5 ns__client_reset_cb /home/ondrej/Projects/bind9/lib/ns/client.c:1528 (libns.so.1502+0x122fa)
#6 isc_nmhandle_unref /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:1083 (libisc.so.1504+0x409eb)
#7 isc__nm_uvreq_put /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:1218 (libisc.so.1504+0x41c3f)
#8 udp_send_cb /home/ondrej/Projects/bind9/lib/isc/netmgr/udp.c:439 (libisc.so.1504+0x46c8d)
#9 <null> <null> (libuv.so.1+0x1d283)
#10 <null> <null> (libtsan.so.0+0x29b3d)
Previous read of size 8 at 0x7b50000c0170 by thread T12:
#0 ns_client_send /home/ondrej/Projects/bind9/lib/ns/client.c:657 (libns.so.1502+0x11048)
#1 respond /home/ondrej/Projects/bind9/lib/ns/update.c:1559 (libns.so.1502+0x4ecb6)
#2 respond /home/ondrej/Projects/bind9/lib/ns/update.c:1551 (libns.so.1502+0x4ecb6)
#3 updatedone_action /home/ondrej/Projects/bind9/lib/ns/update.c:3391 (libns.so.1502+0x4f598)
#4 dispatch /home/ondrej/Projects/bind9/lib/isc/task.c:1134 (libisc.so.1504+0x56fa6)
#5 run /home/ondrej/Projects/bind9/lib/isc/task.c:1319 (libisc.so.1504+0x56fa6)
#6 <null> <null> (libtsan.so.0+0x29b3d)
Location is heap block of size 497 at 0x7b50000c0000 allocated by thread T4:
#0 malloc <null> (libtsan.so.0+0x2b1a3)
#1 default_memalloc /home/ondrej/Projects/bind9/lib/isc/mem.c:685 (libisc.so.1504+0x33fee)
#2 mem_get /home/ondrej/Projects/bind9/lib/isc/mem.c:598 (libisc.so.1504+0x3c001)
#3 isc___mem_get /home/ondrej/Projects/bind9/lib/isc/mem.c:1013 (libisc.so.1504+0x3c001)
#4 isc__mem_get /home/ondrej/Projects/bind9/lib/isc/mem.c:2365 (libisc.so.1504+0x3aef1)
#5 dns_message_create /home/ondrej/Projects/bind9/lib/dns/message.c:715 (libdns.so.1505+0xbcc0e)
#6 ns__client_setup /home/ondrej/Projects/bind9/lib/ns/client.c:2250 (libns.so.1502+0x132d3)
#7 ns__client_request /home/ondrej/Projects/bind9/lib/ns/client.c:1634 (libns.so.1502+0x13d2a)
#8 udp_recv_cb /home/ondrej/Projects/bind9/lib/isc/netmgr/udp.c:317 (libisc.so.1504+0x46926)
#9 <null> <null> (libuv.so.1+0x1d6d4)
#10 <null> <null> (libtsan.so.0+0x29b3d)
Thread T1 'isc-net-0000' (tid=15325, running) created by main thread at:
#0 pthread_create <null> (libtsan.so.0+0x2be1b)
#1 isc_thread_create /home/ondrej/Projects/bind9/lib/isc/pthreads/thread.c:75 (libisc.so.1504+0x7bcc4)
#2 isc_nm_start /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:149 (libisc.so.1504+0x3ec7a)
#3 create_managers main.c:895 (named+0x1ae90)
#4 setup main.c:1235 (named+0x1ae90)
#5 main main.c:1515 (named+0x1ae90)
Thread T12 'isc-worker0003' (tid=15336, running) created by main thread at:
#0 pthread_create <null> (libtsan.so.0+0x2be1b)
#1 isc_thread_create /home/ondrej/Projects/bind9/lib/isc/pthreads/thread.c:75 (libisc.so.1504+0x7bcc4)
#2 isc_taskmgr_create /home/ondrej/Projects/bind9/lib/isc/task.c:1410 (libisc.so.1504+0x59d63)
#3 create_managers main.c:902 (named+0x1aeec)
#4 setup main.c:1235 (named+0x1aeec)
#5 main main.c:1515 (named+0x1aeec)
Thread T4 'isc-net-0003' (tid=15328, running) created by main thread at:
#0 pthread_create <null> (libtsan.so.0+0x2be1b)
#1 isc_thread_create /home/ondrej/Projects/bind9/lib/isc/pthreads/thread.c:75 (libisc.so.1504+0x7bcc4)
#2 isc_nm_start /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:149 (libisc.so.1504+0x3ec7a)
#3 create_managers main.c:895 (named+0x1ae90)
#4 setup main.c:1235 (named+0x1ae90)
#5 main main.c:1515 (named+0x1ae90)
SUMMARY: ThreadSanitizer: data race /home/ondrej/Projects/bind9/lib/dns/message.c:394 in msginittsig
```
```
WARNING: ThreadSanitizer: data race (pid=15310)
Write of size 8 at 0x7b50000c0190 by thread T1:
#0 msginittsig /home/ondrej/Projects/bind9/lib/dns/message.c:397 (libdns.so.1505+0xc2f21)
#1 msginit /home/ondrej/Projects/bind9/lib/dns/message.c:410 (libdns.so.1505+0xc2f21)
#2 msgreset /home/ondrej/Projects/bind9/lib/dns/message.c:656 (libdns.so.1505+0xc2f21)
#3 dns_message_reset /home/ondrej/Projects/bind9/lib/dns/message.c:797 (libdns.so.1505+0xc325e)
#4 ns_client_endrequest /home/ondrej/Projects/bind9/lib/ns/client.c:215 (libns.so.1502+0x122fa)
#5 ns__client_reset_cb /home/ondrej/Projects/bind9/lib/ns/client.c:1528 (libns.so.1502+0x122fa)
#6 isc_nmhandle_unref /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:1083 (libisc.so.1504+0x409eb)
#7 isc__nm_uvreq_put /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:1218 (libisc.so.1504+0x41c3f)
#8 udp_send_cb /home/ondrej/Projects/bind9/lib/isc/netmgr/udp.c:439 (libisc.so.1504+0x46c8d)
#9 <null> <null> (libuv.so.1+0x1d283)
#10 <null> <null> (libtsan.so.0+0x29b3d)
Previous read of size 8 at 0x7b50000c0190 by thread T12:
#0 ns_client_send /home/ondrej/Projects/bind9/lib/ns/client.c:661 (libns.so.1502+0x11093)
#1 respond /home/ondrej/Projects/bind9/lib/ns/update.c:1559 (libns.so.1502+0x4ecb6)
#2 respond /home/ondrej/Projects/bind9/lib/ns/update.c:1551 (libns.so.1502+0x4ecb6)
#3 updatedone_action /home/ondrej/Projects/bind9/lib/ns/update.c:3391 (libns.so.1502+0x4f598)
#4 dispatch /home/ondrej/Projects/bind9/lib/isc/task.c:1134 (libisc.so.1504+0x56fa6)
#5 run /home/ondrej/Projects/bind9/lib/isc/task.c:1319 (libisc.so.1504+0x56fa6)
#6 <null> <null> (libtsan.so.0+0x29b3d)
Location is heap block of size 497 at 0x7b50000c0000 allocated by thread T4:
#0 malloc <null> (libtsan.so.0+0x2b1a3)
#1 default_memalloc /home/ondrej/Projects/bind9/lib/isc/mem.c:685 (libisc.so.1504+0x33fee)
#2 mem_get /home/ondrej/Projects/bind9/lib/isc/mem.c:598 (libisc.so.1504+0x3c001)
#3 isc___mem_get /home/ondrej/Projects/bind9/lib/isc/mem.c:1013 (libisc.so.1504+0x3c001)
#4 isc__mem_get /home/ondrej/Projects/bind9/lib/isc/mem.c:2365 (libisc.so.1504+0x3aef1)
#5 dns_message_create /home/ondrej/Projects/bind9/lib/dns/message.c:715 (libdns.so.1505+0xbcc0e)
#6 ns__client_setup /home/ondrej/Projects/bind9/lib/ns/client.c:2250 (libns.so.1502+0x132d3)
#7 ns__client_request /home/ondrej/Projects/bind9/lib/ns/client.c:1634 (libns.so.1502+0x13d2a)
#8 udp_recv_cb /home/ondrej/Projects/bind9/lib/isc/netmgr/udp.c:317 (libisc.so.1504+0x46926)
#9 <null> <null> (libuv.so.1+0x1d6d4)
#10 <null> <null> (libtsan.so.0+0x29b3d)
Thread T1 'isc-net-0000' (tid=15325, running) created by main thread at:
#0 pthread_create <null> (libtsan.so.0+0x2be1b)
#1 isc_thread_create /home/ondrej/Projects/bind9/lib/isc/pthreads/thread.c:75 (libisc.so.1504+0x7bcc4)
#2 isc_nm_start /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:149 (libisc.so.1504+0x3ec7a)
#3 create_managers main.c:895 (named+0x1ae90)
#4 setup main.c:1235 (named+0x1ae90)
#5 main main.c:1515 (named+0x1ae90)
Thread T12 'isc-worker0003' (tid=15336, running) created by main thread at:
#0 pthread_create <null> (libtsan.so.0+0x2be1b)
#1 isc_thread_create /home/ondrej/Projects/bind9/lib/isc/pthreads/thread.c:75 (libisc.so.1504+0x7bcc4)
#2 isc_taskmgr_create /home/ondrej/Projects/bind9/lib/isc/task.c:1410 (libisc.so.1504+0x59d63)
#3 create_managers main.c:902 (named+0x1aeec)
#4 setup main.c:1235 (named+0x1aeec)
#5 main main.c:1515 (named+0x1aeec)
Thread T4 'isc-net-0003' (tid=15328, running) created by main thread at:
#0 pthread_create <null> (libtsan.so.0+0x2be1b)
#1 isc_thread_create /home/ondrej/Projects/bind9/lib/isc/pthreads/thread.c:75 (libisc.so.1504+0x7bcc4)
#2 isc_nm_start /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:149 (libisc.so.1504+0x3ec7a)
#3 create_managers main.c:895 (named+0x1ae90)
#4 setup main.c:1235 (named+0x1ae90)
#5 main main.c:1515 (named+0x1ae90)
SUMMARY: ThreadSanitizer: data race /home/ondrej/Projects/bind9/lib/dns/message.c:397 in msginittsig
```July 2020 (9.11.21, 9.11.21-S1, 9.16.5, 9.17.3)https://gitlab.isc.org/isc-projects/bind9/-/issues/1935[v9_11] "resolver" test broken on Windows after !35862020-06-29T09:22:18ZMichal Nowak[v9_11] "resolver" test broken on Windows after !3586After !3586, the `resolver` test is broken on `v9_11_20` and the subscription edition's `v9_11_20-S1` (see https://gitlab.isc.org/isc-private/bind9/-/jobs/950432 & https://gitlab.isc.org/isc-private/bind9/-/jobs/950429):
```
I:resolver:c...After !3586, the `resolver` test is broken on `v9_11_20` and the subscription edition's `v9_11_20-S1` (see https://gitlab.isc.org/isc-private/bind9/-/jobs/950432 & https://gitlab.isc.org/isc-private/bind9/-/jobs/950429):
```
I:resolver:check that the resolver limits the number of NS records it follows in a referral response (17)
I:resolver:query count error: 1 NS records: expected queries 1, actual 2
I:resolver:query count error: 2 NS records: expected queries 2, actual 4
I:resolver:query count error: 3 NS records: expected queries 3, actual 6
...
```
With !3586 reverted, `v9_11_20` Windows system tests pass (see https://gitlab.isc.org/mnowak/bind9/-/jobs/951334 & https://gitlab.isc.org/mnowak/bind9/-/jobs/951333).July 2020 (9.11.21, 9.11.21-S1, 9.16.5, 9.17.3)Mark AndrewsMark Andrewshttps://gitlab.isc.org/isc-projects/bind9/-/issues/1979rndc-confgen2020-06-27T18:43:52ZPasan Jayarathnarndc-confgenHI,
I tried to install bind-9.10.1-P2 in Centos7 and when i try to run command "rndc-confgen -b 512", it says "bash: rndc-confgen: command not found"
But when i try install "rndc-confgen" , it says no packages, please help me to fix this...HI,
I tried to install bind-9.10.1-P2 in Centos7 and when i try to run command "rndc-confgen -b 512", it says "bash: rndc-confgen: command not found"
But when i try install "rndc-confgen" , it says no packages, please help me to fix this issue.
Thanks.https://gitlab.isc.org/isc-projects/kea/-/issues/1087Logging and access to current count of 'unacked-clients' during HA heartbeat ...2020-06-26T21:36:16ZCathy AlmondLogging and access to current count of 'unacked-clients' during HA heartbeat communication failures'As suggested from questions on [Support ticket #15920](https://support.isc.org/Ticket/Display.html?id=15920) ...
1. The first question is 'how do I know that my HA peer is ready and waiting to take over if my server fails?'
Particular...As suggested from questions on [Support ticket #15920](https://support.isc.org/Ticket/Display.html?id=15920) ...
1. The first question is 'how do I know that my HA peer is ready and waiting to take over if my server fails?'
Particularly in the case of hot-standby, there's not much visibility into the readiness of the standby server to take over - for example, is it 'seeing' the client traffic that the other server is handling? The conclusion we came to was that it would be good, operationally, to either increase the server (dhcp4 and/or dhcp6) to 'see' the client packets that are being seen but dropped, or to monitor pkt4-received and pkt6-received statistics.
But it might be more helpful if the heartbeat logging (to confirm that the peers are in communication with each other) also indicated whether or not this server is 'seeing' the traffic that it is expecting its partner to handle, unless/until a peer-down state is reached.
2. The second question is 'why hasn't my HA server taken over yet from its peer?'
In most HA configurations, there are two triggers for a server to take over from its peer. The first is that the HA heartbeat has failed (receipt of and/or send of) and HA starts logging communication interrupted. If the server is also configured with non-zero max-unacked-clients, it does not take over right away, but at this point starts watching the client traffic for the other server to determine if it is responding or not.
There is no direct visibility into the status of unacked-clients while it is doing this (although clearly the server that is monitoring and counting them is keeping records). Please could this be logged (along with the HA heartbeat status) so that it's possible for sysadmins to know the full status of HA in a communications-interrupted situation and before reaching the peer-down state.kea1.7.8Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/119Intercept common access denied errors and display it as a separate page2020-06-25T17:20:22ZMarcin SiodelskiIntercept common access denied errors and display it as a separate pageAs pointed out in the following review comment: https://gitlab.isc.org/isc-projects/stork/merge_requests/28#note_99381, we need to intercept certain access errors and display appropriate error page rather than an empty table. This ticket...As pointed out in the following review comment: https://gitlab.isc.org/isc-projects/stork/merge_requests/28#note_99381, we need to intercept certain access errors and display appropriate error page rather than an empty table. This ticket is to deal with this issue in a generic way.0.9Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/kea/-/issues/1264extend the multi-thread safety section in Hook's Developer's Guide2020-06-25T17:06:13ZFrancis Dupontextend the multi-thread safety section in Hook's Developer's GuideThe Hook's Developer's Guide has a short text about multi-thread safety around the multi_threading_compatible C function and the MultiThreadingCriticalSection.
This ticket proposes to extend this by:
- explain the difference between th...The Hook's Developer's Guide has a short text about multi-thread safety around the multi_threading_compatible C function and the MultiThreadingCriticalSection.
This ticket proposes to extend this by:
- explain the difference between the Kea thread safety and the generic thread safety
- explain how to make the hook code Kea thread safe
- insist about the fact that MultiThreadingCriticalSection must **not** be used when can be entered from a packet processing callout point
- give the (short) list of Kea APIs which are generic thread safe
- insist about the fact that by outside this **short** list all Kea APIs are **not** generic thread safe nor in general the C++ programming language
- use the last comment to introduce the fact that hooks are not required to be written in C++kea1.7.10Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/issues/1244KB on How to upgrade/update Kea2020-06-24T21:55:20ZVicky Riskvicky@isc.orgKB on How to upgrade/update KeaWe would like a generic 'How to update your Kea server' with special instructions if the update includes a db schema change and special instructions for an HA pair. If there are any other special cases, include those.
Then in the releas...We would like a generic 'How to update your Kea server' with special instructions if the update includes a db schema change and special instructions for an HA pair. If there are any other special cases, include those.
Then in the release notes, we can tell them if they need to use one of these special cases (based on what the changes are in the release.)kea1.7.9Wlodzimierz WencelWlodzimierz Wencelhttps://gitlab.isc.org/isc-projects/kea/-/issues/1296Spelling errors in the database2020-06-24T18:48:14ZMarcin SiodelskiSpelling errors in the databaseWe have spelling errors in the database in the per subnet statistics. It should be `assigned-addresses`, but it is `assigned-addreses` (with single s). This error is repeated for total addresses and declined addresses too.We have spelling errors in the database in the per subnet statistics. It should be `assigned-addresses`, but it is `assigned-addreses` (with single s). This error is repeated for total addresses and declined addresses too.https://gitlab.isc.org/isc-projects/stork/-/issues/327Handle HTTP 403 errors for unauthorized users2020-06-24T13:52:25ZMarcin SiodelskiHandle HTTP 403 errors for unauthorized usersThis is the follow up ticket to #119. It was found that when the session is destroyed (e.g. removed from the database) but the session information is stored in the local storage (the user didn't log off explicitly via the UI), the user g...This is the follow up ticket to #119. It was found that when the session is destroyed (e.g. removed from the database) but the session information is stored in the local storage (the user didn't log off explicitly via the UI), the user gets redirected to the forbidden page when trying to navigate to the login page. This is because, the login page sends some REST calls to the server and the server apparently returns error 403 for the unauthorized user, rather than 401. This case has to be handled and if the session doesn't exist the user must not navigate to forbidden page, even upon receiving error 403.0.9Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/45Req 2.2 - Host Reservations List2020-06-23T15:59:26ZVicky Riskvicky@isc.orgReq 2.2 - Host Reservations ListAs an administrator, I would like to be able to browse a list of host reservations.
* [ ] I would like to be able to sort this list by IP, ~~date the lease was assigned to a client,~~ or host name.
* [x] I would like to be able to searc...As an administrator, I would like to be able to browse a list of host reservations.
* [ ] I would like to be able to sort this list by IP, ~~date the lease was assigned to a client,~~ or host name.
* [x] I would like to be able to searching for a host reservation based on IP address
* [x] I would like to be able to searching for a host reservation based on hostname
* [ ] ~~I would like to be able to apply a filter to show either all addresses assigned, or all host reservations not claimed.~~
* [ ] ~~I would like to see if a lease for this reservation has actually been requested and assigned.~~
* [ ] ~~I would like to see the pxeboot file option value for each host.~~
* [x] Filter the reservations list by type (hw-address, duid, client-id, flex-id etc)
* [x] Search for a host reservation based on MAC address, client-id, duid, flex-id values.
There were several more requirements here that needed lease information. I moved them to #237.
Those related to displaying options were pushed back to #314.
Details:
* What additional options from the HR can we display?0.9https://gitlab.isc.org/isc-projects/bind9/-/issues/1787BIND (master) does not work with krb5 1.18 (NegoEx)2020-06-23T11:47:32ZMichał KępieńBIND (master) does not work with krb5 1.18 (NegoEx)Current `master` does not work with krb5 1.18 (released in February
2020) - `nsupdate` and `tsiggss` system tests are consistently failing.
`git bisect` claims that an [upstream commit][1] implementing
[NegoEx][2]) is the culprit.
This ...Current `master` does not work with krb5 1.18 (released in February
2020) - `nsupdate` and `tsiggss` system tests are consistently failing.
`git bisect` claims that an [upstream commit][1] implementing
[NegoEx][2]) is the culprit.
This is only an issue for `master` as we do not use krb5's SPNEGO
mechanism in any other branch. Older branches either use an internal
SPNEGO implementation or no SPNEGO mechanism at all when
`--disable-isc-spnego` is used.
Out of all our Docker images, only the Tumbleweed one has krb5 1.18,
though - as luck would have it - the `krb5-devel` package there installs
`krb5-config` into a custom prefix (`/usr/lib/mit`), which prevents
BIND's `./configure` from autodetecting it and thus BIND builds on
Tumbleweed lack GSSAPI support altogether. I will push a branch shortly
which fixes this so that the breakage can be demonstrated in CI.
I cannot say I understand GSSAPI, so this needs attention from someone
who does.
[1]: https://github.com/krb5/krb5/commit/c2ca2f26eaf817a6a7ed42257c380437ab802bd9
[2]: https://tools.ietf.org/html/draft-zhu-negoex-04BIND 9.17 BackburnerOndřej SurýOndřej Surýhttps://gitlab.isc.org/isc-projects/kea/-/issues/1259compilation error on MacOS 10.15.4 with postgresql 12.3_22020-06-23T10:58:24ZRazvan Becheriucompilation error on MacOS 10.15.4 with postgresql 12.3_2might not report on all devices. still need to investigate.
it was introduces by upgrading to postgresql 12.x, but it was fixed partially. initially it was failing for multiple libraries.
currently the only affected lib is the one in sr...might not report on all devices. still need to investigate.
it was introduces by upgrading to postgresql 12.x, but it was fixed partially. initially it was failing for multiple libraries.
currently the only affected lib is the one in src/lib/dhcpsrv/tests/.
might be related to include / link order or dependencies.
```
CXXLD libdhcpsrv_unittests
Undefined symbols for architecture x86_64:
"___darwin_check_fd_set_overflow", referenced from:
(anonymous namespace)::D2ClientMgrTest::selectCheck(bool) in libdhcpsrv_unittests-d2_udp_unittest.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```
configure command:
```
LDFLAGS="-L/usr/local/opt/openssl/lib" DYLD_LIBRARY_PATH="$DYLD_LIBRARY_PATH:/opt/sysrepo/lib:/opt/libyang/lib" XML_CATALOG_FILES="/usr/local/etc/xml/catalog" PATH="/usr/local/opt/sphinx-doc/bin:/usr/local/Cellar/bison/3.6.2/bin:/opt/sysrepo/bin:$PATH" ./configure --verbose --with-mysql --with-pgsql --with-cql=/Users/razvan/isc/releases/kea-1.7.8-rc1/kea-1.7.8-work/tools/cql_config --enable-cql-static-lib --with-sysrepo=/Users/razvan/isc/git/kea-work/tools/sysrepo_config --with-freeradius=/opt/freeradius-client --with-gtest-source=/Users/razvan/isc/git/googletest --enable-generate-parser --enable-perfdhcp --enable-generate-messages --enable-shell --enable-generate-docs --enable-logger-checks --enable-debug --prefix=/opt/kea-1.7.8-work --with-openssl --with-benchmark-source=/Users/razvan/isc/git/benchmark
```
config report file:
[config.report](/uploads/0cd5c0b62870463f864090c044b5ef9d/config.report)
config log file:
[config.log](/uploads/bf48aad2a036a61320f83d6ab304c940/config.log)outstandingRazvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/kea/-/issues/1155Backport #1139 to Kea 1.6.32020-06-23T09:36:24ZMarcin SiodelskiBackport #1139 to Kea 1.6.3The #1139 implements an enhancement to client classification so as the reserved classes are taken into account in pool selection and subnet selection within a shared network.The #1139 implements an enhancement to client classification so as the reserved classes are taken into account in pool selection and subnet selection within a shared network.kea1.6.3Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/322improve preparing and cleaning db for server unit tests2020-06-23T09:01:23ZMichal Nowikowskiimprove preparing and cleaning db for server unit tests1) it should create test db from template db to speed up the setup process
2) it should prepare automatically template db before testing
3) it should remove any reminding test dbs from previous runs
4) switch to machines with SSD1) it should create test db from template db to speed up the setup process
2) it should prepare automatically template db before testing
3) it should remove any reminding test dbs from previous runs
4) switch to machines with SSD0.9Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/stork/-/issues/261switch from DefaultRegisterer to our own in prometheus exporters in agent2020-06-23T08:37:59ZMichal Nowikowskiswitch from DefaultRegisterer to our own in prometheus exporters in agentCurrently we are using defaul DefaultRegisterer. It comes with pre-installed collectors for current process information and Go runtime information. This does not have to be exposed. Additionally it raises some errors to console.
We shou...Currently we are using defaul DefaultRegisterer. It comes with pre-installed collectors for current process information and Go runtime information. This does not have to be exposed. Additionally it raises some errors to console.
We should create our own Registerer and collect there only Kea/BIND9 stats.0.9Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/bind9/-/issues/1966BIND-9.16.3 name.c:1738: INSIST(nlabels == name->labels) failed2020-06-23T05:19:55Znanwn147929@alibaba-inc.comBIND-9.16.3 name.c:1738: INSIST(nlabels == name->labels) failed### Summary
BIND assertion failed and quit.
### BIND version used
```
BIND 9.16.3-RedHat-9.16.3-20200604153203.alios7 (Stable Release) <id:5ea41c1>
running on Linux x86_64 3.10.0-327.ali2012.alios7.x86_64 #1 SMP Mon Oct 9 14:09:14 CS...### Summary
BIND assertion failed and quit.
### BIND version used
```
BIND 9.16.3-RedHat-9.16.3-20200604153203.alios7 (Stable Release) <id:5ea41c1>
running on Linux x86_64 3.10.0-327.ali2012.alios7.x86_64 #1 SMP Mon Oct 9 14:09:14 CST 2017
built by make with '--build=x86_64-redhat-linux-gnu' '--host=x86_64-redhat-linux-gnu' '--program-prefix=' '--disable-dependency-tracking' '--prefix=/usr' '--exec-prefix=/usr' '--bindir=/usr/bin' '--sbindir=/usr/sbin' '--sysconfdir=/etc' '--datadir=/usr/share' '--includedir=/usr/include' '--libdir=/usr/lib64' '--libexecdir=/usr/libexec' '--sharedstatedir=/var/lib' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--with-libtool' '--localstatedir=/var' '--enable-epoll' '--with-tuning=large' '--with-pic' '--with-python=/home/tops/bin/python2.7' '--with-python-install-dir=/home/tops' '--disable-geoip' '--enable-auto-validation=no' '--with-docbook-xsl=/usr/share/sgml/docbook/xsl-stylesheets' '--disable-shared' 'LIBUV_CFLAGS=-I/home/admin/162_20200603144848514_144601008_code/rpm_workspace/rpm/.dep_create/include' 'LIBUV_LIBS=-L/home/admin/162_20200603144848514_144601008_code/rpm_workspace/rpm/.dep_create/lib -luv -lrt -lpthread -lnsl -ldl' 'build_alias=x86_64-redhat-linux-gnu' 'host_alias=x86_64-redhat-linux-gnu' 'CFLAGS= -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic' 'LDFLAGS=-Wl,-z,relro ' 'CPPFLAGS= -DDIG_SIGCHASE' 'PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig'
compiled by GCC 4.8.5 20150623 (Red Hat 4.8.5-4)
compiled with OpenSSL version: OpenSSL 1.0.1e-fips 11 Feb 2013
linked to OpenSSL version: OpenSSL 1.0.1e-fips 11 Feb 2013
compiled with libxml2 version: 2.9.1
linked to libxml2 version: 20901
compiled with zlib version: 1.2.7
linked to zlib version: 1.2.7
threads support is enabled
default paths:
named configuration: /etc/named.conf
rndc configuration: /etc/rndc.conf
DNSSEC root key: /etc/bind.keys
nsupdate session key: /var/run/named/session.key
named PID file: /var/run/named/named.pid
named lock file: /var/run/named/named.lock
```
### Steps to reproduce
Unknown
### What is the current *bug* behavior?
BIND quit due to assertion failed.
### What is the expected *correct* behavior?
Not quit.
### Relevant configuration files
(Paste any relevant configuration files - please use code blocks (```)
to format console output. If submitting the contents of your
configuration file in a non-confidential Issue, it is advisable to
obscure key secrets: this can be done automatically by using
`named-checkconf -px`.)
### Relevant logs and/or screenshots
```
23-Jun-2020 10:02:34.155 general: name.c:1738: INSIST(nlabels == name->labels) failed
23-Jun-2020 10:02:34.155 general: exiting (due to assertion failure)
```
### Possible fixes
(If you can, link to the line of code that might be responsible for the
problem.)https://gitlab.isc.org/isc-projects/bind9/-/issues/1857assertion failure in 9.16.2: name.c:1738: INSIST(nlabels == name->labels)2020-06-23T05:01:40ZEvan Huntassertion failure in 9.16.2: name.c:1738: INSIST(nlabels == name->labels)Reported by Kevan Benson at Sonic, this has happened on two separate servers, Centos 7.8.2003 and FreeBSD 11.3.
Backtrace is [here](/uploads/4221622ae7fdfe5d4d2f0906dfcb35a1/named-backtrace.log).Reported by Kevan Benson at Sonic, this has happened on two separate servers, Centos 7.8.2003 and FreeBSD 11.3.
Backtrace is [here](/uploads/4221622ae7fdfe5d4d2f0906dfcb35a1/named-backtrace.log).June 2020 (9.11.20, 9.11.20-S1, 9.16.4, 9.17.2)Evan HuntEvan Hunthttps://gitlab.isc.org/isc-projects/kea/-/issues/1288pre release 1.7.9 changes2020-06-22T18:32:16ZWlodzimierz Wencelpre release 1.7.9 changeskea1.7.9Wlodzimierz WencelWlodzimierz Wencelhttps://gitlab.isc.org/isc-projects/kea/-/issues/1287lib/hook version bump up for 1.7.92020-06-22T14:51:27ZWlodzimierz Wencellib/hook version bump up for 1.7.9kea1.7.9Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/stork/-/issues/305error while pulling reservations by server from agent2020-06-22T10:48:18ZMichal Nowikowskierror while pulling reservations by server from agentThe problem appears in subsequent fetch of reservations in case when kea-dhcp4 daemon is stopped.
```
ERRO[2020-05-31 11:14:47] host.go:88 error occurred while fetching hosts from app {ID:1 CreatedAt:2020-05-31 09:14:02.2...The problem appears in subsequent fetch of reservations in case when kea-dhcp4 daemon is stopped.
```
ERRO[2020-05-31 11:14:47] host.go:88 error occurred while fetching hosts from app {ID:1 CreatedAt:2020-05-31 09:14:02.279493 +0000 UTC MachineID:1 Machine:0xc000844160 Type:kea Active:false Meta:{Version:1.7.3 ExtendedVersion:} AccessPoints:[0xc0009b20f0] Daemons:[0xc0007c2fc0 0xc0007c3080 0xc0007c3140 0xc0007c3200]}: error returned by Kea in response to reservation-get-page command
isc.org/stork/server/apps/kea.(*HostDetectionIterator).sendReservationGetPage
/home/godfryd/isc/repos/stork-dashb/backend/server/apps/kea/host.go:253
isc.org/stork/server/apps/kea.(*HostDetectionIterator).DetectHostsPageFromHostCmds
/home/godfryd/isc/repos/stork-dashb/backend/server/apps/kea/host.go:366
isc.org/stork/server/apps/kea.updateHostsFromHostCmds
/home/godfryd/isc/repos/stork-dashb/backend/server/apps/kea/host.go:546
isc.org/stork/server/apps/kea.(*HostsPuller).pullData
/home/godfryd/isc/repos/stork-dashb/backend/server/apps/kea/host.go:85
isc.org/stork/server/agentcomm.(*PeriodicPuller).pullerLoop
/home/godfryd/isc/repos/stork-dashb/backend/server/agentcomm/puller.go:93
runtime.goexit
/home/godfryd/isc/repos/stork-dashb/tools/1.13.5/go/src/runtime/asm_amd64.s:1357
problem with sending reservation-get-page command upon attempt to detect host reservations over the host_cmds hooks library
WARN[2020-05-31 11:14:47] statspuller.go:49 missing key total-addreses in LocalSubnet 15 stats
INFO[2020-05-31 11:14:47] host.go:101 completed pulling hosts from Kea apps: 0/1 succeeded
ERRO[2020-05-31 11:14:47] puller.go:95 errors were encountered while pulling data from Kea apps: error returned by Kea in response to reservation-get-page command
isc.org/stork/server/apps/kea.(*HostDetectionIterator).sendReservationGetPage
/home/godfryd/isc/repos/stork-dashb/backend/server/apps/kea/host.go:253
isc.org/stork/server/apps/kea.(*HostDetectionIterator).DetectHostsPageFromHostCmds
/home/godfryd/isc/repos/stork-dashb/backend/server/apps/kea/host.go:366
isc.org/stork/server/apps/kea.updateHostsFromHostCmds
/home/godfryd/isc/repos/stork-dashb/backend/server/apps/kea/host.go:546
isc.org/stork/server/apps/kea.(*HostsPuller).pullData
/home/godfryd/isc/repos/stork-dashb/backend/server/apps/kea/host.go:85
isc.org/stork/server/agentcomm.(*PeriodicPuller).pullerLoop
/home/godfryd/isc/repos/stork-dashb/backend/server/agentcomm/puller.go:93
runtime.goexit
/home/godfryd/isc/repos/stork-dashb/tools/1.13.5/go/src/runtime/asm_amd64.s:1357
problem with sending reservation-get-page command upon attempt to detect host reservations over the host_cmds hooks library
```0.9Marcin SiodelskiMarcin Siodelski