ISC Open Source Projects issueshttps://gitlab.isc.org/groups/isc-projects/-/issues2020-05-29T04:20:30Zhttps://gitlab.isc.org/isc-projects/stork/-/issues/267Enhance search expressions2020-05-29T04:20:30ZMarcin SiodelskiEnhance search expressionsWe currently allow including key=val expressions in search. We think that we might better migrate to something more sophisticated. One particular use case that we already have is to search for all global host reservations. For that we'd ...We currently allow including key=val expressions in search. We think that we might better migrate to something more sophisticated. One particular use case that we already have is to search for all global host reservations. For that we'd like to be able to say:
```
is:global
```
We may also migrate from key=val to key:val.0.8Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/kea/-/issues/1220NetworkState class should be Kea MT safe.2021-06-28T09:51:01ZFrancis DupontNetworkState class should be Kea MT safe.Kea MT safe means MT safe when Kea MT mode is true (vs. general MT safety).Kea MT safe means MT safe when Kea MT mode is true (vs. general MT safety).kea2.1-backlogRazvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/kea/-/issues/1219make the HA hook multi-threading safe2020-05-21T16:12:18ZFrancis Dupontmake the HA hook multi-threading safeCurrently it is a design ticket to find remaining problems, for instance the HA hook disables packet processing but with MT there are more than one way to do this (and the feature by itself can be required to be MT safe).
Note this tick...Currently it is a design ticket to find remaining problems, for instance the HA hook disables packet processing but with MT there are more than one way to do this (and the feature by itself can be required to be MT safe).
Note this ticket can provide some indications for #1147 i.e. not try to avoid races when they are unconditionally impossible.kea1.7.8Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/stork/-/issues/266Doc update: need to mention postgresql-crypto, update man pages2020-08-12T16:46:29ZTomek MrugalskiDoc update: need to mention postgresql-crypto, update man pagesThis is a follow-up to 0.6.0 sanity checks and @marcin comments:
- [x] postgresql-crypto needed on Fedora, postgresql12-contrib on RHEL/CentOS: https://gitlab.isc.org/isc-projects/stork/-/issues/227#note_122038
- [x] agent man page impr...This is a follow-up to 0.6.0 sanity checks and @marcin comments:
- [x] postgresql-crypto needed on Fedora, postgresql12-contrib on RHEL/CentOS: https://gitlab.isc.org/isc-projects/stork/-/issues/227#note_122038
- [x] agent man page improvement: https://gitlab.isc.org/isc-projects/stork/-/issues/227#note_122053
- [x] bring server man page up to date: https://gitlab.isc.org/isc-projects/stork/-/issues/227#note_122056
- [x] `su - postgres` missing in the docs (reported by Wlodek, see stork call 2020-05-05 notes, line 50)0.10Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/265-v, --version: agent, server should report version2020-06-12T17:45:50ZTomek Mrugalski-v, --version: agent, server should report versionThis is a ticket for addressing the 0.6.0 sanity checks issue raised by @marcin here: https://gitlab.isc.org/isc-projects/stork/-/issues/227#note_122037
The idea is obvious: we need a way to identify agent and server version. We need a ...This is a ticket for addressing the 0.6.0 sanity checks issue raised by @marcin here: https://gitlab.isc.org/isc-projects/stork/-/issues/227#note_122037
The idea is obvious: we need a way to identify agent and server version. We need a `-v` and `--version` command line switches for this.0.9Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/bind9/-/issues/1813Align the sizes of isc_rwlock_t between isc_rwlock and pthread_rwlock)2021-10-05T12:12:44ZOndřej SurýAlign the sizes of isc_rwlock_t between isc_rwlock and pthread_rwlock)Currently, the size of the isc_rwlock_t structure changes between isc_rwlock and pthread_rwlock, we need to either:
* make the structure opaque
* align the sizes of the structures, so it doesn't change the sizes that use isc_rwlock_t di...Currently, the size of the isc_rwlock_t structure changes between isc_rwlock and pthread_rwlock, we need to either:
* make the structure opaque
* align the sizes of the structures, so it doesn't change the sizes that use isc_rwlock_t directly.BIND 9.17 Backburnerhttps://gitlab.isc.org/isc-projects/kea/-/issues/1218huge difference of performance gain when memfile is configured with persist f...2022-11-02T15:10:18ZWlodzimierz Wencelhuge difference of performance gain when memfile is configured with persist falseI've executed two tests, multi threading + memfile with persist false (there is no writing to the file).
And results are surprising, revealing possible inefficiency.
results:
* multi threading v6 memfile persist true: 36k leases/s
* mul...I've executed two tests, multi threading + memfile with persist false (there is no writing to the file).
And results are surprising, revealing possible inefficiency.
results:
* multi threading v6 memfile persist true: 36k leases/s
* multi threading v6 memfile persist false: 47k leases/s
* gain: 30%
* multi threading v4 memfile persist true: 20k leases/s
* multi threading v4 memfile persist false: 37k leases/s
* gain: 85%
Please investigate if there is an inefficiency in a way Kea saves v4 leases to the file.backloghttps://gitlab.isc.org/isc-projects/bind9/-/issues/1812Unexpected output from named-checkconf2020-06-18T08:39:09ZPeter DaviesUnexpected output from named-checkconfUnexpected output from named-checkconf:
When run "named-checkconf -p " appends extra test to server lines in static-stub zones
input:
zone "10.in-addr.arpa" { type static-stub; server-addresses { 199.81.216.126; 204.135.12.254; }; };
e...Unexpected output from named-checkconf:
When run "named-checkconf -p " appends extra test to server lines in static-stub zones
input:
zone "10.in-addr.arpa" { type static-stub; server-addresses { 199.81.216.126; 204.135.12.254; }; };
expected output:
zone "10.in-addr.arpa" {
type static-stub;
server-addresses {
199.81.216.126;
204.135.12.254;
};
};
received output:
zone "10.in-addr.arpa" {
type static-stub;
server-addresses {
199.81.216.126 dscp 4294950590;
204.135.12.254 dscp 4294950590;
};
This behaviour appears to start at release 9.11.6
see RT [#16328](https://support.isc.org/Ticket/Display.html?id=16328)June 2020 (9.11.20, 9.11.20-S1, 9.16.4, 9.17.2)https://gitlab.isc.org/isc-projects/kea/-/issues/1217host cache invalid read after free reported by valgrind and tsan - not MT rel...2020-05-06T18:07:10ZRazvan Becheriuhost cache invalid read after free reported by valgrind and tsan - not MT relatedread after heap free
I believe this is related to the fact that we keep a reference of an iterator while deleting (invalidating) it.
valgrind:
```
--9629-- REDIR: 0x81a0720 (libc.so.6:__strnlen_avx2) redirected to 0x4c32c90 (strnlen)
p...read after heap free
I believe this is related to the fact that we keep a reference of an iterator while deleting (invalidating) it.
valgrind:
```
--9629-- REDIR: 0x81a0720 (libc.so.6:__strnlen_avx2) redirected to 0x4c32c90 (strnlen)
profiling:/home/razvan/isc/git/kea-work/ext/gtest/libgtest_a-gtest-all.gcda:Version mismatch - expected A75* got A74*
==9629==
==9629== HEAP SUMMARY:
==9629== in use at exit: 0 bytes in 0 blocks
==9629== total heap usage: 9,420 allocs, 9,420 frees, 845,980 bytes allocated
==9629==
==9629== All heap blocks were freed -- no leaks are possible
==9629==
==9629== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)
==9629==
==9629== 1 errors in context 1 of 1:
==9629== Invalid read of size 8
==9629== at 0x1F3253: hash_value<isc::dhcp::Host> (shared_ptr.hpp:1153)
==9629== by 0x1F3253: operator() (extensions.hpp:262)
==9629== by 0x1F3253: find<boost::shared_ptr<isc::dhcp::Host>, boost::hash<boost::shared_ptr<isc::dhcp::Host> >, std::equal_to<boost::shared_ptr<isc::dhcp::Host> > > (hashed_index.hpp:1527)
==9629== by 0x1F3253: find<boost::shared_ptr<isc::dhcp::Host>, boost::hash<boost::shared_ptr<isc::dhcp::Host> >, std::equal_to<boost::shared_ptr<isc::dhcp::Host> > > (hashed_index.hpp:482)
==9629== by 0x1F3253: find<boost::shared_ptr<isc::dhcp::Host> > (hashed_index.hpp:471)
==9629== by 0x1F3253: isc::host_cache::HostCacheImpl::remove(boost::shared_ptr<isc::dhcp::Host> const&) (host_cache_impl.cc:458)
==9629== by 0x1F3623: isc::host_cache::HostCacheImpl::del6[abi:cxx11](unsigned int const&, isc::asiolink::IOAddress const&) (host_cache_impl.cc:397)
==9629== by 0x1E1153: isc::host_cache::HostCache::cacheRemoveHandler(isc::hooks::CalloutHandle&) (host_cache.cc:887)
==9629== by 0x19F669: (anonymous namespace)::removeHandler(boost::shared_ptr<isc::host_cache::HostCache>, isc::hooks::CalloutHandle&) (command_unittests.cc:324)
==9629== by 0x1D0505: operator()<int, int (*)(boost::shared_ptr<isc::host_cache::HostCache>, isc::hooks::CalloutHandle&), boost::_bi::rrlist1<isc::hooks::CalloutHandle&> > (bind.hpp:309)
==9629== by 0x1D0505: operator()<isc::hooks::CalloutHandle&> (bind.hpp:1306)
==9629== by 0x1D0505: boost::detail::function::function_obj_invoker1<boost::_bi::bind_t<int, int (*)(boost::shared_ptr<isc::host_cache::HostCache>, isc::hooks::CalloutHandle&), boost::_bi::list2<boost::_bi::value<boost::shared_ptr<isc::host_cache::HostCache> >, boost::arg<1> > >, int, isc::hooks::CalloutHandle&>::invoke(boost::detail::function::function_buffer&, isc::hooks::CalloutHandle&) (function_template.hpp:138)
==9629== by 0x1A90EB: operator() (function_template.hpp:760)
==9629== by 0x1A90EB: (anonymous namespace)::CommandTest::checkCommand(boost::function<int (isc::hooks::CalloutHandle&)>, boost::shared_ptr<isc::data::Element const>, int, int, boost::shared_ptr<isc::data::Element const>) [clone .isra.222] (command_unittests.cc:143)
==9629== by 0x1AA653: (anonymous namespace)::CommandTest::checkCommand(boost::function<int (isc::hooks::CalloutHandle&)>, boost::shared_ptr<isc::data::Element const>, int, int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) [clone .isra.225] (command_unittests.cc:177)
==9629== by 0x1AC198: (anonymous namespace)::CommandTest_global_Test::TestBody() (command_unittests.cc:905)
==9629== by 0x2DFF79: HandleSehExceptionsInMethodIfSupported<testing::Test, void> (gtest.cc:2608)
==9629== by 0x2DFF79: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (gtest.cc:2644)
==9629== by 0x2CA8FB: testing::Test::Run() (gtest.cc:2683)
==9629== by 0x2CAC3C: testing::TestInfo::Run() (gtest.cc:2860)
==9629== by 0x2CD170: testing::TestSuite::Run() (gtest.cc:3014)
==9629== Address 0x1060ff10 is 48 bytes inside a block of size 120 free'd
==9629== at 0x4C3123B: operator delete(void*) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9629== by 0x1F3096: deallocate (new_allocator.h:125)
==9629== by 0x1F3096: deallocate_node (multi_index_container.hpp:536)
==9629== by 0x1F3096: erase_ (multi_index_container.hpp:761)
==9629== by 0x1F3096: final_erase_ (index_base.hpp:259)
==9629== by 0x1F3096: erase (ord_index_impl.hpp:351)
==9629== by 0x1F3096: isc::host_cache::HostCacheImpl::removeResv6(boost::shared_ptr<isc::dhcp::Host> const&) (host_cache_impl.cc:88)
==9629== by 0x1F3249: isc::host_cache::HostCacheImpl::remove(boost::shared_ptr<isc::dhcp::Host> const&) (host_cache_impl.cc:455)
==9629== by 0x1F3623: isc::host_cache::HostCacheImpl::del6[abi:cxx11](unsigned int const&, isc::asiolink::IOAddress const&) (host_cache_impl.cc:397)
==9629== by 0x1E1153: isc::host_cache::HostCache::cacheRemoveHandler(isc::hooks::CalloutHandle&) (host_cache.cc:887)
==9629== by 0x19F669: (anonymous namespace)::removeHandler(boost::shared_ptr<isc::host_cache::HostCache>, isc::hooks::CalloutHandle&) (command_unittests.cc:324)
==9629== by 0x1D0505: operator()<int, int (*)(boost::shared_ptr<isc::host_cache::HostCache>, isc::hooks::CalloutHandle&), boost::_bi::rrlist1<isc::hooks::CalloutHandle&> > (bind.hpp:309)
==9629== by 0x1D0505: operator()<isc::hooks::CalloutHandle&> (bind.hpp:1306)
==9629== by 0x1D0505: boost::detail::function::function_obj_invoker1<boost::_bi::bind_t<int, int (*)(boost::shared_ptr<isc::host_cache::HostCache>, isc::hooks::CalloutHandle&), boost::_bi::list2<boost::_bi::value<boost::shared_ptr<isc::host_cache::HostCache> >, boost::arg<1> > >, int, isc::hooks::CalloutHandle&>::invoke(boost::detail::function::function_buffer&, isc::hooks::CalloutHandle&) (function_template.hpp:138)
==9629== by 0x1A90EB: operator() (function_template.hpp:760)
==9629== by 0x1A90EB: (anonymous namespace)::CommandTest::checkCommand(boost::function<int (isc::hooks::CalloutHandle&)>, boost::shared_ptr<isc::data::Element const>, int, int, boost::shared_ptr<isc::data::Element const>) [clone .isra.222] (command_unittests.cc:143)
==9629== by 0x1AA653: (anonymous namespace)::CommandTest::checkCommand(boost::function<int (isc::hooks::CalloutHandle&)>, boost::shared_ptr<isc::data::Element const>, int, int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) [clone .isra.225] (command_unittests.cc:177)
==9629== by 0x1AC198: (anonymous namespace)::CommandTest_global_Test::TestBody() (command_unittests.cc:905)
==9629== by 0x2DFF79: HandleSehExceptionsInMethodIfSupported<testing::Test, void> (gtest.cc:2608)
==9629== by 0x2DFF79: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (gtest.cc:2644)
==9629== by 0x2CA8FB: testing::Test::Run() (gtest.cc:2683)
==9629== Block was alloc'd at
==9629== at 0x4C3017F: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9629== by 0x1F25D7: allocate (new_allocator.h:111)
==9629== by 0x1F25D7: allocate_node (multi_index_container.hpp:530)
==9629== by 0x1F25D7: insert_ (index_base.hpp:117)
==9629== by 0x1F25D7: insert_<boost::multi_index::detail::rvalue_tag> (ord_index_impl.hpp:716)
==9629== by 0x1F25D7: insert_<boost::multi_index::detail::rvalue_tag> (ord_index_impl.hpp:716)
==9629== by 0x1F25D7: insert_<boost::multi_index::detail::rvalue_tag> (multi_index_container.hpp:558)
==9629== by 0x1F25D7: insert_rv_ (multi_index_container.hpp:575)
==9629== by 0x1F25D7: final_insert_rv_ (index_base.hpp:221)
==9629== by 0x1F25D7: insert (ord_index_impl.hpp:302)
==9629== by 0x1F25D7: isc::host_cache::HostCacheImpl::insertResv6(boost::shared_ptr<isc::dhcp::Host> const&) (host_cache_impl.cc:38)
==9629== by 0x1F5F1C: isc::host_cache::HostCacheImpl::insert(boost::shared_ptr<isc::dhcp::Host const> const&, bool) (host_cache_impl.cc:342)
==9629== by 0x1DC52D: isc::host_cache::HostCache::insert(boost::shared_ptr<isc::dhcp::Host const> const&, bool) (host_cache.cc:312)
==9629== by 0x1AAE07: (anonymous namespace)::CommandTest_global_Test::TestBody() (command_unittests.cc:869)
==9629== by 0x2DFF79: HandleSehExceptionsInMethodIfSupported<testing::Test, void> (gtest.cc:2608)
==9629== by 0x2DFF79: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (gtest.cc:2644)
==9629== by 0x2CA8FB: testing::Test::Run() (gtest.cc:2683)
==9629== by 0x2CAC3C: testing::TestInfo::Run() (gtest.cc:2860)
==9629== by 0x2CD170: testing::TestSuite::Run() (gtest.cc:3014)
==9629== by 0x2CDBC0: testing::internal::UnitTestImpl::RunAllTests() (gtest.cc:5598)
==9629== by 0x2DF6A9: HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> (gtest.cc:2608)
==9629== by 0x2DF6A9: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (gtest.cc:2644)
==9629== by 0x2C98F4: testing::UnitTest::Run() (gtest.cc:5185)
==9629==
==9629== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)
```
tsan:
```
WARNING: ThreadSanitizer: heap-use-after-free (pid=4979)
Read of size 8 at 0x7b20000068b0 by main thread:
#0 unsigned long boost::hash_value<isc::dhcp::Host>(boost::shared_ptr<isc::dhcp::Host> const&) /usr/include/boost/smart_ptr/shared_ptr.hpp:1153 (host_cache_unittests+0xa2680)
#1 boost::hash<boost::shared_ptr<isc::dhcp::Host> >::operator()(boost::shared_ptr<isc::dhcp::Host> const&) const /usr/include/boost/functional/hash/extensions.hpp:262 (host_cache_unittests+0xa2680)
#2 boost::multi_index::detail::hashed_index_iterator<boost::multi_index::detail::hashed_index_node<boost::multi_index::detail::ordered_index_node<boost::multi_index::detail::null_augment_policy, boost::multi_index::detail::ordered_index_node<boost::multi_index::detail::null_augment_policy, boost::multi_index::detail::index_node_base<boost::shared_ptr<isc::dhcp::Host>, std::allocator<boost::shared_ptr<isc::dhcp::Host> > > > >, boost::multi_index::detail::hashed_unique_tag>, boost::multi_index::detail::bucket_array<std::allocator<boost::shared_ptr<isc::dhcp::Host> > >, boost::multi_index::detail::hashed_index_global_iterator_tag> boost::multi_index::detail::hashed_index<boost::multi_index::identity<boost::shared_ptr<isc::dhcp::Host> >, boost::hash<boost::shared_ptr<isc::dhcp::Host> >, std::equal_to<boost::shared_ptr<isc::dhcp::Host> >, boost::multi_index::detail::nth_layer<2, boost::shared_ptr<isc::dhcp::Host>, boost::multi_index::indexed_by<boost::multi_index::random_access<boost::multi_index::tag<isc::host_cache::HostRandomIndexTag, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na> >, boost::multi_index::hashed_unique<boost::multi_index::tag<isc::host_cache::HostHashedIndexTag, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, boost::multi_index::identity<boost::shared_ptr<isc::dhcp::Host> >, mpl_::na, mpl_::na>, boost::multi_index::ordered_non_unique<boost::multi_index::tag<isc::host_cache::HostIdentifierIndexTag, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, boost::multi_index::composite_key<isc::dhcp::Host, boost::multi_index::const_mem_fun<isc::dhcp::Host, std::vector<unsigned char, std::allocator<unsigned char> > const&, &(isc::dhcp::Host::getIdentifier() const)>, boost::multi_index::const_mem_fun<isc::dhcp::Host, isc::dhcp::Host::IdentifierType, &(isc::dhcp::Host::getIdentifierType() const)>, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type>, mpl_::na>, boost::multi_index::ordered_non_unique<boost::multi_index::tag<isc::host_cache::HostAddress4IndexTag, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, boost::multi_index::const_mem_fun<isc::dhcp::Host, isc::asiolink::IOAddress const&, &(isc::dhcp::Host::getIPv4Reservation() const)>, mpl_::na>, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, std::allocator<boost::shared_ptr<isc::dhcp::Host> > >, boost::mpl::v_item<isc::host_cache::HostHashedIndexTag, boost::mpl::vector0<mpl_::na>, 0>, boost::multi_index::detail::hashed_unique_tag>::find<boost::shared_ptr<isc::dhcp::Host>, boost::hash<boost::shared_ptr<isc::dhcp::Host> >, std::equal_to<boost::shared_ptr<isc::dhcp::Host> > >(boost::shared_ptr<isc::dhcp::Host> const&, boost::hash<boost::shared_ptr<isc::dhcp::Host> > const&, std::equal_to<boost::shared_ptr<isc::dhcp::Host> > const&, mpl_::bool_<false>) const /usr/include/boost/multi_index/hashed_index.hpp:1527 (host_cache_unittests+0xa2680)
#3 boost::multi_index::detail::hashed_index_iterator<boost::multi_index::detail::hashed_index_node<boost::multi_index::detail::ordered_index_node<boost::multi_index::detail::null_augment_policy, boost::multi_index::detail::ordered_index_node<boost::multi_index::detail::null_augment_policy, boost::multi_index::detail::index_node_base<boost::shared_ptr<isc::dhcp::Host>, std::allocator<boost::shared_ptr<isc::dhcp::Host> > > > >, boost::multi_index::detail::hashed_unique_tag>, boost::multi_index::detail::bucket_array<std::allocator<boost::shared_ptr<isc::dhcp::Host> > >, boost::multi_index::detail::hashed_index_global_iterator_tag> boost::multi_index::detail::hashed_index<boost::multi_index::identity<boost::shared_ptr<isc::dhcp::Host> >, boost::hash<boost::shared_ptr<isc::dhcp::Host> >, std::equal_to<boost::shared_ptr<isc::dhcp::Host> >, boost::multi_index::detail::nth_layer<2, boost::shared_ptr<isc::dhcp::Host>, boost::multi_index::indexed_by<boost::multi_index::random_access<boost::multi_index::tag<isc::host_cache::HostRandomIndexTag, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na> >, boost::multi_index::hashed_unique<boost::multi_index::tag<isc::host_cache::HostHashedIndexTag, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, boost::multi_index::identity<boost::shared_ptr<isc::dhcp::Host> >, mpl_::na, mpl_::na>, boost::multi_index::ordered_non_unique<boost::multi_index::tag<isc::host_cache::HostIdentifierIndexTag, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, boost::multi_index::composite_key<isc::dhcp::Host, boost::multi_index::const_mem_fun<isc::dhcp::Host, std::vector<unsigned char, std::allocator<unsigned char> > const&, &(isc::dhcp::Host::getIdentifier() const)>, boost::multi_index::const_mem_fun<isc::dhcp::Host, isc::dhcp::Host::IdentifierType, &(isc::dhcp::Host::getIdentifierType() const)>, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type>, mpl_::na>, boost::multi_index::ordered_non_unique<boost::multi_index::tag<isc::host_cache::HostAddress4IndexTag, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, boost::multi_index::const_mem_fun<isc::dhcp::Host, isc::asiolink::IOAddress const&, &(isc::dhcp::Host::getIPv4Reservation() const)>, mpl_::na>, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, std::allocator<boost::shared_ptr<isc::dhcp::Host> > >, boost::mpl::v_item<isc::host_cache::HostHashedIndexTag, boost::mpl::vector0<mpl_::na>, 0>, boost::multi_index::detail::hashed_unique_tag>::find<boost::shared_ptr<isc::dhcp::Host>, boost::hash<boost::shared_ptr<isc::dhcp::Host> >, std::equal_to<boost::shared_ptr<isc::dhcp::Host> > >(boost::shared_ptr<isc::dhcp::Host> const&, boost::hash<boost::shared_ptr<isc::dhcp::Host> > const&, std::equal_to<boost::shared_ptr<isc::dhcp::Host> > const&) const /usr/include/boost/multi_index/hashed_index.hpp:482 (host_cache_unittests+0xa2680)
#4 boost::multi_index::detail::hashed_index_iterator<boost::multi_index::detail::hashed_index_node<boost::multi_index::detail::ordered_index_node<boost::multi_index::detail::null_augment_policy, boost::multi_index::detail::ordered_index_node<boost::multi_index::detail::null_augment_policy, boost::multi_index::detail::index_node_base<boost::shared_ptr<isc::dhcp::Host>, std::allocator<boost::shared_ptr<isc::dhcp::Host> > > > >, boost::multi_index::detail::hashed_unique_tag>, boost::multi_index::detail::bucket_array<std::allocator<boost::shared_ptr<isc::dhcp::Host> > >, boost::multi_index::detail::hashed_index_global_iterator_tag> boost::multi_index::detail::hashed_index<boost::multi_index::identity<boost::shared_ptr<isc::dhcp::Host> >, boost::hash<boost::shared_ptr<isc::dhcp::Host> >, std::equal_to<boost::shared_ptr<isc::dhcp::Host> >, boost::multi_index::detail::nth_layer<2, boost::shared_ptr<isc::dhcp::Host>, boost::multi_index::indexed_by<boost::multi_index::random_access<boost::multi_index::tag<isc::host_cache::HostRandomIndexTag, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na> >, boost::multi_index::hashed_unique<boost::multi_index::tag<isc::host_cache::HostHashedIndexTag, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, boost::multi_index::identity<boost::shared_ptr<isc::dhcp::Host> >, mpl_::na, mpl_::na>, boost::multi_index::ordered_non_unique<boost::multi_index::tag<isc::host_cache::HostIdentifierIndexTag, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, boost::multi_index::composite_key<isc::dhcp::Host, boost::multi_index::const_mem_fun<isc::dhcp::Host, std::vector<unsigned char, std::allocator<unsigned char> > const&, &(isc::dhcp::Host::getIdentifier() const)>, boost::multi_index::const_mem_fun<isc::dhcp::Host, isc::dhcp::Host::IdentifierType, &(isc::dhcp::Host::getIdentifierType() const)>, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type>, mpl_::na>, boost::multi_index::ordered_non_unique<boost::multi_index::tag<isc::host_cache::HostAddress4IndexTag, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, boost::multi_index::const_mem_fun<isc::dhcp::Host, isc::asiolink::IOAddress const&, &(isc::dhcp::Host::getIPv4Reservation() const)>, mpl_::na>, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, std::allocator<boost::shared_ptr<isc::dhcp::Host> > >, boost::mpl::v_item<isc::host_cache::HostHashedIndexTag, boost::mpl::vector0<mpl_::na>, 0>, boost::multi_index::detail::hashed_unique_tag>::find<boost::shared_ptr<isc::dhcp::Host> >(boost::shared_ptr<isc::dhcp::Host> const&) const /usr/include/boost/multi_index/hashed_index.hpp:471 (host_cache_unittests+0xa2680)
#5 isc::host_cache::HostCacheImpl::remove(boost::shared_ptr<isc::dhcp::Host> const&) /home/razvan/isc/git/kea-review/premium/src/hooks/dhcp/host_cache/host_cache_impl.cc:456 (host_cache_unittests+0xa2680)
#6 isc::host_cache::HostCacheImpl::del6[abi:cxx11](unsigned int const&, isc::asiolink::IOAddress const&) /home/razvan/isc/git/kea-review/premium/src/hooks/dhcp/host_cache/host_cache_impl.cc:395 (host_cache_unittests+0xa2d9b)
#7 isc::host_cache::HostCache::cacheRemoveHandler(isc::hooks::CalloutHandle&) /home/razvan/isc/git/kea-review/premium/src/hooks/dhcp/host_cache/host_cache.cc:887 (host_cache_unittests+0x9316a)
#8 removeHandler /home/razvan/isc/git/kea-review/premium/src/hooks/dhcp/host_cache/tests/command_unittests.cc:324 (host_cache_unittests+0x567bd)
#9 int boost::_bi::list2<boost::_bi::value<boost::shared_ptr<isc::host_cache::HostCache> >, boost::arg<1> >::operator()<int, int (*)(boost::shared_ptr<isc::host_cache::HostCache>, isc::hooks::CalloutHandle&), boost::_bi::rrlist1<isc::hooks::CalloutHandle&> >(boost::_bi::type<int>, int (*&)(boost::shared_ptr<isc::host_cache::HostCache>, isc::hooks::CalloutHandle&), boost::_bi::rrlist1<isc::hooks::CalloutHandle&>&, long) /usr/include/boost/bind/bind.hpp:309 (host_cache_unittests+0x7be1c)
#10 int boost::_bi::bind_t<int, int (*)(boost::shared_ptr<isc::host_cache::HostCache>, isc::hooks::CalloutHandle&), boost::_bi::list2<boost::_bi::value<boost::shared_ptr<isc::host_cache::HostCache> >, boost::arg<1> > >::operator()<isc::hooks::CalloutHandle&>(isc::hooks::CalloutHandle&) /usr/include/boost/bind/bind.hpp:1306 (host_cache_unittests+0x7be1c)
#11 boost::detail::function::function_obj_invoker1<boost::_bi::bind_t<int, int (*)(boost::shared_ptr<isc::host_cache::HostCache>, isc::hooks::CalloutHandle&), boost::_bi::list2<boost::_bi::value<boost::shared_ptr<isc::host_cache::HostCache> >, boost::arg<1> > >, int, isc::hooks::CalloutHandle&>::invoke(boost::detail::function::function_buffer&, isc::hooks::CalloutHandle&) /usr/include/boost/function/function_template.hpp:138 (host_cache_unittests+0x7be1c)
#12 boost::function1<int, isc::hooks::CalloutHandle&>::operator()(isc::hooks::CalloutHandle&) const /usr/include/boost/function/function_template.hpp:760 (host_cache_unittests+0x5d1e9)
#13 checkCommand /home/razvan/isc/git/kea-review/premium/src/hooks/dhcp/host_cache/tests/command_unittests.cc:143 (host_cache_unittests+0x5d1e9)
#14 checkCommand /home/razvan/isc/git/kea-review/premium/src/hooks/dhcp/host_cache/tests/command_unittests.cc:177 (host_cache_unittests+0x622ed)
#15 TestBody /home/razvan/isc/git/kea-review/premium/src/hooks/dhcp/host_cache/tests/command_unittests.cc:905 (host_cache_unittests+0x64059)
#16 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/razvan/isc/git/googletest/googletest/src/gtest.cc:2608 (host_cache_unittests+0x176588)
#17 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/razvan/isc/git/googletest/googletest/src/gtest.cc:2644 (host_cache_unittests+0x176588)
#18 testing::Test::Run() /home/razvan/isc/git/googletest/googletest/src/gtest.cc:2683 (host_cache_unittests+0x1654c4)
#19 testing::TestInfo::Run() /home/razvan/isc/git/googletest/googletest/src/gtest.cc:2860 (host_cache_unittests+0x1658c6)
#20 testing::TestSuite::Run() /home/razvan/isc/git/googletest/googletest/src/gtest.cc:3014 (host_cache_unittests+0x166533)
#21 testing::internal::UnitTestImpl::RunAllTests() /home/razvan/isc/git/googletest/googletest/src/gtest.cc:5598 (host_cache_unittests+0x166e1f)
#22 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/razvan/isc/git/googletest/googletest/src/gtest.cc:2608 (host_cache_unittests+0x176c94)
#23 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/razvan/isc/git/googletest/googletest/src/gtest.cc:2644 (host_cache_unittests+0x176c94)
#24 testing::UnitTest::Run() /home/razvan/isc/git/googletest/googletest/src/gtest.cc:5185 (host_cache_unittests+0x165a59)
#25 RUN_ALL_TESTS() /home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:2482 (host_cache_unittests+0x2aeae)
#26 main /home/razvan/isc/git/kea-review/premium/src/hooks/dhcp/host_cache/tests/run_unittests.cc:16 (host_cache_unittests+0x2aeae)
Previous write of size 8 at 0x7b20000068b0 by main thread:
#0 operator delete(void*) <null> (libtsan.so.0+0x740cd)
#1 __gnu_cxx::new_allocator<boost::multi_index::detail::ordered_index_node<boost::multi_index::detail::null_augment_policy, boost::multi_index::detail::ordered_index_node<boost::multi_index::detail::null_augment_policy, boost::multi_index::detail::index_node_base<isc::host_cache::HostResrv6Tuple, std::allocator<isc::host_cache::HostResrv6Tuple> > > > >::deallocate(boost::multi_index::detail::ordered_index_node<boost::multi_index::detail::null_augment_policy, boost::multi_index::detail::ordered_index_node<boost::multi_index::detail::null_augment_policy, boost::multi_index::detail::index_node_base<isc::host_cache::HostResrv6Tuple, std::allocator<isc::host_cache::HostResrv6Tuple> > > >*, unsigned long) /usr/include/c++/7/ext/new_allocator.h:125 (host_cache_unittests+0xa0c95)
#2 boost::multi_index::multi_index_container<isc::host_cache::HostResrv6Tuple, boost::multi_index::indexed_by<boost::multi_index::ordered_non_unique<boost::multi_index::tag<isc::host_cache::Resv6AddressIndexTag, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, boost::multi_index::const_mem_fun<isc::host_cache::HostResrv6Tuple, isc::asiolink::IOAddress const&, &(isc::host_cache::HostResrv6Tuple::getKey() const)>, mpl_::na>, boost::multi_index::ordered_unique<boost::multi_index::tag<isc::host_cache::Resv6SubnetAddressIndexTag, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, boost::multi_index::composite_key<isc::host_cache::HostResrv6Tuple, boost::multi_index::member<isc::host_cache::HostResrv6Tuple, unsigned int const, &isc::host_cache::HostResrv6Tuple::subnet_id_>, boost::multi_index::const_mem_fun<isc::host_cache::HostResrv6Tuple, isc::asiolink::IOAddress const&, &(isc::host_cache::HostResrv6Tuple::getKey() const)>, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type>, mpl_::na>, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, std::allocator<isc::host_cache::HostResrv6Tuple> >::deallocate_node(boost::multi_index::detail::ordered_index_node<boost::multi_index::detail::null_augment_policy, boost::multi_index::detail::ordered_index_node<boost::multi_index::detail::null_augment_policy, boost::multi_index::detail::index_node_base<isc::host_cache::HostResrv6Tuple, std::allocator<isc::host_cache::HostResrv6Tuple> > > >*) /usr/include/boost/multi_index_container.hpp:536 (host_cache_unittests+0xa0c95)
#3 boost::multi_index::multi_index_container<isc::host_cache::HostResrv6Tuple, boost::multi_index::indexed_by<boost::multi_index::ordered_non_unique<boost::multi_index::tag<isc::host_cache::Resv6AddressIndexTag, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, boost::multi_index::const_mem_fun<isc::host_cache::HostResrv6Tuple, isc::asiolink::IOAddress const&, &(isc::host_cache::HostResrv6Tuple::getKey() const)>, mpl_::na>, boost::multi_index::ordered_unique<boost::multi_index::tag<isc::host_cache::Resv6SubnetAddressIndexTag, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, boost::multi_index::composite_key<isc::host_cache::HostResrv6Tuple, boost::multi_index::member<isc::host_cache::HostResrv6Tuple, unsigned int const, &isc::host_cache::HostResrv6Tuple::subnet_id_>, boost::multi_index::const_mem_fun<isc::host_cache::HostResrv6Tuple, isc::asiolink::IOAddress const&, &(isc::host_cache::HostResrv6Tuple::getKey() const)>, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type>, mpl_::na>, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, std::allocator<isc::host_cache::HostResrv6Tuple> >::erase_(boost::multi_index::detail::ordered_index_node<boost::multi_index::detail::null_augment_policy, boost::multi_index::detail::ordered_index_node<boost::multi_index::detail::null_augment_policy, boost::multi_index::detail::index_node_base<isc::host_cache::HostResrv6Tuple, std::allocator<isc::host_cache::HostResrv6Tuple> > > >*) /usr/include/boost/multi_index_container.hpp:761 (host_cache_unittests+0xa0c95)
#4 boost::multi_index::detail::index_base<isc::host_cache::HostResrv6Tuple, boost::multi_index::indexed_by<boost::multi_index::ordered_non_unique<boost::multi_index::tag<isc::host_cache::Resv6AddressIndexTag, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, boost::multi_index::const_mem_fun<isc::host_cache::HostResrv6Tuple, isc::asiolink::IOAddress const&, &(isc::host_cache::HostResrv6Tuple::getKey() const)>, mpl_::na>, boost::multi_index::ordered_unique<boost::multi_index::tag<isc::host_cache::Resv6SubnetAddressIndexTag, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, boost::multi_index::composite_key<isc::host_cache::HostResrv6Tuple, boost::multi_index::member<isc::host_cache::HostResrv6Tuple, unsigned int const, &isc::host_cache::HostResrv6Tuple::subnet_id_>, boost::multi_index::const_mem_fun<isc::host_cache::HostResrv6Tuple, isc::asiolink::IOAddress const&, &(isc::host_cache::HostResrv6Tuple::getKey() const)>, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type>, mpl_::na>, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, std::allocator<isc::host_cache::HostResrv6Tuple> >::final_erase_(boost::multi_index::detail::ordered_index_node<boost::multi_index::detail::null_augment_policy, boost::multi_index::detail::ordered_index_node<boost::multi_index::detail::null_augment_policy, boost::multi_index::detail::index_node_base<isc::host_cache::HostResrv6Tuple, std::allocator<isc::host_cache::HostResrv6Tuple> > > >*) /usr/include/boost/multi_index/detail/index_base.hpp:259 (host_cache_unittests+0xa0c95)
#5 boost::multi_index::detail::ordered_index_impl<boost::multi_index::const_mem_fun<isc::host_cache::HostResrv6Tuple, isc::asiolink::IOAddress const&, &(isc::host_cache::HostResrv6Tuple::getKey() const)>, std::less<isc::asiolink::IOAddress const>, boost::multi_index::detail::nth_layer<1, isc::host_cache::HostResrv6Tuple, boost::multi_index::indexed_by<boost::multi_index::ordered_non_unique<boost::multi_index::tag<isc::host_cache::Resv6AddressIndexTag, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, boost::multi_index::const_mem_fun<isc::host_cache::HostResrv6Tuple, isc::asiolink::IOAddress const&, &(isc::host_cache::HostResrv6Tuple::getKey() const)>, mpl_::na>, boost::multi_index::ordered_unique<boost::multi_index::tag<isc::host_cache::Resv6SubnetAddressIndexTag, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, boost::multi_index::composite_key<isc::host_cache::HostResrv6Tuple, boost::multi_index::member<isc::host_cache::HostResrv6Tuple, unsigned int const, &isc::host_cache::HostResrv6Tuple::subnet_id_>, boost::multi_index::const_mem_fun<isc::host_cache::HostResrv6Tuple, isc::asiolink::IOAddress const&, &(isc::host_cache::HostResrv6Tuple::getKey() const)>, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type>, mpl_::na>, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, std::allocator<isc::host_cache::HostResrv6Tuple> >, boost::mpl::v_item<isc::host_cache::Resv6AddressIndexTag, boost::mpl::vector0<mpl_::na>, 0>, boost::multi_index::detail::ordered_non_unique_tag, boost::multi_index::detail::null_augment_policy>::erase(boost::multi_index::detail::bidir_node_iterator<boost::multi_index::detail::ordered_index_node<boost::multi_index::detail::null_augment_policy, boost::multi_index::detail::ordered_index_node<boost::multi_index::detail::null_augment_policy, boost::multi_index::detail::index_node_base<isc::host_cache::HostResrv6Tuple, std::allocator<isc::host_cache::HostResrv6Tuple> > > > >) /usr/include/boost/multi_index/detail/ord_index_impl.hpp:351 (host_cache_unittests+0xa0c95)
#6 isc::host_cache::HostCacheImpl::removeResv6(boost::shared_ptr<isc::dhcp::Host> const&) /home/razvan/isc/git/kea-review/premium/src/hooks/dhcp/host_cache/host_cache_impl.cc:88 (host_cache_unittests+0xa0c95)
#7 isc::host_cache::HostCacheImpl::remove(boost::shared_ptr<isc::dhcp::Host> const&) /home/razvan/isc/git/kea-review/premium/src/hooks/dhcp/host_cache/host_cache_impl.cc:455 (host_cache_unittests+0xa2678)
#8 isc::host_cache::HostCacheImpl::del6[abi:cxx11](unsigned int const&, isc::asiolink::IOAddress const&) /home/razvan/isc/git/kea-review/premium/src/hooks/dhcp/host_cache/host_cache_impl.cc:395 (host_cache_unittests+0xa2d9b)
#9 isc::host_cache::HostCache::cacheRemoveHandler(isc::hooks::CalloutHandle&) /home/razvan/isc/git/kea-review/premium/src/hooks/dhcp/host_cache/host_cache.cc:887 (host_cache_unittests+0x9316a)
#10 removeHandler /home/razvan/isc/git/kea-review/premium/src/hooks/dhcp/host_cache/tests/command_unittests.cc:324 (host_cache_unittests+0x567bd)
#11 int boost::_bi::list2<boost::_bi::value<boost::shared_ptr<isc::host_cache::HostCache> >, boost::arg<1> >::operator()<int, int (*)(boost::shared_ptr<isc::host_cache::HostCache>, isc::hooks::CalloutHandle&), boost::_bi::rrlist1<isc::hooks::CalloutHandle&> >(boost::_bi::type<int>, int (*&)(boost::shared_ptr<isc::host_cache::HostCache>, isc::hooks::CalloutHandle&), boost::_bi::rrlist1<isc::hooks::CalloutHandle&>&, long) /usr/include/boost/bind/bind.hpp:309 (host_cache_unittests+0x7be1c)
#12 int boost::_bi::bind_t<int, int (*)(boost::shared_ptr<isc::host_cache::HostCache>, isc::hooks::CalloutHandle&), boost::_bi::list2<boost::_bi::value<boost::shared_ptr<isc::host_cache::HostCache> >, boost::arg<1> > >::operator()<isc::hooks::CalloutHandle&>(isc::hooks::CalloutHandle&) /usr/include/boost/bind/bind.hpp:1306 (host_cache_unittests+0x7be1c)
#13 boost::detail::function::function_obj_invoker1<boost::_bi::bind_t<int, int (*)(boost::shared_ptr<isc::host_cache::HostCache>, isc::hooks::CalloutHandle&), boost::_bi::list2<boost::_bi::value<boost::shared_ptr<isc::host_cache::HostCache> >, boost::arg<1> > >, int, isc::hooks::CalloutHandle&>::invoke(boost::detail::function::function_buffer&, isc::hooks::CalloutHandle&) /usr/include/boost/function/function_template.hpp:138 (host_cache_unittests+0x7be1c)
#14 boost::function1<int, isc::hooks::CalloutHandle&>::operator()(isc::hooks::CalloutHandle&) const /usr/include/boost/function/function_template.hpp:760 (host_cache_unittests+0x5d1e9)
#15 checkCommand /home/razvan/isc/git/kea-review/premium/src/hooks/dhcp/host_cache/tests/command_unittests.cc:143 (host_cache_unittests+0x5d1e9)
#16 checkCommand /home/razvan/isc/git/kea-review/premium/src/hooks/dhcp/host_cache/tests/command_unittests.cc:177 (host_cache_unittests+0x622ed)
#17 TestBody /home/razvan/isc/git/kea-review/premium/src/hooks/dhcp/host_cache/tests/command_unittests.cc:905 (host_cache_unittests+0x64059)
#18 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/razvan/isc/git/googletest/googletest/src/gtest.cc:2608 (host_cache_unittests+0x176588)
#19 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/razvan/isc/git/googletest/googletest/src/gtest.cc:2644 (host_cache_unittests+0x176588)
#20 testing::Test::Run() /home/razvan/isc/git/googletest/googletest/src/gtest.cc:2683 (host_cache_unittests+0x1654c4)
#21 testing::TestInfo::Run() /home/razvan/isc/git/googletest/googletest/src/gtest.cc:2860 (host_cache_unittests+0x1658c6)
#22 testing::TestSuite::Run() /home/razvan/isc/git/googletest/googletest/src/gtest.cc:3014 (host_cache_unittests+0x166533)
#23 testing::internal::UnitTestImpl::RunAllTests() /home/razvan/isc/git/googletest/googletest/src/gtest.cc:5598 (host_cache_unittests+0x166e1f)
#24 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/razvan/isc/git/googletest/googletest/src/gtest.cc:2608 (host_cache_unittests+0x176c94)
#25 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/razvan/isc/git/googletest/googletest/src/gtest.cc:2644 (host_cache_unittests+0x176c94)
#26 testing::UnitTest::Run() /home/razvan/isc/git/googletest/googletest/src/gtest.cc:5185 (host_cache_unittests+0x165a59)
#27 RUN_ALL_TESTS() /home/razvan/isc/git/googletest/googletest//include/gtest/gtest.h:2482 (host_cache_unittests+0x2aeae)
#28 main /home/razvan/isc/git/kea-review/premium/src/hooks/dhcp/host_cache/tests/run_unittests.cc:16 (host_cache_unittests+0x2aeae)
SUMMARY: ThreadSanitizer: heap-use-after-free /usr/include/boost/smart_ptr/shared_ptr.hpp:1153 in unsigned long boost::hash_value<isc::dhcp::Host>(boost::shared_ptr<isc::dhcp::Host> const&)
```
I prefer the fix in the comments, not the one in the MR. I'll update the MR if there is no issue with the second fix.kea1.7.8Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/stork/-/issues/264problem with parsing kea config with comments2022-01-04T12:33:56ZMichal Nowikowskiproblem with parsing kea config with commentsWhen `http-port` setting in kea config is commented out then agent will incorrectly take it as valid setting.When `http-port` setting in kea config is commented out then agent will incorrectly take it as valid setting.1.1Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/kea/-/issues/1216Modify the DDNS FQDN format from DHCP42020-05-20T15:05:36ZvarsrajaModify the DDNS FQDN format from DHCP4
Kea version : 1.6.2
Services used: DHCP4 , DHCP-DDNS
Issue:
I would like to modify how the default FQDN is generated in the DHCP4 server for DDNS update.
By default we have the <prefix>-<IP-address-hyphenated>.<suffix> [eg abc-x...
Kea version : 1.6.2
Services used: DHCP4 , DHCP-DDNS
Issue:
I would like to modify how the default FQDN is generated in the DHCP4 server for DDNS update.
By default we have the <prefix>-<IP-address-hyphenated>.<suffix> [eg abc-x.x.x.x.mnp.com].
I would like to generate the same using mac address instead of ip-address [eg abc-macaddress.mnp.com]
1. Is there any configuration that is available to achieve this?
2. Can someone please let me know if I will be able to write a hook to achieve this.
Ps: I referred to following mail threads but am not able to access the bug tickets mentioned in them.
1. https://lists.isc.org/pipermail/kea-users/2016-January/000205.html
2. http://kea-users.7364.n8.nabble.com/Kea-users-Issue-with-DDNS-updates-td229.html#a234
Thanks
VarshaThomas MarkwalderThomas Markwalderhttps://gitlab.isc.org/isc-projects/kea/-/issues/1215Pkt<4/6>::getName() should support all message type names2020-05-13T14:33:40ZThomas MarkwalderPkt<4/6>::getName() should support all message type namesNotably missing from Pkt4::getName() are the lease query related message types. It would be handy if we returned labels for all the types, not just those we handle.Notably missing from Pkt4::getName() are the lease query related message types. It would be handy if we returned labels for all the types, not just those we handle.kea1.7.8Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/issues/1213fix sphinx list rendering2020-05-13T14:42:15ZFrancis Dupontfix sphinx list renderingSphinx seems a bit picky about list, for instance:
```
- ``foo`` - explain foo here
and bla bla...
```
is not rendered as:
```
- ``foo`` - explain foo here
and this bugs?
```
This issue should fix all instances of this problem ...Sphinx seems a bit picky about list, for instance:
```
- ``foo`` - explain foo here
and bla bla...
```
is not rendered as:
```
- ``foo`` - explain foo here
and this bugs?
```
This issue should fix all instances of this problem kept by translation to sphinx.kea1.7.8Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/bind9/-/issues/1811Follow-up from "Don't set recv/send buffer sizes for udp sockets in netmgr."2020-05-05T12:59:18ZOndřej SurýFollow-up from "Don't set recv/send buffer sizes for udp sockets in netmgr."The following discussion from !3476 should be addressed:
- [ ] @ondrej started a [discussion](https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/3476#note_128851): (+1 comment)
> I would suggest killing the same code in th...The following discussion from !3476 should be addressed:
- [ ] @ondrej started a [discussion](https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/3476#note_128851): (+1 comment)
> I would suggest killing the same code in the old networking code.May 2020 (9.11.19, 9.11.19-S1, 9.14.12, 9.16.3)https://gitlab.isc.org/isc-projects/bind9/-/issues/1810Refactor ecdsa and eddsa tests after testcrypto.sh changes2021-03-02T13:53:54ZOndřej SurýRefactor ecdsa and eddsa tests after testcrypto.sh changesBoth `ecdsa` and `eddsa` tests treat all algorithms in set as either all supported or all unsupported.
This makes it hard to incrementally add more algorithms and it also doesn't match reality (ED448 was added to OpenSSL much later than...Both `ecdsa` and `eddsa` tests treat all algorithms in set as either all supported or all unsupported.
This makes it hard to incrementally add more algorithms and it also doesn't match reality (ED448 was added to OpenSSL much later than ED25519).March 2021 (9.11.29, 9.11.29-S1, 9.16.13, 9.16.13-S1, 9.17.11)Matthijs Mekkingmatthijs@isc.orgMatthijs Mekkingmatthijs@isc.orghttps://gitlab.isc.org/isc-projects/bind9/-/issues/1808assertion failure in bind 9.16.22020-06-08T12:52:05ZOndřej Surýassertion failure in bind 9.16.2As reported to SO:
```
> Hello there,
>
> I'm running some dnsperf test against from in your testlab, and quite often i bind to crash with assertion failure.
>
> I'm running bind dnsperf with: dnsperf -f inet -t 10 -s <SANITIZED> -d...As reported to SO:
```
> Hello there,
>
> I'm running some dnsperf test against from in your testlab, and quite often i bind to crash with assertion failure.
>
> I'm running bind dnsperf with: dnsperf -f inet -t 10 -s <SANITIZED> -d dns_clear.txt -c 200 -T 4 -l 36000000 -q 5000 -S 1 (Attached dns_clear.txt, which is are reallife traffic dump from our prod bind servers). We're running CentOS Linux release 7.7.1908 (Core) in both test/prod.
>
> 29-Apr-2020 15:45:27.651 general: critical: netaddr.c:365: INSIST(0) failed, back trace
> 29-Apr-2020 15:45:27.651 general: critical: #0 0x42b890 in ??
> 29-Apr-2020 15:45:27.651 general: critical: #1 0x7f033062cada in ??
> 29-Apr-2020 15:45:27.651 general: critical: #2 0x7f033064a3d3 in ??
> 29-Apr-2020 15:45:27.651 general: critical: #3 0x7f033064fcc0 in ??
> 29-Apr-2020 15:45:27.651 general: critical: #4 0x7f033064ff56 in ??
> 29-Apr-2020 15:45:27.651 general: critical: #5 0x7f033195feaa in ??
> 29-Apr-2020 15:45:27.651 general: critical: #6 0x7f033187c448 in ??
> 29-Apr-2020 15:45:27.651 general: critical: #7 0x7f0331972a40 in ??
> 29-Apr-2020 15:45:27.651 general: critical: #8 0x7f0330652ada in ??
> 29-Apr-2020 15:45:27.651 general: critical: #9 0x7f032edc2e65 in ??
> 29-Apr-2020 15:45:27.651 general: critical: #10 0x7f032e6cd88d in ??
> 29-Apr-2020 15:45:27.651 general: critical: exiting (due to assertion failure)
>
> I've several coredumps.. Do you guys have a place where i can upload them?
>
> [root@srv07 data]# ls -lh
> total 5.7G
> -rw-------. 1 named named 1.7G Apr 22 08:48 core.11065
> -rw-------. 1 named named 1.6G Apr 22 12:58 core.11877
> -rw-------. 1 named named 2.6G Apr 21 21:17 core.126377
> -rw-------. 1 named named 1.4G Apr 29 15:45 core.15168
> -rw-------. 1 named named 166M Apr 27 17:03 core.21234
> -rw-------. 1 named named 175M Apr 27 17:07 core.21301
> -rw-------. 1 named named 2.2G Apr 21 15:33 core.72474
>
> [root@srv07 log]# named -V
> BIND 9.16.2 (Stable Release) <id:b310dc7>
> running on Linux x86_64 3.10.0-1062.18.1.el7.x86_64 #1 SMP Tue Mar 17 23:49:17 UTC 2020
> built by make with '--build=x86_64-redhat-linux-gnu' '--host=x86_64-redhat-linux-gnu' '--program-prefix=' '--disable-dependency-tracking' '--prefix=/opt/isc/isc-bind/root/usr' '--exec-prefix=/opt/isc/isc-bind/root/usr' '--bindir=/opt/isc/isc-bind/root/usr/bin' '--sbindir=/opt/isc/isc-bind/root/usr/sbin' '--sysconfdir=/etc/opt/isc/isc-bind' '--datadir=/opt/isc/isc-bind/root/usr/share' '--includedir=/opt/isc/isc-bind/root/usr/include' '--libdir=/opt/isc/isc-bind/root/usr/lib64' '--libexecdir=/opt/isc/isc-bind/root/usr/libexec' '--localstatedir=/var/opt/isc/isc-bind' '--sharedstatedir=/var/opt/isc/isc-bind/lib' '--mandir=/opt/isc/isc-bind/root/usr/share/man' '--infodir=/opt/isc/isc-bind/root/usr/share/info' '--disable-static' '--enable-dnstap' '--with-pic' '--with-gssapi' '--with-json-c' '--with-libtool' '--with-libxml2' '--without-lmdb' '--with-docbook-xsl=/usr/share/sgml/docbook/xsl-stylesheets' '--with-python' 'build_alias=x86_64-redhat-linux-gnu' 'host_alias=x86_64-redhat-linux-gnu' 'CFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic' 'LDFLAGS= -L/opt/isc/isc-bind/root/usr/lib64' 'PKG_CONFIG_PATH=:/opt/isc/isc-bind/root/usr/lib64/pkgconfig:/opt/isc/isc-bind/root/usr/share/pkgconfig'
> compiled by GCC 4.8.5 20150623 (Red Hat 4.8.5-39)
> compiled with OpenSSL version: OpenSSL 1.0.2k-fips 26 Jan 2017
> linked to OpenSSL version: OpenSSL 1.0.2k-fips 26 Jan 2017
> compiled with libxml2 version: 2.9.1
> linked to libxml2 version: 20901
> compiled with json-c version: 0.11
> linked to json-c version: 0.11
> compiled with zlib version: 1.2.7
> linked to zlib version: 1.2.7
> compiled with protobuf-c version: 1.3.2
> linked to protobuf-c version: 1.3.2
> threads support is enabled
>
> default paths:
> named configuration: /etc/opt/isc/isc-bind/named.conf
> rndc configuration: /etc/opt/isc/isc-bind/rndc.conf
> DNSSEC root key: /etc/opt/isc/isc-bind/bind.keys
> nsupdate session key: /var/opt/isc/isc-bind/run/named/session.key
> named PID file: /var/opt/isc/isc-bind/run/named/named.pid
> named lock file: /var/opt/isc/isc-bind/run/named/named.lock
>
>
>
> [root@srv07 log]# ldd /opt/isc/isc-bind/root/usr/sbin/named
> linux-vdso.so.1 => (0x00007ffcc594a000)
> libns.so.1602 => /opt/isc/isc-bind/root/usr/lib64/libns.so.1602 (0x00007f8aa0acf000)
> libdns.so.1602 => /opt/isc/isc-bind/root/usr/lib64/libdns.so.1602 (0x00007f8aa06a6000)
> libbind9.so.1600 => /opt/isc/isc-bind/root/usr/lib64/libbind9.so.1600 (0x00007f8aa0493000)
> libisccfg.so.1600 => /opt/isc/isc-bind/root/usr/lib64/libisccfg.so.1600 (0x00007f8aa0261000)
> libgssapi_krb5.so.2 => /lib64/libgssapi_krb5.so.2 (0x00007f8aa0014000)
> libkrb5.so.3 => /lib64/libkrb5.so.3 (0x00007f8a9fd2b000)
> libk5crypto.so.3 => /lib64/libk5crypto.so.3 (0x00007f8a9faf8000)
> libcom_err.so.2 => /lib64/libcom_err.so.2 (0x00007f8a9f8f4000)
> libisccc.so.1600 => /opt/isc/isc-bind/root/usr/lib64/libisccc.so.1600 (0x00007f8a9f6ea000)
> libisc.so.1602 => /opt/isc/isc-bind/root/usr/lib64/libisc.so.1602 (0x00007f8a9f475000)
> libcrypto.so.10 => /lib64/libcrypto.so.10 (0x00007f8a9f012000)
> libjson-c.so.2 => /lib64/libjson-c.so.2 (0x00007f8a9ee07000)
> libxml2.so.2 => /lib64/libxml2.so.2 (0x00007f8a9ea9d000)
> libz.so.1 => /lib64/libz.so.1 (0x00007f8a9e887000)
> libcap.so.2 => /lib64/libcap.so.2 (0x00007f8a9e682000)
> libprotobuf-c.so.1 => /opt/isc/isc-bind/root/usr/lib64/libprotobuf-c.so.1 (0x00007f8a9e479000)
> libfstrm.so.0 => /opt/isc/isc-bind/root/usr/lib64/libfstrm.so.0 (0x00007f8a9e26e000)
> libuv.so.1 => /opt/isc/isc-bind/root/usr/lib64/libuv.so.1 (0x00007f8a9e03f000)
> librt.so.1 => /lib64/librt.so.1 (0x00007f8a9de37000)
> libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f8a9dc1b000)
> libnsl.so.1 => /lib64/libnsl.so.1 (0x00007f8a9da01000)
> libdl.so.2 => /lib64/libdl.so.2 (0x00007f8a9d7fd000)
> libc.so.6 => /lib64/libc.so.6 (0x00007f8a9d42f000)
> /lib64/ld-linux-x86-64.so.2 (0x00007f8aa0d16000)
> libkrb5support.so.0 => /lib64/libkrb5support.so.0 (0x00007f8a9d21f000)
> libkeyutils.so.1 => /lib64/libkeyutils.so.1 (0x00007f8a9d01b000)
> libresolv.so.2 => /lib64/libresolv.so.2 (0x00007f8a9ce02000)
> liblzma.so.5 => /lib64/liblzma.so.5 (0x00007f8a9cbdc000)
> libm.so.6 => /lib64/libm.so.6 (0x00007f8a9c8da000)
> libattr.so.1 => /lib64/libattr.so.1 (0x00007f8a9c6d5000)
> libselinux.so.1 => /lib64/libselinux.so.1 (0x00007f8a9c4ae000)
> libpcre.so.1 => /lib64/libpcre.so.1 (0x00007f8a9c24c000)
```
The reporter is using our packages:
> We've installed bind directly from your CentOS repo; Do you still want us to send your debug symbols?
and the coredumps have been uploaded to my <SANITIZED>.June 2020 (9.11.20, 9.11.20-S1, 9.16.4, 9.17.2)Witold KrecickiWitold Krecickihttps://gitlab.isc.org/isc-projects/bind9/-/issues/1807"named-checkconf -z" exit status reflects only the last view loaded2022-01-24T16:35:07ZGraham Clinch"named-checkconf -z" exit status reflects only the last view loaded<!--
If the bug you are reporting is potentially security-related - for example,
if it involves an assertion failure or other crash in `named` that can be
triggered repeatedly - then please do *NOT* report it here, but send an
email to [...<!--
If the bug you are reporting is potentially security-related - for example,
if it involves an assertion failure or other crash in `named` that can be
triggered repeatedly - then please do *NOT* report it here, but send an
email to [security-officer@isc.org](security-officer@isc.org).
-->
### Summary
When processing a named.conf with views, the exit status of 'named-checkconf -z' only reflects whether there were errors whilst loading the final view, even though all zones in all views are processed and errors printed as appropriate.
### BIND version used
```
BIND 9.16.2 (Stable Release) <id:b310dc7>
running on Darwin x86_64 19.4.0 Darwin Kernel Version 19.4.0: Wed Mar 4 22:28:40 PST 2020; root:xnu-6153.101.6~15/RELEASE_X86_64
built by make with '--prefix=/usr/local/Cellar/bind/9.16.2' '--with-json-c' '--with-openssl=/usr/local/opt/openssl@1.1' '--with-libjson=/usr/local/opt/json-c' '--with-python-install-dir=/usr/local/Cellar/bind/9.16.2/libexec/vendor/lib/python3.8/site-packages' '--with-python=/usr/local/opt/python@3.8/bin/python3' '--without-lmdb' 'CC=clang' 'PKG_CONFIG_PATH=/usr/local/opt/json-c/lib/pkgconfig:/usr/local/opt/libuv/lib/pkgconfig:/usr/local/opt/openssl@1.1/lib/pkgconfig:/usr/local/opt/readline/lib/pkgconfig:/usr/local/opt/sqlite/lib/pkgconfig:/usr/local/opt/xz/lib/pkgconfig:/usr/local/opt/python@3.8/lib/pkgconfig' 'PKG_CONFIG_LIBDIR=/usr/lib/pkgconfig:/usr/local/Homebrew/Library/Homebrew/os/mac/pkgconfig/10.15'
compiled by CLANG 4.2.1 Compatible Apple LLVM 11.0.3 (clang-1103.0.32.59)
compiled with OpenSSL version: OpenSSL 1.1.1f 31 Mar 2020
linked to OpenSSL version: OpenSSL 1.1.1g 21 Apr 2020
compiled with libxml2 version: 2.9.4
linked to libxml2 version: 20904
compiled with json-c version: 0.13.1
linked to json-c version: 0.13.1
compiled with zlib version: 1.2.11
linked to zlib version: 1.2.11
threads support is enabled
default paths:
named configuration: /usr/local/Cellar/bind/9.16.2/etc/named.conf
rndc configuration: /usr/local/Cellar/bind/9.16.2/etc/rndc.conf
DNSSEC root key: /usr/local/Cellar/bind/9.16.2/etc/bind.keys
nsupdate session key: /usr/local/Cellar/bind/9.16.2/var/run/named/session.key
named PID file: /usr/local/Cellar/bind/9.16.2/var/run/named/named.pid
named lock file: /usr/local/Cellar/bind/9.16.2/var/run/named/named.lock
```
### Steps to reproduce
Given the configuration files listed later on, and intentionally creating an error by not creating a missing.net zone file:
Running named-checkconf -z against named-missing-last.conf gives an exit status of 1 as expected:
```
$ named-checkconf -d -z named-missing-last.conf
loading "example.net" from "example.net" class "IN"
zone example.net/IN: loaded serial 1
loading "missing.net" from "missing.net" class "IN"
zone missing.net/IN: loading from master file missing.net failed: file not found
zone missing.net/IN: not loaded due to errors.
missing/missing.net/IN: file not found
$ echo $?
1
```
Running named-checkconf -z against named-missing-first.conf should also give an exit status of 1, but does not:
```
$ named-checkconf -d -z named-missing-first.conf
loading "missing.net" from "missing.net" class "IN"
zone missing.net/IN: loading from master file missing.net failed: file not found
zone missing.net/IN: not loaded due to errors.
missing/missing.net/IN: file not found
loading "example.net" from "example.net" class "IN"
zone example.net/IN: loaded serial 1
$ echo $?
0
```
### What is the current *bug* behavior?
The exit status of named-checkconf -z reflects whether there was an error loading the zones in the *final* view.
### What is the expected *correct* behavior?
The exit status of named-checkconf -z should reflect whether there was an error loading the zones in *any* view.
### Relevant configuration files
named-missing-first.conf:
```
view "missing" {
zone "missing.net" {
type master;
file "missing.net";
};
};
view "example" {
zone "example.net" {
type master;
file "example.net";
};
};
```
named-missing-last.conf:
```
view "example" {
zone "example.net" {
type master;
file "example.net";
};
};
view "missing" {
zone "missing.net" {
type master;
file "missing.net";
};
};
```
example.net zone file:
```
$TTL 5
@ SOA ns1.example.net. hostmaster.example.net. 1 300 300 300 300
@ NS ns1.example.net.
ns1 A 127.0.0.1
```
*and no missing.net zone file*
### Possible fixes
bin/check/named-checkconf.c: load_zones_fromconfig() - 'result' (taken from 'tresult') variable appears to be reset by each call to configure_view.May 2020 (9.11.19, 9.11.19-S1, 9.14.12, 9.16.3)https://gitlab.isc.org/isc-projects/kea/-/issues/1212Advice for avoiding HA deadlock2020-05-01T05:58:50ZPeter DaviesAdvice for avoiding HA deadlockUpdate documentation to describe the steps needed to re-enable HA after clocking gets out of skew and avoid recurrent HA deadlock.
Refers to RT [16311](https://support.isc.org/Ticket/Display.html?id=16311)Update documentation to describe the steps needed to re-enable HA after clocking gets out of skew and avoid recurrent HA deadlock.
Refers to RT [16311](https://support.isc.org/Ticket/Display.html?id=16311)https://gitlab.isc.org/isc-projects/dhcp/-/issues/103LICENSE file has confusing preamble2022-01-20T16:13:29ZTomek MrugalskiLICENSE file has confusing preambleThe code is now published under MPL-2.0 license, but the there is extra preamble is slightly confusing.The code is now published under MPL-2.0 license, but the there is extra preamble is slightly confusing.4.4.3-beta1https://gitlab.isc.org/isc-projects/kea/-/issues/1211Compilation warnings on Ubuntu 19.10/g++ 9.2.12020-06-15T15:46:01ZTomek MrugalskiCompilation warnings on Ubuntu 19.10/g++ 9.2.1There are several compilation warnings:
```
labelsequence_unittest.cc: In member function ‘virtual void {anonymous}::ExtendableLabelSequenceTest_extendableLabelSequence_Test::TestBody()’:
labelsequence_unittest.cc:998:33: warning: impli...There are several compilation warnings:
```
labelsequence_unittest.cc: In member function ‘virtual void {anonymous}::ExtendableLabelSequenceTest_extendableLabelSequence_Test::TestBody()’:
labelsequence_unittest.cc:998:33: warning: implicitly-declared ‘constexpr isc::dns::LabelSequence& isc::dns::LabelSequence::operator=(const isc::dns::LabelSequence&)’ is deprecated [-Wdeprecated-copy]
998 | els = LabelSequence(ls1, buf);
| ^
In file included from labelsequence_unittest.cc:11:
../../../../src/lib/dns/labelsequence.h:125:5: note: because ‘isc::dns::LabelSequence’ has user-provided ‘isc::dns::LabelSequence::LabelSequence(const isc::dns::LabelSequence&)’
125 | LabelSequence(const LabelSequence& ls):
| ^~~~~~~~~~~~~
```
(repeated many times throughout the file.
```
cfg_option_unittest.cc: In member function ‘virtual void {anonymous}::CfgOptionTest_replace_Test::TestBody()’:
cfg_option_unittest.cc:297:28: warning: implicitly-declared ‘isc::dhcp::OptionDescriptor& isc::dhcp::OptionDescriptor::operator=(const isc::dhcp::OptionDescriptor&)’ is deprecated [-Wdeprecated-copy]
297 | desc = cfg.get("isc", 2);
| ^
In file included from cfg_option_unittest.cc:17:
../../../../src/lib/dhcpsrv/cfg_option.h:104:5: note: because ‘isc::dhcp::OptionDescriptor’ has user-provided ‘isc::dhcp::OptionDescriptor::OptionDescriptor(const isc::dhcp::OptionDescriptor&)’
104 | OptionDescriptor(const OptionDescriptor& desc)
| ^~~~~~~~~~~~~~~~
```
This also affects client_class_def_unittest.cc, cfg_subnets4_unittest.cc, subnet_unittest.cc and config_backend_unittest.cc (and possibly more.kea1.7.9Francis DupontFrancis Dupont