ISC Open Source Projects issueshttps://gitlab.isc.org/groups/isc-projects/-/issues2020-04-23T15:18:32Zhttps://gitlab.isc.org/isc-projects/kea/-/issues/1157radius hook package should depend on the host cache one.2020-04-23T15:18:32ZFrancis Dupontradius hook package should depend on the host cache one.The RADIUS hook requires the host cache one so when the RADIUS package is loaded it should load the host cache one as a dependency.
Note it is far to be critical so it can be postponed to the next milestone.The RADIUS hook requires the host cache one so when the RADIUS package is loaded it should load the host cache one as a dependency.
Note it is far to be critical so it can be postponed to the next milestone.kea1.7.7https://gitlab.isc.org/isc-projects/kea/-/issues/1094thread sanitizer reporting unit test in control agent2020-04-22T19:23:17ZWlodzimierz Wencelthread sanitizer reporting unit test in control agenthttps://jenkins.isc.org/job/kea-1.7/job/ut-thread/3/testReport/
CtrlAgentControllerTest.sigintShutdown
```
Error Message
ca_controller_unittests.cc:255
Value of: elapsed_time.total_milliseconds() < 300
Actual: false
Expected: true
Sta...https://jenkins.isc.org/job/kea-1.7/job/ut-thread/3/testReport/
CtrlAgentControllerTest.sigintShutdown
```
Error Message
ca_controller_unittests.cc:255
Value of: elapsed_time.total_milliseconds() < 300
Actual: false
Expected: true
Stacktrace
ca_controller_unittests.cc:255
Value of: elapsed_time.total_milliseconds() < 300
Actual: false
Expected: true
```
failing on freebsd 12 and ubuntu 1910kea1.7.7Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/issues/1070Switch to bison 3.52020-03-30T16:32:35ZFrancis DupontSwitch to bison 3.5kea1.7.7Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/issues/987Increase the flexibility of Flex-id hook to include conditional processing op...2020-03-26T15:21:22ZCathy AlmondIncrease the flexibility of Flex-id hook to include conditional processing optionsCurrently flex-id processing is all or nothing (with small measure of if/else that doesn't scale well).
The use case is one where the identifier needs to be defined differently depending on the vendor ID. To make this usable, we'd like...Currently flex-id processing is all or nothing (with small measure of if/else that doesn't scale well).
The use case is one where the identifier needs to be defined differently depending on the vendor ID. To make this usable, we'd like to propose that classification is used to help define this, something like:
```
"parameters": {
"identifier-expressions": [{
"class": "foo",
"substring(relay6[0].option[18].hex,0,40)"
},{
"class": "bar",
"substring(relay6[0].option[18].hex,0,32)"
}
]
}
```
This is from [Support ticket #15379](https://support.isc.org/Ticket/Display.html?id=15379), for which we do not yet have a viable workaround or solution.kea1.7.7https://gitlab.isc.org/isc-projects/kea/-/issues/343Put socket control buffer in the stack2020-03-26T08:05:01ZFrancis DupontPut socket control buffer in the stackThere is no good reason to have socket control buffers in the packet filter object: simply put them in the stack where the input/output buffer already is. This enables for instance multiple receiving threads (DHCP is over UDP so it is sa...There is no good reason to have socket control buffers in the packet filter object: simply put them in the stack where the input/output buffer already is. This enables for instance multiple receiving threads (DHCP is over UDP so it is safe, at least with a way to not receive the same query in all threads...).
fixes #1158kea1.7.7Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/issues/279Built-in Prometheus stats exporter and Grafana template [ISC-support #14725]2020-04-16T13:31:01ZVicky Riskvicky@isc.orgBuilt-in Prometheus stats exporter and Grafana template [ISC-support #14725]
Please add a feature to export Kea statistics to Prometheus
Please publish a Grafana template for displaying the statistics in a useful way. (I will open a separate ticket for this, but the two should be tested together).
**Some initia...
Please add a feature to export Kea statistics to Prometheus
Please publish a Grafana template for displaying the statistics in a useful way. (I will open a separate ticket for this, but the two should be tested together).
**Some initial questions**
- Are you sure your feature is not already implemented in the latest Kea version?
Yes
- Are you sure what you would like to do is not possible using some other mechanisms?
It is possible to manually import the Kea stats into Prometheus but this would make it easier, more automatic.
It is also possible to implement a Prometheus client in Kea. This is more work, a tighter integration and is not what I am asking for here.
- Have you discussed your idea on kea-users or kea-dev mailing lists?
No. But if we are about to implement it, I would be happy to ask on Kea-users if people want it.
This was requested by an ISC Kea support customer.
**Is your feature request related to a problem? Please describe.**
It would be nice if we could simplify the process of exporting and displaying Kea statistics for users of these two popular open source projects (Prometheus and Grafana).
**Describe the solution you'd like**
User can enable stats export to Prometheus.
User must install Prometheus and configure Prometheus 'target' system information in Kea
User may optionally select/tailor which statistics to export, or use the reasonable default we establish.
**Describe alternatives you've considered**
An alternative would be implementing a Prometheus client.https://prometheus.io/docs/instrumenting/clientlibs/
**Additional context**
https://prometheus.io/docs/instrumenting/exporters/
Direct link: [support#14725](https://support.isc.org/Ticket/Display.html?id=14725)kea1.7.7https://gitlab.isc.org/isc-projects/stork/-/issues/171UI tweak: pagination/total entries layout should be unified2020-04-20T09:44:05ZTomek MrugalskiUI tweak: pagination/total entries layout should be unifiedA minor UI usability improvement.
When viewing Kea services, BIND services or Machines, the bar with X of Y pages/show Z per page line is above the content. The subnets and networks views has it below the content. This should be unified...A minor UI usability improvement.
When viewing Kea services, BIND services or Machines, the bar with X of Y pages/show Z per page line is above the content. The subnets and networks views has it below the content. This should be unified.
I think the standard is to keep it at the bottom.0.7Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/stork/-/issues/74Req 10.1.1 - Single Machine Installation2020-04-09T10:05:06ZVicky Riskvicky@isc.orgReq 10.1.1 - Single Machine InstallationAs a user with a small deployment I would like to run Stork on the same machine as the service is running on. I realize that if the server goes down, so does my management capability.
I might especially want to be able to do this for a ...As a user with a small deployment I would like to run Stork on the same machine as the service is running on. I realize that if the server goes down, so does my management capability.
I might especially want to be able to do this for a trial or demo.0.7Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/stork/-/issues/13Stork architecture design2020-05-08T14:26:34ZTomek MrugalskiStork architecture designWe need a high level Stork design. It should cover at least the following:
- overall architecture
- what tasks Stork agent has to do
- backend role, in particular how to handle tasks in the background (such as monitoring for failure eve...We need a high level Stork design. It should cover at least the following:
- overall architecture
- what tasks Stork agent has to do
- backend role, in particular how to handle tasks in the background (such as monitoring for failure events, such as server going down, running out of addresses in dhcp or sending srvfail in dns)
- database interaction
- prometheus integration0.7Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/269bump version to 0.7.02020-05-08T08:23:59ZMichal Nowikowskibump version to 0.7.00.7Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/stork/-/issues/263Need to show global Host Reservations2020-05-06T17:17:24ZTomek MrugalskiNeed to show global Host ReservationsAs pointed out in https://gitlab.isc.org/isc-projects/stork/-/issues/45#note_127068, Stork does not show global (with subnet-id=0) reservations. It should.As pointed out in https://gitlab.isc.org/isc-projects/stork/-/issues/45#note_127068, Stork does not show global (with subnet-id=0) reservations. It should.0.7Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/262cleanup of files in backend/server/restservice is needed2020-05-06T12:10:41ZMichal Nowikowskicleanup of files in backend/server/restservice is neededmake file names consistentmake file names consistent0.7Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/stork/-/issues/259Eliminate errors printed in console2023-03-07T09:16:54ZTomek MrugalskiEliminate errors printed in consoleThere are way too many errors printed when running demo.
Steps to reproduce:
1. `rake docker_up`
2. add agent-kea, agent-kea-ha1, agent-kea-ha2
Here's a couple of errors:
```
agent-kea-ha2_1 | ERRO[2020-04-28 11:40:41] promkeaexporte...There are way too many errors printed when running demo.
Steps to reproduce:
1. `rake docker_up`
2. add agent-kea, agent-kea-ha1, agent-kea-ha2
Here's a couple of errors:
```
agent-kea-ha2_1 | ERRO[2020-04-28 11:40:41] promkeaexporter.go:488 cannot get stat from daemon: response result from Kea != 0: 1, text: unable to forward command to the dhcp6 service: No such file or directory. The server is likely to be offline
agent-kea-ha2_1 | isc.org/stork/agent.(*PromKeaExporter).setDaemonStats
agent-kea-ha2_1 | /home/thomson/devel/stork/backend/agent/promkeaexporter.go:345
agent-kea-ha2_1 | isc.org/stork/agent.(*PromKeaExporter).collectStats
agent-kea-ha2_1 | /home/thomson/devel/stork/backend/agent/promkeaexporter.go:486
agent-kea-ha2_1 | isc.org/stork/agent.(*PromKeaExporter).statsCollectorLoop
agent-kea-ha2_1 | /home/thomson/devel/stork/backend/agent/promkeaexporter.go:313
agent-kea-ha2_1 | runtime.goexit
agent-kea-ha2_1 | /home/thomson/devel/stork/tools/1.13.5/go/src/runtime/asm_amd64.s:1357
```
```
gent-kea_1 | time="2020-04-28T11:40:22Z" level=error msg="ERROR: diskstats collector failed after 0.001589s: invalid line for /proc/diskstats for sdh" source="collector.go:123"
agent-kea_1 | time="2020-04-28T11:40:22Z" level=error msg="error gathering metrics: collected metric node_hwmon_temp_celsius label:<name:\"chip\" value:\"thermal_thermal_zone0\" > label:<name:\"sensor\" value:\"temp0\" > gauge:<value:27.8 > has help \"Hardware monitor for temperature ()\" but should have \"Hardware monitor for temperature (input)\"
agent-kea_1 | " source="<autogenerated>:1"
agent-kea_1 | INFO[2020-04-28 11:40:22] promkeaexporter.go:444 APP &{Type:kea AccessPoints:[{Type:control Address:127.0.0.1 Port:8000 Key:}]}
```
```
agent-bind9_1 | * collected metric node_hwmon_temp_celsius label:<name:\"chip\" value:\"platform_coretemp_0\" > label:<name:\"sensor\" value:\"temp3\" > gauge:<value:41 > has help \"Hardware monitor for temperature (input)\" but should have \"Hardware monitor for temperature ()\"
agent-bind9_1 | * collected metric node_hwmon_temp_celsius label:<name:\"chip\" value:\"platform_coretemp_0\" > label:<name:\"sensor\" value:\"temp4\" > gauge:<value:43 > has help \"Hardware monitor for temperature (input)\" but should have \"Hardware monitor for temperature ()\"
agent-bind9_1 | * collected metric node_hwmon_temp_celsius label:<name:\"chip\" value:\"platform_nct6775_656\" > label:<name:\"sensor\" value:\"temp8\" > gauge:<value:0 > has help \"Hardware monitor for temperature (input)\" but should have \"Hardware monitor for temperature ()\"
agent-bind9_1 | * collected metric node_hwmon_temp_celsius label:<name:\"chip\" value:\"platform_nct6775_656\" > label:<name:\"sensor\" value:\"temp1\" > gauge:<value:44 > has help \"Hardware monitor for temperature (input)\" but should have \"Hardware monitor for temperature ()\"
```
There may be more. I think we should catch exceptions and log something more reasonable.0.7Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/stork/-/issues/258BIND-free mode2020-05-07T12:30:36ZVicky Riskvicky@isc.orgBIND-free modeAll of our users at the outset, and maybe for a while, will be using Stork Kea and not for BIND.
Can we make it a configurable setting whether you are using Stork with BIND or Kea, and hide the BIND dashboard or menu choices, links to t...All of our users at the outset, and maybe for a while, will be using Stork Kea and not for BIND.
Can we make it a configurable setting whether you are using Stork with BIND or Kea, and hide the BIND dashboard or menu choices, links to the BIND docs, etc, if the admin is not using it with BIND?
At one point when I suggested this, Godfryd said that this might be something Stork could just infer from the servers it was configure to monitor - that is fine too, and I suppose even cooler, but either is ok.
There are several places in the UI where we mention BIND, perhaps we can remove those as well for the time being.0.7Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/256add support for global search2020-04-30T08:47:27ZMichal Nowikowskiadd support for global search0.7Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/stork/-/issues/251Adopt HA data model to the new layout of daemons information2020-04-27T10:07:50ZMarcin SiodelskiAdopt HA data model to the new layout of daemons informationIn #233 we have added new SQL tables dedicated for holding information about the daemons. The HA service tables should now refer to these tables rather than the tables holding apps. This is going to ease displaying the HA status in the d...In #233 we have added new SQL tables dedicated for holding information about the daemons. The HA service tables should now refer to these tables rather than the tables holding apps. This is going to ease displaying the HA status in the dashboard, it will generally make the HA status more accessible.0.7Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/247update stork deps (for backend in go and for webui)2020-04-22T10:09:03ZMichal Nowikowskiupdate stork deps (for backend in go and for webui)deps for update:
- angular to 9.1
- and moredeps for update:
- angular to 9.1
- and more0.7Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/stork/-/issues/246Display the source of information for hosts in the UI2020-04-21T10:25:12ZMarcin SiodelskiDisplay the source of information for hosts in the UIWe do record in the database whether the host reservation comes from the config file or from the hosts_cmds hooks library. We want to display that in the UI next to each reservation.We do record in the database whether the host reservation comes from the config file or from the hosts_cmds hooks library. We want to display that in the UI next to each reservation.0.7Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/241improve presenting kea daemons on app page2020-04-20T09:58:05ZMichal Nowikowskiimprove presenting kea daemons on app pageInstead presenting subnets table there should be just links to subnets page with filtering set to given app id. The same for shared networks and hosts reservations.Instead presenting subnets table there should be just links to subnets page with filtering set to given app id. The same for shared networks and hosts reservations.0.7Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/stork/-/issues/240Remote HA partner link is not displayed in docker demo2020-04-17T12:13:14ZMarcin SiodelskiRemote HA partner link is not displayed in docker demoSteps to reproduce:
- rake docker_up cache=false
- Open UI
- Add two machines: agent-kea-ha1 and agent-kea-ha2
- Click on one of the Kea apps added
The HA status shows two boxes, one for local server, one for remote. In the title of the...Steps to reproduce:
- rake docker_up cache=false
- Open UI
- Add two machines: agent-kea-ha1 and agent-kea-ha2
- Click on one of the Kea apps added
The HA status shows two boxes, one for local server, one for remote. In the title of the remote partner's box there should be a link to the partner, but it is not shown.
The reason for it seems to be that Storks ends up creating two HA services for the two apps, rather than one. I suspect that the reason for it is that their configs slightly differ. Strictly speaking they differ by the following url:
```
"url": "http://172.20.0.102:8002/"
```
vs
```
"url": "http://172.20.0.102:8002"
```
We could make the URLs comparison slightly less fragile but I think it should come in some other issue that looks at more aspects of HA configuration matching than URLs. Here, we should really just make it work with the minimal effort given the time constraints.0.7