ISC Open Source Projects issueshttps://gitlab.isc.org/groups/isc-projects/-/issues2020-06-05T16:31:45Zhttps://gitlab.isc.org/isc-projects/stork/-/issues/275implement refresh data model2020-06-05T16:31:45ZMichal Nowikowskiimplement refresh data modelaccording to this design: https://gitlab.isc.org/isc-projects/stork/-/wikis/Designs/Refreshing-Dataaccording to this design: https://gitlab.isc.org/isc-projects/stork/-/wikis/Designs/Refreshing-Data0.8Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/stork/-/issues/274stork-agent should be able to determine CWD of kea or named processes2022-07-04T07:26:19ZMichal Nowikowskistork-agent should be able to determine CWD of kea or named processes@garbled1 reported in #243:
```
I keep getting this in my logs:
May 11 05:55:10 pollux stork-agent[29532]: #33 (closed)[33mWARN#033[0m[2020-05-11 05:55:10] monitor.go:159 cannot get process current working directory: readlink ...@garbled1 reported in #243:
```
I keep getting this in my logs:
May 11 05:55:10 pollux stork-agent[29532]: #33 (closed)[33mWARN#033[0m[2020-05-11 05:55:10] monitor.go:159 cannot get process current working directory: readlink /proc/22855/cwd: permission denied
lrwxrwxrwx 1 bind bind 0 Apr 18 13:32 /proc/22855/cwd -> /var/cache/bind
drwxr-xr-x 9 root root 4096 Oct 12 2019 /var/cache
drwxrwxr-x 2 root bind 4096 May 11 03:19 /var/cache/bind
That is probably apparmor related?
```
This can be solved by adding:
```
AmbientCapabilities=CAP_SYS_PTRACE
```
to service file.
`CAP_SYS_PTRACE` gives permission to read `/proc/<pid>/cwd`0.8https://gitlab.isc.org/isc-projects/stork/-/issues/273stork-agent cannot read bind config files that have 600 persmissions2020-05-18T12:54:55ZMichal Nowikowskistork-agent cannot read bind config files that have 600 persmissions@garbled1 reported in #243:
```
This was what told me there was an error:
May 9 06:05:35 pollux stork-agent[28307]: #33 (closed)[33mWARN#033[0m[2020-05-09 06:05:35] bind9.go:254 cannot parse BIND 9 config file /etc/bind/nam...@garbled1 reported in #243:
```
This was what told me there was an error:
May 9 06:05:35 pollux stork-agent[28307]: #33 (closed)[33mWARN#033[0m[2020-05-09 06:05:35] bind9.go:254 cannot parse BIND 9 config file /etc/bind/named.conf: exit status 1
At the top of that file, I include /etc/bind/rndc.key
Easy fix was to edit /etc/group:
bind:x:113:stork-agent
```
stork-agent could be added to bind group during installation if this group exists0.8https://gitlab.isc.org/isc-projects/stork/-/issues/271Sanity checks for 0.7.02022-02-02T09:51:30ZMichal NowikowskiSanity checks for 0.7.01) Please, get the tarball and check it, run tests.
1) tarball: https://gitlab.isc.org/isc-projects/stork/-/jobs/876122/artifacts/browse
1) Start demo locally (rake docker_up) and follow the steps from https://gitlab.isc.org/isc-proje...1) Please, get the tarball and check it, run tests.
1) tarball: https://gitlab.isc.org/isc-projects/stork/-/jobs/876122/artifacts/browse
1) Start demo locally (rake docker_up) and follow the steps from https://gitlab.isc.org/isc-projects/stork/-/wikis/Demo
1) Install server and agent localy e.g. in VMs from binary packages:
1) debs: https://gitlab.isc.org/isc-projects/stork/-/jobs/876123/artifacts/browse
1) rpms: https://gitlab.isc.org/isc-projects/stork/-/jobs/876124/artifacts/browse0.8https://gitlab.isc.org/isc-projects/stork/-/issues/267Enhance search expressions2020-05-29T04:20:30ZMarcin SiodelskiEnhance search expressionsWe currently allow including key=val expressions in search. We think that we might better migrate to something more sophisticated. One particular use case that we already have is to search for all global host reservations. For that we'd ...We currently allow including key=val expressions in search. We think that we might better migrate to something more sophisticated. One particular use case that we already have is to search for all global host reservations. For that we'd like to be able to say:
```
is:global
```
We may also migrate from key=val to key:val.0.8Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/stork/-/issues/248after entering kea app page with ha status there are lots of errors in the we...2020-06-03T18:16:19ZMichal Nowikowskiafter entering kea app page with ha status there are lots of errors in the web browser consolethe errors:
```
ERROR TypeError: "this._receivedStatus is undefined"
```the errors:
```
ERROR TypeError: "this._receivedStatus is undefined"
```0.8Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/245Subnet filtering bug: showing the same subnet several times2020-05-29T14:51:28ZTomek MrugalskiSubnet filtering bug: showing the same subnet several timesThere's a bug in filtering subnets. I have only agent-kea configured. It reports there are 9 subnets. I went to DHCP->Subnets and used "6" as a filtering string hoping to see only 192.0.6.0 subnet. However, it now shows 11 subnets includ...There's a bug in filtering subnets. I have only agent-kea configured. It reports there are 9 subnets. I went to DHCP->Subnets and used "6" as a filtering string hoping to see only 192.0.6.0 subnet. However, it now shows 11 subnets including 3 copies of 192.0.6.0.
If I use a longer filter string 0.6.0 it now limits the subnets correctly, but still shows 3 copies of 192.0.6.0 subnet.
This is what I have in the db:
```
stork=> select * from subnet;
id | created_at | prefix | shared_network_id | client_class | addr_utilization | pd_utilization
----+---------------------------+---------------+-------------------+--------------+------------------+----------------
1 | 2020-04-20 11:35:49.21212 | 192.0.5.0/24 | 1 | class-01-00 | |
2 | 2020-04-20 11:35:49.21212 | 192.0.6.0/24 | 1 | class-01-01 | |
3 | 2020-04-20 11:35:49.21212 | 192.0.7.0/24 | 1 | class-01-02 | |
4 | 2020-04-20 11:35:49.21212 | 192.0.8.0/24 | 1 | class-01-03 | |
5 | 2020-04-20 11:35:49.21212 | 192.0.9.0/24 | 1 | class-01-04 | |
6 | 2020-04-20 11:35:49.21212 | 192.1.15.0/24 | 2 | class-02-00 | |
7 | 2020-04-20 11:35:49.21212 | 192.1.16.0/24 | 2 | class-02-01 | |
8 | 2020-04-20 11:35:49.21212 | 192.1.17.0/24 | 2 | class-02-02 | |
9 | 2020-04-20 11:35:49.21212 | 192.0.2.0/24 | | class-00-00 | |
(9 rows)
```
and this is how it looks filtered:
![bug-duplicate-subnets](/uploads/93df4695f51dd1872cb44ec193bcf405/bug-duplicate-subnets.png)0.8Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/218Port bind_exporter to embedded Stork exporter2020-07-10T12:35:19ZMatthijs Mekkingmatthijs@isc.orgPort bind_exporter to embedded Stork exporter0.8Matthijs Mekkingmatthijs@isc.orgMatthijs Mekkingmatthijs@isc.orghttps://gitlab.isc.org/isc-projects/stork/-/issues/213serverless mode: agent as prometheus exporter2020-05-22T14:35:54ZTomek Mrugalskiserverless mode: agent as prometheus exporterThere are two tickets in Kea (https://gitlab.isc.org/isc-projects/kea/issues/279 and https://gitlab.isc.org/isc-projects/kea/issues/280) that requested having Prometheus exporter and Grafana template. We could address this request using ...There are two tickets in Kea (https://gitlab.isc.org/isc-projects/kea/issues/279 and https://gitlab.isc.org/isc-projects/kea/issues/280) that requested having Prometheus exporter and Grafana template. We could address this request using stork agent. The agent would be working in exporter-only mode.
This should be reasonably simple to implement. There should be a command line switch (or some entry in the config file) that would prevent agent from opening grpc socket and only open Prometheus export socket.
(on a somewhat related note, there should be a way to do the opposite - only open grpc and not open Prometheus socket. That's to address scenario where user is not interested in Grafana).0.8https://gitlab.isc.org/isc-projects/stork/-/issues/132Go code when run in containers should be built in containers2020-05-14T14:53:52ZMichal NowikowskiGo code when run in containers should be built in containersOtherwise when code is built on e.g. macOS it is not possible to run such binaries in a container with Linux.
Such error is observed:
```
`server_1 | /bin/sh: 1: /server/stork-server: Exec format error`
```Otherwise when code is built on e.g. macOS it is not possible to run such binaries in a container with Linux.
Such error is observed:
```
`server_1 | /bin/sh: 1: /server/stork-server: Exec format error`
```0.8Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/bind9/-/issues/1930Possible race in TCP accepting vs quota2020-06-10T18:49:37ZWitold KrecickiPossible race in TCP accepting vs quotaThere's a possibility of a race in TCP accepting code:
1. T1 accepts a connection C1
2. T2 accepts a connection C2
3. T1 tries to accept a connection C3, but we hit a quota, isc_quota_cb_init() sets quota_accept_cb for the socket, we ret...There's a possibility of a race in TCP accepting code:
1. T1 accepts a connection C1
2. T2 accepts a connection C2
3. T1 tries to accept a connection C3, but we hit a quota, isc_quota_cb_init() sets quota_accept_cb for the socket, we return from accept_connection
4. T2 drops C2, but we race in quota_release with accepting C3 so we don't see quota->waiting is > 0, we don't launch the callback
5. T1 accepts a connection C4, we are able to get the quota we clear the quota_accept_cb from sock->quotacb
6. T1 drops C1, tries to call the callback which is zeroed, sigsegv.June 2020 (9.11.20, 9.11.20-S1, 9.16.4, 9.17.2)https://gitlab.isc.org/isc-projects/bind9/-/issues/1924Release Checklist for BIND 9.11.20, BIND 9.11.20-S1, BIND 9.16.4, BIND 9.17.22020-06-18T09:49:12ZMichał KępieńRelease Checklist for BIND 9.11.20, BIND 9.11.20-S1, BIND 9.16.4, BIND 9.17.2## Release Schedule
**Code Freeze:** Friday, June 5th, 2020
**Tagging Deadline:** Wednesday, June 10th, 2020
**Public Release:** Wednesday, June 17th, 2020
## Release Checklist
### Before the Code Freeze
- [x] ***(QA)*** Inform Su...## Release Schedule
**Code Freeze:** Friday, June 5th, 2020
**Tagging Deadline:** Wednesday, June 10th, 2020
**Public Release:** Wednesday, June 17th, 2020
## Release Checklist
### Before the Code Freeze
- [x] ***(QA)*** Inform Support and Marketing of impending release (and give estimated release dates).
- [x] ***(QA)*** Ensure there are no permanent test failures on any platform.
- [x] ***(QA)*** Check Perflab to ensure there has been no unexplained drop in performance for the versions being released.
- [x] ***(QA)*** Check whether all issues assigned to the release milestone are resolved[^1].
- [x] ***(QA)*** Ensure that there are no outstanding merge requests in the private repository[^1] (Subscription Edition only).
- [x] ***(QA)*** Ensure all merge requests marked for backporting have been indeed backported.
### Before the Tagging Deadline
- [x] ***(QA)*** Look for outstanding documentation issues (e.g. `CHANGES` mistakes) and address them if any are found.
- [x] ***(QA)*** Ensure release notes are correct, ask Support and Marketing to check them as well.
- [x] ***(Support)*** Check release notes, ask QA to correct any mistakes found.
- [x] ***(Marketing)*** Check release notes, ask QA to correct any mistakes found.
- [x] ***(SwEng)*** Update API files for libraries with new version information.
- [x] ***(SwEng)*** Change software version and library versions in `configure.ac` (new major release only).
- [x] ***(SwEng)*** Rebuild `configure` using Autoconf on `docs.isc.org`.
- [x] ***(SwEng)*** Update `CHANGES`.
- [x] ***(SwEng)*** Update `CHANGES.SE` (Subscription Edition only).
- [x] ***(SwEng)*** Update `README.md`.
- [x] ***(SwEng)*** Update `version`.
- [x] ***(SwEng)*** Build documentation on `docs.isc.org`.
- [x] ***(QA)*** Check that all the above steps were performed correctly.
- [x] ***(QA)*** Check that the formatting is correct for text, PDF, and HTML versions of release notes.
- [x] ***(SwEng)*** Tag the releases[^2]. (Tags may only be pushed to the public repository for releases which are *not* security releases.)
- [x] ***(SwEng)*** If this is the first tag for a release (e.g. beta), create a release branch named `release_v9_X_Y` to allow development to continue on the maintenance branch whilst release engineering continues.
### Before the ASN Deadline (for ASN Releases) or the Public Release Date (for Regular Releases)
- [x] ***(QA)*** Verify GitLab CI results for the tags created and prepare a QA report for the releases to be published.
- [x] ***(QA)*** Request signatures for the tarballs, providing their location and checksums.
- [x] ***(Signers)*** Validate tarball checksums, sign tarballs, and upload signatures.
- [x] ***(QA)*** Verify tarball signatures and check tarball checksums again.
- [x] ***(Support)*** Pre-publish ASN and/or Subscription Edition tarballs so that packages can be built.
- [x] ***(QA)*** Build and test ASN and/or Subscription Edition packages.
- [x] ***(QA)*** Notify Support that the releases have been prepared.
- [x] ***(Support)*** Send out ASNs (if applicable).
### On the Day of Public Release
- [x] ***(Support)*** Wait for clearance from Security Officer to proceed with the public release (if applicable).
- [x] ***(Support)*** Place tarballs in public location on FTP site.
- [x] ***(Support)*** Publish links to downloads on ISC website.
- [x] ***(Support)*** Write release email to *bind-announce*.
- [x] ***(Support)*** Write email to *bind-users* (if a major release).
- [x] ***(Support)*** Update tickets in case of waiting support customers.
- [x] ***(QA)*** Build and test any outstanding private packages.
- [x] ***(QA)*** Build public packages (`*.deb`, RPMs).
- [x] ***(QA)*** Inform Marketing of the release.
- [x] ***(QA)*** Update the internal [BIND release dates wiki page](https://wiki.isc.org/bin/view/Main/BindReleaseDates) when public announcement has been made.
- [x] ***(Marketing)*** Post short note to Twitter.
- [x] ***(Marketing)*** Update [Wikipedia entry for BIND](https://en.wikipedia.org/wiki/BIND).
- [x] ***(Marketing)*** Write blog article (if a major release).
- [x] ***(QA)*** Ensure all new tags are annotated and signed.
- [x] ***(SwEng)*** Merge the automatically prepared `prep 9.X.Y` commit which updates `version` and documentation on the release branch into the relevant maintenance branch (`v9_X`).
- [x] ***(SwEng)*** Push tags for the published releases to the public repository.
- [x] ***(QA)*** For each maintained branch, update the `BIND_BASELINE_VERSION` variable for the `abi-check` job in `.gitlab-ci.yml` to the latest published BIND version tag for a given branch.
- [x] ***(QA)*** Prepare empty release notes for the next set of releases.
- [x] ***(QA)*** Update QA tools used in GitLab CI (e.g. Flake8, PyLint) by modifying the relevant `Dockerfile`.
[^1]: If not, use the time remaining until the tagging deadline to ensure all outstanding issues are either resolved or moved to a different milestone.
[^2]: Preferred command line: `git tag -u <DEVELOPER_KEYID> -a -s -m "BIND 9.X.Y[alphatag]" v9_X_Y[alphatag]`, where `[alphatag]` is an optional string such as `b1`, `rc1`, etc.June 2020 (9.11.20, 9.11.20-S1, 9.16.4, 9.17.2)Michał KępieńMichał Kępień2020-06-17https://gitlab.isc.org/isc-projects/bind9/-/issues/1921Adapt CI jobs involved in producing release tarballs to work with Automake & ...2020-06-09T12:56:40ZMichał KępieńAdapt CI jobs involved in producing release tarballs to work with Automake & Sphinx - Source tarballs for `master` should be produced using `make dist`.
- Release tarballs for `master` and `v9_16` must contain
Sphinx-generated documentation files.
Internal discussion led to the following solution:
- Include... - Source tarballs for `master` should be produced using `make dist`.
- Release tarballs for `master` and `v9_16` must contain
Sphinx-generated documentation files.
Internal discussion led to the following solution:
- Include the ARM in HTML, PDF, and EPUB formats in the release
tarball (i.e. in the FTP directory for a given release).
- Do not prepare any separate documents with just the release notes,
but point the reader towards them.June 2020 (9.11.20, 9.11.20-S1, 9.16.4, 9.17.2)Michał KępieńMichał Kępieńhttps://gitlab.isc.org/isc-projects/bind9/-/issues/1914Text edits in libdns.rst2020-06-08T12:20:44ZSuzanne GoldlustText edits in libdns.rstContent, clarity, and grammar updates to the DNS Library Support section of the BIND ARMContent, clarity, and grammar updates to the DNS Library Support section of the BIND ARMJune 2020 (9.11.20, 9.11.20-S1, 9.16.4, 9.17.2)Suzanne GoldlustSuzanne Goldlusthttps://gitlab.isc.org/isc-projects/bind9/-/issues/1910Text edits in general.rst2020-06-08T12:20:23ZSuzanne GoldlustText edits in general.rstContent, clarity, and grammar updates in the BIND ARMContent, clarity, and grammar updates in the BIND ARMJune 2020 (9.11.20, 9.11.20-S1, 9.16.4, 9.17.2)Suzanne GoldlustSuzanne Goldlusthttps://gitlab.isc.org/isc-projects/bind9/-/issues/1909Text edits in history.rst2020-06-08T12:10:48ZSuzanne GoldlustText edits in history.rstContent, clarity, grammarContent, clarity, grammarJune 2020 (9.11.20, 9.11.20-S1, 9.16.4, 9.17.2)Suzanne GoldlustSuzanne Goldlusthttps://gitlab.isc.org/isc-projects/bind9/-/issues/1908Text edits in troubleshooting.rst2020-06-08T12:11:23ZSuzanne GoldlustText edits in troubleshooting.rstContent, clarity, grammar fixesContent, clarity, grammar fixesJune 2020 (9.11.20, 9.11.20-S1, 9.16.4, 9.17.2)Suzanne GoldlustSuzanne Goldlusthttps://gitlab.isc.org/isc-projects/bind9/-/issues/1906More BIND ARM text edits2020-06-08T12:11:06ZSuzanne GoldlustMore BIND ARM text editssecurity.rst updatessecurity.rst updatesJune 2020 (9.11.20, 9.11.20-S1, 9.16.4, 9.17.2)Suzanne GoldlustSuzanne Goldlusthttps://gitlab.isc.org/isc-projects/bind9/-/issues/1902BIND build problems on NetBSD 92020-06-04T12:47:57ZMichal NowakBIND build problems on NetBSD 9There are three BIND 9.16.3 compilation issues on NetBSD 9 with Clang 9.0.1:
```
--- parser.o ---
clang -include /home/newman/bind-9.16.3/config.h -I/home/newman/bind-9.16.3 -I../.. -I. -I/home/newman/bind-9.16.3/lib/dns/include -I../....There are three BIND 9.16.3 compilation issues on NetBSD 9 with Clang 9.0.1:
```
--- parser.o ---
clang -include /home/newman/bind-9.16.3/config.h -I/home/newman/bind-9.16.3 -I../.. -I. -I/home/newman/bind-9.16.3/lib/dns/include -I../../lib/dns/include -I/home/newman/bind-9.16.3/lib/isc/include -I../../lib/isc -I../../lib/isc/include -I../../lib/isc/unix/include -I../../lib/isc/pthreads/include -I/home/newman/bind-9.16.3/lib/isccfg/include -I../../lib/isccfg/include -DISC_MEM_DEFAULTFILL=1 -DISC_LIST_CHECKINIT=1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -O1 -g -Wall -Wextra -pthread -I/usr/pkg/include -fPIC -W -Wall -Wmissing-prototypes -Wcast-qual -Wwrite-strings -Wformat -Wpointer-arith -Wno-missing-field-initializers -fno-strict-aliasing -Wshadow -Werror -c parser.c
--- parser.o ---
parser.c:1286:6: error: array subscript is of type 'char' [-Werror,-Wchar-subscripts]
if (toupper(TOKEN_STRING(pctx)[0]) == 'P') {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/sys/ctype_inline.h:60:46: note: expanded from macro 'toupper'
#define toupper(c) ((int)((_toupper_tab_ + 1)[(c)]))
^~~~
clang -include /home/newman/bind-9.16.3/config.h -I/home/newman/bind-9.16.3 -I../.. -I./include -I./unix/include -I. -I/home/newman/bind-9.16.3/lib/ns/include -I../../lib/ns/include -I/home/newman/bind-9.16.3/lib/dns/include -I../../lib/dns/include -I/home/newman/bind-9.16.3/lib/bind9/include -I../../lib/bind9/include -I/home/newman/bind-9.16.3/lib/isccfg/include -I../../lib/isccfg/include -I/home/newman/bind-9.16.3/lib/isccc/include -I../../lib/isccc/include -I/home/newman/bind-9.16.3/lib/isc/include -I../../lib/isc -I../../lib/isc/include -I../../lib/isc/unix/include -I../../lib/isc/pthreads/include -I../../contrib/dlz/drivers/include -I/usr/pkg/include/json-c -I/usr/pkg/include/libxml2 -DCONTRIB_DLZ -DDLZ_FILESYSTEM -DISC_MEM_DEFAULTFILL=1 -DISC_LIST_CHECKINIT=1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -O1 -g -Wall -Wextra -pthread -I/usr/pkg/include -fPIC -W -Wall -Wmissing-prototypes -Wcast-qual -Wwrite-strings -Wformat -Wpointer-arith -Wno-missing-field-initializers -fno-strict-aliasing -Wshadow -Werror -DVERSION=\"9.16.3\" -DPRODUCT=\""BIND"\" -DDESCRIPTION=\""(Stable Release)"\" -DSRCID=\"5ea41c1\" -DCONFIGARGS="\"'--disable-maintainer-mode' '--enable-developer' '--disable-static' '--with-cmocka' '--with-libxml2' '--with-json-c' '--without-make-clean' '--with-python=python3.7' '--disable-backtrace' '--disable-symtable' 'CC=clang' 'CFLAGS=-fno-omit-frame-pointer -fno-optimize-sibling-calls -O1 -g -Wall -Wextra'\"" -DBUILDER="\"make\"" -DNAMED_LOCALSTATEDIR=\"/usr/local/var\" -DNAMED_SYSCONFDIR=\"/usr/local/etc\" -c ./main.c
./main.c:358:8: error: array subscript is of type 'char' [-Werror,-Wchar-subscripts]
if (isalnum(*src) || *src == ',' || *src == '-' ||
^~~~~~~~~~~~~
/usr/include/sys/ctype_inline.h:48:44: note: expanded from macro 'isalnum'
#define isalnum(c) ((int)((_ctype_tab_ + 1)[(c)] & (_CTYPE_A|_CTYPE_D)))
^~~~
./main.c:362:15: error: array subscript is of type 'char' [-Werror,-Wchar-subscripts]
} else if (isprint(*src)) {
^~~~~~~~~~~~~
/usr/include/sys/ctype_inline.h:54:44: note: expanded from macro 'isprint'
#define isprint(c) ((int)((_ctype_tab_ + 1)[(c)] & _CTYPE_R))
^~~~
```
I fixed this by adding `(unsigned char)` before the parameter of failing macros:
- `toupper((unsigned char)TOKEN_STRING(pctx)[0]`
- `isalnum((unsigned char)*src)`
- `isprint((unsigned char)*src))`
There's also a `gen.c` linking problem:
```
clang -fno-omit-frame-pointer -fno-optimize-sibling-calls -O1 -g -Wall -Wextra -pthread -I/usr/pkg/include -fPIC -I../../lib/isc/include -Wl,-E -o gen ./gen.c -L/usr/pkg/lib -luv -lkvm -lrt -lpthread
make include/dns/enumtype.h
./gen -s . -t > include/dns/enumtype.h || { rm -f include/dns/enumtype.h ; exit 1; }
./gen: Shared object "libuv.so.1" not found
*** [include/dns/enumtype.h] Error code 1
```
I workedaround it with `LD_LIBRARY_PATH=/usr/pkg/lib make`, haven't look for a proper fix.June 2020 (9.11.20, 9.11.20-S1, 9.16.4, 9.17.2)Michal NowakMichal Nowakhttps://gitlab.isc.org/isc-projects/bind9/-/issues/1899TCP Accept Refactoring broke Windows2020-06-08T12:19:30ZOndřej SurýTCP Accept Refactoring broke WindowsThe !3320 that got merged to master broke TCP connections on Windows. This needs to be fixed on master (before we release next 9.17.2) and also before we merged the backport to the BIND 9.16 branch.The !3320 that got merged to master broke TCP connections on Windows. This needs to be fixed on master (before we release next 9.17.2) and also before we merged the backport to the BIND 9.16 branch.June 2020 (9.11.20, 9.11.20-S1, 9.16.4, 9.17.2)Witold KrecickiWitold Krecicki