- 02 Oct, 2020 13 commits
-
-
Matthijs Mekking authored
Resolve "dnssec-policy behaviour for algorithm 15 keys different to algorithm 8 keys" Closes #2171 See merge request isc-projects/bind9!4199
-
Matthijs Mekking authored
Sometimes, not all keys have been created in time before 'check_keys' is called. Run a 'retry_quiet' on checking the number of keys before continuing checking the key data.
-
Matthijs Mekking authored
The minimal size for RSASHA1, RSASHA256 is 512, but due to bad assignment it was set to 1024.
-
Matthijs Mekking authored
This test case is unrelated to the fix for #2171 but was added to reproduce the problem.
-
Matthijs Mekking authored
The 'wait_for_nsec' does not need to add TSIG because it calls 'dig_with_opts' and that already checks for TSIG.
-
Matthijs Mekking authored
This is a bug that needs to be noted.
-
Matthijs Mekking authored
The kasp code had bad implicit size values for the cryptographic algorithms Ed25519 and Ed448. When creating keys they would never match the dnssec-policy, leading to new attempts to create keys. These algorithms were previously not yet added to the system tests, due to lack of availability on some systems.
-
Matthijs Mekking authored
Use the testcrypto script to see if these algorithms are supported by openssl. If so, add the specific configuration to the named.conf file and touch a file to indicate support. If the file exists, the corresponding setup and tests are performed.
-
Michał Kępień authored
"rrset-order" fixes and cleanups Closes #2139 See merge request isc-projects/bind9!4195
-
Michał Kępień authored
-
Michał Kępień authored
Certain parts of the existing documentation for the "rrset-order" statement are incorrect, others are ambiguous. Rework the relevant section of the ARM to make it clear and up-to-date with the source code.
-
Michał Kępień authored
Make sure "order none" RRset ordering rules are tested in the "rrsetorder" system test just like all other rule types are. As the check for the case of no "rrset-order" rule matching a given RRset also tests "order none" (rather than "order random", as the test code may suggest at first glance), replace the test code for that case so that it matches other "order none" tests.
-
Michał Kępień authored
named-checkconf treats the following configuration as valid: options { rrset-order { order none; }; }; Yet, the above configuration causes named to crash on startup with: order.c:74: REQUIRE(mode == 0x00000800 || mode == 0x00000400 || mode == 0x00800000) failed, back trace Add DNS_RDATASETATTR_NONE to the list of RRset ordering modes accepted by dns_order_add() to allow "order none" to be used in "rrset-order" rules. This both prevents the aforementioned crashes and addresses the discrepancy between named-checkconf and named.
-
- 01 Oct, 2020 9 commits
-
-
Mark Andrews authored
Resolve "Allow task_test and rdata_tests subtests to be selected at runtime." Closes #2112 See merge request isc-projects/bind9!4059
-
Mark Andrews authored
-
Mark Andrews authored
-
Mark Andrews authored
task_test [-t <test_name>]
-
Mark Andrews authored
-
Mark Andrews authored
Merge branch '2191-missing-locks-when-accessing-keynode-initial-and-keynode-managed-triggering-tsan' into 'main' Resolve "Missing locks when accessing keynode.initial and keynode.managed triggered TSAN." Closes #2191 See merge request isc-projects/bind9!4205
-
Mark Andrews authored
WARNING: ThreadSanitizer: data race Write of size 1 at 0x000000000001 by thread T1 (mutexes: write M1): #0 dns_keynode_trust lib/dns/keytable.c:836 #1 keyfetch_done lib/dns/zone.c:10187 #2 dispatch lib/isc/task.c:1152 #3 run lib/isc/task.c:1344 #4 <null> <null> Previous read of size 1 at 0x000000000001 by thread T2 (mutexes: read M2): #0 keynode_dslist_totext lib/dns/keytable.c:682 #1 dns_keytable_totext lib/dns/keytable.c:732 #2 named_server_dumpsecroots bin/named/server.c:11357 #3 named_control_docommand bin/named/control.c:264 #4 control_command bin/named/controlconf.c:390 #5 dispatch lib/isc/task.c:1152 #6 run lib/isc/task.c:1344 #7 <null> <null> Location is heap block of size 241 at 0x000000000010 allocated by thread T3: #0 malloc <null> #1 default_memalloc lib/isc/mem.c:713 #2 mem_get lib/isc/mem.c:622 #3 mem_allocateunlocked lib/isc/mem.c:1268 #4 isc___mem_allocate lib/isc/mem.c:1288 #5 isc__mem_allocate lib/isc/mem.c:2453 #6 isc___mem_get lib/isc/mem.c:1037 #7 isc__mem_get lib/isc/mem.c:2432 #8 new_keynode lib/dns/keytable.c:346 #9 insert lib/dns/keytable.c:393 #10 dns_keytable_add lib/dns/keytable.c:421 #11 process_key bin/named/server.c:955 #12 load_view_keys bin/named/server.c:983 #13 configure_view_dnsseckeys bin/named/server.c:1140 #14 configure_view bin/named/server.c:5371 #15 load_configuration bin/named/server.c:9110 #16 loadconfig bin/named/server.c:10310 #17 named_server_reconfigcommand bin/named/server.c:10693 #18 named_control_docommand bin/named/control.c:250 #19 control_command bin/named/controlconf.c:390 #20 dispatch lib/isc/task.c:1152 #21 run lib/isc/task.c:1344 #22 <null> <null> Mutex M1 is already destroyed. Mutex M2 is already destroyed. Thread T1 (running) created by main thread at: #0 pthread_create <null> #1 isc_thread_create pthreads/thread.c:73 #2 isc_taskmgr_create lib/isc/task.c:1434 #3 create_managers bin/named/main.c:915 #4 setup bin/named/main.c:1223 #5 main bin/named/main.c:1523 Thread T2 (running) created by main thread at: #0 pthread_create <null> #1 isc_thread_create pthreads/thread.c:73 #2 isc_taskmgr_create lib/isc/task.c:1434 #3 create_managers bin/named/main.c:915 #4 setup bin/named/main.c:1223 #5 main bin/named/main.c:1523 Thread T3 (running) created by main thread at: #0 pthread_create <null> #1 isc_thread_create pthreads/thread.c:73 #2 isc_taskmgr_create lib/isc/task.c:1434 #3 create_managers bin/named/main.c:915 #4 setup bin/named/main.c:1223 #5 main bin/named/main.c:1523 SUMMARY: ThreadSanitizer: data race lib/dns/keytable.c:836 in dns_keynode_trust
-
Mark Andrews authored
Resolve "TSAN error accessing listener->connections" Closes #2192 See merge request isc-projects/bind9!4206
-
Mark Andrews authored
as it is accessed from multiple threads with libuv. WARNING: ThreadSanitizer: data race Write of size 8 at 0x000000000001 by thread T1: #0 conn_reset bin/named/controlconf.c:574 #1 isc_nmhandle_detach netmgr/netmgr.c:1257 #2 isc__nm_uvreq_put netmgr/netmgr.c:1389 #3 tcp_send_cb netmgr/tcp.c:1030 #4 <null> <null> #5 <null> <null> Previous read of size 8 at 0x000000000001 by thread T2: #0 conn_reset bin/named/controlconf.c:574 #1 isc_nmhandle_detach netmgr/netmgr.c:1257 #2 control_recvmessage bin/named/controlconf.c:556 #3 recv_data lib/isccc/ccmsg.c:110 #4 isc__nm_tcp_shutdown netmgr/tcp.c:1161 #5 shutdown_walk_cb netmgr/netmgr.c:1511 #6 uv_walk <null> #7 process_queue netmgr/netmgr.c:656 #8 process_normal_queue netmgr/netmgr.c:582 #9 process_queues netmgr/netmgr.c:590 #10 async_cb netmgr/netmgr.c:548 #11 <null> <null> #12 <null> <null> Location is heap block of size 265 at 0x000000000017 allocated by thread T3: #0 malloc <null> #1 default_memalloc lib/isc/mem.c:713 #2 mem_get lib/isc/mem.c:622 #3 isc___mem_get lib/isc/mem.c:1044 #4 isc__mem_get lib/isc/mem.c:2432 #5 add_listener bin/named/controlconf.c:1127 #6 named_controls_configure bin/named/controlconf.c:1324 #7 load_configuration bin/named/server.c:9181 #8 run_server bin/named/server.c:9819 #9 dispatch lib/isc/task.c:1152 #10 run lib/isc/task.c:1344 #11 <null> <null> Thread T1 (running) created by main thread at: #0 pthread_create <null> #1 isc_thread_create pthreads/thread.c:73 #2 isc_nm_start netmgr/netmgr.c:232 #3 create_managers bin/named/main.c:909 #4 setup bin/named/main.c:1223 #5 main bin/named/main.c:1523 Thread T2 (running) created by main thread at: #0 pthread_create <null> #1 isc_thread_create pthreads/thread.c:73 #2 isc_nm_start netmgr/netmgr.c:232 #3 create_managers bin/named/main.c:909 #4 setup bin/named/main.c:1223 #5 main bin/named/main.c:1523 Thread T3 (running) created by main thread at: #0 pthread_create <null> #1 isc_thread_create pthreads/thread.c:73 #2 isc_taskmgr_create lib/isc/task.c:1434 #3 create_managers bin/named/main.c:915 #4 setup bin/named/main.c:1223 #5 main bin/named/main.c:1523 SUMMARY: ThreadSanitizer: data race bin/named/controlconf.c:574 in conn_reset
-
- 30 Sep, 2020 15 commits
-
-
Ondřej Surý authored
Remove the .key from the beginning of the line in rst file See merge request isc-projects/bind9!4203
-
Ondřej Surý authored
The handling of . (dot) characted at the beginning of the line has changed between the sphinx-doc versions, and it was constantly giving us trouble when generating man pages when using different sphinx-doc. This commit just changes the source rst file, so there's no more . (dot) the beginning of the line.
-
Mark Andrews authored
Resolve "ThreadSanitizer: data race bin/named/server.c:9678:25 in view_loaded" Closes #2180 See merge request isc-projects/bind9!4167
-
Mark Andrews authored
WARNING: ThreadSanitizer: data race Write of size 4 at 0x000000000001 by thread T1: #0 view_loaded bin/named/server.c:9678:25 #1 call_loaddone lib/dns/zt.c:308:3 #2 doneloading lib/dns/zt.c:582:3 #3 zone_asyncload lib/dns/zone.c:2322:3 #4 dispatch lib/isc/task.c:1152:7 #5 run lib/isc/task.c:1344:2 Previous read of size 4 at 0x000000000001 by thread T2: #0 named_server_status bin/named/server.c:11903:14 #1 named_control_docommand bin/named/control.c:272:12 #2 control_command bin/named/controlconf.c:390:17 #3 dispatch lib/isc/task.c:1152:7 #4 run lib/isc/task.c:1344:2 Location is heap block of size 409 at 0x000000000011 allocated by main thread: #0 malloc <null> #1 default_memalloc lib/isc/mem.c:713:8 #2 mem_get lib/isc/mem.c:622:8 #3 mem_allocateunlocked lib/isc/mem.c:1268:8 #4 isc___mem_allocate lib/isc/mem.c:1288:7 #5 isc__mem_allocate lib/isc/mem.c:2453:10 #6 isc___mem_get lib/isc/mem.c:1037:11 #7 isc__mem_get lib/isc/mem.c:2432:10 #8 named_server_create bin/named/server.c:9978:27 #9 setup bin/named/main.c:1256:2 #10 main bin/named/main.c:1523:2 Thread T1 (running) created by main thread at: #0 pthread_create <null> #1 isc_thread_create lib/isc/pthreads/thread.c:73:8 #2 isc_taskmgr_create lib/isc/task.c:1434:3 #3 create_managers bin/named/main.c:915:11 #4 setup bin/named/main.c:1223:11 #5 main bin/named/main.c:1523:2 Thread T2 (running) created by main thread at: #0 pthread_create <null> #1 isc_thread_create lib/isc/pthreads/thread.c:73:8 #2 isc_taskmgr_create lib/isc/task.c:1434:3 #3 create_managers bin/named/main.c:915:11 #4 setup bin/named/main.c:1223:11 #5 main bin/named/main.c:1523:2 SUMMARY: ThreadSanitizer: data race bin/named/server.c:9678:25 in view_loaded
-
Mark Andrews authored
dig: print timestamps with microsecond precision if "-u" is used in YAML output mode Closes #2190 See merge request isc-projects/bind9!4193
-
Mark Andrews authored
-
Mark Andrews authored
-
Mark Andrews authored
-
Mark Andrews authored
Merge branch '2188-bug-in-message-c-673-ensure-isc_mempool_getallocated-msg-namepool-0-failed' into 'main' Resolve "Bug in message.c:673: ENSURE(isc_mempool_getallocated(msg->namepool) == 0) failed" Closes #2188 See merge request isc-projects/bind9!4189
-
Mark Andrews authored
-
Mark Andrews authored
-
Mark Andrews authored
The fuzzing harness operates on dns_message_t in non-standard ways and if 'sig0name' is non-NULL when msgresetsigs() and dns_message_renderreset() are called it should be cleaned up.
-
Mark Andrews authored
-
Ondřej Surý authored
regenerate ddns-confgen.8in See merge request isc-projects/bind9!4198
-
Mark Andrews authored
-
- 29 Sep, 2020 3 commits
-
-
Ondřej Surý authored
Resolve "Bind 9.16.6 Assertion failure message.c:4733: REQUIRE(msg->state == (-1)) failed" Closes #2124 See merge request isc-projects/bind9!4194
-
Ondřej Surý authored
-
Ondřej Surý authored
The dns_message_create() function cannot soft fail (as all memory allocations either succeed or cause abort), so we change the function to return void and cleanup the calls.
-