Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
D
DNS-Compliance-Testing
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
6
Issues
6
List
Boards
Labels
Service Desk
Milestones
Merge Requests
1
Merge Requests
1
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Incidents
Environments
Packages & Registries
Packages & Registries
Container Registry
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
ISC Open Source Projects
DNS-Compliance-Testing
Commits
3837a529
Commit
3837a529
authored
Sep 14, 2018
by
Mark Andrews
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
delay adding 'proxy'; print tsigerror on all rcodes if none zero
parent
34d19d0d
Pipeline
#4804
passed with stages
in 1 minute and 13 seconds
Changes
1
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
12 additions
and
5 deletions
+12
-5
genreport.c
genreport.c
+12
-5
No files found.
genreport.c
View file @
3837a529
...
...
@@ -1770,13 +1770,13 @@ process(struct workitem *item, unsigned char *buf, int buflen) {
char
name
[
1024
],
ns
[
1024
];
unsigned
int
i
,
id
,
qr
,
aa
,
tc
,
rd
,
ra
,
z
,
ad
,
cd
;
unsigned
int
qrcount
,
ancount
,
aucount
,
adcount
;
unsigned
int
opcode
,
rcode
,
tsigerror
;
unsigned
int
opcode
,
rcode
,
tsigerror
=
0
;
unsigned
int
ednssize
=
0
,
class
,
ednsttl
=
0
,
ttl
,
rdlen
;
unsigned
short
type
;
unsigned
char
*
cp
,
*
eom
;
int
seenopt
=
0
,
seensoa
=
0
,
seenrrsig
=
0
;
int
seennsid
=
0
,
seenecs
=
0
,
seenexpire
=
0
,
seencookie
=
0
;
int
seenecho
=
0
,
seentsig
=
0
;
int
seenecho
=
0
,
seentsig
=
0
,
proxy
=
0
,
addrcode
=
1
;
int
n
;
char
addrbuf
[
64
];
int
ednsvers
=
0
;
...
...
@@ -2185,6 +2185,8 @@ process(struct workitem *item, unsigned char *buf, int buflen) {
/*
* Restore original id.
*/
if
(
buf
[
0
]
!=
oid
[
0
]
||
buf
[
1
]
!=
oid
[
1
])
proxy
=
1
;
buf
[
0
]
=
oid
[
0
];
buf
[
1
]
=
oid
[
1
];
...
...
@@ -2309,15 +2311,18 @@ process(struct workitem *item, unsigned char *buf, int buflen) {
((
rcode
!=
0
&&
!
opts
[
item
->
test
].
cookie
)
||
(
rcode
!=
0
&&
(
rcode
!=
ns_r_badcookie
||
!
seencookie
)
&&
opts
[
item
->
test
].
cookie
)))
addtag
(
item
,
rcodetext
(
rcode
)),
ok
=
0
;
addtag
(
item
,
rcodetext
(
rcode
)),
ok
=
0
,
addrcode
=
0
;
/* Expect NOTIMP */
if
(
opts
[
item
->
test
].
opcode
!=
0
&&
rcode
!=
4
)
addtag
(
item
,
rcodetext
(
rcode
)),
ok
=
0
;
addtag
(
item
,
rcodetext
(
rcode
)),
ok
=
0
,
addrcode
=
0
;
}
/* Report the TSIG error if any */
if
(
seentsig
&&
rcode
==
ns_r_notauth
&&
tsigerror
!=
0
)
if
(
seentsig
&&
tsigerror
!=
0
)
{
if
(
addrcode
&&
rcode
!=
ns_r_notauth
)
addtag
(
item
,
rcodetext
(
rcode
)),
ok
=
0
;
addtag
(
item
,
tsigerrortext
(
tsigerror
)),
ok
=
0
;
}
/* Report if we didn't get a TSIG when we were expecting it */
if
(
strcmp
(
opts
[
item
->
test
].
name
,
"dnswkk"
)
==
0
&&
!
seentsig
)
...
...
@@ -2421,6 +2426,8 @@ process(struct workitem *item, unsigned char *buf, int buflen) {
}
if
(
seenecs
)
addtag
(
item
,
"subnet"
);
if
(
proxy
)
addtag
(
item
,
"proxy"
);
goto
done
;
err:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment