task.c 20 KB
Newer Older
Bob Halley's avatar
base  
Bob Halley committed
1

Bob Halley's avatar
Bob Halley committed
2 3
#include "attribute.h"

Bob Halley's avatar
base  
Bob Halley committed
4 5
#include <isc/assertions.h>

Bob Halley's avatar
Bob Halley committed
6
#include <isc/thread.h>
7 8
#include <isc/mutex.h>
#include <isc/condition.h>
Bob Halley's avatar
Bob Halley committed
9
#include <isc/unexpect.h>
Bob Halley's avatar
Bob Halley committed
10
#include <isc/task.h>
Bob Halley's avatar
base  
Bob Halley committed
11

Bob Halley's avatar
Bob Halley committed
12 13 14 15

/***
 *** General Macros.
 ***/
Bob Halley's avatar
base  
Bob Halley committed
16

Bob Halley's avatar
update  
Bob Halley committed
17
/*
Bob Halley's avatar
Bob Halley committed
18
 * We use macros instead of calling the routines directly because
Bob Halley's avatar
update  
Bob Halley committed
19 20 21 22
 * the capital letters make the locking stand out.
 *
 * We INSIST that they succeed since there's no way for us to continue
 * if they fail.
Bob Halley's avatar
update  
Bob Halley committed
23
 */
Bob Halley's avatar
Bob Halley committed
24 25 26 27 28 29 30

#define LOCK(lp) \
	INSIST(isc_mutex_lock((lp)) == ISC_R_SUCCESS);
#define UNLOCK(lp) \
	INSIST(isc_mutex_unlock((lp)) == ISC_R_SUCCESS);
#define BROADCAST(cvp) \
	INSIST(isc_condition_broadcast((cvp)) == ISC_R_SUCCESS);
31 32
#define SIGNAL(cvp) \
	INSIST(isc_condition_signal((cvp)) == ISC_R_SUCCESS);
Bob Halley's avatar
Bob Halley committed
33 34 35 36 37
#define WAIT(cvp, lp) \
	INSIST(isc_condition_wait((cvp), (lp)) == ISC_R_SUCCESS);
#define WAITUNTIL(cvp, lp, tp, bp) \
	INSIST(isc_condition_waituntil((cvp), (lp), (tp), (bp)) == \
	ISC_R_SUCCESS);
Bob Halley's avatar
base  
Bob Halley committed
38

Bob Halley's avatar
Bob Halley committed
39
#ifdef ISC_TASK_TRACE
Bob Halley's avatar
update  
Bob Halley committed
40
#define XTRACE(m)		printf("%s task %p thread %lu\n", (m), \
Bob Halley's avatar
Bob Halley committed
41
				       task, isc_thread_self())
Bob Halley's avatar
Bob Halley committed
42 43 44
#else
#define XTRACE(m)
#endif
Bob Halley's avatar
base  
Bob Halley committed
45

Bob Halley's avatar
Bob Halley committed
46 47

/***
Bob Halley's avatar
Bob Halley committed
48
 *** Types.
Bob Halley's avatar
Bob Halley committed
49 50
 ***/

Bob Halley's avatar
Bob Halley committed
51 52 53 54 55 56 57 58 59
typedef enum {
	task_state_idle, task_state_ready, task_state_running,
	task_state_shutdown
} task_state_t;

#define TASK_MAGIC			0x5441534BU	/* TASK. */
#define VALID_TASK(t)			((t) != NULL && \
					 (t)->magic == TASK_MAGIC)

Bob Halley's avatar
Bob Halley committed
60
struct isc_task {
Bob Halley's avatar
Bob Halley committed
61 62
	/* Not locked. */
	unsigned int			magic;
Bob Halley's avatar
Bob Halley committed
63
	isc_taskmgr_t			manager;
Bob Halley's avatar
Bob Halley committed
64
	isc_mutex_t			lock;
Bob Halley's avatar
Bob Halley committed
65 66 67
	/* Locked by task lock. */
	task_state_t			state;
	unsigned int			references;
Bob Halley's avatar
Bob Halley committed
68
	isc_eventlist_t			events;
Bob Halley's avatar
Bob Halley committed
69
	unsigned int			quantum;
Bob Halley's avatar
Bob Halley committed
70
	isc_boolean_t			enqueue_allowed;
Bob Halley's avatar
Bob Halley committed
71
	isc_event_t			shutdown_event;
Bob Halley's avatar
Bob Halley committed
72
	/* Locked by task manager lock. */
Bob Halley's avatar
Bob Halley committed
73 74
	LINK(struct isc_task)		link;
	LINK(struct isc_task)		ready_link;
Bob Halley's avatar
Bob Halley committed
75 76 77 78 79 80
};

#define TASK_MANAGER_MAGIC		0x54534B4DU	/* TSKM. */
#define VALID_MANAGER(m)		((m) != NULL && \
					 (m)->magic == TASK_MANAGER_MAGIC)

Bob Halley's avatar
Bob Halley committed
81
struct isc_taskmgr {
Bob Halley's avatar
Bob Halley committed
82 83
	/* Not locked. */
	unsigned int			magic;
Bob Halley's avatar
Bob Halley committed
84
	isc_memctx_t			mctx;
Bob Halley's avatar
Bob Halley committed
85
	isc_mutex_t			lock;
86 87
	unsigned int			workers;
	isc_thread_t *			threads;
Bob Halley's avatar
Bob Halley committed
88 89
	/* Locked by task manager lock. */
	unsigned int			default_quantum;
Bob Halley's avatar
Bob Halley committed
90 91
	LIST(struct isc_task)		tasks;
	LIST(struct isc_task)		ready_tasks;
Bob Halley's avatar
Bob Halley committed
92
	isc_condition_t			work_available;
Bob Halley's avatar
Bob Halley committed
93
	isc_boolean_t			exiting;
Bob Halley's avatar
Bob Halley committed
94
};
Bob Halley's avatar
Bob Halley committed
95

Bob Halley's avatar
Bob Halley committed
96 97
#define DEFAULT_DEFAULT_QUANTUM		5
#define FINISHED(m)			((m)->exiting && EMPTY((m)->tasks))
Bob Halley's avatar
Bob Halley committed
98

Bob Halley's avatar
update  
Bob Halley committed
99 100 101 102 103

/***
 *** Events.
 ***/

Bob Halley's avatar
Bob Halley committed
104
static inline isc_event_t
Bob Halley's avatar
Bob Halley committed
105
event_allocate(isc_memctx_t mctx, void *sender, isc_eventtype_t type,
Bob Halley's avatar
Bob Halley committed
106
	       isc_taskaction_t action, void *arg, size_t size)
Bob Halley's avatar
update  
Bob Halley committed
107
{
Bob Halley's avatar
Bob Halley committed
108
	isc_event_t event;
Bob Halley's avatar
update  
Bob Halley committed
109

Bob Halley's avatar
Bob Halley committed
110
	event = isc_mem_get(mctx, size);
Bob Halley's avatar
update  
Bob Halley committed
111 112 113 114
	if (event == NULL)
		return (NULL);
	event->mctx = mctx;
	event->size = size;
Bob Halley's avatar
Bob Halley committed
115
	event->sender = sender;
Bob Halley's avatar
update  
Bob Halley committed
116 117 118 119 120 121 122
	event->type = type;
	event->action = action;
	event->arg = arg;

	return (event);
}

Bob Halley's avatar
Bob Halley committed
123
isc_event_t
Bob Halley's avatar
Bob Halley committed
124 125
isc_event_allocate(isc_memctx_t mctx, void *sender, isc_eventtype_t type,
		   isc_taskaction_t action, void *arg, size_t size)
Bob Halley's avatar
update  
Bob Halley committed
126
{
Bob Halley's avatar
Bob Halley committed
127
	if (size < sizeof (struct isc_event))
Bob Halley's avatar
update  
Bob Halley committed
128 129 130 131 132 133
		return (NULL);
	if (type < 0)
		return (NULL);
	if (action == NULL)
		return (NULL);

Bob Halley's avatar
Bob Halley committed
134
	return (event_allocate(mctx, sender, type, action, arg, size));
Bob Halley's avatar
update  
Bob Halley committed
135 136 137
}

void
Bob Halley's avatar
Bob Halley committed
138 139
isc_event_free(isc_event_t *eventp) {
	isc_event_t event;
Bob Halley's avatar
update  
Bob Halley committed
140 141 142 143 144
	
	REQUIRE(eventp != NULL);
	event = *eventp;
	REQUIRE(event != NULL);

Bob Halley's avatar
Bob Halley committed
145 146
	if (event->destroy != NULL)
		(event->destroy)(event);
Bob Halley's avatar
Bob Halley committed
147
	isc_mem_put(event->mctx, event, event->size);
Bob Halley's avatar
update  
Bob Halley committed
148 149 150 151

	*eventp = NULL;
}

Bob Halley's avatar
base  
Bob Halley committed
152 153 154 155 156
/***
 *** Tasks.
 ***/

static void
Bob Halley's avatar
Bob Halley committed
157 158
task_free(isc_task_t task) {
	isc_taskmgr_t manager = task->manager;
Bob Halley's avatar
base  
Bob Halley committed
159

Bob Halley's avatar
Bob Halley committed
160
	XTRACE("free task");
Bob Halley's avatar
base  
Bob Halley committed
161 162 163 164 165 166 167 168 169 170 171 172 173 174
	REQUIRE(EMPTY(task->events));

	LOCK(&manager->lock);
	UNLINK(manager->tasks, task, link);
	if (FINISHED(manager)) {
		/*
		 * All tasks have completed and the
		 * task manager is exiting.  Wake up
		 * any idle worker threads so they
		 * can exit.
		 */
		BROADCAST(&manager->work_available);
	}
	UNLOCK(&manager->lock);
Bob Halley's avatar
Bob Halley committed
175
	(void)isc_mutex_destroy(&task->lock);
Bob Halley's avatar
update  
Bob Halley committed
176
	if (task->shutdown_event != NULL)
Bob Halley's avatar
Bob Halley committed
177
		isc_event_free(&task->shutdown_event);
Bob Halley's avatar
base  
Bob Halley committed
178
	task->magic = 0;
Bob Halley's avatar
Bob Halley committed
179
	isc_mem_put(manager->mctx, task, sizeof *task);
Bob Halley's avatar
base  
Bob Halley committed
180 181
}

Bob Halley's avatar
Bob Halley committed
182
isc_result_t
Bob Halley's avatar
Bob Halley committed
183 184
isc_task_create(isc_taskmgr_t manager, isc_taskaction_t shutdown_action,
		void *shutdown_arg, unsigned int quantum, isc_task_t *taskp)
Bob Halley's avatar
Bob Halley committed
185
{
Bob Halley's avatar
Bob Halley committed
186
	isc_task_t task;
Bob Halley's avatar
base  
Bob Halley committed
187 188 189 190

	REQUIRE(VALID_MANAGER(manager));
	REQUIRE(taskp != NULL && *taskp == NULL);

Bob Halley's avatar
Bob Halley committed
191
	task = isc_mem_get(manager->mctx, sizeof *task);
Bob Halley's avatar
base  
Bob Halley committed
192
	if (task == NULL)
Bob Halley's avatar
Bob Halley committed
193
		return (ISC_R_NOMEMORY);
Bob Halley's avatar
base  
Bob Halley committed
194 195 196

	task->magic = TASK_MAGIC;
	task->manager = manager;
Bob Halley's avatar
Bob Halley committed
197
	if (isc_mutex_init(&task->lock) != ISC_R_SUCCESS) {
Bob Halley's avatar
Bob Halley committed
198
		isc_mem_put(manager->mctx, task, sizeof *task);
Bob Halley's avatar
Bob Halley committed
199 200 201
		UNEXPECTED_ERROR(__FILE__, __LINE__,
				 "isc_mutex_init() failed");
		return (ISC_R_UNEXPECTED);
Bob Halley's avatar
update  
Bob Halley committed
202
	}
Bob Halley's avatar
base  
Bob Halley committed
203 204 205 206
	task->state = task_state_idle;
	task->references = 1;
	INIT_LIST(task->events);
	task->quantum = quantum;
Bob Halley's avatar
Bob Halley committed
207
	task->enqueue_allowed = ISC_TRUE;
Bob Halley's avatar
update  
Bob Halley committed
208
	task->shutdown_event = event_allocate(manager->mctx,
Bob Halley's avatar
Bob Halley committed
209
					      NULL,
Bob Halley's avatar
Bob Halley committed
210
					      ISC_TASKEVENT_SHUTDOWN,
Bob Halley's avatar
update  
Bob Halley committed
211 212 213 214
					      shutdown_action,
					      shutdown_arg,
					      sizeof *task->shutdown_event);
	if (task->shutdown_event == NULL) {
Bob Halley's avatar
Bob Halley committed
215
		(void)isc_mutex_destroy(&task->lock);
Bob Halley's avatar
Bob Halley committed
216
		isc_mem_put(manager->mctx, task, sizeof *task);
Bob Halley's avatar
Bob Halley committed
217
		return (ISC_R_NOMEMORY);
Bob Halley's avatar
update  
Bob Halley committed
218
	}
Bob Halley's avatar
base  
Bob Halley committed
219 220 221 222 223 224 225 226 227 228 229
	INIT_LINK(task, link);
	INIT_LINK(task, ready_link);

	LOCK(&manager->lock);
	if (task->quantum == 0)
		task->quantum = manager->default_quantum;
	APPEND(manager->tasks, task, link);
	UNLOCK(&manager->lock);

	*taskp = task;

Bob Halley's avatar
Bob Halley committed
230
	return (ISC_R_SUCCESS);
Bob Halley's avatar
base  
Bob Halley committed
231 232
}

Bob Halley's avatar
update  
Bob Halley committed
233
void
Bob Halley's avatar
Bob Halley committed
234
isc_task_attach(isc_task_t task, isc_task_t *taskp) {
Bob Halley's avatar
base  
Bob Halley committed
235 236 237 238 239 240 241 242 243 244 245

	REQUIRE(VALID_TASK(task));
	REQUIRE(taskp != NULL && *taskp == NULL);

	LOCK(&task->lock);
	task->references++;
	UNLOCK(&task->lock);

	*taskp = task;
}

Bob Halley's avatar
Bob Halley committed
246
void
Bob Halley's avatar
Bob Halley committed
247
isc_task_detach(isc_task_t *taskp) {
Bob Halley's avatar
Bob Halley committed
248
	isc_boolean_t free_task = ISC_FALSE;
Bob Halley's avatar
Bob Halley committed
249
	isc_task_t task;
Bob Halley's avatar
base  
Bob Halley committed
250

Bob Halley's avatar
Bob Halley committed
251
	XTRACE("isc_task_detach");
Bob Halley's avatar
base  
Bob Halley committed
252 253 254 255 256 257 258 259

	REQUIRE(taskp != NULL);
	task = *taskp;
	REQUIRE(VALID_TASK(task));

	LOCK(&task->lock);
	REQUIRE(task->references > 0);
	task->references--;
260
	if (task->state == task_state_shutdown && task->references == 0)
Bob Halley's avatar
Bob Halley committed
261
		free_task = ISC_TRUE;
Bob Halley's avatar
base  
Bob Halley committed
262 263 264 265 266 267 268 269
	UNLOCK(&task->lock);

	if (free_task)
		task_free(task);

	*taskp = NULL;
}

Bob Halley's avatar
Bob Halley committed
270
void
Bob Halley's avatar
Bob Halley committed
271
isc_task_send(isc_task_t task, isc_event_t *eventp) {
Bob Halley's avatar
Bob Halley committed
272 273
	isc_boolean_t was_idle = ISC_FALSE;
	isc_boolean_t discard = ISC_FALSE;
Bob Halley's avatar
Bob Halley committed
274
	isc_event_t event;
Bob Halley's avatar
base  
Bob Halley committed
275 276

	REQUIRE(VALID_TASK(task));
Bob Halley's avatar
update  
Bob Halley committed
277 278
	REQUIRE(eventp != NULL);
	event = *eventp;
Bob Halley's avatar
base  
Bob Halley committed
279
	REQUIRE(event != NULL);
Bob Halley's avatar
Bob Halley committed
280 281
	REQUIRE(event->sender != NULL);
	REQUIRE(event->type > 0);
Bob Halley's avatar
base  
Bob Halley committed
282

Bob Halley's avatar
Bob Halley committed
283
	XTRACE("sending");
Bob Halley's avatar
base  
Bob Halley committed
284 285 286 287 288 289
	/*
	 * We're trying hard to hold locks for as short a time as possible.
	 * We're also trying to hold as few locks as possible.  This is why
	 * some processing is deferred until after a lock is released.
	 */
	LOCK(&task->lock);
Bob Halley's avatar
update  
Bob Halley committed
290
	if (task->enqueue_allowed) {
Bob Halley's avatar
base  
Bob Halley committed
291
		if (task->state == task_state_idle) {
Bob Halley's avatar
Bob Halley committed
292
			was_idle = ISC_TRUE;
Bob Halley's avatar
base  
Bob Halley committed
293 294 295 296 297 298 299
			INSIST(EMPTY(task->events));
			task->state = task_state_ready;
		}
		INSIST(task->state == task_state_ready ||
		       task->state == task_state_running);
		ENQUEUE(task->events, event, link);
	} else
Bob Halley's avatar
Bob Halley committed
300
		discard = ISC_TRUE;
Bob Halley's avatar
base  
Bob Halley committed
301 302 303
	UNLOCK(&task->lock);

	if (discard) {
Bob Halley's avatar
Bob Halley committed
304
		isc_event_free(&event);
Bob Halley's avatar
update  
Bob Halley committed
305
		*eventp = NULL;
Bob Halley's avatar
Bob Halley committed
306
		return;
Bob Halley's avatar
base  
Bob Halley committed
307 308 309
	}

	if (was_idle) {
Bob Halley's avatar
Bob Halley committed
310
		isc_taskmgr_t manager;
Bob Halley's avatar
base  
Bob Halley committed
311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334

		/*
		 * We need to add this task to the ready queue.
		 *
		 * We've waited until now to do it, rather than doing it
		 * while holding the task lock, because we don't want to
		 * block while holding the task lock.
		 *
		 * We've changed the state to ready, so no one else will
		 * be trying to add this task to the ready queue.  It
		 * thus doesn't matter if more events have been added to
		 * the queue after we gave up the task lock.
		 *
		 * Shutting down a task requires posting a shutdown event
		 * to the task's queue and then executing it, so there's
		 * no way the task can disappear.  A task is always on the
		 * task manager's 'tasks' list, so the task manager can
		 * always post a shutdown event to all tasks if it is
		 * requested to shutdown.
		 */
		manager = task->manager;
		INSIST(VALID_MANAGER(manager));
		LOCK(&manager->lock);
		ENQUEUE(manager->ready_tasks, task, ready_link);
335
		SIGNAL(&manager->work_available);
Bob Halley's avatar
base  
Bob Halley committed
336 337 338
		UNLOCK(&manager->lock);
	}

Bob Halley's avatar
update  
Bob Halley committed
339 340
	*eventp = NULL;

Bob Halley's avatar
Bob Halley committed
341
	XTRACE("sent");
Bob Halley's avatar
base  
Bob Halley committed
342 343
}

Bob Halley's avatar
Bob Halley committed
344
void
Bob Halley's avatar
Bob Halley committed
345 346 347
isc_task_purge(isc_task_t task, void *sender, isc_eventtype_t type) {
	isc_event_t event, next_event;
	isc_eventlist_t purgeable;
Bob Halley's avatar
Bob Halley committed
348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376

	REQUIRE(VALID_TASK(task));
	REQUIRE(type >= 0);

	/*
	 * Purge events matching 'sender' and 'type'.  sender == NULL means
	 * "any sender".  type == NULL means any type.  Task manager events
	 * cannot be purged.
	 */

	INIT_LIST(purgeable);

	LOCK(&task->lock);
	for (event = HEAD(task->events);
	     event != NULL;
	     event = next_event) {
		next_event = NEXT(event, link);
		if ((sender == NULL || event->sender == sender) &&
		    ((type == 0 && event->type > 0) || event->type == type)) {
			DEQUEUE(task->events, event, link);
			ENQUEUE(purgeable, event, link);
		}
	}
	UNLOCK(&task->lock);

	for (event = HEAD(purgeable);
	     event != NULL;
	     event = next_event) {
		next_event = NEXT(event, link);
Bob Halley's avatar
Bob Halley committed
377
		isc_event_free(&event);
Bob Halley's avatar
Bob Halley committed
378 379 380
	}
}

Bob Halley's avatar
Bob Halley committed
381
void
Bob Halley's avatar
Bob Halley committed
382
isc_task_shutdown(isc_task_t task) {
Bob Halley's avatar
Bob Halley committed
383 384
	isc_boolean_t was_idle = ISC_FALSE;
	isc_boolean_t discard = ISC_FALSE;
Bob Halley's avatar
base  
Bob Halley committed
385 386 387 388

	REQUIRE(VALID_TASK(task));

	/*
389
	 * This routine is very similar to isc_task_send() above.
Bob Halley's avatar
base  
Bob Halley committed
390 391 392
	 */

	LOCK(&task->lock);
Bob Halley's avatar
update  
Bob Halley committed
393
	if (task->enqueue_allowed) {
Bob Halley's avatar
base  
Bob Halley committed
394
		if (task->state == task_state_idle) {
Bob Halley's avatar
Bob Halley committed
395
			was_idle = ISC_TRUE;
Bob Halley's avatar
base  
Bob Halley committed
396 397 398 399 400
			INSIST(EMPTY(task->events));
			task->state = task_state_ready;
		}
		INSIST(task->state == task_state_ready ||
		       task->state == task_state_running);
Bob Halley's avatar
update  
Bob Halley committed
401 402 403
		INSIST(task->shutdown_event != NULL);
		ENQUEUE(task->events, task->shutdown_event, link);
		task->shutdown_event = NULL;
Bob Halley's avatar
Bob Halley committed
404
		task->enqueue_allowed = ISC_FALSE;
Bob Halley's avatar
base  
Bob Halley committed
405
	} else
Bob Halley's avatar
Bob Halley committed
406
		discard = ISC_TRUE;
Bob Halley's avatar
base  
Bob Halley committed
407 408
	UNLOCK(&task->lock);

Bob Halley's avatar
Bob Halley committed
409
	if (discard)
Bob Halley's avatar
Bob Halley committed
410
		return;
Bob Halley's avatar
base  
Bob Halley committed
411 412

	if (was_idle) {
Bob Halley's avatar
Bob Halley committed
413
		isc_taskmgr_t manager;
Bob Halley's avatar
base  
Bob Halley committed
414 415 416 417 418

		manager = task->manager;
		INSIST(VALID_MANAGER(manager));
		LOCK(&manager->lock);
		ENQUEUE(manager->ready_tasks, task, ready_link);
419
		SIGNAL(&manager->work_available);
Bob Halley's avatar
base  
Bob Halley committed
420 421
		UNLOCK(&manager->lock);
	}
Bob Halley's avatar
Bob Halley committed
422
}
Bob Halley's avatar
base  
Bob Halley committed
423

Bob Halley's avatar
Bob Halley committed
424
void
Bob Halley's avatar
Bob Halley committed
425
isc_task_destroy(isc_task_t *taskp) {
Bob Halley's avatar
Bob Halley committed
426 427 428

	REQUIRE(taskp != NULL);

Bob Halley's avatar
Bob Halley committed
429 430
	isc_task_shutdown(*taskp);
	isc_task_detach(taskp);
Bob Halley's avatar
base  
Bob Halley committed
431 432 433
}


Bob Halley's avatar
Bob Halley committed
434

Bob Halley's avatar
base  
Bob Halley committed
435 436 437 438
/***
 *** Task Manager.
 ***/

Bob Halley's avatar
update  
Bob Halley committed
439
static isc_threadresult_t
Bob Halley's avatar
Bob Halley committed
440 441 442
#ifdef _WIN32
WINAPI
#endif
Bob Halley's avatar
update  
Bob Halley committed
443
run(void *uap) {
Bob Halley's avatar
Bob Halley committed
444 445
	isc_taskmgr_t manager = uap;
	isc_task_t task;
Bob Halley's avatar
base  
Bob Halley committed
446

Bob Halley's avatar
Bob Halley committed
447
	XTRACE("start");
Bob Halley's avatar
base  
Bob Halley committed
448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504

	REQUIRE(VALID_MANAGER(manager));

	/*
	 * Again we're trying to hold the lock for as short a time as possible
	 * and to do as little locking and unlocking as possible.
	 * 
	 * In both while loops, the appropriate lock must be held before the
	 * while body starts.  Code which acquired the lock at the top of
	 * the loop would be more readable, but would result in a lot of
	 * extra locking.  Compare:
	 *
	 * Straightforward:
	 *
	 *	LOCK();
	 *	...
	 *	UNLOCK();
	 *	while (expression) {
	 *		LOCK();
	 *		...
	 *		UNLOCK();
	 *
	 *	       	Unlocked part here...
	 *
	 *		LOCK();
	 *		...
	 *		UNLOCK();
	 *	}
	 *
	 * Note how if the loop continues we unlock and then immediately lock.
	 * For N iterations of the loop, this code does 2N+1 locks and 2N+1
	 * unlocks.  Also note that the lock is not held when the while
	 * condition is tested, which may or may not be important, depending
	 * on the expression.
	 * 
	 * As written:
	 *
	 *	LOCK();
	 *	while (expression) {
	 *		...
	 *		UNLOCK();
	 *
	 *	       	Unlocked part here...
	 *
	 *		LOCK();
	 *		...
	 *	}
	 *	UNLOCK();
	 *
	 * For N iterations of the loop, this code does N+1 locks and N+1
	 * unlocks.  The while expression is always protected by the lock.
	 */

	LOCK(&manager->lock);
	while (!FINISHED(manager)) {
		/*
		 * For reasons similar to those given in the comment in
505
		 * isc_task_send() above, it is safe for us to dequeue
Bob Halley's avatar
base  
Bob Halley committed
506 507 508 509 510
		 * the task while only holding the manager lock, and then
		 * change the task to running state while only holding the
		 * task lock.
		 */
		while (EMPTY(manager->ready_tasks) && !FINISHED(manager)) {
Bob Halley's avatar
Bob Halley committed
511
			XTRACE("wait");
Bob Halley's avatar
base  
Bob Halley committed
512
			WAIT(&manager->work_available, &manager->lock);
Bob Halley's avatar
Bob Halley committed
513
			XTRACE("awake");
Bob Halley's avatar
base  
Bob Halley committed
514
		}
Bob Halley's avatar
Bob Halley committed
515
		XTRACE("working");
Bob Halley's avatar
base  
Bob Halley committed
516 517 518
		
		task = HEAD(manager->ready_tasks);
		if (task != NULL) {
Bob Halley's avatar
Bob Halley committed
519
			unsigned int dispatch_count = 0;
Bob Halley's avatar
Bob Halley committed
520 521 522 523 524
			isc_boolean_t done = ISC_FALSE;
			isc_boolean_t requeue = ISC_FALSE;
			isc_boolean_t wants_shutdown;
			isc_boolean_t is_shutdown;
			isc_boolean_t free_task = ISC_FALSE;
Bob Halley's avatar
Bob Halley committed
525 526
			isc_event_t event;
			isc_eventlist_t remaining_events;
Bob Halley's avatar
Bob Halley committed
527
			isc_boolean_t discard_remaining = ISC_FALSE;
Bob Halley's avatar
base  
Bob Halley committed
528 529 530 531 532 533 534 535 536 537 538 539

			INSIST(VALID_TASK(task));

			/*
			 * Note we only unlock the manager lock if we actually
			 * have a task to do.  We must reacquire the manager 
			 * lock before exiting the 'if (task != NULL)' block.
			 */
			DEQUEUE(manager->ready_tasks, task, ready_link);
			UNLOCK(&manager->lock);

			LOCK(&task->lock);
Bob Halley's avatar
Bob Halley committed
540 541 542 543 544 545 546 547
			INSIST(task->state == task_state_ready);
			if (EMPTY(task->events)) {
				/*
				 * The task became runnable, but all events
				 * in the run queue were subsequently purged.
				 * Put the task to sleep.
				 */
				task->state = task_state_idle;
Bob Halley's avatar
Bob Halley committed
548
				done = ISC_TRUE;
Bob Halley's avatar
Bob Halley committed
549 550 551
				XTRACE("ready but empty");
			} else
				task->state = task_state_running;
Bob Halley's avatar
base  
Bob Halley committed
552
			while (!done) {
Bob Halley's avatar
update  
Bob Halley committed
553 554 555
				INSIST(!EMPTY(task->events));
				event = HEAD(task->events);
				DEQUEUE(task->events, event, link);
Bob Halley's avatar
base  
Bob Halley committed
556 557
				UNLOCK(&task->lock);

Bob Halley's avatar
Bob Halley committed
558
				if (event->type == ISC_TASKEVENT_SHUTDOWN)
Bob Halley's avatar
Bob Halley committed
559
					is_shutdown = ISC_TRUE;
Bob Halley's avatar
update  
Bob Halley committed
560
				else
Bob Halley's avatar
Bob Halley committed
561
					is_shutdown = ISC_FALSE;
Bob Halley's avatar
update  
Bob Halley committed
562

Bob Halley's avatar
base  
Bob Halley committed
563 564 565
				/*
				 * Execute the event action.
				 */
Bob Halley's avatar
Bob Halley committed
566
				XTRACE("execute action");
Bob Halley's avatar
update  
Bob Halley committed
567 568 569
				if (event->action != NULL)
					wants_shutdown =
						(event->action)(task, event);
Bob Halley's avatar
base  
Bob Halley committed
570
				else
Bob Halley's avatar
Bob Halley committed
571
					wants_shutdown = ISC_FALSE;
Bob Halley's avatar
Bob Halley committed
572
				dispatch_count++;
Bob Halley's avatar
update  
Bob Halley committed
573
				
Bob Halley's avatar
base  
Bob Halley committed
574
				LOCK(&task->lock);
Bob Halley's avatar
update  
Bob Halley committed
575
				if (wants_shutdown || is_shutdown) {
Bob Halley's avatar
Bob Halley committed
576
					/*
Bob Halley's avatar
update  
Bob Halley committed
577 578 579 580
					 * The event action has either
					 * requested shutdown, or the event
					 * we just executed was the shutdown
					 * event.
Bob Halley's avatar
Bob Halley committed
581 582 583 584 585 586 587 588
					 *
					 * Since no more events can be
					 * delivered to the task, we purge
					 * any remaining events (but defer
					 * freeing them until we've released
					 * the lock).
					 */
					XTRACE("wants shutdown");
Bob Halley's avatar
base  
Bob Halley committed
589 590 591 592
					if (!EMPTY(task->events)) {
						remaining_events =
							task->events;
						INIT_LIST(task->events);
Bob Halley's avatar
Bob Halley committed
593
						discard_remaining = ISC_TRUE;
Bob Halley's avatar
base  
Bob Halley committed
594 595
					}
					if (task->references == 0)
Bob Halley's avatar
Bob Halley committed
596
						free_task = ISC_TRUE;
Bob Halley's avatar
Bob Halley committed
597
					task->state = task_state_shutdown;
Bob Halley's avatar
Bob Halley committed
598 599
					task->enqueue_allowed = ISC_FALSE;
					done = ISC_TRUE;
Bob Halley's avatar
update  
Bob Halley committed
600
				} else if (EMPTY(task->events)) {
Bob Halley's avatar
Bob Halley committed
601 602 603
					/*
					 * Nothing else to do for this task.
					 * Put it to sleep.
Bob Halley's avatar
Bob Halley committed
604 605 606
					 *
					 * XXX detect tasks with 0 references
					 * and do something about them.
Bob Halley's avatar
Bob Halley committed
607
					 */
Bob Halley's avatar
Bob Halley committed
608
					XTRACE("empty");
Bob Halley's avatar
base  
Bob Halley committed
609
					task->state = task_state_idle;
Bob Halley's avatar
Bob Halley committed
610
					done = ISC_TRUE;
Bob Halley's avatar
base  
Bob Halley committed
611 612 613 614 615 616 617 618 619 620 621
				} else if (dispatch_count >= task->quantum) {
					/*
					 * Our quantum has expired, but
					 * there is more work to be done.
					 * We'll requeue it to the ready
					 * queue later.
					 *
					 * We don't check quantum until
					 * dispatching at least one event,
					 * so the minimum quantum is one.
					 */
Bob Halley's avatar
Bob Halley committed
622
					XTRACE("quantum");
Bob Halley's avatar
base  
Bob Halley committed
623
					task->state = task_state_ready;
Bob Halley's avatar
Bob Halley committed
624 625
					requeue = ISC_TRUE;
					done = ISC_TRUE;
Bob Halley's avatar
base  
Bob Halley committed
626 627 628 629 630
				}
			}
			UNLOCK(&task->lock);

			if (discard_remaining) {
Bob Halley's avatar
Bob Halley committed
631
				isc_event_t next_event;
Bob Halley's avatar
base  
Bob Halley committed
632 633 634 635 636

				for (event = HEAD(remaining_events);
				     event != NULL;
				     event = next_event) {
					next_event = NEXT(event, link);
Bob Halley's avatar
Bob Halley committed
637
					isc_event_free(&event);
Bob Halley's avatar
base  
Bob Halley committed
638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671
				}
			}

			if (free_task)
				task_free(task);

			LOCK(&manager->lock);
			if (requeue) {
				/*
				 * We know we're awake, so we don't have
				 * to wakeup any sleeping threads if the
				 * ready queue is empty before we requeue.
				 *
				 * A possible optimization if the queue is
				 * empty is to 'goto' the 'if (task != NULL)'
				 * block, avoiding the ENQUEUE of the task
				 * and the subsequent immediate DEQUEUE
				 * (since it is the only executable task).
				 * We don't do this because then we'd be
				 * skipping the exit_requested check.  The
				 * cost of ENQUEUE is low anyway, especially
				 * when you consider that we'd have to do
				 * an extra EMPTY check to see if we could
				 * do the optimization.  If the ready queue
				 * were usually nonempty, the 'optimization'
				 * might even hurt rather than help.
				 */
				ENQUEUE(manager->ready_tasks, task,
					ready_link);
			}
		}
	}
	UNLOCK(&manager->lock);

Bob Halley's avatar
Bob Halley committed
672
	XTRACE("exit");
Bob Halley's avatar
base  
Bob Halley committed
673

Bob Halley's avatar
update  
Bob Halley committed
674
	return ((isc_threadresult_t)0);
Bob Halley's avatar
base  
Bob Halley committed
675 676 677
}

static void
Bob Halley's avatar
Bob Halley committed
678
manager_free(isc_taskmgr_t manager) {
Bob Halley's avatar
Bob Halley committed
679 680
	(void)isc_condition_destroy(&manager->work_available);
	(void)isc_mutex_destroy(&manager->lock);
681 682
	isc_mem_put(manager->mctx, manager->threads,
		    manager->workers * sizeof (isc_thread_t));
Bob Halley's avatar
base  
Bob Halley committed
683
	manager->magic = 0;
Bob Halley's avatar
Bob Halley committed
684
	isc_mem_put(manager->mctx, manager, sizeof *manager);
Bob Halley's avatar
base  
Bob Halley committed
685 686
}

Bob Halley's avatar
Bob Halley committed
687
isc_result_t
Bob Halley's avatar
Bob Halley committed
688 689
isc_taskmgr_create(isc_memctx_t mctx, unsigned int workers, 
		   unsigned int default_quantum, isc_taskmgr_t *managerp)
Bob Halley's avatar
Bob Halley committed
690 691
{
	unsigned int i, started = 0;
Bob Halley's avatar
Bob Halley committed
692
	isc_taskmgr_t manager;
693
	isc_thread_t *threads;
Bob Halley's avatar
Bob Halley committed
694 695

	REQUIRE(workers > 0);
Bob Halley's avatar
base  
Bob Halley committed
696

Bob Halley's avatar
Bob Halley committed
697
	manager = isc_mem_get(mctx, sizeof *manager);
Bob Halley's avatar
base  
Bob Halley committed
698
	if (manager == NULL)
Bob Halley's avatar
Bob Halley committed
699
		return (ISC_R_NOMEMORY);
Bob Halley's avatar
base  
Bob Halley committed
700 701
	manager->magic = TASK_MANAGER_MAGIC;
	manager->mctx = mctx;
702 703 704 705 706 707 708
	threads = isc_mem_get(mctx, workers * sizeof (isc_thread_t));
	if (threads == NULL) {
		isc_mem_put(mctx, manager, sizeof *manager);
		return (ISC_R_NOMEMORY);
	}
	manager->threads = threads;
	manager->workers = 0;
Bob Halley's avatar
Bob Halley committed
709
	if (isc_mutex_init(&manager->lock) != ISC_R_SUCCESS) {
710
		isc_mem_put(mctx, threads, workers * sizeof (isc_thread_t));
Bob Halley's avatar
Bob Halley committed
711
		isc_mem_put(mctx, manager, sizeof *manager);
Bob Halley's avatar
Bob Halley committed
712 713 714
		UNEXPECTED_ERROR(__FILE__, __LINE__,
				 "isc_mutex_init() failed");
		return (ISC_R_UNEXPECTED);
Bob Halley's avatar
update  
Bob Halley committed
715
	}
Bob Halley's avatar
base  
Bob Halley committed
716 717 718 719 720
	if (default_quantum == 0)
		default_quantum = DEFAULT_DEFAULT_QUANTUM;
	manager->default_quantum = default_quantum;
	INIT_LIST(manager->tasks);
	INIT_LIST(manager->ready_tasks);
Bob Halley's avatar
Bob Halley committed
721 722
	if (isc_condition_init(&manager->work_available) != ISC_R_SUCCESS) {
		(void)isc_mutex_destroy(&manager->lock);
723
		isc_mem_put(mctx, threads, workers * sizeof (isc_thread_t));
Bob Halley's avatar
Bob Halley committed
724
		isc_mem_put(mctx, manager, sizeof *manager);
Bob Halley's avatar
Bob Halley committed
725 726 727
		UNEXPECTED_ERROR(__FILE__, __LINE__,
				 "isc_condition_init() failed");
		return (ISC_R_UNEXPECTED);
Bob Halley's avatar
update  
Bob Halley committed
728
	}
Bob Halley's avatar
Bob Halley committed
729
	manager->exiting = ISC_FALSE;
Bob Halley's avatar
base  
Bob Halley committed
730 731 732 733 734 735 736
	manager->workers = 0;

	LOCK(&manager->lock);
	/*
	 * Start workers.
	 */
	for (i = 0; i < workers; i++) {
737 738
		if (isc_thread_create(run, manager,
				      &manager->threads[manager->workers]) == 
Bob Halley's avatar
Bob Halley committed
739
		    ISC_R_SUCCESS) {
Bob Halley's avatar
base  
Bob Halley committed
740 741 742 743 744 745 746 747
			manager->workers++;
			started++;
		}
	}
	UNLOCK(&manager->lock);

	if (started == 0) {
		manager_free(manager);
Bob Halley's avatar
Bob Halley committed
748
		return (ISC_R_NOTHREADS);
Bob Halley's avatar
base  
Bob Halley committed
749 750 751 752
	}		

	*managerp = manager;

Bob Halley's avatar
Bob Halley committed
753
	return (ISC_R_SUCCESS);
Bob Halley's avatar
base  
Bob Halley committed
754 755
}

Bob Halley's avatar
update  
Bob Halley committed
756
void
Bob Halley's avatar
Bob Halley committed
757 758 759
isc_taskmgr_destroy(isc_taskmgr_t *managerp) {
	isc_taskmgr_t manager;
	isc_task_t task;
760
	unsigned int i;
Bob Halley's avatar
base  
Bob Halley committed
761 762 763 764 765

	REQUIRE(managerp != NULL);
	manager = *managerp;
	REQUIRE(VALID_MANAGER(manager));

Bob Halley's avatar
Bob Halley committed
766
	XTRACE("isc_taskmgr_destroy");
Bob Halley's avatar
base  
Bob Halley committed
767 768 769 770
	/*
	 * Only one non-worker thread may ever call this routine.
	 * If a worker thread wants to initiate shutdown of the
	 * task manager, it should ask some non-worker thread to call
Bob Halley's avatar
Bob Halley committed
771
	 * isc_taskmgr_destroy(), e.g. by signalling a condition variable
Bob Halley's avatar
base  
Bob Halley committed
772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789
	 * that the startup thread is sleeping on.
	 */

	/*
	 * Unlike elsewhere, we're going to hold this lock a long time.
	 * We need to do so, because otherwise the list of tasks could
	 * change while we were traversing it.
	 *
	 * This is also the only function where we will hold both the
	 * task manager lock and a task lock at the same time.
	 */

	LOCK(&manager->lock);

	/*
	 * Make sure we only get called once.
	 */
	INSIST(!manager->exiting);
Bob Halley's avatar
Bob Halley committed
790
	manager->exiting = ISC_TRUE;
Bob Halley's avatar
base  
Bob Halley committed
791 792

	/*
Bob Halley's avatar
update  
Bob Halley committed
793 794
	 * Post the shutdown event to every task (if it hasn't already been
	 * posted).
Bob Halley's avatar
base  
Bob Halley committed
795 796 797 798 799
	 */
	for (task = HEAD(manager->tasks);
	     task != NULL;
	     task = NEXT(task, link)) {
		LOCK(&task->lock);
Bob Halley's avatar
update  
Bob Halley committed
800 801 802 803 804 805 806 807 808 809 810
		if (task->enqueue_allowed) {
			INSIST(task->shutdown_event != NULL);
			ENQUEUE(task->events, task->shutdown_event, link);
			task->shutdown_event = NULL;
			if (task->state == task_state_idle) {
				task->state = task_state_ready;
				ENQUEUE(manager->ready_tasks, task,
					ready_link);
			}
			INSIST(task->state == task_state_ready ||
			       task->state == task_state_running);
Bob Halley's avatar
Bob Halley committed
811
			task->enqueue_allowed = ISC_FALSE;
Bob Halley's avatar
base  
Bob Halley committed
812 813 814 815 816 817 818 819 820 821
		}
		UNLOCK(&task->lock);
	}

	/*
	 * Wake up any sleeping workers.  This ensures we get work done if
	 * there's work left to do, and if there are already no tasks left
	 * it will cause the workers to see manager->exiting.
	 */
	BROADCAST(&manager->work_available);
822
	UNLOCK(&manager->lock);
Bob Halley's avatar
base  
Bob Halley committed
823 824 825 826

	/*
	 * Wait for all the worker threads to exit.
	 */
827 828
	for (i = 0; i < manager->workers; i++)
		(void)isc_thread_join(manager->threads[i], NULL);
Bob Halley's avatar
base  
Bob Halley committed
829 830 831 832 833

	manager_free(manager);

	*managerp = NULL;
}