Commit 00b57b01 authored by Ondřej Surý's avatar Ondřej Surý

Merge branch '1081-fix-statistics-in-x86-windows-builds' into 'master'

Fix statistics in x86 Windows builds

Closes #1081

See merge request !2025
parents 9e499ddb cbb2edb8
Pipeline #16145 passed with stages
in 1 minute and 6 seconds
5251. [bug] Statistics were broken in x86 Windows builds.
[GL #1081]
5250. [func] The default size for RSA keys is now 2048 bits,
for both ZSKs and KSKs. [GL #1097]
......
......@@ -15352,6 +15352,15 @@ HOST-127.EXAMPLE. MX 0 .
<acronym>BIND</acronym> 8 statistics, if applicable.
</para>
<para>
Note: BIND statistics counters are signed 64-bit values on
all platforms except one: 32-bit Windows, where they are
signed 32-bit values. Given that 32-bit values have a
vastly smaller range than 64-bit values, BIND statistics
counters in 32-bit Windows builds overflow significantly
more quickly than on all other platforms.
</para>
<section xml:id="stats_counters"><info><title>Name Server Statistics Counters</title></info>
<informaltable colsep="0" rowsep="0">
......
......@@ -28,7 +28,11 @@
#define ISC_STATS_MAGIC ISC_MAGIC('S', 't', 'a', 't')
#define ISC_STATS_VALID(x) ISC_MAGIC_VALID(x, ISC_STATS_MAGIC)
#if defined(_WIN32) && !defined(_WIN64)
typedef atomic_int_fast32_t isc_stat_t;
#else
typedef atomic_int_fast64_t isc_stat_t;
#endif
struct isc_stats {
unsigned int magic;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment