Merge branch '877-clang-scan-build-redundant-assignments-detected-2' into 'master'

Add missing asserts to socket_test.c and dnstest.c

See merge request !1523

lib/dns/tests/dnstest.c

@@ -551,6 +551,7 @@ dns_test_namefromstring(const char *namestr, dns_fixedname_t *fname) {
 	name = dns_fixedname_initname(fname);
 
 	result = isc_buffer_allocate(mctx, &b, length);
+	assert_int_equal(result, ISC_R_SUCCESS);
 
 	isc_buffer_putmem(b, (const unsigned char *) namestr, length);
 	result = dns_name_fromtext(name, b, dns_rootname, 0, NULL);

lib/isc/tests/socket_test.c

@@ -817,6 +817,7 @@ udp_trunc_test(void **state) {
 	completion_init(&completion);
 	recv_trunc = false;
 	result = isc_socket_recv(s2, &r, 1, task, event_done, &completion);
+	assert_int_equal(result, ISC_R_SUCCESS);
 	waitfor(&completion);
 	assert_true(completion.done);
 	assert_int_equal(completion.result, ISC_R_SUCCESS);