Commit 29c45200 authored by Ondřej Surý's avatar Ondřej Surý
Browse files

Add extra return failure after INSIST(0) in default branch

parent 4eaf9275
......@@ -570,6 +570,7 @@ openssleddsa_todns(const dst_key_t *key, isc_buffer_t *data) {
default:
INSIST(0);
}
return (DST_R_OPENSSLFAILURE);
}
static isc_result_t
......
......@@ -551,7 +551,7 @@ totext_loc(ARGS_TOTEXT) {
altitude -= 10000000;
}
snprintf(NULL, 0,
snprintf(buf, sizeof(buf),
"%d %d %d.%03d %s %d %d %d.%03d %s %s%lu.%02lum %s %s %s",
d1, m1, s1, fs1, north ? "N" : "S",
d2, m2, s2, fs2, east ? "E" : "W",
......
......@@ -36,7 +36,7 @@ static inline isc_result_t
totext_in_dhcid(ARGS_TOTEXT) {
isc_region_t sr, sr2;
/* " ; 64000 255 64000" */
char buf[5 + 3*5 + 1];
char buf[5 + 3*11 + 1];
REQUIRE(rdata->type == dns_rdatatype_dhcid);
REQUIRE(rdata->rdclass == dns_rdataclass_in);
......@@ -55,7 +55,7 @@ totext_in_dhcid(ARGS_TOTEXT) {
if ((tctx->flags & DNS_STYLEFLAG_MULTILINE) != 0) {
RETERR(str_totext(/* ( */ " )", target));
if (rdata->length > 2) {
snprintf(NULL, 0, " ; %u %u %u",
snprintf(buf, sizeof(buf), " ; %u %u %u",
sr2.base[0] * 256U + sr2.base[1],
sr2.base[2], rdata->length - 3U);
RETERR(str_totext(buf, target));
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment