Commit 2cd3c885 authored by Mark Andrews's avatar Mark Andrews
Browse files

3576. [bug] Address a shutdown race when validating. [RT #33573]

parent 162933ba
3576. [bug] Address a shutdown race when validating. [RT #33573]
3575. [func] Changed the logging category for RRL events from
'queries' to 'query-errors'. [RT #33540]
......
......@@ -3713,7 +3713,7 @@ dns_validator_create(dns_view_t *view, dns_name_t *name, dns_rdatatype_t type,
if (val == NULL)
return (ISC_R_NOMEMORY);
val->view = NULL;
dns_view_weakattach(view, &val->view);
dns_view_attach(view, &val->view);
event = (dns_validatorevent_t *)
isc_event_allocate(view->mctx, task,
......@@ -3787,7 +3787,7 @@ dns_validator_create(dns_view_t *view, dns_name_t *name, dns_rdatatype_t type,
isc_event_free(ISC_EVENT_PTR(&event));
cleanup_val:
dns_view_weakdetach(&val->view);
dns_view_detach(&val->view);
isc_mem_put(view->mctx, val, sizeof(*val));
return (result);
......@@ -3867,7 +3867,7 @@ destroy(dns_validator_t *val) {
if (val->siginfo != NULL)
isc_mem_put(mctx, val->siginfo, sizeof(*val->siginfo));
DESTROYLOCK(&val->lock);
dns_view_weakdetach(&val->view);
dns_view_detach(&val->view);
val->magic = 0;
isc_mem_put(mctx, val, sizeof(*val));
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment