Commit 615b961e authored by Mark Andrews's avatar Mark Andrews
Browse files

4682. [bug] Don't report errors on records below a DNAME.

                        [RT #44880]
parent 7655cd1f
4682. [bug] Don't report errors on records below a DNAME.
[RT #44880]
4681. [bug] Log messages from the validator now include the
associated view unless the view is "_default/IN"
or "_dnsclient/IN". [RT #45770]
......
$TTL 300
example. SOA marka.isc.org. a.root.servers.nil. (
2026 ; serial
600 ; refresh
600 ; retry
1200 ; expire
600 ; minimum
)
example. DNAME example.net. ; only the apex record exist
example. NS ns.example.net. ; out of zone
foo.example. NS exavider.example. ; no "address" records
$TTL 300
example. SOA marka.isc.org. a.root.servers.nil. (
2026 ; serial
600 ; refresh
600 ; retry
1200 ; expire
600 ; minimum
)
example. NS ns.example.net. ; out of zone
foo.example. NS ns.example.net. ; out of zone
bar.foo.example. NS x.foo.example. ; no address records
......@@ -2949,14 +2949,14 @@ integrity_checks(dns_zone_t *zone, dns_db_t *db) {
* Don't check the NS records at the origin.
*/
if (dns_name_equal(name, &zone->origin))
goto checkmx;
goto checkfordname;
result = dns_db_findrdataset(db, node, NULL, dns_rdatatype_ns,
0, 0, &rdataset, NULL);
if (result != ISC_R_SUCCESS)
goto checkmx;
goto checkfordname;
/*
* Remember bottom of zone.
* Remember bottom of zone due to NS.
*/
dns_name_copy(name, bottom, NULL);
......@@ -2973,7 +2973,18 @@ integrity_checks(dns_zone_t *zone, dns_db_t *db) {
dns_rdataset_disassociate(&rdataset);
goto next;
checkmx:
checkfordname:
result = dns_db_findrdataset(db, node, NULL,
dns_rdatatype_dname, 0, 0,
&rdataset, NULL);
if (result == ISC_R_SUCCESS) {
/*
* Remember bottom of zone due to DNAME.
*/
dns_name_copy(name, bottom, NULL);
dns_rdataset_disassociate(&rdataset);
}
result = dns_db_findrdataset(db, node, NULL, dns_rdatatype_mx,
0, 0, &rdataset, NULL);
if (result != ISC_R_SUCCESS)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment