Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
ISC Open Source Projects
BIND
Commits
615b961e
Commit
615b961e
authored
Aug 17, 2017
by
Mark Andrews
Browse files
4682. [bug] Don't report errors on records below a DNAME.
[RT #44880]
parent
7655cd1f
Changes
4
Hide whitespace changes
Inline
Side-by-side
CHANGES
View file @
615b961e
4682. [bug] Don't report errors on records below a DNAME.
[RT #44880]
4681. [bug] Log messages from the validator now include the
associated view unless the view is "_default/IN"
or "_dnsclient/IN". [RT #45770]
...
...
bin/tests/system/checkzone/zones/good-occulted-ns-by-dname.db
0 → 100644
View file @
615b961e
$TTL 300
example. SOA marka.isc.org. a.root.servers.nil. (
2026 ; serial
600 ; refresh
600 ; retry
1200 ; expire
600 ; minimum
)
example. DNAME example.net. ; only the apex record exist
example. NS ns.example.net. ; out of zone
foo.example. NS exavider.example. ; no "address" records
bin/tests/system/checkzone/zones/good-occulted-ns-by-ns.db
0 → 100644
View file @
615b961e
$TTL 300
example. SOA marka.isc.org. a.root.servers.nil. (
2026 ; serial
600 ; refresh
600 ; retry
1200 ; expire
600 ; minimum
)
example. NS ns.example.net. ; out of zone
foo.example. NS ns.example.net. ; out of zone
bar.foo.example. NS x.foo.example. ; no address records
lib/dns/zone.c
View file @
615b961e
...
...
@@ -2949,14 +2949,14 @@ integrity_checks(dns_zone_t *zone, dns_db_t *db) {
* Don't check the NS records at the origin.
*/
if
(
dns_name_equal
(
name
,
&
zone
->
origin
))
goto
check
mx
;
goto
check
fordname
;
result
=
dns_db_findrdataset
(
db
,
node
,
NULL
,
dns_rdatatype_ns
,
0
,
0
,
&
rdataset
,
NULL
);
if
(
result
!=
ISC_R_SUCCESS
)
goto
check
mx
;
goto
check
fordname
;
/*
* Remember bottom of zone.
* Remember bottom of zone
due to NS
.
*/
dns_name_copy
(
name
,
bottom
,
NULL
);
...
...
@@ -2973,7 +2973,18 @@ integrity_checks(dns_zone_t *zone, dns_db_t *db) {
dns_rdataset_disassociate
(
&
rdataset
);
goto
next
;
checkmx:
checkfordname:
result
=
dns_db_findrdataset
(
db
,
node
,
NULL
,
dns_rdatatype_dname
,
0
,
0
,
&
rdataset
,
NULL
);
if
(
result
==
ISC_R_SUCCESS
)
{
/*
* Remember bottom of zone due to DNAME.
*/
dns_name_copy
(
name
,
bottom
,
NULL
);
dns_rdataset_disassociate
(
&
rdataset
);
}
result
=
dns_db_findrdataset
(
db
,
node
,
NULL
,
dns_rdatatype_mx
,
0
,
0
,
&
rdataset
,
NULL
);
if
(
result
!=
ISC_R_SUCCESS
)
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment