Commit 96c17c5e authored by Mark Andrews's avatar Mark Andrews
Browse files

3761. [bug] Address dangling reference bug in dns_keytable_add.

                        [RT #35471]
parent 98922b2b
3761. [bug] Address dangling reference bug in dns_keytable_add.
[RT #35471]
3760. [bug] Improve SIT with native PKCS#11 and on Windows. 3760. [bug] Improve SIT with native PKCS#11 and on Windows.
[RT #35433] [RT #35433]
......
...@@ -174,6 +174,7 @@ insert(dns_keytable_t *keytable, isc_boolean_t managed, ...@@ -174,6 +174,7 @@ insert(dns_keytable_t *keytable, isc_boolean_t managed,
for (k = node->data; k != NULL; k = k->next) { for (k = node->data; k != NULL; k = k->next) {
if (k->key == NULL) { if (k->key == NULL) {
k->key = *keyp; k->key = *keyp;
*keyp = NULL; /* transfer ownership */
break; break;
} }
if (dst_key_compare(k->key, *keyp) == ISC_TRUE) if (dst_key_compare(k->key, *keyp) == ISC_TRUE)
...@@ -182,7 +183,7 @@ insert(dns_keytable_t *keytable, isc_boolean_t managed, ...@@ -182,7 +183,7 @@ insert(dns_keytable_t *keytable, isc_boolean_t managed,
if (k == NULL) if (k == NULL)
result = ISC_R_SUCCESS; result = ISC_R_SUCCESS;
else else if (*keyp != NULL)
dst_key_free(keyp); dst_key_free(keyp);
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment