Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
ISC Open Source Projects
BIND
Commits
a3157f3c
Commit
a3157f3c
authored
Nov 11, 2014
by
Mukund Sivaraman
Browse files
[master] close() fd when done (Coverity report)
parent
fadf7291
Changes
1
Hide whitespace changes
Inline
Side-by-side
lib/isc/tests/file_test.c
View file @
a3157f3c
...
...
@@ -46,6 +46,7 @@ ATF_TC_HEAD(isc_file_sanitize, tc) {
ATF_TC_BODY
(
isc_file_sanitize
,
tc
)
{
isc_result_t
result
;
char
buf
[
1024
];
int
fd
;
ATF_CHECK
(
chdir
(
TESTS
)
!=
-
1
);
...
...
@@ -56,15 +57,19 @@ ATF_TC_BODY(isc_file_sanitize, tc) {
ATF_CHECK_EQ
(
result
,
ISC_R_SUCCESS
);
ATF_CHECK
(
strcmp
(
buf
,
F
(
NAME
))
==
0
);
ATF_CHECK
(
creat
(
F
(
TRUNC_SHA
),
0644
)
!=
-
1
);
fd
=
creat
(
F
(
TRUNC_SHA
),
0644
);
ATF_CHECK
(
fd
!=
-
1
);
result
=
isc_file_sanitize
(
"testdata/file"
,
NAME
,
"test"
,
buf
,
1024
);
ATF_CHECK_EQ
(
result
,
ISC_R_SUCCESS
);
ATF_CHECK
(
strcmp
(
buf
,
F
(
TRUNC_SHA
))
==
0
);
close
(
fd
);
ATF_CHECK
(
creat
(
F
(
SHA
),
0644
)
!=
-
1
);
fd
=
creat
(
F
(
SHA
),
0644
);
ATF_CHECK
(
fd
!=
-
1
);
result
=
isc_file_sanitize
(
"testdata/file"
,
NAME
,
"test"
,
buf
,
1024
);
ATF_CHECK_EQ
(
result
,
ISC_R_SUCCESS
);
ATF_CHECK
(
strcmp
(
buf
,
F
(
SHA
))
==
0
);
close
(
fd
);
result
=
isc_file_sanitize
(
"testdata/file"
,
BAD1
,
"test"
,
buf
,
1024
);
ATF_CHECK_EQ
(
result
,
ISC_R_SUCCESS
);
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment