Commit c4b7db49 authored by Evan Hunt's avatar Evan Hunt
Browse files

[master] render querylog format consistent, and add a release note

4471.	[cleanup]	Render client/query logging format consistent for
			ease of log file parsing. (Note that this affects
			"querylog" format: there is now an additional field
			indicating the client object address.) [RT #43238]
parent a4cc9c9c
4471. [placeholder]
4471. [cleanup] Render client/query logging format consistent for
ease of log file parsing. (Note that this affects
"querylog" format: there is now an additional field
indicating the client object address.) [RT #43238]
4470. [bug] Reset message with intent parse before
calling dns_dispatch_getnext. [RT #43229]
......
......@@ -3688,6 +3688,7 @@ ns_client_logv(ns_client_t *client, isc_logcategory_t *category,
{
char msgbuf[4096];
char signerbuf[DNS_NAME_FORMATSIZE], qnamebuf[DNS_NAME_FORMATSIZE];
char peerbuf[ISC_SOCKADDR_FORMATSIZE];
const char *viewname = "";
const char *sep1 = "", *sep2 = "", *sep3 = "", *sep4 = "";
const char *signer = "", *qname = "";
......@@ -3717,20 +3718,16 @@ ns_client_logv(ns_client_t *client, isc_logcategory_t *category,
}
if (client->peeraddr_valid) {
char peerbuf[ISC_SOCKADDR_FORMATSIZE];
isc_sockaddr_format(&client->peeraddr,
peerbuf, sizeof(peerbuf));
} else {
snprintf(peerbuf, sizeof(peerbuf), "(no-peer)");
}
isc_log_write(ns_g_lctx, category, module, level,
"client @%p %s%s%s%s%s%s%s%s: %s",
client, peerbuf, sep1, signer, sep2, qname, sep3,
sep4, viewname, msgbuf);
} else {
isc_log_write(ns_g_lctx, category, module, level,
"client @%p%s%s%s%s%s%s%s: %s",
client, sep1, signer, sep2, qname, sep3,
sep4, viewname, msgbuf);
}
}
void
......
......@@ -640,6 +640,11 @@
<section xml:id="relnotes_changes"><info><title>Feature Changes</title></info>
<itemizedlist>
<listitem>
<para>
The logging format used for <command>querylog</command> has been
altered. It now includes an additional field indicating the
address in memory of the client object processing the query.
</para>
<para>
The ISC DNSSEC Lookaside Validation (DLV) service is scheduled
to be disabled in 2017. A warning is now logged when
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment