Merge branch 'ondrej/use-strlcpy-in-wks_11.c-v9_12' into 'v9_12'

Use strlcpy in place where strncpy(s, ...) + s[sizeof(s)-1] = \0; was used

See merge request !1113

contrib/dlz/drivers/dlz_filesystem_driver.c

@@ -59,6 +59,7 @@
 #include <isc/platform.h>
 #include <isc/print.h>
 #include <isc/result.h>
+#include <isc/string.h>
 #include <isc/util.h>
 
 #include <named/globals.h>
@@ -437,12 +438,12 @@ process_dir(isc_dir_t *dir, void *passback, config_data_t *cd,
 					 */
 					if (strcmp((char *) &dir->entry.name[6],
 						   "-") == 0)
-						strcpy(host, "*");
-					else {
-						strncpy(host,
+					{
+						strlcpy(host, "*", sizeof(host));
+					} else {
+						strlcpy(host,
 						   (char *) &dir->entry.name[6],
-						   sizeof(host) - 1);
-						host[255] = '\0';
+						   sizeof(host));
 					}
 					foundHost = true;
 					break;

lib/dns/rdata/in_1/wks_11.c

@@ -155,8 +155,7 @@ fromtext_in_wks(ARGS_FROMTEXT) {
 		 * Lowercase the service string as some getservbyname() are
 		 * case sensitive and the database is usually in lowercase.
 		 */
-		strncpy(service, DNS_AS_STR(token), sizeof(service));
-		service[sizeof(service)-1] = '\0';
+		strlcpy(service, DNS_AS_STR(token), sizeof(service));
 		for (i = strlen(service) - 1; i >= 0; i--)
 			if (isupper(service[i]&0xff))
 				service[i] = tolower(service[i]&0xff);