Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
BIND
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
606
Issues
606
List
Boards
Labels
Service Desk
Milestones
Merge Requests
112
Merge Requests
112
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Incidents
Environments
Packages & Registries
Packages & Registries
Container Registry
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
ISC Open Source Projects
BIND
Commits
f8d753d4
Commit
f8d753d4
authored
May 05, 2020
by
Evan Hunt
2
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
initialize sockaddrdscp to prevent spurious output from 'named-checkconf -p'
parent
7072f9db
Pipeline
#40990
passed with stages
in 23 minutes and 47 seconds
Changes
5
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
13 additions
and
1 deletion
+13
-1
CHANGES
CHANGES
+4
-0
bin/tests/system/checkconf/good.conf
bin/tests/system/checkconf/good.conf
+6
-0
bin/tests/system/checkconf/good.zonelist
bin/tests/system/checkconf/good.zonelist
+1
-0
bin/tests/system/checkconf/tests.sh
bin/tests/system/checkconf/tests.sh
+1
-1
lib/isccfg/parser.c
lib/isccfg/parser.c
+1
-0
No files found.
CHANGES
View file @
f8d753d4
5405. [bug] 'named-checkconf -p' could include spurious text
in server-addresses statements due to an uninitialized
DSCP value. [GL #1812]
5404. [bug] 'named-checkconf -z' could incorrectly indicate
success if errors were found in one view but not in a
subsequent one. [GL #1807]
...
...
bin/tests/system/checkconf/good.conf
View file @
f8d753d4
...
...
@@ -120,6 +120,12 @@ view "second" {
};
zone
-
statistics
no
;
};
zone
"example3"
{
type
static
-
stub
;
server
-
addresses
{
1
.
2
.
3
.
4
;
};
};
zone
"clone"
{
in
-
view
"first"
;
};
...
...
bin/tests/system/checkconf/good.zonelist
View file @
f8d753d4
...
...
@@ -2,6 +2,7 @@ example1 IN first master
clone IN first master
example1 IN second master
example2 IN second static-stub
example3 IN second static-stub
clone IN second in-view first
. IN second redirect
clone IN third in-view first
...
...
bin/tests/system/checkconf/tests.sh
View file @
f8d753d4
...
...
@@ -380,7 +380,7 @@ if [ $ret != 0 ]; then echo_i "failed"; ret=1; fi
status
=
`
expr
$status
+
$ret
`
n
=
`
expr
$n
+ 1
`
echo_i
"check that named-checkconf -l print out the zone list (
$n
)"
echo_i
"check that named-checkconf -l print
s
out the zone list (
$n
)"
ret
=
0
$CHECKCONF
-l
good.conf |
grep
-v
"is not implemented"
|
...
...
lib/isccfg/parser.c
View file @
f8d753d4
...
...
@@ -3239,6 +3239,7 @@ parse_netaddr(cfg_parser_t *pctx, const cfg_type_t *type, cfg_obj_t **ret) {
CHECK
(
cfg_create_obj
(
pctx
,
type
,
&
obj
));
CHECK
(
cfg_parse_rawaddr
(
pctx
,
flags
,
&
netaddr
));
isc_sockaddr_fromnetaddr
(
&
obj
->
value
.
sockaddr
,
&
netaddr
,
0
);
obj
->
value
.
sockaddrdscp
.
dscp
=
-
1
;
*
ret
=
obj
;
return
(
ISC_R_SUCCESS
);
cleanup:
...
...
Evan Hunt
@each
mentioned in commit
a6549897
·
May 06, 2020
mentioned in commit
a6549897
mentioned in commit a6549897165f821c322933b0e3b2be65087e5cf6
Toggle commit list
Evan Hunt
@each
mentioned in commit
1df41412
·
May 06, 2020
mentioned in commit
1df41412
mentioned in commit 1df4141279200f1d689bc04492f142cb1ae0f78e
Toggle commit list
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment