Commit fe4d0fbc authored by Mark Andrews's avatar Mark Andrews
Browse files

4473. [bug] Only call fsync / _commit on regular files. [RT #43196]

parent ca67897b
4473. [bug] Only call fsync / _commit on regular files. [RT #43196]
4472. [bug] Named could fail to find the correct NSEC3 records when
a zone was updated between looking for the answer and
looking for the NSEC3 records proving non-existance
......
......@@ -128,14 +128,20 @@ isc_stdio_flush(FILE *f) {
isc_result_t
isc_stdio_sync(FILE *f) {
struct stat buf;
int r;
r = fsync(fileno(f));
if (fstat(fileno(f), &buf) != 0)
return (isc__errno2result(errno));
/*
* fsync is not supported on sockets and pipes which
* result in EINVAL / ENOTSUP.
* Only call fsync() on regular files.
*/
if (r == 0 || errno == EINVAL || errno == ENOTSUP)
if ((buf.st_mode & S_IFMT) != S_IFREG)
return (ISC_R_SUCCESS);
r = fsync(fileno(f));
if (r == 0)
return (ISC_R_SUCCESS);
else
return (isc__errno2result(errno));
......
......@@ -16,6 +16,9 @@
#include <isc/stdio.h>
#include <isc/util.h>
#include <sys/stat.h>
#include <sys/types.h>
#include "errno2result.h"
isc_result_t
......@@ -124,8 +127,18 @@ isc_stdio_flush(FILE *f) {
isc_result_t
isc_stdio_sync(FILE *f) {
struct _stat buf;
int r;
if (_fstat(_fileno(f), &buf) != 0)
return (isc__errno2result(errno));
/*
* Only call _commit() on regular files.
*/
if ((buf.st_mode & S_IFMT) != S_IFREG)
return (ISC_R_SUCCESS);
r = _commit(_fileno(f));
if (r == 0)
return (ISC_R_SUCCESS);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment