GitLab

- use $PERL instead of perl
- use $DIFF instead of cmp for windows portability; cmp doesn't
  handle CR characters properly

typographical error prevented reconfiguration

this test doesn't work on windows

- dnssec-cds wasn't being built for windows
- nsec3hash was available, but the NSEC3HASH variable wasn't
  set in conf.sh.win32

as perl and python are both native to cygwin, we don't want to use
the "kill -f" option to terminate them.

the addresses set up in ifconfig.bat were out of sync with the
ones in ifconfig.sh

- the test lists in conf.sh.in and conf.sh.win32 were out of sync

dig: return a non-zero exit code for failed TCP EOF retries

Closes #820

See merge request !1358

5144.	[bug]		dig now returns a non-zero exit code when a TCP
			connection is prematurely closed by a peer more than
			once for the same lookup.  [GL #820]

dig retries a TCP query when a server closes the connection prematurely.
However, dig's exit code remains unaffected even if the second attempt
to get a response also fails with the same error for the same lookup,
which should not be the case.  Ensure the exit code is updated
appropriately when a retry triggered by a TCP EOF condition fails.

improve handling of trailing dots in dnssec-keymgr and dnssec-coverage

Closes #560

See merge request !1374

- mishandling of trailing dots caused bad behavior with the
  root zone or names like "example.com."
- fixing this exposed an error in dnssec-coverage caused the
  wrong return value if there were KSK errors but no ZSK errors
- incidentally silenced the dnssec-keygen output in the coverage
  system test

cleanup cfg_parse_buffer* functions

Closes #323

See merge request !1377

cfg_parse_buffer() now has the same signature as the former
cfg_parse_buffer4(). cfg_parse_buffer{2,3,4}() have been removed.

remove dead RPZ code

See merge request !1392

remove --disable-rpz-nsip and --disable-rpz-nsdname from configure

Closes #824

See merge request !1376

set the magic number at the end of dns_dt_create()

See merge request !1383

placeholder

See merge request !1385

Merge branch '117-running-dnssec-keymgr-with-old-keys-inactivates-deletes-them-immediately' into 'master'

Resolve "Running dnssec-keymgr with old keys inactivates/deletes them immediately"

Closes #117

See merge request !1378

fix broken masterformat test

Closes #823

See merge request !1365

- dig command had the @ parameter in the wrong place
- private-dnskey and private-cdnskey are queried in a separate
  loop, which strips 'private-' from the name to determine the qtype

clean up debugging fprintf

See merge request !1368

GitLab CI cleanup

See merge request !1329

In an attempt to ensure that:

  - all important changes to repository contents are tested,
  - pipelines are not automatically created for every single push,
  - some flexibility is allowed for corner cases,

change pipeline triggering settings so that:

  - full build & test pipelines are only automatically created for merge
    requests and tags (both for creation and updates),

  - pipelines for other repository changes (e.g. pushes to arbitrary
    branches) can only be created manually, using GitLab's web
    interface,

  - merging a merge request only causes jobs pushing the updated ARM to
    GitLab Pages to be run (as semi-linear Git history is enforced and
    thus testing a MR is identical to testing the target branch
    post-merge in terms of code),

  - repository synchronization does not trigger duplicate pipelines in
    projects which are set as mirroring targets.

Group jobs by build type and operating system to make the layout of
.gitlab-ci.yml more consistent and improve locality of YAML references.

Make sure all jobs are named using the following pattern:

    [<job-type>:]<build-type>:<system>:<architecture>

where specifying <job-type> is optional for "precheck" and "build" jobs.

This should make it easier to quickly recognize:

  - what kind of actions are performed by each job,
  - which BIND build flavor is used by each job,
  - which operating system image is used by each job.

While we are at it, drop use of the "docker" tag since all BIND CI jobs
are currently run inside Docker containers.

There is no need to build BIND binaries before building docs and thus
the job building the current version of the ARM can be moved to the
build stage of CI.