1. 25 Mar, 2020 3 commits
    • Ondřej Surý's avatar
      Fix 'Dereference of null pointer' from scan-build-10 · 0fdc09ef
      Ondřej Surý authored
      These are mostly false positives, the clang-analyzer FAQ[1] specifies
      why and how to fix it:
      
      > The reason the analyzer often thinks that a pointer can be null is
      > because the preceding code checked compared it against null. So if you
      > are absolutely sure that it cannot be null, remove the preceding check
      > and, preferably, add an assertion as well.
      
      The 4 warnings reported are:
      
      dnssec-cds.c:781:4: warning: Access to field 'base' results in a dereference of a null pointer (loaded from variable 'buf')
                              isc_buffer_availableregion(buf, &r);
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      /builds/isc-projects/bind9/lib/isc/include/isc/buffer.h:996:36: note: expanded from macro 'isc_buffer_availableregion'
                                         ^
      /builds/isc-projects/bind9/lib/isc/include/isc/buffer.h:821:16: note: expanded from macro 'ISC__BUFFER_AVAILABLEREGION'
                      (_r)->base = isc_buffer_used(_b);              \
                                   ^~~~~~~~~~~~~~~~~~~
      /builds/isc-projects/bind9/lib/isc/include/isc/buffer.h:152:29: note: expanded from macro 'isc_buffer_used'
              ((void *)((unsigned char *)(b)->base + (b)->used)) /*d*/
                                         ^~~~~~~~~
      1 warning generated.
      
      --
      
      byname_test.c:308:34: warning: Access to field 'fwdtable' results in a dereference of a null pointer (loaded from variable 'view')
                      RUNTIME_CHECK(dns_fwdtable_add(view->fwdtable, dns_rootname,
                                                     ^~~~~~~~~~~~~~
      /builds/isc-projects/bind9/lib/isc/include/isc/util.h:318:52: note: expanded from macro 'RUNTIME_CHECK'
                                                         ^~~~
      /builds/isc-projects/bind9/lib/isc/include/isc/error.h:50:21: note: expanded from macro 'ISC_ERROR_RUNTIMECHECK'
              ((void)(ISC_LIKELY(cond) ||  \
                                 ^~~~
      /builds/isc-projects/bind9/lib/isc/include/isc/likely.h:23:43: note: expanded from macro 'ISC_LIKELY'
                                                  ^
      1 warning generated.
      
      --
      
      ./rndc.c:255:6: warning: Dereference of null pointer (loaded from variable 'host')
              if (*host == '/') {
                  ^~~~~
      1 warning generated.
      
      --
      
      ./main.c:1254:9: warning: Access to field 'sctx' results in a dereference of a null pointer (loaded from variable 'named_g_server')
              sctx = named_g_server->sctx;
                     ^~~~~~~~~~~~~~~~~~~~
      1 warning generated.
      
      References:
      1. https://clang-analyzer.llvm.org/faq.html#null_pointer
      
      (cherry picked from commit ddd0d356)
      0fdc09ef
    • Ondřej Surý's avatar
      Fix 'Dead nested assignment's from scan-build-10 · 230d250b
      Ondřej Surý authored
      The 3 warnings reported are:
      
      os.c:872:7: warning: Although the value stored to 'ptr' is used in the enclosing expression, the value is never actually read from 'ptr'
              if ((ptr = strtok_r(command, " \t", &last)) == NULL) {
                   ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      1 warning generated.
      
      --
      
      rpz.c:1117:10: warning: Although the value stored to 'zbits' is used in the enclosing expression, the value is never actually read from 'zbits'
              return (zbits &= x);
                      ^        ~
      1 warning generated.
      
      --
      
      openssleddsa_link.c:532:10: warning: Although the value stored to 'err' is used in the enclosing expression, the value is never actually read from 'err'
              while ((err = ERR_get_error()) != 0) {
                      ^     ~~~~~~~~~~~~~~~
      1 warning generated.
      
      (cherry picked from commit 262f087b)
      230d250b
    • Ondřej Surý's avatar
      Merge branch 'ondrej/remove-debian-jessie-from-gitlab-ci-v9_16' into 'v9_16' · 0db685ed
      Ondřej Surý authored
      Remove Debian 8 ("Jessie") from the GitLab CI
      
      See merge request !3282
      0db685ed
  2. 24 Mar, 2020 3 commits
  3. 20 Mar, 2020 13 commits
    • Ondřej Surý's avatar
      Merge branch '4-gitlab-ci.yml-improvement-v9_16' into 'v9_16' · 6aebc6c2
      Ondřej Surý authored
      Improve GitLab CI configuration [v9.16]
      
      See merge request !3259
      6aebc6c2
    • Ondřej Surý's avatar
      Rename MAKE environment variable to MAKE_COMMAND · b1475b1f
      Ondřej Surý authored
      The environment variable MAKE has been replaced with MAKE_COMMAND,
      because overriding MAKE variable also changed the definition of the MAKE
      inside the Makefiles, and we want only a single wrapper around the whole
      build process.
      
      Previously, setting `MAKE` to `bear make` meant that `bear make` would
      be run at every nested make invocation, which messed up the upcoming
      automake transition as compile_commands.json would be generated in every
      subdirectory instead of just having one central file at the top of the
      build tree.
      
      (cherry picked from commit de1a637a)
      b1475b1f
    • Ondřej Surý's avatar
      Remove cppcheck arm64 job · a872f027
      Ondřej Surý authored
      All *:sid:amd64 jobs were errorneously copied to *:sid:arm64 including
      the extra cppcheck run.  Remove the extra definitions from arm64 jobs.
      
      (cherry picked from commit 99f9e2c5)
      a872f027
    • Ondřej Surý's avatar
      Replace dependencies+needs with needs+artifacts in GitLabCI config · 7a296c60
      Ondřej Surý authored
      All jobs now use solely the newer needs configuration to declare
      dependencies between jobs:
      
          needs:
            - job: <foo>
              artifacts: true
      
      instead of combination of dependencies and needs which is deprecated.
      This change completely unbundles the stages (alas the stages still needs
      to stay because the job graph has to stay acyclic between the stages).
      
      (cherry picked from commit 66ba808c)
      7a296c60
    • Michal Nowak's avatar
      Merge branch 'mnowak/abi-tracker-helper-v9.17.0-v9_16' into 'v9_16' · 8d46aba6
      Michal Nowak authored
      [v9_16] Bump BIND baseline version for abi-check
      
      See merge request !3270
      8d46aba6
    • Michal Nowak's avatar
      Bump BIND baseline version for abi-check · 5fae0df7
      Michal Nowak authored
      (cherry picked from commit 3730d59b)
      5fae0df7
    • Matthijs Mekking's avatar
      Merge branch 'v9_16_1-release' into 'v9_16' · 3a13a961
      Matthijs Mekking authored
      Apply 9.16.1 release branch
      
      See merge request !3263
      3a13a961
    • Tinderbox User's avatar
      Update changes after QA review · ecfea36b
      Tinderbox User authored
      ecfea36b
    • Tinderbox User's avatar
      regen v9_16 · d2c4cfcf
      Tinderbox User authored
      d2c4cfcf
    • Tinderbox User's avatar
      prep 9.16.1 · aed7d77c
      Tinderbox User authored
      Updated version and CHANGES files with new release number.
      
      Check the API files:
      - lib/bind9/api:
        Source code changes, but no interface changes: increment
        LIBREVISION.
      - lib/dns/api:
        Function dns_acl_match changed, struct dns_badcache changed,
        function dns_badcache_add changed, function dns_clent_startupdate
        changed, struct dns_compress changed, struct dns_resolver changed,
        rwlock size changed. This means a LIBINTERFACE increment.
      - lib/irs/api:
        Source code changes, but no interface changes: increment
        LIBREVISION.
      - lib/isc/api:
        The structs isc__networker and isc_nmsocket changed. This means
        increment LIBINTERFACE.  The functions isc_uv_export and
        isc_uv_import are removed, so LIBAGE must beq zero.
      - lib/isccc/api:
        Source code changes, but no interface changes: increment
        LIBREVISION.
      - lib/isccfg/api:
        Source code changes, but no interface changes: increment
        LIBREVISION.
      - lib/ns/api:
        Function ns_clientmgr_create, ns_interfacemgr_create, and
        structs ns_clientmg...
      aed7d77c
    • Michal Nowak's avatar
      Merge branch 'mnowak/unit-test-debugging-enhancements-v9_16' into 'v9_16' · 2bddcc9e
      Michal Nowak authored
      [v9_16] Enhance unit test debugging
      
      See merge request !3267
      2bddcc9e
    • Michal Nowak's avatar
      Enhance unit test debugging · 94fa27e4
      Michal Nowak authored
      When unit test fails, core file is created. Kyua's 'debug' command can
      run GDB on it and provide backtrace. Unfortunately Kyua is picky about
      location of these core files we opt to use custom Kyua fork and copy
      core files from Kyua working directory to source tree and make it
      available in GitLab.
      
      (cherry picked from commit 8fad74e0)
      94fa27e4
    • Ondřej Surý's avatar
      Merge branch... · 509a06f7
      Ondřej Surý authored
      Merge branch '1679-remove-workaround-for-systems-with-broken-gettimeofday-system-calls-v9_16' into 'v9_16'
      
      Use clock_gettime() instead of gettimeofday() for isc_stdtime function
      
      See merge request !3258
      509a06f7
  4. 19 Mar, 2020 1 commit
  5. 18 Mar, 2020 4 commits
  6. 17 Mar, 2020 10 commits
  7. 16 Mar, 2020 6 commits