1. 25 Mar, 2020 3 commits
    • Ondřej Surý's avatar
      Fix 'Dereference of null pointer' from scan-build-10 · 0ff5c1f1
      Ondřej Surý authored
      These are mostly false positives, the clang-analyzer FAQ[1] specifies
      why and how to fix it:
      
      > The reason the analyzer often thinks that a pointer can be null is
      > because the preceding code checked compared it against null. So if you
      > are absolutely sure that it cannot be null, remove the preceding check
      > and, preferably, add an assertion as well.
      
      The 2 warnings reported are:
      
      byname_test.c:308:34: warning: Access to field 'fwdtable' results in a dereference of a null pointer (loaded from variable 'view')
                      RUNTIME_CHECK(dns_fwdtable_add(view->fwdtable, dns_rootname,
                                                     ^~~~~~~~~~~~~~
      /builds/isc-projects/bind9/lib/isc/include/isc/util.h:318:52: note: expanded from macro 'RUNTIME_CHECK'
                                                         ^~~~
      /builds/isc-projects/bind9/lib/isc/include/isc/error.h:50:21: note: expanded from macro 'ISC_ERROR_RUNTIMECHECK'
              ((void)(ISC_LIKELY(cond) ||  \
                                 ^~~~
      /builds/isc-projects/bind9/lib/isc/include/isc/likely.h:23:43: note: expanded from macro 'ISC_LIKELY'
                                                  ^
      1 warning generated.
      
      --
      
      ./rndc.c:255:6: warning: Dereference of null pointer (loaded from variable 'host')
              if (*host == '/') {
                  ^~~~~
      1 warning generated.
      
      References:
      1. https://clang-analyzer.llvm.org/faq.html#null_pointer
      
      (cherry picked from commit ddd0d356)
      (cherry picked from commit 9b76eea0)
      0ff5c1f1
    • Ondřej Surý's avatar
      Fix 'Dead nested assignment's from scan-build-10 · 2beca482
      Ondřej Surý authored
      The 3 warnings reported are:
      
      os.c:872:7: warning: Although the value stored to 'ptr' is used in the enclosing expression, the value is never actually read from 'ptr'
              if ((ptr = strtok_r(command, " \t", &last)) == NULL) {
                   ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      1 warning generated.
      
      --
      
      rpz.c:1117:10: warning: Although the value stored to 'zbits' is used in the enclosing expression, the value is never actually read from 'zbits'
              return (zbits &= x);
                      ^        ~
      1 warning generated.
      
      --
      
      openssleddsa_link.c:532:10: warning: Although the value stored to 'err' is used in the enclosing expression, the value is never actually read from 'err'
              while ((err = ERR_get_error()) != 0) {
                      ^     ~~~~~~~~~~~~~~~
      1 warning generated.
      
      (cherry picked from commit 262f087b)
      (cherry picked from commit 138dded9)
      2beca482
    • Michał Kępień's avatar
      Merge branch 'ondrej/remove-debian-jessie-from-gitlab-ci-v9_14' into 'v9_14' · 6389f365
      Michał Kępień authored
      Remove Debian 8 ("Jessie") from the GitLab CI
      
      See merge request !3283
      6389f365
  2. 24 Mar, 2020 1 commit
    • Ondřej Surý's avatar
      Remove Debian 8 ("Jessie") from the GitLab CI · 900efca9
      Ondřej Surý authored
      There are several reason why remove Debian 8 from the CI:
      
      * Debian 8 ("jessie") has been superseded by Debian 9 ("stretch").
      * Regular security support updates have been discontinued as of
        June 17th, 2018.
      * Jessie LTS is supported from 17th June 2018 to June 30, 2020.
      
      In other words, it's no longer officially supported by Debian security
      team, but by the volunteer/paid contributor composed LTS team.  And the
      release will be discontinued in three months from now.  We can use the
      freed CI resources to bring new platforms or just to make the jobs run a
      bit faster.
      
      (cherry picked from commit 75f46cc3)
      900efca9
  3. 20 Mar, 2020 5 commits
  4. 16 Mar, 2020 3 commits
  5. 09 Mar, 2020 2 commits
    • Michał Kępień's avatar
      Merge branch 'michal/do-not-run-openbsd-system-test-jobs-for-tags-v9_14' into 'v9_14' · 5319564d
      Michał Kępień authored
      [v9_14] Do not run OpenBSD system test jobs for tags
      
      See merge request !3189
      5319564d
    • Michał Kępień's avatar
      Do not run OpenBSD system test jobs for tags · 3ad4c327
      Michał Kępień authored
      OpenBSD virtual machines seem to affected particularly badly by other
      activity happening on the host.  This causes trouble around release
      time: when multiple tags are pushed to the repository, a large number of
      jobs is started concurrently on all CI runners.  In extreme cases, this
      causes the system test suite to run for about an hour (!) on OpenBSD
      VMs, with multiple tests failing.  We investigated the test artifacts
      for all such cases in the past and the outcome was always the same: test
      failures were caused by extremely slow I/O on the guest.  We tried
      various tricks to work around this problem, but nothing helped.
      
      Given the above, stop running OpenBSD system test jobs for pending BIND
      releases to prevent the results of these jobs from affecting the
      assessment of a given release's readiness for publication.  This change
      does not affect OpenBSD build jobs.  OpenBSD system test jobs will still
      be run for scheduled and web-requested pipelines, to make sure we catch
      any severe issues with test code on that platform sooner or later.
      
      (cherry picked from commit 7b002cea)
      3ad4c327
  6. 06 Mar, 2020 2 commits
  7. 05 Mar, 2020 4 commits
  8. 03 Mar, 2020 13 commits
  9. 21 Feb, 2020 2 commits
  10. 20 Feb, 2020 4 commits
  11. 13 Feb, 2020 1 commit