(cherry picked from commit 9b753aa1)

(cherry picked from commit a4ebe83c)

(cherry picked from commit f58ac8ad)

(cherry picked from commit 8ecf69ef)

(cherry picked from commit 109546cb)

(cherry picked from commit c6c1e992)

(cherry picked from commit d80825c4)

(cherry picked from commit e2b8699d)

(cherry picked from commit 874e2fc7)

(cherry picked from commit 979f0547)

(cherry picked from commit 05b7251d)

(cherry picked from commit 62f65007)

(cherry picked from commit 6ad1a042)

(cherry picked from commit 6717f31e)

- added tests to the dnssec system test that duplicate the ones
  from bin/tests/dnssec-signzone
- changed cleanall.sh so it doesn't automatically remove all
  key files, because there are now some of those that are part of the
  distribution

(cherry picked from commit ccfe778c)

- some of these tests are obsolete and should be cleared up,
  others overlap with ATF tests and may be removed later.
  for now, let's just tidy up the bin/tests directory by
  moving these files down a level.

(cherry picked from commit 344ab0eb)

(cherry picked from commit a633f6c5)

Update documentation to remove obsolete bind9-bugs@isc.org email address

See merge request !111

Ondřej Surý authored Mar 08, 2018 and Evan Hunt committed Mar 08, 2018

(cherry picked from commit efc9bc5d)
(cherry picked from commit 486e7905)

Tweak timestamp checking in the cds system test

Closes #136

See merge request !114

4912.	[test]		Improved the reliability of the 'cds' system test.
			[GL #136]

(cherry picked from commit c92bacec)

Given the characteristics of the three timestamps involved in file
modification time checks in the cds system test (each one is an hour
apart from the next), reduce the resolution of these checks to 1 minute.
This will prevent intermittent false negatives caused by exceeding the
currently allowed difference of 9 seconds between file modification
times without making the test moot.

Also note that by using abs(), checkmtime.pl allows the cds system test
to pass when the modification time of the checked file is less than an
hour (or two hours for the second check) in the past.  This should never
happen, so remove abs() from the condition checked by checkmtime.pl.

(cherry picked from commit ab2913a2)

Update documentation to remove obsolete bind9-bugs@isc.org email address

See merge request !111

Ondřej Surý authored Mar 08, 2018 and Evan Hunt committed Mar 08, 2018

(cherry picked from commit efc9bc5d)

Fix a race in the mkeys system test

Closes #128

See merge request !103

4911.	[test]		Improved the reliability of the 'mkeys' system test.
			[GL #128]

(cherry picked from commit 32f875f9)

Calling nextpart() after reconfiguring ns1 is not safe, because the
expected log message may appear in ns5/named.run before nextpart() is
run.  With the TTL for ./DNSKEY set to 20 seconds, ns5 will refresh it
after 10 seconds, by which time wait_for_log() will already have failed.
This results in a false negative.

However, just calling nextpart() before reconfiguring ns1 would
introduce a different problem: if ns5 refreshed ./DNSKEY between these
two steps, the subsequent wait_for_log() call would return immediately
as it would come across the log message about a failure while refreshing
./DNSKEY instead of the expected success.  This in turn would result in
a different false negative as the root key would still be uninitialized
by the time "rndc secroots" is called.

Prevent both kinds of false negatives by:

  - calling nextpart() before reconfiguring ns1, in order to prevent the
    first case described above,

  - looking for a more specific log message, in order to prevent the
    second case described above.

Also look for a more specific log message in the first part of the
relevant check, not to fix any problem, but just to emphasize that a
different fetch result is expected in that case.

With these tweaks in place, if a (failed) ./DNSKEY refresh is scheduled
between nextpart() and reconfiguring ns1, wait_for_log() will just wait
for two more seconds (one "hour"), at which point another refresh
attempt will be made that will succeed.

(cherry picked from commit 012ca0a2)

Resolve "Update util/check-changes to work on release branches."

Closes #133

See merge request !110

(cherry picked from commit 88a22020)

Resolve "in-view duplicate zone not detected by named-checkconf"

Closes #125

See merge request !97

(cherry picked from commit 83f85817)

check for in-view zones colliding with other zone definitions; also check the syntax of the in-view zone name

(cherry picked from commit 3e7e2800)

(cherry picked from commit ca55c672)

use the test name in the -D string for each name server

See merge request !107